* [Buildroot] [PATCH] package/putty: disable for uClibc
@ 2019-03-25 21:08 Baruch Siach
2019-03-25 21:36 ` Arnout Vandecappelle
0 siblings, 1 reply; 3+ messages in thread
From: Baruch Siach @ 2019-03-25 21:08 UTC (permalink / raw)
To: buildroot
putty now uses the futimes() BSD extension that uClibc does not
implement.
Fixes:
http://autobuild.buildroot.net/results/801/801e2b2909363b5dcd9735362bb921e017569edc/
http://autobuild.buildroot.net/results/398/3984c6cdd3398645c8ad98bbe23af9090cf4bfcf/
http://autobuild.buildroot.net/results/632/632f93046f9cceffd9b604911542426c10967e0f/
Cc: Alexander Dahl <post@lespocky.de>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
package/putty/Config.in | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/package/putty/Config.in b/package/putty/Config.in
index f901c71da297..065a7152f705 100644
--- a/package/putty/Config.in
+++ b/package/putty/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_PUTTY
depends on BR2_USE_MMU # fork()
depends on BR2_USE_WCHAR
depends on !BR2_STATIC_LIBS
+ depends on !BR2_TOOLCHAIN_USES_UCLIBC # futimes
help
PuTTY is a free SSH and Telnet client. Without GTK2
activated, only the commandline tools plink, pscp, psftp,
@@ -11,6 +12,7 @@ config BR2_PACKAGE_PUTTY
http://www.chiark.greenend.org.uk/~sgtatham/putty/
-comment "putty needs a toolchain w/ wchar, dynamic library"
+comment "putty needs a glibc or musl toolchain w/ wchar, dynamic library"
depends on BR2_USE_MMU
- depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS
+ depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS || \
+ BR2_TOOLCHAIN_USES_UCLIBC
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/putty: disable for uClibc
2019-03-25 21:08 [Buildroot] [PATCH] package/putty: disable for uClibc Baruch Siach
@ 2019-03-25 21:36 ` Arnout Vandecappelle
2019-03-26 17:09 ` Baruch Siach
0 siblings, 1 reply; 3+ messages in thread
From: Arnout Vandecappelle @ 2019-03-25 21:36 UTC (permalink / raw)
To: buildroot
On 25/03/2019 22:08, Baruch Siach wrote:
> putty now uses the futimes() BSD extension that uClibc does not
> implement.
>
> Fixes:
> http://autobuild.buildroot.net/results/801/801e2b2909363b5dcd9735362bb921e017569edc/
> http://autobuild.buildroot.net/results/398/3984c6cdd3398645c8ad98bbe23af9090cf4bfcf/
> http://autobuild.buildroot.net/results/632/632f93046f9cceffd9b604911542426c10967e0f/
Although it's true that it also eventually fails to link due to futimes(), the
actual errors in the autobuilders are about POLLRDNORM and POLLRDBAND, which
require _XOPEN_SOURCE to be set.
This is quite heavy fallout for something marked as "security bump"...
Regards,
Arnout
>
> Cc: Alexander Dahl <post@lespocky.de>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> package/putty/Config.in | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/package/putty/Config.in b/package/putty/Config.in
> index f901c71da297..065a7152f705 100644
> --- a/package/putty/Config.in
> +++ b/package/putty/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_PUTTY
> depends on BR2_USE_MMU # fork()
> depends on BR2_USE_WCHAR
> depends on !BR2_STATIC_LIBS
> + depends on !BR2_TOOLCHAIN_USES_UCLIBC # futimes
> help
> PuTTY is a free SSH and Telnet client. Without GTK2
> activated, only the commandline tools plink, pscp, psftp,
> @@ -11,6 +12,7 @@ config BR2_PACKAGE_PUTTY
>
> http://www.chiark.greenend.org.uk/~sgtatham/putty/
>
> -comment "putty needs a toolchain w/ wchar, dynamic library"
> +comment "putty needs a glibc or musl toolchain w/ wchar, dynamic library"
> depends on BR2_USE_MMU
> - depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS
> + depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS || \
> + BR2_TOOLCHAIN_USES_UCLIBC
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/putty: disable for uClibc
2019-03-25 21:36 ` Arnout Vandecappelle
@ 2019-03-26 17:09 ` Baruch Siach
0 siblings, 0 replies; 3+ messages in thread
From: Baruch Siach @ 2019-03-26 17:09 UTC (permalink / raw)
To: buildroot
Hi Arnout,
On Mon, Mar 25 2019, Arnout Vandecappelle wrote:
> On 25/03/2019 22:08, Baruch Siach wrote:
>> putty now uses the futimes() BSD extension that uClibc does not
>> implement.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/801/801e2b2909363b5dcd9735362bb921e017569edc/
>> http://autobuild.buildroot.net/results/398/3984c6cdd3398645c8ad98bbe23af9090cf4bfcf/
>> http://autobuild.buildroot.net/results/632/632f93046f9cceffd9b604911542426c10967e0f/
>
> Although it's true that it also eventually fails to link due to futimes(), the
> actual errors in the autobuilders are about POLLRDNORM and POLLRDBAND, which
> require _XOPEN_SOURCE to be set.
>
> This is quite heavy fallout for something marked as "security bump"...
Indeed. Fortunately, upstream has responded promptly to my build failure
report. Simon Tatham suggested a patch that fixes this issue, and
another uClibc build issue for ARM.
I'll send a followup patch with these fixes.
baruch
>
> Regards,
> Arnout
>
>>
>> Cc: Alexander Dahl <post@lespocky.de>
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> ---
>> package/putty/Config.in | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/putty/Config.in b/package/putty/Config.in
>> index f901c71da297..065a7152f705 100644
>> --- a/package/putty/Config.in
>> +++ b/package/putty/Config.in
>> @@ -3,6 +3,7 @@ config BR2_PACKAGE_PUTTY
>> depends on BR2_USE_MMU # fork()
>> depends on BR2_USE_WCHAR
>> depends on !BR2_STATIC_LIBS
>> + depends on !BR2_TOOLCHAIN_USES_UCLIBC # futimes
>> help
>> PuTTY is a free SSH and Telnet client. Without GTK2
>> activated, only the commandline tools plink, pscp, psftp,
>> @@ -11,6 +12,7 @@ config BR2_PACKAGE_PUTTY
>>
>> http://www.chiark.greenend.org.uk/~sgtatham/putty/
>>
>> -comment "putty needs a toolchain w/ wchar, dynamic library"
>> +comment "putty needs a glibc or musl toolchain w/ wchar, dynamic library"
>> depends on BR2_USE_MMU
>> - depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS
>> + depends on !BR2_USE_WCHAR || BR2_STATIC_LIBS || \
>> + BR2_TOOLCHAIN_USES_UCLIBC
>>
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-26 17:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-25 21:08 [Buildroot] [PATCH] package/putty: disable for uClibc Baruch Siach
2019-03-25 21:36 ` Arnout Vandecappelle
2019-03-26 17:09 ` Baruch Siach
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.