From: Milo Kim <woogyom.kim@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Lee Jones <lee.jones@linaro.org>,
devicetree@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
linux-kernel@vger.kernel.org, bcousson@baylibre.com,
linux-omap@vger.kernel.org,
Robert Nelson <robertcnelson@gmail.com>
Subject: Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources
Date: Wed, 23 Nov 2016 22:06:18 +0900 [thread overview]
Message-ID: <27c48fc3-29bd-996b-bdc4-75884a39865a@gmail.com> (raw)
In-Reply-To: <33562327.jVWx4tN2gP@wuerfel>
On 11/23/2016 08:51 PM, Arnd Bergmann wrote:
> Ah, the numbers come from the data sheet. Please just remove the
> header then, there is no need to keep them as an ABI, in particular
> when the driver doesn't even include that header today.
Got it.
> What matters here is the binding documentation in
> Documentation/devicetree/bindings/power/supply/tps65217_charger.txt
OK, in addition to this, the interrupt specifier needs to be added in
Documentation/devicetree/bindings/input/tps65218-pwrbutton.txt.
> Please fix that instead to mandate that the two interrupts are
> required, what their functions are, and what the interrupt-names
> (not interrupts-names) property must list.
Oops, wrong interrupt name property - my bad.
Thanks for all your feedback.
Best regards,
Milo
WARNING: multiple messages have this Message-ID (diff)
From: Milo Kim <woogyom.kim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Robert Nelson
<robertcnelson-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources
Date: Wed, 23 Nov 2016 22:06:18 +0900 [thread overview]
Message-ID: <27c48fc3-29bd-996b-bdc4-75884a39865a@gmail.com> (raw)
In-Reply-To: <33562327.jVWx4tN2gP@wuerfel>
On 11/23/2016 08:51 PM, Arnd Bergmann wrote:
> Ah, the numbers come from the data sheet. Please just remove the
> header then, there is no need to keep them as an ABI, in particular
> when the driver doesn't even include that header today.
Got it.
> What matters here is the binding documentation in
> Documentation/devicetree/bindings/power/supply/tps65217_charger.txt
OK, in addition to this, the interrupt specifier needs to be added in
Documentation/devicetree/bindings/input/tps65218-pwrbutton.txt.
> Please fix that instead to mandate that the two interrupts are
> required, what their functions are, and what the interrupt-names
> (not interrupts-names) property must list.
Oops, wrong interrupt name property - my bad.
Thanks for all your feedback.
Best regards,
Milo
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: woogyom.kim@gmail.com (Milo Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources
Date: Wed, 23 Nov 2016 22:06:18 +0900 [thread overview]
Message-ID: <27c48fc3-29bd-996b-bdc4-75884a39865a@gmail.com> (raw)
In-Reply-To: <33562327.jVWx4tN2gP@wuerfel>
On 11/23/2016 08:51 PM, Arnd Bergmann wrote:
> Ah, the numbers come from the data sheet. Please just remove the
> header then, there is no need to keep them as an ABI, in particular
> when the driver doesn't even include that header today.
Got it.
> What matters here is the binding documentation in
> Documentation/devicetree/bindings/power/supply/tps65217_charger.txt
OK, in addition to this, the interrupt specifier needs to be added in
Documentation/devicetree/bindings/input/tps65218-pwrbutton.txt.
> Please fix that instead to mandate that the two interrupts are
> required, what their functions are, and what the interrupt-names
> (not interrupts-names) property must list.
Oops, wrong interrupt name property - my bad.
Thanks for all your feedback.
Best regards,
Milo
next prev parent reply other threads:[~2016-11-23 13:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 13:15 [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources Milo Kim
2016-11-21 13:15 ` Milo Kim
2016-11-22 15:57 ` Lee Jones
2016-11-22 15:57 ` Lee Jones
2016-11-22 16:00 ` Lee Jones
2016-11-22 16:00 ` Lee Jones
2016-11-22 16:00 ` Lee Jones
2016-11-22 21:08 ` Arnd Bergmann
2016-11-22 21:08 ` Arnd Bergmann
2016-11-22 21:08 ` Arnd Bergmann
2016-11-23 11:38 ` Milo Kim
2016-11-23 11:38 ` Milo Kim
2016-11-23 11:38 ` Milo Kim
2016-11-23 11:51 ` Arnd Bergmann
2016-11-23 11:51 ` Arnd Bergmann
2016-11-23 11:51 ` Arnd Bergmann
2016-11-23 13:06 ` Milo Kim [this message]
2016-11-23 13:06 ` Milo Kim
2016-11-23 13:06 ` Milo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27c48fc3-29bd-996b-bdc4-75884a39865a@gmail.com \
--to=woogyom.kim@gmail.com \
--cc=arnd@arndb.de \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robertcnelson@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.