[PATCH] libibmad/src/rpc.c: Remove superfluous packet dump

[PATCH] libibmad/src/rpc.c: Remove superfluous packet dump

[Albert Chu]

When idebug == 1, mad_rpc outputs only the mad data
response in debug output.  It does not output the request
mad data.  This is confusing since it's not clear if it's
request or response output.

When idebug > 1, full mad send and receive buffers are
output, which makes the mad data output with idebug == 1
superfluous.  Remove it to remove confusion.

Signed-off-by: Albert Chu <chu11-i2BcT+NCU+M@public.gmane.org>
---
 src/rpc.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/src/rpc.c b/src/rpc.c
index 8d961f2..202fac5 100644
--- a/src/rpc.c
+++ b/src/rpc.c
@@ -272,11 +272,6 @@ void *mad_rpc(const struct ibmad_port *port, ib_rpc_t * rpc,
 		return NULL;
 	}
 
-	if (ibdebug) {
-		IBWARN("data offs %d sz %d", rpc->dataoffs, rpc->datasz);
-		xdump(stderr, "mad data\n", mad + rpc->dataoffs, rpc->datasz);
-	}
-
 	if (rcvdata)
 		memcpy(rcvdata, mad + rpc->dataoffs, rpc->datasz);
 
-- 
1.7.1




--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] libibmad/src/rpc.c: Remove superfluous packet dump

[Weiny, Ira]

Any reason this should not be removed from mad_rpc_rmpp as well?

Ira


> -----Original Message-----
> From: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-rdma-
> owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Albert Chu
> Sent: Friday, December 19, 2014 11:08 AM
> To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Subject: [PATCH] libibmad/src/rpc.c: Remove superfluous packet dump
> 
> When idebug == 1, mad_rpc outputs only the mad data response in debug
> output.  It does not output the request mad data.  This is confusing since it's not
> clear if it's request or response output.
> 
> When idebug > 1, full mad send and receive buffers are output, which makes
> the mad data output with idebug == 1 superfluous.  Remove it to remove
> confusion.
> 
> Signed-off-by: Albert Chu <chu11-i2BcT+NCU+M@public.gmane.org>
> ---
>  src/rpc.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/src/rpc.c b/src/rpc.c
> index 8d961f2..202fac5 100644
> --- a/src/rpc.c
> +++ b/src/rpc.c
> @@ -272,11 +272,6 @@ void *mad_rpc(const struct ibmad_port *port,
> ib_rpc_t * rpc,
>  		return NULL;
>  	}
> 
> -	if (ibdebug) {
> -		IBWARN("data offs %d sz %d", rpc->dataoffs, rpc->datasz);
> -		xdump(stderr, "mad data\n", mad + rpc->dataoffs, rpc-
> >datasz);
> -	}
> -
>  	if (rcvdata)
>  		memcpy(rcvdata, mad + rpc->dataoffs, rpc->datasz);
> 
> --
> 1.7.1
> 
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] libibmad/src/rpc.c: Remove superfluous packet dump

[Albert Chu]

Just didn't hit the issue there so didn't think to remove it there a
well.  I'll repost

Al

On Fri, 2015-01-09 at 23:27 +0000, Weiny, Ira wrote:
> Any reason this should not be removed from mad_rpc_rmpp as well?
> 
> Ira
> 
> 
> > -----Original Message-----
> > From: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org [mailto:linux-rdma-
> > owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org] On Behalf Of Albert Chu
> > Sent: Friday, December 19, 2014 11:08 AM
> > To: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > Subject: [PATCH] libibmad/src/rpc.c: Remove superfluous packet dump
> > 
> > When idebug == 1, mad_rpc outputs only the mad data response in debug
> > output.  It does not output the request mad data.  This is confusing since it's not
> > clear if it's request or response output.
> > 
> > When idebug > 1, full mad send and receive buffers are output, which makes
> > the mad data output with idebug == 1 superfluous.  Remove it to remove
> > confusion.
> > 
> > Signed-off-by: Albert Chu <chu11-i2BcT+NCU+M@public.gmane.org>
> > ---
> >  src/rpc.c |    5 -----
> >  1 files changed, 0 insertions(+), 5 deletions(-)
> > 
> > diff --git a/src/rpc.c b/src/rpc.c
> > index 8d961f2..202fac5 100644
> > --- a/src/rpc.c
> > +++ b/src/rpc.c
> > @@ -272,11 +272,6 @@ void *mad_rpc(const struct ibmad_port *port,
> > ib_rpc_t * rpc,
> >  		return NULL;
> >  	}
> > 
> > -	if (ibdebug) {
> > -		IBWARN("data offs %d sz %d", rpc->dataoffs, rpc->datasz);
> > -		xdump(stderr, "mad data\n", mad + rpc->dataoffs, rpc-
> > >datasz);
> > -	}
> > -
> >  	if (rcvdata)
> >  		memcpy(rcvdata, mad + rpc->dataoffs, rpc->datasz);
> > 
> > --
> > 1.7.1
> > 
> > 
> > 
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
-- 
Albert Chu
chu11-i2BcT+NCU+M@public.gmane.org
Computer Scientist
High Performance Systems Division
Lawrence Livermore National Laboratory


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] libibmad/src/rpc.c: Remove superfluous packet dump

[Albert Chu]

When idebug is >= 1, mad_rpc and mad_rpc_rmpp output only
the mad data response in debug output.  It does not output
the request mad data.  This is confusing since it's not clear
if it's request or response output.

When idebug > 1, full mad send and receive buffers are
output, which makes the mad data output with idebug == 1
superfluous.  Remove this output to remove confusion.

Signed-off-by: Albert Chu <chu11-i2BcT+NCU+M@public.gmane.org>
---
 src/rpc.c |   11 -----------
 1 files changed, 0 insertions(+), 11 deletions(-)

diff --git a/src/rpc.c b/src/rpc.c
index 8d961f2..f286af7 100644
--- a/src/rpc.c
+++ b/src/rpc.c
@@ -272,11 +272,6 @@ void *mad_rpc(const struct ibmad_port *port, ib_rpc_t * rpc,
 		return NULL;
 	}
 
-	if (ibdebug) {
-		IBWARN("data offs %d sz %d", rpc->dataoffs, rpc->datasz);
-		xdump(stderr, "mad data\n", mad + rpc->dataoffs, rpc->datasz);
-	}
-
 	if (rcvdata)
 		memcpy(rcvdata, mad + rpc->dataoffs, rpc->datasz);
 
@@ -322,12 +317,6 @@ void *mad_rpc_rmpp(const struct ibmad_port *port, ib_rpc_t * rpc,
 		return NULL;
 	}
 
-	if (ibdebug) {
-		IBWARN("data offs %d sz %d", rpc->dataoffs, rpc->datasz);
-		xdump(stderr, "rmpp mad data\n", mad + rpc->dataoffs,
-		      rpc->datasz);
-	}
-
 	if (rmpp) {
 		rmpp->flags = mad_get_field(mad, 0, IB_SA_RMPP_FLAGS_F);
 		if ((rmpp->flags & 0x3) &&
-- 
1.7.1



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] libibmad/src/rpc.c: Remove superfluous packet dump

[Weiny, Ira]

> 
> When idebug is >= 1, mad_rpc and mad_rpc_rmpp output only the mad data
> response in debug output.  It does not output the request mad data.  This is
> confusing since it's not clear if it's request or response output.
> 
> When idebug > 1, full mad send and receive buffers are output, which makes
> the mad data output with idebug == 1 superfluous.  Remove this output to
> remove confusion.
> 
> Signed-off-by: Albert Chu <chu11-i2BcT+NCU+M@public.gmane.org>

Thanks applied.

Ira


> ---
>  src/rpc.c |   11 -----------
>  1 files changed, 0 insertions(+), 11 deletions(-)
> 
> diff --git a/src/rpc.c b/src/rpc.c
> index 8d961f2..f286af7 100644
> --- a/src/rpc.c
> +++ b/src/rpc.c
> @@ -272,11 +272,6 @@ void *mad_rpc(const struct ibmad_port *port,
> ib_rpc_t * rpc,
>  		return NULL;
>  	}
> 
> -	if (ibdebug) {
> -		IBWARN("data offs %d sz %d", rpc->dataoffs, rpc->datasz);
> -		xdump(stderr, "mad data\n", mad + rpc->dataoffs, rpc-
> >datasz);
> -	}
> -
>  	if (rcvdata)
>  		memcpy(rcvdata, mad + rpc->dataoffs, rpc->datasz);
> 
> @@ -322,12 +317,6 @@ void *mad_rpc_rmpp(const struct ibmad_port *port,
> ib_rpc_t * rpc,
>  		return NULL;
>  	}
> 
> -	if (ibdebug) {
> -		IBWARN("data offs %d sz %d", rpc->dataoffs, rpc->datasz);
> -		xdump(stderr, "rmpp mad data\n", mad + rpc->dataoffs,
> -		      rpc->datasz);
> -	}
> -
>  	if (rmpp) {
>  		rmpp->flags = mad_get_field(mad, 0, IB_SA_RMPP_FLAGS_F);
>  		if ((rmpp->flags & 0x3) &&
> --
> 1.7.1
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html