* [PATCH] IB/hfi1: Allocate cpu mask on the heap to silence warning
@ 2016-08-03 18:37 ira.weiny-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1470249441-22787-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: ira.weiny-ral2JQCrhuEAvxtiuMwx3w @ 2016-08-03 18:37 UTC (permalink / raw)
To: dledford-H+wXaHxf7aLQT0dZR+AlfA
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Tadeusz Struk
From: Tadeusz Struk <tadeusz.struk-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
If CONFIG_FRAME_WARN is small (1K) and CONFIG_NR_CPUS big
then a frame size warning is triggered during build.
Allocate the cpu mask dynamically to silence the warning.
Reviewed-by: Sebastian Sanchez <sebastian.sanchez-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Reviewed-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Signed-off-by: Tadeusz Struk <tadeusz.struk-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
---
drivers/infiniband/hw/hfi1/affinity.c | 20 +++++++++++++-------
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/drivers/infiniband/hw/hfi1/affinity.c b/drivers/infiniband/hw/hfi1/affinity.c
index 79575ee873f2..62be2eda1b96 100644
--- a/drivers/infiniband/hw/hfi1/affinity.c
+++ b/drivers/infiniband/hw/hfi1/affinity.c
@@ -682,7 +682,7 @@ int hfi1_set_sdma_affinity(struct hfi1_devdata *dd, const char *buf,
size_t count)
{
struct hfi1_affinity_node *entry;
- struct cpumask mask;
+ cpumask_var_t mask;
int ret, i;
spin_lock(&node_affinity.lock);
@@ -692,19 +692,24 @@ int hfi1_set_sdma_affinity(struct hfi1_devdata *dd, const char *buf,
if (!entry)
return -EINVAL;
- ret = cpulist_parse(buf, &mask);
- if (ret)
+ ret = zalloc_cpumask_var(&mask, GFP_KERNEL);
+ if (!ret)
return ret;
- if (!cpumask_subset(&mask, cpu_online_mask) || cpumask_empty(&mask)) {
+ ret = cpulist_parse(buf, mask);
+ if (ret)
+ goto out;
+
+ if (!cpumask_subset(mask, cpu_online_mask) || cpumask_empty(mask)) {
dd_dev_warn(dd, "Invalid CPU mask\n");
- return -EINVAL;
+ ret = -EINVAL;
+ goto out;
}
mutex_lock(&sdma_affinity_mutex);
/* reset the SDMA interrupt affinity details */
init_cpu_mask_set(&entry->def_intr);
- cpumask_copy(&entry->def_intr.mask, &mask);
+ cpumask_copy(&entry->def_intr.mask, mask);
/*
* Reassign the affinity for each SDMA interrupt.
*/
@@ -720,8 +725,9 @@ int hfi1_set_sdma_affinity(struct hfi1_devdata *dd, const char *buf,
if (ret)
break;
}
-
mutex_unlock(&sdma_affinity_mutex);
+out:
+ free_cpumask_var(mask);
return ret ? ret : strnlen(buf, PAGE_SIZE);
}
--
1.8.2.3
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] IB/hfi1: Allocate cpu mask on the heap to silence warning
[not found] ` <1470249441-22787-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
@ 2016-08-03 18:54 ` Leon Romanovsky
[not found] ` <20160803185403.GH27667-2ukJVAZIZ/Y@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Leon Romanovsky @ 2016-08-03 18:54 UTC (permalink / raw)
To: ira.weiny-ral2JQCrhuEAvxtiuMwx3w
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA, Tadeusz Struk
[-- Attachment #1: Type: text/plain, Size: 1676 bytes --]
On Wed, Aug 03, 2016 at 02:37:21PM -0400, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote:
> From: Tadeusz Struk <tadeusz.struk-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>
> If CONFIG_FRAME_WARN is small (1K) and CONFIG_NR_CPUS big
> then a frame size warning is triggered during build.
> Allocate the cpu mask dynamically to silence the warning.
>
> Reviewed-by: Sebastian Sanchez <sebastian.sanchez-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Reviewed-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Tadeusz Struk <tadeusz.struk-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> ---
> drivers/infiniband/hw/hfi1/affinity.c | 20 +++++++++++++-------
> 1 file changed, 13 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/infiniband/hw/hfi1/affinity.c b/drivers/infiniband/hw/hfi1/affinity.c
> index 79575ee873f2..62be2eda1b96 100644
> --- a/drivers/infiniband/hw/hfi1/affinity.c
> +++ b/drivers/infiniband/hw/hfi1/affinity.c
> @@ -682,7 +682,7 @@ int hfi1_set_sdma_affinity(struct hfi1_devdata *dd, const char *buf,
> size_t count)
> {
> struct hfi1_affinity_node *entry;
> - struct cpumask mask;
> + cpumask_var_t mask;
> int ret, i;
>
> spin_lock(&node_affinity.lock);
> @@ -692,19 +692,24 @@ int hfi1_set_sdma_affinity(struct hfi1_devdata *dd, const char *buf,
> if (!entry)
> return -EINVAL;
>
> - ret = cpulist_parse(buf, &mask);
> - if (ret)
> + ret = zalloc_cpumask_var(&mask, GFP_KERNEL);
> + if (!ret)
> return ret;
Ira,
Are you aware that before this change you returned value different from
zero in case of error and now you will return zero?
Thanks
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] IB/hfi1: Allocate cpu mask on the heap to silence warning
[not found] ` <20160803185403.GH27667-2ukJVAZIZ/Y@public.gmane.org>
@ 2016-08-03 23:17 ` Weiny, Ira
0 siblings, 0 replies; 3+ messages in thread
From: Weiny, Ira @ 2016-08-03 23:17 UTC (permalink / raw)
To: Leon Romanovsky
Cc: dledford-H+wXaHxf7aLQT0dZR+AlfA,
linux-rdma-u79uwXL29TY76Z2rM5mHXA, Struk, Tadeusz
>
> On Wed, Aug 03, 2016 at 02:37:21PM -0400, ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org wrote:
> > From: Tadeusz Struk <tadeusz.struk-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> >
> > If CONFIG_FRAME_WARN is small (1K) and CONFIG_NR_CPUS big then a
> frame
> > size warning is triggered during build.
> > Allocate the cpu mask dynamically to silence the warning.
> >
> > Reviewed-by: Sebastian Sanchez <sebastian.sanchez-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Reviewed-by: Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > Signed-off-by: Tadeusz Struk <tadeusz.struk-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> > ---
> > drivers/infiniband/hw/hfi1/affinity.c | 20 +++++++++++++-------
> > 1 file changed, 13 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/hfi1/affinity.c
> > b/drivers/infiniband/hw/hfi1/affinity.c
> > index 79575ee873f2..62be2eda1b96 100644
> > --- a/drivers/infiniband/hw/hfi1/affinity.c
> > +++ b/drivers/infiniband/hw/hfi1/affinity.c
> > @@ -682,7 +682,7 @@ int hfi1_set_sdma_affinity(struct hfi1_devdata
> *dd, const char *buf,
> > size_t count)
> > {
> > struct hfi1_affinity_node *entry;
> > - struct cpumask mask;
> > + cpumask_var_t mask;
> > int ret, i;
> >
> > spin_lock(&node_affinity.lock);
> > @@ -692,19 +692,24 @@ int hfi1_set_sdma_affinity(struct hfi1_devdata
> *dd, const char *buf,
> > if (!entry)
> > return -EINVAL;
> >
> > - ret = cpulist_parse(buf, &mask);
> > - if (ret)
> > + ret = zalloc_cpumask_var(&mask, GFP_KERNEL);
> > + if (!ret)
> > return ret;
>
> Ira,
> Are you aware that before this change you returned value different from
> zero in case of error and now you will return zero?
>
No I did not realize that zalloc_cpumask_var returns bool...
Thanks, v2 on it's way.
Ira
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-08-03 23:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-03 18:37 [PATCH] IB/hfi1: Allocate cpu mask on the heap to silence warning ira.weiny-ral2JQCrhuEAvxtiuMwx3w
[not found] ` <1470249441-22787-1-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-08-03 18:54 ` Leon Romanovsky
[not found] ` <20160803185403.GH27667-2ukJVAZIZ/Y@public.gmane.org>
2016-08-03 23:17 ` Weiny, Ira
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.