From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, olivier.matz@6wind.com,
pablo.de.lara.guarch@intel.com, ramirose@gmail.com
Subject: Re: [PATCH] rte_ring: add newline to error message
Date: Wed, 27 Mar 2019 12:21:25 +0100 [thread overview]
Message-ID: <2813505.FGjIkkUpHa@xps> (raw)
In-Reply-To: <20190321230341.6576-1-stephen@networkplumber.org>
22/03/2019 00:03, Stephen Hemminger:
> Log message should end with newline.
>
> Fixes: 4e32101f9b01 ("ring: support freeing")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> - RTE_LOG(ERR, RING, "Cannot free ring (not created with rte_ring_create()");
> + RTE_LOG(ERR, RING,
> + "Cannot free ring (not created with rte_ring_create()\n");
While at it, could you fix the parens?
I think it would be better to replace the first paren with a comma.
next prev parent reply other threads:[~2019-03-27 11:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 23:03 [PATCH] rte_ring: add newline to error message Stephen Hemminger
2019-03-22 9:49 ` Rami Rosen
2019-03-27 11:21 ` Thomas Monjalon [this message]
2019-04-02 15:30 ` [PATCH v2] " Stephen Hemminger
2019-04-03 16:40 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2813505.FGjIkkUpHa@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=ramirose@gmail.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.