All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] firmware/efi : use NULL instead of 0 for pointer
@ 2014-02-13  9:54 ` Daeseok Youn
  0 siblings, 0 replies; 4+ messages in thread
From: Daeseok Youn @ 2014-02-13  9:54 UTC (permalink / raw)
  To: matt.fleming; +Cc: linux-efi, linux-kernel

>From 1c70573009a3b50cef2acaae1e5a8cd350edfe6d Mon Sep 17 00:00:00 2001
From: Daeseok Youn <daeseok.youn@gmail.com>
Date: Thu, 13 Feb 2014 17:16:36 +0900
Subject: [PATCH] firmware/efi : use NULL instead of 0 for pointer

following sparse warnings:

drivers/firmware/efi/efivars.c:230:66: warning:
 Using plain integer as NULL pointer
drivers/firmware/efi/efi.c:236:27: warning:
 Using plain integer as NULL pointer

Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
 drivers/firmware/efi/efi.c     |    2 +-
 drivers/firmware/efi/efivars.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 4753bac..d85187f 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -233,7 +233,7 @@ static __initdata efi_config_table_type_t common_tables[] = 
{
 	{SAL_SYSTEM_TABLE_GUID, "SALsystab", &efi.sal_systab},
 	{SMBIOS_TABLE_GUID, "SMBIOS", &efi.smbios},
 	{UGA_IO_PROTOCOL_GUID, "UGA", &efi.uga},
-	{NULL_GUID, NULL, 0},
+	{NULL_GUID, NULL, NULL},
 };
 
 static __init int match_config_table(efi_guid_t *guid,
diff --git a/drivers/firmware/efi/efivars.c b/drivers/firmware/efi/efivars.c
index 3dc2482..50ea412 100644
--- a/drivers/firmware/efi/efivars.c
+++ b/drivers/firmware/efi/efivars.c
@@ -227,7 +227,7 @@ efivar_store_raw(struct efivar_entry *entry, const char 
*buf, size_t count)
 	memcpy(&entry->var, new_var, count);
 
 	err = efivar_entry_set(entry, new_var->Attributes,
-			       new_var->DataSize, new_var->Data, false);
+			       new_var->DataSize, new_var->Data, NULL);
 	if (err) {
 		printk(KERN_WARNING "efivars: set_variable() failed: status=%d\n", 
err);
 		return -EIO;
-- 
1.7.9.5



^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] firmware/efi : use NULL instead of 0 for pointer
@ 2014-02-13  9:54 ` Daeseok Youn
  0 siblings, 0 replies; 4+ messages in thread
From: Daeseok Youn @ 2014-02-13  9:54 UTC (permalink / raw)
  To: matt.fleming-ral2JQCrhuEAvxtiuMwx3w
  Cc: linux-efi-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA

>From 1c70573009a3b50cef2acaae1e5a8cd350edfe6d Mon Sep 17 00:00:00 2001
From: Daeseok Youn <daeseok.youn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Date: Thu, 13 Feb 2014 17:16:36 +0900
Subject: [PATCH] firmware/efi : use NULL instead of 0 for pointer

following sparse warnings:

drivers/firmware/efi/efivars.c:230:66: warning:
 Using plain integer as NULL pointer
drivers/firmware/efi/efi.c:236:27: warning:
 Using plain integer as NULL pointer

Signed-off-by: Daeseok Youn <daeseok.youn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 drivers/firmware/efi/efi.c     |    2 +-
 drivers/firmware/efi/efivars.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
index 4753bac..d85187f 100644
--- a/drivers/firmware/efi/efi.c
+++ b/drivers/firmware/efi/efi.c
@@ -233,7 +233,7 @@ static __initdata efi_config_table_type_t common_tables[] = 
{
 	{SAL_SYSTEM_TABLE_GUID, "SALsystab", &efi.sal_systab},
 	{SMBIOS_TABLE_GUID, "SMBIOS", &efi.smbios},
 	{UGA_IO_PROTOCOL_GUID, "UGA", &efi.uga},
-	{NULL_GUID, NULL, 0},
+	{NULL_GUID, NULL, NULL},
 };
 
 static __init int match_config_table(efi_guid_t *guid,
diff --git a/drivers/firmware/efi/efivars.c b/drivers/firmware/efi/efivars.c
index 3dc2482..50ea412 100644
--- a/drivers/firmware/efi/efivars.c
+++ b/drivers/firmware/efi/efivars.c
@@ -227,7 +227,7 @@ efivar_store_raw(struct efivar_entry *entry, const char 
*buf, size_t count)
 	memcpy(&entry->var, new_var, count);
 
 	err = efivar_entry_set(entry, new_var->Attributes,
-			       new_var->DataSize, new_var->Data, false);
+			       new_var->DataSize, new_var->Data, NULL);
 	if (err) {
 		printk(KERN_WARNING "efivars: set_variable() failed: status=%d\n", 
err);
 		return -EIO;
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] firmware/efi : use NULL instead of 0 for pointer
@ 2014-02-13 11:06   ` Matt Fleming
  0 siblings, 0 replies; 4+ messages in thread
From: Matt Fleming @ 2014-02-13 11:06 UTC (permalink / raw)
  To: Daeseok Youn; +Cc: matt.fleming, linux-efi, linux-kernel

On Thu, 13 Feb, at 06:54:48PM, Daeseok Youn wrote:
> From 1c70573009a3b50cef2acaae1e5a8cd350edfe6d Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <daeseok.youn@gmail.com>
> Date: Thu, 13 Feb 2014 17:16:36 +0900
> Subject: [PATCH] firmware/efi : use NULL instead of 0 for pointer
> 
> following sparse warnings:
> 
> drivers/firmware/efi/efivars.c:230:66: warning:
>  Using plain integer as NULL pointer
> drivers/firmware/efi/efi.c:236:27: warning:
>  Using plain integer as NULL pointer
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
>  drivers/firmware/efi/efi.c     |    2 +-
>  drivers/firmware/efi/efivars.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

This patch doesn't apply because it is corrupt,

  fatal: corrupt patch at line 11
  Patch failed at 0001 efi: Use NULL instead of 0 for pointer

Please attach the patch in a reply.

-- 
Matt Fleming, Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] firmware/efi : use NULL instead of 0 for pointer
@ 2014-02-13 11:06   ` Matt Fleming
  0 siblings, 0 replies; 4+ messages in thread
From: Matt Fleming @ 2014-02-13 11:06 UTC (permalink / raw)
  To: Daeseok Youn
  Cc: matt.fleming-ral2JQCrhuEAvxtiuMwx3w,
	linux-efi-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

On Thu, 13 Feb, at 06:54:48PM, Daeseok Youn wrote:
> From 1c70573009a3b50cef2acaae1e5a8cd350edfe6d Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <daeseok.youn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date: Thu, 13 Feb 2014 17:16:36 +0900
> Subject: [PATCH] firmware/efi : use NULL instead of 0 for pointer
> 
> following sparse warnings:
> 
> drivers/firmware/efi/efivars.c:230:66: warning:
>  Using plain integer as NULL pointer
> drivers/firmware/efi/efi.c:236:27: warning:
>  Using plain integer as NULL pointer
> 
> Signed-off-by: Daeseok Youn <daeseok.youn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  drivers/firmware/efi/efi.c     |    2 +-
>  drivers/firmware/efi/efivars.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

This patch doesn't apply because it is corrupt,

  fatal: corrupt patch at line 11
  Patch failed at 0001 efi: Use NULL instead of 0 for pointer

Please attach the patch in a reply.

-- 
Matt Fleming, Intel Open Source Technology Center

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-02-13 11:06 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-02-13  9:54 [PATCH] firmware/efi : use NULL instead of 0 for pointer Daeseok Youn
2014-02-13  9:54 ` Daeseok Youn
2014-02-13 11:06 ` Matt Fleming
2014-02-13 11:06   ` Matt Fleming

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.