Re: [meta-oe][PATCH] directfb: fix tslib version check in configure.in

Re: [meta-oe][PATCH] directfb: fix tslib version check in configure.in

[Jonas Mark (BT-FIR/ENG1)]

Hi Richard,

I already sent an updated version of the patch to the
openembedded-devel@lists.openembedded.org mailing list. An automatic
system informed me that I hit the wrong mailing list. I am now
intentionally cross-posting this reply to both lists. Hopefully, further
discussions will only take place at openembedded-devel.

[meta-oe,v2] directfb: fix tslib version check in configure.in
https://patchwork.openembedded.org/patch/153470/

> > From: Guan Ben <ben.guan@cn.bosch.com>
> >
> > The patch makes sure that the old as well as the new tslib pkg-config
> > metadata file naming style is handled correctly.
> >
> > tslib 0.0 to 1.0 created only a tslib-<VERSION>.pc pkg-config
> > metadata
> > file.
> >
> > With tslib 1.1 the tslib-<VERSION>.pc phase out was started.
> > Additionally, the pkg-config metadata file tslib.pc was added.
> >
> > Since tslib 1.6 the tslib-<VERSION>.pc metadata file is deprecated.
> > Now, there is only a tslib.pc.

In the beginning tslib only had a tslib-<VERSION>.pc for pkgconfig.

Starting with tslib 1.1, tslib.pc and tslib-<VERSION>.pc were created
for pkgconfig. And the tslib-<VERSION>.pc file was declared to be
deprecated.

From tslib 1.6 on only the tslib.pc file is available.

DirectFB's configure.in is not aware that there is a situation without
a tslib-<VERSION>.pc file. Thus it will not find tslib and this causes
that the tslib input driver won't be built.

DirectFB 1.7.7:

enable_tslib=no
if test "$checkfor_tslib" = "yes"; then
  PKG_CHECK_MODULES([TSLIB], [tslib-1.0 >= 1.0.0], [enable_tslib=yes], [enable_tslib=no])
  if test "$enable_tslib" = "no"; then
     PKG_CHECK_MODULES([TSLIB], [tslib-0.0], [enable_tslib=yes], [enable_tslib=no
       AC_MSG_WARN([*** no tslib -- tslib driver will not be built.])])
  fi
fi


Patched:

enable_tslib=no
if test "$checkfor_tslib" = "yes"; then
  PKG_CHECK_MODULES([TSLIB], [tslib >= 1.1], [enable_tslib=yes], [enable_tslib=no])
  if test "$enable_tslib" = "no"; then
    PKG_CHECK_MODULES([TSLIB], [tslib-1.0 >= 1.0], [enable_tslib=yes], [enable_tslib=no])
    if test "$enable_tslib" = "no"; then
      PKG_CHECK_MODULES([TSLIB], [tslib-0.0], [enable_tslib=yes], [enable_tslib=no
        AC_MSG_WARN([*** no tslib -- tslib driver will not be built.])])
    fi
  fi
fi

Greetings,
Mark

Building Technologies, Panel Software Fire (BT-FIR/ENG1) 
Bosch Sicherheitssysteme GmbH | Postfach 11 11 | 85626 Grasbrunn | GERMANY | www.boschsecurity.com

Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart HRB 23118 
Aufsichtsratsvorsitzender: Stefan Hartung; Geschäftsführung: Tanja Rückert, Andreas Bartz, Thomas Quante, Bernhard Schuster

Re: [OE-core] [meta-oe][PATCH] directfb: fix tslib version check in configure.in

[Jonas Mark (BT-FIR/ENG1)]

Hi Richard,

I already sent an updated version of the patch to the
openembedded-devel@lists.openembedded.org mailing list. An automatic
system informed me that I hit the wrong mailing list. I am now
intentionally cross-posting this reply to both lists. Hopefully, further
discussions will only take place at openembedded-devel.

[meta-oe,v2] directfb: fix tslib version check in configure.in
https://patchwork.openembedded.org/patch/153470/

> > From: Guan Ben <ben.guan@cn.bosch.com>
> >
> > The patch makes sure that the old as well as the new tslib pkg-config
> > metadata file naming style is handled correctly.
> >
> > tslib 0.0 to 1.0 created only a tslib-<VERSION>.pc pkg-config
> > metadata
> > file.
> >
> > With tslib 1.1 the tslib-<VERSION>.pc phase out was started.
> > Additionally, the pkg-config metadata file tslib.pc was added.
> >
> > Since tslib 1.6 the tslib-<VERSION>.pc metadata file is deprecated.
> > Now, there is only a tslib.pc.

In the beginning tslib only had a tslib-<VERSION>.pc for pkgconfig.

Starting with tslib 1.1, tslib.pc and tslib-<VERSION>.pc were created
for pkgconfig. And the tslib-<VERSION>.pc file was declared to be
deprecated.

From tslib 1.6 on only the tslib.pc file is available.

DirectFB's configure.in is not aware that there is a situation without
a tslib-<VERSION>.pc file. Thus it will not find tslib and this causes
that the tslib input driver won't be built.

DirectFB 1.7.7:

enable_tslib=no
if test "$checkfor_tslib" = "yes"; then
  PKG_CHECK_MODULES([TSLIB], [tslib-1.0 >= 1.0.0], [enable_tslib=yes], [enable_tslib=no])
  if test "$enable_tslib" = "no"; then
     PKG_CHECK_MODULES([TSLIB], [tslib-0.0], [enable_tslib=yes], [enable_tslib=no
       AC_MSG_WARN([*** no tslib -- tslib driver will not be built.])])
  fi
fi


Patched:

enable_tslib=no
if test "$checkfor_tslib" = "yes"; then
  PKG_CHECK_MODULES([TSLIB], [tslib >= 1.1], [enable_tslib=yes], [enable_tslib=no])
  if test "$enable_tslib" = "no"; then
    PKG_CHECK_MODULES([TSLIB], [tslib-1.0 >= 1.0], [enable_tslib=yes], [enable_tslib=no])
    if test "$enable_tslib" = "no"; then
      PKG_CHECK_MODULES([TSLIB], [tslib-0.0], [enable_tslib=yes], [enable_tslib=no
        AC_MSG_WARN([*** no tslib -- tslib driver will not be built.])])
    fi
  fi
fi

Greetings,
Mark

Building Technologies, Panel Software Fire (BT-FIR/ENG1) 
Bosch Sicherheitssysteme GmbH | Postfach 11 11 | 85626 Grasbrunn | GERMANY | www.boschsecurity.com

Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart HRB 23118 
Aufsichtsratsvorsitzender: Stefan Hartung; Geschäftsführung: Tanja Rückert, Andreas Bartz, Thomas Quante, Bernhard Schuster

Re: [meta-oe][PATCH] directfb: fix tslib version check in configure.in

[Khem Raj]

On Tue, Aug 21, 2018 at 2:58 PM <richard.purdie@linuxfoundation.org> wrote:
>
> On Tue, 2018-08-21 at 08:36 +0000, Jonas Mark (BT-FIR/ENG1) wrote:
> > Hi Richard,
> >
> > This is my third attempt getting my reply onto the mailing list. I
> > suspect the first two attempts were filtered due to the link to the
> > v2
> > patch I added. I removed the link this time.
> >
> > I already sent an updated version of the patch to the
> > openembedded-devel@lists.openembedded.org mailing list because an
> > automatic system informed me that I hit the wrong mailing list. I
> > propose to switch to openembedded-devel for further discussions.
> >
> > [meta-oe,v2] directfb: fix tslib version check in configure.in
> >
> > Sadly, there hasn't been any reaction yet.
>
> FWIW your messages do appear to be making it to the mailing list(s) and
> you can see them in the archives, e.g.:
>
> http://lists.openembedded.org/pipermail/openembedded-devel/2018-August/120115.html
>
> I look after OE-Core, not meta-oe where this patch needs to go so I
> can't help with that but the patch is on the right list for them to see
> it.

its in master

>
> Cheers,
>
> Richard

Re: [meta-oe][PATCH] directfb: fix tslib version check in configure.in

[richard.purdie]

On Tue, 2018-08-21 at 08:36 +0000, Jonas Mark (BT-FIR/ENG1) wrote:
> Hi Richard,
> 
> This is my third attempt getting my reply onto the mailing list. I
> suspect the first two attempts were filtered due to the link to the
> v2
> patch I added. I removed the link this time.
> 	
> I already sent an updated version of the patch to the
> openembedded-devel@lists.openembedded.org mailing list because an
> automatic system informed me that I hit the wrong mailing list. I
> propose to switch to openembedded-devel for further discussions.
> 
> [meta-oe,v2] directfb: fix tslib version check in configure.in
> 
> Sadly, there hasn't been any reaction yet.

FWIW your messages do appear to be making it to the mailing list(s) and
you can see them in the archives, e.g.:

http://lists.openembedded.org/pipermail/openembedded-devel/2018-August/120115.html

I look after OE-Core, not meta-oe where this patch needs to go so I
can't help with that but the patch is on the right list for them to see
it.

Cheers,

Richard

Re: [meta-oe][PATCH] directfb: fix tslib version check in configure.in

[Jonas Mark (BT-FIR/ENG1)]

Hi Richard,

This is my third attempt getting my reply onto the mailing list. I
suspect the first two attempts were filtered due to the link to the v2
patch I added. I removed the link this time.
	
I already sent an updated version of the patch to the
openembedded-devel@lists.openembedded.org mailing list because an
automatic system informed me that I hit the wrong mailing list. I
propose to switch to openembedded-devel for further discussions.

[meta-oe,v2] directfb: fix tslib version check in configure.in

Sadly, there hasn't been any reaction yet.

> > From: Guan Ben <ben.guan@cn.bosch.com>
> >
> > The patch makes sure that the old as well as the new tslib pkg-config
> > metadata file naming style is handled correctly.
> >
> > tslib 0.0 to 1.0 created only a tslib-<VERSION>.pc pkg-config
> > metadata
> > file.
> >
> > With tslib 1.1 the tslib-<VERSION>.pc phase out was started.
> > Additionally, the pkg-config metadata file tslib.pc was added.
> >
> > Since tslib 1.6 the tslib-<VERSION>.pc metadata file is deprecated.
> > Now, there is only a tslib.pc.
> 
> I'm a little confused about why OE needs this patch? Surely OE is using
> the more recent tslib releases and therefore we don't need this patch?

OE needs this patch because it uses DirectFB's build system and that is
broken with the most recent tslib releases.

In the beginning tslib only had a tslib-<VERSION>.pc for pkgconfig.

Starting with tslib 1.1, tslib.pc and tslib-<VERSION>.pc were created
for pkgconfig. And the tslib-<VERSION>.pc file was declared to be
deprecated.

From tslib 1.6 on only the tslib.pc file is available.

DirectFB's configure.in is not aware that there is a situation without
a tslib-<VERSION>.pc file. Thus it will not find tslib and this causes
that the tslib input driver won't be built.

DirectFB 1.7.7:

enable_tslib=no
if test "$checkfor_tslib" = "yes"; then
  PKG_CHECK_MODULES([TSLIB], [tslib-1.0 >= 1.0.0], [enable_tslib=yes], [enable_tslib=no])
  if test "$enable_tslib" = "no"; then
     PKG_CHECK_MODULES([TSLIB], [tslib-0.0], [enable_tslib=yes], [enable_tslib=no
       AC_MSG_WARN([*** no tslib -- tslib driver will not be built.])])
  fi
fi


Patched:

enable_tslib=no
if test "$checkfor_tslib" = "yes"; then
  PKG_CHECK_MODULES([TSLIB], [tslib >= 1.1], [enable_tslib=yes], [enable_tslib=no])
  if test "$enable_tslib" = "no"; then
    PKG_CHECK_MODULES([TSLIB], [tslib-1.0 >= 1.0], [enable_tslib=yes], [enable_tslib=no])
    if test "$enable_tslib" = "no"; then
      PKG_CHECK_MODULES([TSLIB], [tslib-0.0], [enable_tslib=yes], [enable_tslib=no
        AC_MSG_WARN([*** no tslib -- tslib driver will not be built.])])
    fi
  fi
fi

Greetings,
Mark

Building Technologies, Panel Software Fire (BT-FIR/ENG1) 
Bosch Sicherheitssysteme GmbH | Postfach 11 11 | 85626 Grasbrunn | GERMANY | www.boschsecurity.com

Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart HRB 23118 
Aufsichtsratsvorsitzender: Stefan Hartung; Geschäftsführung: Tanja Rückert, Andreas Bartz, Thomas Quante, Bernhard Schuster

Re: [meta-oe][PATCH] directfb: fix tslib version check in configure.in

[Jonas Mark (BT-FIR/ENG1)]

Hi Richard,

I already sent an updated version of the patch to the
openembedded-devel@lists.openembedded.org mailing list because an
automatic system informed me that I hit the wrong mailing list. I
propose to switch to openembedded-devel for further discussions.

[meta-oe,v2] directfb: fix tslib version check in configure.in
https://patchwork.openembedded.org/patch/153470/

Sadly, there hasn't been any reaction yet.

> > From: Guan Ben <ben.guan@cn.bosch.com>
> >
> > The patch makes sure that the old as well as the new tslib pkg-config
> > metadata file naming style is handled correctly.
> >
> > tslib 0.0 to 1.0 created only a tslib-<VERSION>.pc pkg-config
> > metadata
> > file.
> >
> > With tslib 1.1 the tslib-<VERSION>.pc phase out was started.
> > Additionally, the pkg-config metadata file tslib.pc was added.
> >
> > Since tslib 1.6 the tslib-<VERSION>.pc metadata file is deprecated.
> > Now, there is only a tslib.pc.
> 
> I'm a little confused about why OE needs this patch? Surely OE is using
> the more recent tslib releases and therefore we don't need this patch?

OE needs this patch because it uses DirectFB's build system and that is
broken with the most recent tslib releases.

In the beginning tslib only had a tslib-<VERSION>.pc for pkgconfig.

Starting with tslib 1.1, tslib.pc and tslib-<VERSION>.pc were created
for pkgconfig. And the tslib-<VERSION>.pc file was declared to be
deprecated.

From tslib 1.6 on only the tslib.pc file is available.

DirectFB's configure.in is not aware that there is a situation without
a tslib-<VERSION>.pc file. Thus it will not find tslib and this causes
that the tslib input driver won't be built.

DirectFB 1.7.7:

enable_tslib=no
if test "$checkfor_tslib" = "yes"; then
  PKG_CHECK_MODULES([TSLIB], [tslib-1.0 >= 1.0.0], [enable_tslib=yes], [enable_tslib=no])
  if test "$enable_tslib" = "no"; then
     PKG_CHECK_MODULES([TSLIB], [tslib-0.0], [enable_tslib=yes], [enable_tslib=no
       AC_MSG_WARN([*** no tslib -- tslib driver will not be built.])])
  fi
fi


Patched:

enable_tslib=no
if test "$checkfor_tslib" = "yes"; then
  PKG_CHECK_MODULES([TSLIB], [tslib >= 1.1], [enable_tslib=yes], [enable_tslib=no])
  if test "$enable_tslib" = "no"; then
    PKG_CHECK_MODULES([TSLIB], [tslib-1.0 >= 1.0], [enable_tslib=yes], [enable_tslib=no])
    if test "$enable_tslib" = "no"; then
      PKG_CHECK_MODULES([TSLIB], [tslib-0.0], [enable_tslib=yes], [enable_tslib=no
        AC_MSG_WARN([*** no tslib -- tslib driver will not be built.])])
    fi
  fi
fi

Greetings,
Mark

Building Technologies, Panel Software Fire (BT-FIR/ENG1) 
Bosch Sicherheitssysteme GmbH | Postfach 11 11 | 85626 Grasbrunn | GERMANY | www.boschsecurity.com

Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart HRB 23118 
Aufsichtsratsvorsitzender: Stefan Hartung; Geschäftsführung: Tanja Rückert, Andreas Bartz, Thomas Quante, Bernhard Schuster

Re: [meta-oe][PATCH] directfb: fix tslib version check in configure.in

[Richard Purdie]

On Sat, 2018-08-04 at 20:26 +0200, Mark Jonas wrote:
> From: Guan Ben <ben.guan@cn.bosch.com>
> 
> The patch makes sure that the old as well as the new tslib pkg-config
> metadata file naming style is handled correctly.
> 
> tslib 0.0 to 1.0 created only a tslib-<VERSION>.pc pkg-config
> metadata
> file.
> 
> With tslib 1.1 the tslib-<VERSION>.pc phase out was started.
> Additionally, the pkg-config metadata file tslib.pc was added.
> 
> Since tslib 1.6 the tslib-<VERSION>.pc metadata file is deprecated.
> Now, there is only a tslib.pc.

I'm a little confused about why OE needs this patch? Surely OE is using
the more recent tslib releases and therefore we don't need this patch?

Cheers,

Richard

[meta-oe][PATCH] directfb: fix tslib version check in configure.in

[Mark Jonas]

From: Guan Ben <ben.guan@cn.bosch.com>

The patch makes sure that the old as well as the new tslib pkg-config
metadata file naming style is handled correctly.

tslib 0.0 to 1.0 created only a tslib-<VERSION>.pc pkg-config metadata
file.

With tslib 1.1 the tslib-<VERSION>.pc phase out was started.
Additionally, the pkg-config metadata file tslib.pc was added.

Since tslib 1.6 the tslib-<VERSION>.pc metadata file is deprecated.
Now, there is only a tslib.pc.

Signed-off-by: Ben Guan <ben.guan@cn.bosch.com>
Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com>
---
 meta-oe/recipes-graphics/directfb/directfb.inc       |  1 +
 .../directfb/fix-tslib-version-version-check.patch   | 20 ++++++++++++++++++++
 2 files changed, 21 insertions(+)
 create mode 100644 meta-oe/recipes-graphics/directfb/directfb/fix-tslib-version-version-check.patch

diff --git a/meta-oe/recipes-graphics/directfb/directfb.inc b/meta-oe/recipes-graphics/directfb/directfb.inc
index bd66a28..af07ad7 100644
--- a/meta-oe/recipes-graphics/directfb/directfb.inc
+++ b/meta-oe/recipes-graphics/directfb/directfb.inc
@@ -20,6 +20,7 @@ SRC_URI = "http://downloads.yoctoproject.org/mirror/sources/DirectFB-${PV}.tar.g
            file://union-sigval.patch \
            file://use-PTHREAD_MUTEX_RECURSIVE.patch \
            file://fix-client-gfx_state-initialisation.patch \
+           file://fix-tslib-version-version-check.patch \
           "
 
 S = "${WORKDIR}/DirectFB-${PV}"
diff --git a/meta-oe/recipes-graphics/directfb/directfb/fix-tslib-version-version-check.patch b/meta-oe/recipes-graphics/directfb/directfb/fix-tslib-version-version-check.patch
new file mode 100644
index 0000000..b30db11
--- /dev/null
+++ b/meta-oe/recipes-graphics/directfb/directfb/fix-tslib-version-version-check.patch
@@ -0,0 +1,20 @@
+diff -Nru DirectFB-1.7.7.orig/configure.in DirectFB-1.7.7/configure.in
+--- DirectFB-1.7.7.orig/configure.in	2015-02-10 01:16:46.000000000 +0800
++++ DirectFB-1.7.7/configure.in	2018-06-06 17:19:18.472143103 +0800
+@@ -2459,10 +2459,13 @@
+ 
+ enable_tslib=no
+ if test "$checkfor_tslib" = "yes"; then
+-  PKG_CHECK_MODULES([TSLIB], [tslib-1.0 >= 1.0.0], [enable_tslib=yes], [enable_tslib=no])
++  PKG_CHECK_MODULES([TSLIB], [tslib >= 1.1], [enable_tslib=yes], [enable_tslib=no])
+   if test "$enable_tslib" = "no"; then
+-     PKG_CHECK_MODULES([TSLIB], [tslib-0.0], [enable_tslib=yes], [enable_tslib=no
+-       AC_MSG_WARN([*** no tslib -- tslib driver will not be built.])])
++    PKG_CHECK_MODULES([TSLIB], [tslib-1.0 >= 1.0], [enable_tslib=yes], [enable_tslib=no])
++    if test "$enable_tslib" = "no"; then
++      PKG_CHECK_MODULES([TSLIB], [tslib-0.0], [enable_tslib=yes], [enable_tslib=no
++        AC_MSG_WARN([*** no tslib -- tslib driver will not be built.])])
++    fi
+   fi
+ fi
+ 
-- 
2.7.4