From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> To: Lee Jones <lee.jones@linaro.org> Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, johnson.wang@mediatek.com, hsin-hsiung.wang@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: mfd: mt6397: Add compatibles for MT6331 RTC and keys Date: Thu, 16 Jun 2022 10:36:23 +0200 [thread overview] Message-ID: <2859add6-74c3-5a4e-d3fa-68b311418459@collabora.com> (raw) In-Reply-To: <YqpTrwlXmXMYuDd0@google.com> Il 15/06/22 23:48, Lee Jones ha scritto: > On Fri, 20 May 2022, AngeloGioacchino Del Regno wrote: > >> MT6331 is a multifunction device, providing RTC, keys and more: add > > No such thing as an MFD. What does the data-sheet call it? Datasheets for this chip, or the other (6332) are not public ... and I have no access to any: whatever you see here is done with an accurate reading of downstream drivers and a lot of debugging and research. Anyway, MT6331 is a PMIC, MT6332 is also a PMIC (in this case, a companion pmic). > > What "more"? > More is voltage regulators, display backlight PWM, LED PWM, some GPIOs, battery charging, fuel gauge... and I think nothing else. Anyway, okay I will list things out in the commit description. >> the necessary compatibles to start implementing the basics. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> Documentation/devicetree/bindings/mfd/mt6397.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt >> index d59063503b0d..2a9533c47365 100644 >> --- a/Documentation/devicetree/bindings/mfd/mt6397.txt >> +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt >> @@ -30,6 +30,7 @@ Optional subnodes: >> - rtc >> Required properties: Should be one of follows >> - compatible: "mediatek,mt6323-rtc" >> + - compatible: "mediatek,mt6331-rtc" >> - compatible: "mediatek,mt6358-rtc" >> - compatible: "mediatek,mt6397-rtc" >> For details, see ../rtc/rtc-mt6397.txt >> @@ -55,6 +56,7 @@ Optional subnodes: >> - keys >> Required properties: >> - compatible: "mediatek,mt6397-keys" or "mediatek,mt6323-keys" >> + or "mediatek,mt6331-keys" > > Please place these in a vertical list. Will do! Regards, Angelo
WARNING: multiple messages have this Message-ID (diff)
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> To: Lee Jones <lee.jones@linaro.org> Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, johnson.wang@mediatek.com, hsin-hsiung.wang@mediatek.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] dt-bindings: mfd: mt6397: Add compatibles for MT6331 RTC and keys Date: Thu, 16 Jun 2022 10:36:23 +0200 [thread overview] Message-ID: <2859add6-74c3-5a4e-d3fa-68b311418459@collabora.com> (raw) In-Reply-To: <YqpTrwlXmXMYuDd0@google.com> Il 15/06/22 23:48, Lee Jones ha scritto: > On Fri, 20 May 2022, AngeloGioacchino Del Regno wrote: > >> MT6331 is a multifunction device, providing RTC, keys and more: add > > No such thing as an MFD. What does the data-sheet call it? Datasheets for this chip, or the other (6332) are not public ... and I have no access to any: whatever you see here is done with an accurate reading of downstream drivers and a lot of debugging and research. Anyway, MT6331 is a PMIC, MT6332 is also a PMIC (in this case, a companion pmic). > > What "more"? > More is voltage regulators, display backlight PWM, LED PWM, some GPIOs, battery charging, fuel gauge... and I think nothing else. Anyway, okay I will list things out in the commit description. >> the necessary compatibles to start implementing the basics. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> Documentation/devicetree/bindings/mfd/mt6397.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt >> index d59063503b0d..2a9533c47365 100644 >> --- a/Documentation/devicetree/bindings/mfd/mt6397.txt >> +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt >> @@ -30,6 +30,7 @@ Optional subnodes: >> - rtc >> Required properties: Should be one of follows >> - compatible: "mediatek,mt6323-rtc" >> + - compatible: "mediatek,mt6331-rtc" >> - compatible: "mediatek,mt6358-rtc" >> - compatible: "mediatek,mt6397-rtc" >> For details, see ../rtc/rtc-mt6397.txt >> @@ -55,6 +56,7 @@ Optional subnodes: >> - keys >> Required properties: >> - compatible: "mediatek,mt6397-keys" or "mediatek,mt6323-keys" >> + or "mediatek,mt6331-keys" > > Please place these in a vertical list. Will do! Regards, Angelo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-16 8:36 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-20 12:46 [PATCH 0/2] MediaTek Helio X10 MT6795 - MT6331/6332 PMIC MFD integration AngeloGioacchino Del Regno 2022-05-20 12:46 ` AngeloGioacchino Del Regno 2022-05-20 12:46 ` AngeloGioacchino Del Regno 2022-05-20 12:46 ` [PATCH 1/2] dt-bindings: mfd: mt6397: Add compatibles for MT6331 RTC and keys AngeloGioacchino Del Regno 2022-05-20 12:46 ` AngeloGioacchino Del Regno 2022-05-20 12:46 ` AngeloGioacchino Del Regno 2022-06-01 11:07 ` Krzysztof Kozlowski 2022-06-01 11:07 ` Krzysztof Kozlowski 2022-06-01 11:07 ` Krzysztof Kozlowski 2022-06-15 21:48 ` Lee Jones 2022-06-15 21:48 ` Lee Jones 2022-06-16 8:36 ` AngeloGioacchino Del Regno [this message] 2022-06-16 8:36 ` AngeloGioacchino Del Regno 2022-05-20 12:46 ` [PATCH 2/2] mfd: mt6397: Add basic support for MT6331+MT6332 PMIC AngeloGioacchino Del Regno 2022-05-20 12:46 ` AngeloGioacchino Del Regno 2022-05-20 12:46 ` AngeloGioacchino Del Regno 2022-06-15 21:52 ` Lee Jones 2022-06-15 21:52 ` Lee Jones 2022-06-16 8:43 ` AngeloGioacchino Del Regno 2022-06-16 8:43 ` AngeloGioacchino Del Regno 2022-06-16 18:40 ` Lee Jones 2022-06-16 18:40 ` Lee Jones 2022-06-17 7:35 ` AngeloGioacchino Del Regno 2022-06-17 7:35 ` AngeloGioacchino Del Regno 2022-06-01 11:03 ` [PATCH 0/2] MediaTek Helio X10 MT6795 - MT6331/6332 PMIC MFD integration AngeloGioacchino Del Regno 2022-06-01 11:03 ` AngeloGioacchino Del Regno 2022-06-01 11:03 ` AngeloGioacchino Del Regno 2022-06-01 11:07 ` Krzysztof Kozlowski 2022-06-01 11:07 ` Krzysztof Kozlowski 2022-06-01 11:07 ` Krzysztof Kozlowski 2022-06-01 11:08 ` AngeloGioacchino Del Regno 2022-06-01 11:08 ` AngeloGioacchino Del Regno 2022-06-01 11:08 ` AngeloGioacchino Del Regno
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2859add6-74c3-5a4e-d3fa-68b311418459@collabora.com \ --to=angelogioacchino.delregno@collabora.com \ --cc=devicetree@vger.kernel.org \ --cc=hsin-hsiung.wang@mediatek.com \ --cc=johnson.wang@mediatek.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.