All of lore.kernel.org
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Tomasz Figa <tomasz.figa@gmail.com>,
	linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Aditya Pakki <pakki001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
	Navid Emamdoost <emamd001@umn.edu>,
	Stephen McCamant <smccaman@umn.edu>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: clk: samsung: Checking a kmemdup() call in _samsung_clk_register_pll()
Date: Wed, 16 Oct 2019 12:55:22 +0200	[thread overview]
Message-ID: <285fab33-0513-8a6b-f30d-f602c4e5108e@web.de> (raw)
In-Reply-To: <CA+Ln22GpcMF5e8wjwoRH0wExyoGfta4n3YuaOBNDE+rfqhSZjg@mail.gmail.com>

>> * Is there a need to adjust the error handling here?
>
> No, there isn't much that can be done if we fail the allocation at
> such an early stage.

Can it matter to perform the setting “pll->rate_count” only according
to a null pointer check for the variable “pll->rate_table”
because of the function call “kmemdup”?

Regards,
Markus

WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Tomasz Figa <tomasz.figa@gmail.com>,
	linux-clk@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>,
	Aditya Pakki <pakki001@umn.edu>, Kangjie Lu <kjlu@umn.edu>,
	Navid Emamdoost <emamd001@umn.edu>,
	Stephen McCamant <smccaman@umn.edu>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: clk: samsung: Checking a kmemdup() call in _samsung_clk_register_pll()
Date: Wed, 16 Oct 2019 10:55:22 +0000	[thread overview]
Message-ID: <285fab33-0513-8a6b-f30d-f602c4e5108e@web.de> (raw)
In-Reply-To: <CA+Ln22GpcMF5e8wjwoRH0wExyoGfta4n3YuaOBNDE+rfqhSZjg@mail.gmail.com>

>> * Is there a need to adjust the error handling here?
>
> No, there isn't much that can be done if we fail the allocation at
> such an early stage.

Can it matter to perform the setting “pll->rate_count” only according
to a null pointer check for the variable “pll->rate_table”
because of the function call “kmemdup”?

Regards,
Markus

  parent reply	other threads:[~2019-10-16 10:55 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-12 14:17 clk: samsung: Checking a kmemdup() call in _samsung_clk_register_pll() Markus Elfring
2019-10-12 14:17 ` Markus Elfring
2019-10-15 14:49 ` Tomasz Figa
2019-10-15 14:49   ` Tomasz Figa
2019-10-15 17:55   ` Markus Elfring
2019-10-15 17:55     ` Markus Elfring
2019-10-16 11:43     ` Tomasz Figa
2019-10-16 11:43       ` Tomasz Figa
2019-10-16 11:58       ` Markus Elfring
2019-10-16 11:58         ` Markus Elfring
2019-10-15 17:55   ` Markus Elfring
2019-10-15 17:55     ` Markus Elfring
2019-10-16 10:55   ` Markus Elfring [this message]
2019-10-16 10:55     ` Markus Elfring
2019-10-16 11:44     ` Tomasz Figa
2019-10-16 11:44       ` Tomasz Figa
     [not found] <CGME20191012141739epcas3p31e41c151b30d49c94aeb933aa42dc9f7@epcas3p3.samsung.com>
2019-10-12 14:17 ` Markus Elfring
2019-10-12 14:17   ` Markus Elfring
2019-10-14  6:55   ` Chanwoo Choi
2019-10-14  6:55     ` Chanwoo Choi
2019-10-14  8:05     ` Markus Elfring
2019-10-14  8:05       ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=285fab33-0513-8a6b-f30d-f602c4e5108e@web.de \
    --to=markus.elfring@web.de \
    --cc=cw00.choi@samsung.com \
    --cc=emamd001@umn.edu \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kjlu@umn.edu \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=pakki001@umn.edu \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@kernel.org \
    --cc=smccaman@umn.edu \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.