All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Baoyou Xie <baoyou.xie@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	xie.baoyou@zte.com.cn
Subject: Re: [PATCH] clk: versatile: add missing header dependencies
Date: Wed, 14 Sep 2016 11:08:28 +0200	[thread overview]
Message-ID: <2862092.ohvOYo10Tb@wuerfel> (raw)
In-Reply-To: <CACRpkdb2BK2_CeSJ8kbuZH6_WwDRqabhcuMqRb+etCBwT80K7A@mail.gmail.com>

On Wednesday, September 14, 2016 11:04:29 AM CEST Linus Walleij wrote:
> On Wed, Sep 14, 2016 at 9:31 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Wednesday, September 14, 2016 2:29:47 PM CEST Baoyou Xie wrote:
> >> We get 1 warning when building kernel with W=1:
> >> drivers/clk/versatile/clk-realview.c:54:13: warning: no previous prototype for 'realview_clk_init' [-Wmissing-prototypes]
> >>
> >> In fact, this function is declared in clk-realview.h,
> >> so this patch add missing header dependencies.
> >>
> >> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> >>
> >
> > Please leave this one for now. We are in the process of removing the
> > last caller of this function, and should just remove the header file
> > and the function definition in the next release.
> 
> +1 on this, leave it. I can clean it up for v4.10 or even
> for an -rc if you want it real neat in v4.9.
> 

I think v4.10 is fine: Baoyou has done a great job so far fixing a lot
of those warnings, but we already know that there will be a lot remaining
after v4.9, so v4.10 is the earliest possible version in which we
can turn on the warning by default.

	Arnd

  reply	other threads:[~2016-09-14  9:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-14  6:29 [PATCH] clk: versatile: add missing header dependencies Baoyou Xie
2016-09-14  7:31 ` Arnd Bergmann
2016-09-14  9:04   ` Linus Walleij
2016-09-14  9:08     ` Arnd Bergmann [this message]
2016-09-24  4:31 Baoyou Xie
2016-09-24  9:09 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2862092.ohvOYo10Tb@wuerfel \
    --to=arnd@arndb.de \
    --cc=baoyou.xie@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=sboyd@codeaurora.org \
    --cc=xie.baoyou@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.