[PATCH] irqchip/irq-imx-gpcv2: Remove unused function

[PATCH] irqchip/irq-imx-gpcv2: Remove unused function

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@nxp.com>

imx_gpcv2_get_wakeup_source() is not used anywhere, so remove it.

This fixes the following sparse warning:

drivers/irqchip/irq-imx-gpcv2.c:34:5: warning: symbol 'imx_gpcv2_get_wakeup_source' was not declared. Should it be static?

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 drivers/irqchip/irq-imx-gpcv2.c | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
index 675eda5..4760307 100644
--- a/drivers/irqchip/irq-imx-gpcv2.c
+++ b/drivers/irqchip/irq-imx-gpcv2.c
@@ -28,20 +28,6 @@ struct gpcv2_irqchip_data {
 
 static struct gpcv2_irqchip_data *imx_gpcv2_instance;
 
-/*
- * Interface for the low level wakeup code.
- */
-u32 imx_gpcv2_get_wakeup_source(u32 **sources)
-{
-	if (!imx_gpcv2_instance)
-		return 0;
-
-	if (sources)
-		*sources = imx_gpcv2_instance->wakeup_sources;
-
-	return IMR_NUM;
-}
-
 static int gpcv2_wakeup_source_save(void)
 {
 	struct gpcv2_irqchip_data *cd;
-- 
2.7.4

Re: [PATCH] irqchip/irq-imx-gpcv2: Remove unused function

[Marc Zyngier]

On 12/02/18 13:12, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> imx_gpcv2_get_wakeup_source() is not used anywhere, so remove it.
> 
> This fixes the following sparse warning:
> 
> drivers/irqchip/irq-imx-gpcv2.c:34:5: warning: symbol 'imx_gpcv2_get_wakeup_source' was not declared. Should it be static?
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  drivers/irqchip/irq-imx-gpcv2.c | 14 --------------
>  1 file changed, 14 deletions(-)
> 
> diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c
> index 675eda5..4760307 100644
> --- a/drivers/irqchip/irq-imx-gpcv2.c
> +++ b/drivers/irqchip/irq-imx-gpcv2.c
> @@ -28,20 +28,6 @@ struct gpcv2_irqchip_data {
>  
>  static struct gpcv2_irqchip_data *imx_gpcv2_instance;
>  
> -/*
> - * Interface for the low level wakeup code.
> - */
> -u32 imx_gpcv2_get_wakeup_source(u32 **sources)
> -{
> -	if (!imx_gpcv2_instance)
> -		return 0;
> -
> -	if (sources)
> -		*sources = imx_gpcv2_instance->wakeup_sources;
> -
> -	return IMR_NUM;
> -}
> -
>  static int gpcv2_wakeup_source_save(void)
>  {
>  	struct gpcv2_irqchip_data *cd;
> 

I'll queue this up for -rc2, with this addition:

Fixes: e324c4dc4a59 ("irqchip/imx-gpcv2: IMX GPCv2 driver for wakeup
sources")

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

Re: [PATCH] irqchip/irq-imx-gpcv2: Remove unused function

[Fabio Estevam]

Hi Marc,

On Mon, Feb 12, 2018 at 11:22 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:

> I'll queue this up for -rc2, with this addition:
>
> Fixes: e324c4dc4a59 ("irqchip/imx-gpcv2: IMX GPCv2 driver for wakeup
> sources")

It seems this one got missed?

Thanks

Re: [PATCH] irqchip/irq-imx-gpcv2: Remove unused function

[Marc Zyngier]

On Sat, 10 Mar 2018 20:31:27 +0000,
Fabio Estevam wrote:
> 
> Hi Marc,
> 
> On Mon, Feb 12, 2018 at 11:22 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:
> 
> > I'll queue this up for -rc2, with this addition:
> >
> > Fixes: e324c4dc4a59 ("irqchip/imx-gpcv2: IMX GPCv2 driver for wakeup
> > sources")
> 
> It seems this one got missed?

Yes, that's quite bizarre. I see it in the queue of patches for the
-rc2 pull request, but I managed not to apply it. I have no idea how I
managed that, as the process is pretty much automatic... I must have
dropped it when rebasing the branch on -rc1. Sorry about that.

I've now moved the patch to the -rc5 tag which I'm about to send to
Thomas with the few patches I had already queued.

Thanks for the heads up.

	M.

-- 
Jazz is not dead, it just smell funny.