All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] Fix flash and erase of eMMC Boot2 with Fastboot
@ 2021-05-14 21:06 Oleh Kravchenko
  2021-05-14 21:24 ` Oleh Kravchenko
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Oleh Kravchenko @ 2021-05-14 21:06 UTC (permalink / raw)
  To: u-boot

The current U-Boot version has the next matches for boot partitions:
> mmc0boot0 to EMMC_BOOT1
> mmc0boot1 to EMMC_BOOT1 (should be EMMC_BOOT2)
This patch fixes a typo for the boot partition number.

Signed-off-by: Oleh Kravchenko <oleg@kaa.org.ua>
Cc: Pantelis Antoniou <panto@antoniou-consulting.com>
Cc: Marek Vasut <marex@denx.de>
---
Changes for v2:
   - updated commit message
   - CI https://github.com/u-boot/u-boot/pull/76

 drivers/fastboot/fb_mmc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/fastboot/fb_mmc.c b/drivers/fastboot/fb_mmc.c
index 2f3837e559..2326067882 100644
--- a/drivers/fastboot/fb_mmc.c
+++ b/drivers/fastboot/fb_mmc.c
@@ -525,7 +525,7 @@ void fastboot_mmc_flash_write(const char *cmd, void *download_buffer,
 	if (strcmp(cmd, CONFIG_FASTBOOT_MMC_BOOT2_NAME) == 0) {
 		dev_desc = fastboot_mmc_get_dev(response);
 		if (dev_desc)
-			fb_mmc_boot_ops(dev_desc, download_buffer, 1,
+			fb_mmc_boot_ops(dev_desc, download_buffer, 2,
 					download_bytes, response);
 		return;
 	}
@@ -655,7 +655,7 @@ void fastboot_mmc_erase(const char *cmd, char *response)
 		/* erase EMMC boot2 */
 		dev_desc = fastboot_mmc_get_dev(response);
 		if (dev_desc)
-			fb_mmc_boot_ops(dev_desc, NULL, 1, 0, response);
+			fb_mmc_boot_ops(dev_desc, NULL, 2, 0, response);
 		return;
 	}
 #endif
-- 
2.26.3

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* [PATCH v2] Fix flash and erase of eMMC Boot2 with Fastboot
  2021-05-14 21:06 [PATCH v2] Fix flash and erase of eMMC Boot2 with Fastboot Oleh Kravchenko
@ 2021-05-14 21:24 ` Oleh Kravchenko
  2021-05-20 14:59 ` Sean Anderson
  2021-08-22 20:54 ` Tom Rini
  2 siblings, 0 replies; 5+ messages in thread
From: Oleh Kravchenko @ 2021-05-14 21:24 UTC (permalink / raw)
  To: u-boot

Hello guys,
Could you please review and merge this patch?

PR successfully passed CI:
https://github.com/u-boot/u-boot/pull/76

15.05.21 00:06, Oleh Kravchenko ????:
> The current U-Boot version has the next matches for boot partitions:
>> mmc0boot0 to EMMC_BOOT1
>> mmc0boot1 to EMMC_BOOT1 (should be EMMC_BOOT2)
> This patch fixes a typo for the boot partition number.
> 
> Signed-off-by: Oleh Kravchenko <oleg@kaa.org.ua>
> Cc: Pantelis Antoniou <panto@antoniou-consulting.com>
> Cc: Marek Vasut <marex@denx.de>
> ---
> Changes for v2:
>    - updated commit message
>    - CI https://github.com/u-boot/u-boot/pull/76
> 
>  drivers/fastboot/fb_mmc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/fastboot/fb_mmc.c b/drivers/fastboot/fb_mmc.c
> index 2f3837e559..2326067882 100644
> --- a/drivers/fastboot/fb_mmc.c
> +++ b/drivers/fastboot/fb_mmc.c
> @@ -525,7 +525,7 @@ void fastboot_mmc_flash_write(const char *cmd, void *download_buffer,
>  	if (strcmp(cmd, CONFIG_FASTBOOT_MMC_BOOT2_NAME) == 0) {
>  		dev_desc = fastboot_mmc_get_dev(response);
>  		if (dev_desc)
> -			fb_mmc_boot_ops(dev_desc, download_buffer, 1,
> +			fb_mmc_boot_ops(dev_desc, download_buffer, 2,
>  					download_bytes, response);
>  		return;
>  	}
> @@ -655,7 +655,7 @@ void fastboot_mmc_erase(const char *cmd, char *response)
>  		/* erase EMMC boot2 */
>  		dev_desc = fastboot_mmc_get_dev(response);
>  		if (dev_desc)
> -			fb_mmc_boot_ops(dev_desc, NULL, 1, 0, response);
> +			fb_mmc_boot_ops(dev_desc, NULL, 2, 0, response);
>  		return;
>  	}
>  #endif
> 

-- 
Best regards,
Oleh Kravchenko

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH v2] Fix flash and erase of eMMC Boot2 with Fastboot
  2021-05-14 21:06 [PATCH v2] Fix flash and erase of eMMC Boot2 with Fastboot Oleh Kravchenko
  2021-05-14 21:24 ` Oleh Kravchenko
@ 2021-05-20 14:59 ` Sean Anderson
  2021-05-20 15:20   ` Oleh Kravchenko
  2021-08-22 20:54 ` Tom Rini
  2 siblings, 1 reply; 5+ messages in thread
From: Sean Anderson @ 2021-05-20 14:59 UTC (permalink / raw)
  To: u-boot



On 5/14/21 5:06 PM, Oleh Kravchenko wrote:
> The current U-Boot version has the next matches for boot partitions:
>> mmc0boot0 to EMMC_BOOT1
>> mmc0boot1 to EMMC_BOOT1 (should be EMMC_BOOT2)
> This patch fixes a typo for the boot partition number.
> 
> Signed-off-by: Oleh Kravchenko <oleg@kaa.org.ua>
> Cc: Pantelis Antoniou <panto@antoniou-consulting.com>
> Cc: Marek Vasut <marex@denx.de>
> ---
> Changes for v2:
>     - updated commit message
>     - CI https://github.com/u-boot/u-boot/pull/76
> 
>   drivers/fastboot/fb_mmc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/fastboot/fb_mmc.c b/drivers/fastboot/fb_mmc.c
> index 2f3837e559..2326067882 100644
> --- a/drivers/fastboot/fb_mmc.c
> +++ b/drivers/fastboot/fb_mmc.c
> @@ -525,7 +525,7 @@ void fastboot_mmc_flash_write(const char *cmd, void *download_buffer,
>   	if (strcmp(cmd, CONFIG_FASTBOOT_MMC_BOOT2_NAME) == 0) {
>   		dev_desc = fastboot_mmc_get_dev(response);
>   		if (dev_desc)
> -			fb_mmc_boot_ops(dev_desc, download_buffer, 1,
> +			fb_mmc_boot_ops(dev_desc, download_buffer, 2,
>   					download_bytes, response);
>   		return;
>   	}
> @@ -655,7 +655,7 @@ void fastboot_mmc_erase(const char *cmd, char *response)
>   		/* erase EMMC boot2 */
>   		dev_desc = fastboot_mmc_get_dev(response);
>   		if (dev_desc)
> -			fb_mmc_boot_ops(dev_desc, NULL, 1, 0, response);
> +			fb_mmc_boot_ops(dev_desc, NULL, 2, 0, response);
>   		return;
>   	}
>   #endif
> 

Reviewed-by: Sean Anderson <sean.anderson@seco.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH v2] Fix flash and erase of eMMC Boot2 with Fastboot
  2021-05-20 14:59 ` Sean Anderson
@ 2021-05-20 15:20   ` Oleh Kravchenko
  0 siblings, 0 replies; 5+ messages in thread
From: Oleh Kravchenko @ 2021-05-20 15:20 UTC (permalink / raw)
  To: u-boot

Hello Lukasz,
Could you please review this patch?

This patch fixes small typos for Fastboot mmc boot2 partition.

20.05.21 17:59, Sean Anderson ????:
> 
> 
> On 5/14/21 5:06 PM, Oleh Kravchenko wrote:
>> The current U-Boot version has the next matches for boot partitions:
>>> mmc0boot0 to EMMC_BOOT1
>>> mmc0boot1 to EMMC_BOOT1 (should be EMMC_BOOT2)
>> This patch fixes a typo for the boot partition number.
>>
>> Signed-off-by: Oleh Kravchenko <oleg@kaa.org.ua>
>> Cc: Pantelis Antoniou <panto@antoniou-consulting.com>
>> Cc: Marek Vasut <marex@denx.de>
>> ---
>> Changes for v2:
>> ??? - updated commit message
>> ??? - CI https://github.com/u-boot/u-boot/pull/76
>>
>> ? drivers/fastboot/fb_mmc.c | 4 ++--
>> ? 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/fastboot/fb_mmc.c b/drivers/fastboot/fb_mmc.c
>> index 2f3837e559..2326067882 100644
>> --- a/drivers/fastboot/fb_mmc.c
>> +++ b/drivers/fastboot/fb_mmc.c
>> @@ -525,7 +525,7 @@ void fastboot_mmc_flash_write(const char *cmd, void *download_buffer,
>> ????? if (strcmp(cmd, CONFIG_FASTBOOT_MMC_BOOT2_NAME) == 0) {
>> ????????? dev_desc = fastboot_mmc_get_dev(response);
>> ????????? if (dev_desc)
>> -??????????? fb_mmc_boot_ops(dev_desc, download_buffer, 1,
>> +??????????? fb_mmc_boot_ops(dev_desc, download_buffer, 2,
>> ????????????????????? download_bytes, response);
>> ????????? return;
>> ????? }
>> @@ -655,7 +655,7 @@ void fastboot_mmc_erase(const char *cmd, char *response)
>> ????????? /* erase EMMC boot2 */
>> ????????? dev_desc = fastboot_mmc_get_dev(response);
>> ????????? if (dev_desc)
>> -??????????? fb_mmc_boot_ops(dev_desc, NULL, 1, 0, response);
>> +??????????? fb_mmc_boot_ops(dev_desc, NULL, 2, 0, response);
>> ????????? return;
>> ????? }
>> ? #endif
>>
> 
> Reviewed-by: Sean Anderson <sean.anderson@seco.com>

-- 
Best regards,
Oleh Kravchenko

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH v2] Fix flash and erase of eMMC Boot2 with Fastboot
  2021-05-14 21:06 [PATCH v2] Fix flash and erase of eMMC Boot2 with Fastboot Oleh Kravchenko
  2021-05-14 21:24 ` Oleh Kravchenko
  2021-05-20 14:59 ` Sean Anderson
@ 2021-08-22 20:54 ` Tom Rini
  2 siblings, 0 replies; 5+ messages in thread
From: Tom Rini @ 2021-08-22 20:54 UTC (permalink / raw)
  To: Oleh Kravchenko; +Cc: u-boot, Pantelis Antoniou, Marek Vasut

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

On Sat, May 15, 2021 at 12:06:21AM +0300, Oleh Kravchenko wrote:

> The current U-Boot version has the next matches for boot partitions:
> > mmc0boot0 to EMMC_BOOT1
> > mmc0boot1 to EMMC_BOOT1 (should be EMMC_BOOT2)
> This patch fixes a typo for the boot partition number.
> 
> Signed-off-by: Oleh Kravchenko <oleg@kaa.org.ua>
> Cc: Pantelis Antoniou <panto@antoniou-consulting.com>
> Cc: Marek Vasut <marex@denx.de>
> Reviewed-by: Sean Anderson <sean.anderson@seco.com>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-08-22 20:54 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-14 21:06 [PATCH v2] Fix flash and erase of eMMC Boot2 with Fastboot Oleh Kravchenko
2021-05-14 21:24 ` Oleh Kravchenko
2021-05-20 14:59 ` Sean Anderson
2021-05-20 15:20   ` Oleh Kravchenko
2021-08-22 20:54 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.