dmaengine: ppc4xx: fix off-by-one build failure

dmaengine: ppc4xx: fix off-by-one build failure

[Christian Lamparter]

On Tuesday, October 16, 2018 4:40:27 PM CEST Vinod wrote:
> On 14-10-18, 23:28, Christian Lamparter wrote:
> > There are two poly_store, but one should have been poly_show.
> > 
> > |adma.c:4382:16: error: conflicting types for 'poly_store'
> > | static ssize_t poly_store(struct device_driver *dev, const char *buf,
> > |                ^~~~~~~~~~
> > |adma.c:4363:16: note: previous definition of 'poly_store' was here
> > | static ssize_t poly_store(struct device_driver *dev, char *buf)
> > |                ^~~~~~~~~~
> 
> How come no one noticed till now :(

Well, I don't know if this driver works or not. I tried to evaluate
if this driver could be modified to fit the PLB4DMA of the APM82181.
But sadly this was not the case because the APM82181 and PPC460EX 
have a new design. So, I just happend to find this little bug, no
idea if there's more bit-rot. 
 
Regards,
Christian

dmaengine: ppc4xx: fix off-by-one build failure

[Vinod Koul]

On 14-10-18, 23:28, Christian Lamparter wrote:
> There are two poly_store, but one should have been poly_show.
> 
> |adma.c:4382:16: error: conflicting types for 'poly_store'
> | static ssize_t poly_store(struct device_driver *dev, const char *buf,
> |                ^~~~~~~~~~
> |adma.c:4363:16: note: previous definition of 'poly_store' was here
> | static ssize_t poly_store(struct device_driver *dev, char *buf)
> |                ^~~~~~~~~~

How come no one noticed till now :(

Applied and cced stable

Thanks

dmaengine: ppc4xx: fix off-by-one build failure

[Christian Lamparter]

There are two poly_store, but one should have been poly_show.

|adma.c:4382:16: error: conflicting types for 'poly_store'
| static ssize_t poly_store(struct device_driver *dev, const char *buf,
|                ^~~~~~~~~~
|adma.c:4363:16: note: previous definition of 'poly_store' was here
| static ssize_t poly_store(struct device_driver *dev, char *buf)
|                ^~~~~~~~~~

Fixes: 13efe1a05384 ("dmaengine: ppc4xx: remove DRIVER_ATTR() usage")
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
---
 drivers/dma/ppc4xx/adma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/ppc4xx/adma.c b/drivers/dma/ppc4xx/adma.c
index 4cf0d4d0cecf..25610286979f 100644
--- a/drivers/dma/ppc4xx/adma.c
+++ b/drivers/dma/ppc4xx/adma.c
@@ -4360,7 +4360,7 @@ static ssize_t enable_store(struct device_driver *dev, const char *buf,
 }
 static DRIVER_ATTR_RW(enable);
 
-static ssize_t poly_store(struct device_driver *dev, char *buf)
+static ssize_t poly_show(struct device_driver *dev, char *buf)
 {
 	ssize_t size = 0;
 	u32 reg;