From: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> To: Ramesh Shanmugasundaram <ramesh.shanmugasundaram-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org, sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, crope-X3B1VOXEql0@public.gmane.org, chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org, geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org, linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [RFC 5/5] doc_rst: media: New SDR formats SC16, SC18 & SC20 Date: Tue, 18 Oct 2016 21:35:27 +0300 [thread overview] Message-ID: <2893157.XL3Txm4q5I@avalon> (raw) In-Reply-To: <1476281429-27603-6-git-send-email-ramesh.shanmugasundaram-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> Hi Ramesh, Thank you for the patch. On Wednesday 12 Oct 2016 15:10:29 Ramesh Shanmugasundaram wrote: > This patch adds documentation for the three new SDR formats > > V4L2_SDR_FMT_SCU16BE > V4L2_SDR_FMT_SCU18BE > V4L2_SDR_FMT_SCU20BE > > Signed-off-by: Ramesh Shanmugasundaram > <ramesh.shanmugasundaram-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> --- > .../media/uapi/v4l/pixfmt-sdr-scu16be.rst | 44 ++++++++++++++++++ > .../media/uapi/v4l/pixfmt-sdr-scu18be.rst | 48 +++++++++++++++++++ > .../media/uapi/v4l/pixfmt-sdr-scu20be.rst | 48 +++++++++++++++++++ > Documentation/media/uapi/v4l/sdr-formats.rst | 3 ++ > 4 files changed, 143 insertions(+) > create mode 100644 Documentation/media/uapi/v4l/pixfmt-sdr-scu16be.rst > create mode 100644 Documentation/media/uapi/v4l/pixfmt-sdr-scu18be.rst > create mode 100644 Documentation/media/uapi/v4l/pixfmt-sdr-scu20be.rst > > diff --git a/Documentation/media/uapi/v4l/pixfmt-sdr-scu16be.rst > b/Documentation/media/uapi/v4l/pixfmt-sdr-scu16be.rst new file mode 100644 > index 0000000..d6c2123 > --- /dev/null > +++ b/Documentation/media/uapi/v4l/pixfmt-sdr-scu16be.rst > @@ -0,0 +1,44 @@ > +.. -*- coding: utf-8; mode: rst -*- > + > +.. _V4L2-SDR-FMT-SCU16BE: > + > +****************************** > +V4L2_SDR_FMT_SCU16BE ('SCU16') The value between parentheses is the ASCII representation of the 4CC, it should be SC16. Same comment for the other formats. > +****************************** > + > +Sliced complex unsigned 16-bit big endian IQ sample > + > + > +Description > +=========== > + > +This format contains a sequence of complex number samples. Each complex > +number consist of two parts called In-phase and Quadrature (IQ). Both I > +and Q are represented as a 16 bit unsigned big endian number. I value > +starts first and Q value starts at an offset equalling half of the buffer > +size. 14 bit data is stored in 16 bit space with unused stuffed bits > +padded with 0. Please specify here how the 14-bit numbers are aligned (i.e. padding in bits 15:14 or bits 1:0 or any other strange option). Same comment for the other formats. > + > +**Byte Order.** > +Each cell is one byte. > + > + > +.. flat-table:: > + :header-rows: 0 > + :stub-columns: 0 > + > + - .. row 1 Please use the more compact table stable * - start + 0: - I'\ :sub:`0[D13:D6]` ... Same comment for the other formats. > + > + - start + 0: > + > + - I'\ :sub:`0[D13:D6]` > + > + - I'\ :sub:`0[D5:D0]` > + > + - .. row 2 > + > + - start + buffer_size/2: > + > + - Q'\ :sub:`0[D13:D6]` > + > + - Q'\ :sub:`0[D5:D0]` The format looks planar, does it use one V4L2 plane (as does NV12) or two V4L2 planes (as does NV12M) ? Same question for the other formats. > diff --git a/Documentation/media/uapi/v4l/pixfmt-sdr-scu18be.rst > b/Documentation/media/uapi/v4l/pixfmt-sdr-scu18be.rst new file mode 100644 > index 0000000..e6e0aff > --- /dev/null > +++ b/Documentation/media/uapi/v4l/pixfmt-sdr-scu18be.rst > @@ -0,0 +1,48 @@ > +.. -*- coding: utf-8; mode: rst -*- > + > +.. _V4L2-SDR-FMT-SCU18BE: > + > +****************************** > +V4L2_SDR_FMT_SCU18BE ('SCU18') > +****************************** > + > +Sliced complex unsigned 18-bit big endian IQ sample > + > + > +Description > +=========== > + > +This format contains a sequence of complex number samples. Each complex > +number consist of two parts called In-phase and Quadrature (IQ). Both I > +and Q are represented as a 18 bit unsigned big endian number. I value > +starts first and Q value starts at an offset equalling half of the buffer > +size. 16 bit data is stored in 18 bit space with unused stuffed bits > +padded with 0. Your example below suggests that 18 bit data is stored in 24 bits. Similar comment for SCU20. > + > +**Byte Order.** > +Each cell is one byte. > + > + > +.. flat-table:: > + :header-rows: 0 > + :stub-columns: 0 > + > + - .. row 1 > + > + - start + 0: > + > + - I'\ :sub:`0[D17:D10]` > + > + - I'\ :sub:`0[D9:D2]` > + > + - I'\ :sub:`0[D1:D0]` > + > + - .. row 2 > + > + - start + buffer_size/2: > + > + - Q'\ :sub:`0[D17:D10]` > + > + - Q'\ :sub:`0[D9:D2]` > + > + - Q'\ :sub:`0[D1:D0]` > diff --git a/Documentation/media/uapi/v4l/pixfmt-sdr-scu20be.rst > b/Documentation/media/uapi/v4l/pixfmt-sdr-scu20be.rst new file mode 100644 > index 0000000..374e0a3 > --- /dev/null > +++ b/Documentation/media/uapi/v4l/pixfmt-sdr-scu20be.rst > @@ -0,0 +1,48 @@ > +.. -*- coding: utf-8; mode: rst -*- > + > +.. _V4L2-SDR-FMT-SCU20BE: > + > +****************************** > +V4L2_SDR_FMT_SCU20BE ('SCU20') > +****************************** > + > +Sliced complex unsigned 20-bit big endian IQ sample > + > + > +Description > +=========== > + > +This format contains a sequence of complex number samples. Each complex > +number consist of two parts called In-phase and Quadrature (IQ). Both I > +and Q are represented as a 20 bit unsigned big endian number. I value > +starts first and Q value starts at an offset equalling half of the buffer > +size. 18 bit data is stored in 20 bit space with unused stuffed bits > +padded with 0. > + > +**Byte Order.** > +Each cell is one byte. > + > + > +.. flat-table:: > + :header-rows: 0 > + :stub-columns: 0 > + > + - .. row 1 > + > + - start + 0: > + > + - I'\ :sub:`0[D19:D12]` > + > + - I'\ :sub:`0[D11:D4]` > + > + - I'\ :sub:`0[D3:D0]` > + > + - .. row 2 > + > + - start + buffer_size/2: > + > + - Q'\ :sub:`0[D19:D12]` > + > + - Q'\ :sub:`0[D11:D4]` > + > + - Q'\ :sub:`0[D3:D0]` > diff --git a/Documentation/media/uapi/v4l/sdr-formats.rst > b/Documentation/media/uapi/v4l/sdr-formats.rst index f863c08..4c01cf9 > 100644 > --- a/Documentation/media/uapi/v4l/sdr-formats.rst > +++ b/Documentation/media/uapi/v4l/sdr-formats.rst > @@ -17,3 +17,6 @@ These formats are used for :ref:`SDR <sdr>` interface > only. pixfmt-sdr-cs08 > pixfmt-sdr-cs14le > pixfmt-sdr-ru12le > + pixfmt-sdr-scu16be > + pixfmt-sdr-scu18be > + pixfmt-sdr-scu20be -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Ramesh Shanmugasundaram <ramesh.shanmugasundaram@bp.renesas.com> Cc: robh+dt@kernel.org, mark.rutland@arm.com, mchehab@kernel.org, hverkuil@xs4all.nl, sakari.ailus@linux.intel.com, crope@iki.fi, chris.paterson2@renesas.com, geert@linux-m68k.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [RFC 5/5] doc_rst: media: New SDR formats SC16, SC18 & SC20 Date: Tue, 18 Oct 2016 21:35:27 +0300 [thread overview] Message-ID: <2893157.XL3Txm4q5I@avalon> (raw) In-Reply-To: <1476281429-27603-6-git-send-email-ramesh.shanmugasundaram@bp.renesas.com> Hi Ramesh, Thank you for the patch. On Wednesday 12 Oct 2016 15:10:29 Ramesh Shanmugasundaram wrote: > This patch adds documentation for the three new SDR formats > > V4L2_SDR_FMT_SCU16BE > V4L2_SDR_FMT_SCU18BE > V4L2_SDR_FMT_SCU20BE > > Signed-off-by: Ramesh Shanmugasundaram > <ramesh.shanmugasundaram@bp.renesas.com> --- > .../media/uapi/v4l/pixfmt-sdr-scu16be.rst | 44 ++++++++++++++++++ > .../media/uapi/v4l/pixfmt-sdr-scu18be.rst | 48 +++++++++++++++++++ > .../media/uapi/v4l/pixfmt-sdr-scu20be.rst | 48 +++++++++++++++++++ > Documentation/media/uapi/v4l/sdr-formats.rst | 3 ++ > 4 files changed, 143 insertions(+) > create mode 100644 Documentation/media/uapi/v4l/pixfmt-sdr-scu16be.rst > create mode 100644 Documentation/media/uapi/v4l/pixfmt-sdr-scu18be.rst > create mode 100644 Documentation/media/uapi/v4l/pixfmt-sdr-scu20be.rst > > diff --git a/Documentation/media/uapi/v4l/pixfmt-sdr-scu16be.rst > b/Documentation/media/uapi/v4l/pixfmt-sdr-scu16be.rst new file mode 100644 > index 0000000..d6c2123 > --- /dev/null > +++ b/Documentation/media/uapi/v4l/pixfmt-sdr-scu16be.rst > @@ -0,0 +1,44 @@ > +.. -*- coding: utf-8; mode: rst -*- > + > +.. _V4L2-SDR-FMT-SCU16BE: > + > +****************************** > +V4L2_SDR_FMT_SCU16BE ('SCU16') The value between parentheses is the ASCII representation of the 4CC, it should be SC16. Same comment for the other formats. > +****************************** > + > +Sliced complex unsigned 16-bit big endian IQ sample > + > + > +Description > +=========== > + > +This format contains a sequence of complex number samples. Each complex > +number consist of two parts called In-phase and Quadrature (IQ). Both I > +and Q are represented as a 16 bit unsigned big endian number. I value > +starts first and Q value starts at an offset equalling half of the buffer > +size. 14 bit data is stored in 16 bit space with unused stuffed bits > +padded with 0. Please specify here how the 14-bit numbers are aligned (i.e. padding in bits 15:14 or bits 1:0 or any other strange option). Same comment for the other formats. > + > +**Byte Order.** > +Each cell is one byte. > + > + > +.. flat-table:: > + :header-rows: 0 > + :stub-columns: 0 > + > + - .. row 1 Please use the more compact table stable * - start + 0: - I'\ :sub:`0[D13:D6]` ... Same comment for the other formats. > + > + - start + 0: > + > + - I'\ :sub:`0[D13:D6]` > + > + - I'\ :sub:`0[D5:D0]` > + > + - .. row 2 > + > + - start + buffer_size/2: > + > + - Q'\ :sub:`0[D13:D6]` > + > + - Q'\ :sub:`0[D5:D0]` The format looks planar, does it use one V4L2 plane (as does NV12) or two V4L2 planes (as does NV12M) ? Same question for the other formats. > diff --git a/Documentation/media/uapi/v4l/pixfmt-sdr-scu18be.rst > b/Documentation/media/uapi/v4l/pixfmt-sdr-scu18be.rst new file mode 100644 > index 0000000..e6e0aff > --- /dev/null > +++ b/Documentation/media/uapi/v4l/pixfmt-sdr-scu18be.rst > @@ -0,0 +1,48 @@ > +.. -*- coding: utf-8; mode: rst -*- > + > +.. _V4L2-SDR-FMT-SCU18BE: > + > +****************************** > +V4L2_SDR_FMT_SCU18BE ('SCU18') > +****************************** > + > +Sliced complex unsigned 18-bit big endian IQ sample > + > + > +Description > +=========== > + > +This format contains a sequence of complex number samples. Each complex > +number consist of two parts called In-phase and Quadrature (IQ). Both I > +and Q are represented as a 18 bit unsigned big endian number. I value > +starts first and Q value starts at an offset equalling half of the buffer > +size. 16 bit data is stored in 18 bit space with unused stuffed bits > +padded with 0. Your example below suggests that 18 bit data is stored in 24 bits. Similar comment for SCU20. > + > +**Byte Order.** > +Each cell is one byte. > + > + > +.. flat-table:: > + :header-rows: 0 > + :stub-columns: 0 > + > + - .. row 1 > + > + - start + 0: > + > + - I'\ :sub:`0[D17:D10]` > + > + - I'\ :sub:`0[D9:D2]` > + > + - I'\ :sub:`0[D1:D0]` > + > + - .. row 2 > + > + - start + buffer_size/2: > + > + - Q'\ :sub:`0[D17:D10]` > + > + - Q'\ :sub:`0[D9:D2]` > + > + - Q'\ :sub:`0[D1:D0]` > diff --git a/Documentation/media/uapi/v4l/pixfmt-sdr-scu20be.rst > b/Documentation/media/uapi/v4l/pixfmt-sdr-scu20be.rst new file mode 100644 > index 0000000..374e0a3 > --- /dev/null > +++ b/Documentation/media/uapi/v4l/pixfmt-sdr-scu20be.rst > @@ -0,0 +1,48 @@ > +.. -*- coding: utf-8; mode: rst -*- > + > +.. _V4L2-SDR-FMT-SCU20BE: > + > +****************************** > +V4L2_SDR_FMT_SCU20BE ('SCU20') > +****************************** > + > +Sliced complex unsigned 20-bit big endian IQ sample > + > + > +Description > +=========== > + > +This format contains a sequence of complex number samples. Each complex > +number consist of two parts called In-phase and Quadrature (IQ). Both I > +and Q are represented as a 20 bit unsigned big endian number. I value > +starts first and Q value starts at an offset equalling half of the buffer > +size. 18 bit data is stored in 20 bit space with unused stuffed bits > +padded with 0. > + > +**Byte Order.** > +Each cell is one byte. > + > + > +.. flat-table:: > + :header-rows: 0 > + :stub-columns: 0 > + > + - .. row 1 > + > + - start + 0: > + > + - I'\ :sub:`0[D19:D12]` > + > + - I'\ :sub:`0[D11:D4]` > + > + - I'\ :sub:`0[D3:D0]` > + > + - .. row 2 > + > + - start + buffer_size/2: > + > + - Q'\ :sub:`0[D19:D12]` > + > + - Q'\ :sub:`0[D11:D4]` > + > + - Q'\ :sub:`0[D3:D0]` > diff --git a/Documentation/media/uapi/v4l/sdr-formats.rst > b/Documentation/media/uapi/v4l/sdr-formats.rst index f863c08..4c01cf9 > 100644 > --- a/Documentation/media/uapi/v4l/sdr-formats.rst > +++ b/Documentation/media/uapi/v4l/sdr-formats.rst > @@ -17,3 +17,6 @@ These formats are used for :ref:`SDR <sdr>` interface > only. pixfmt-sdr-cs08 > pixfmt-sdr-cs14le > pixfmt-sdr-ru12le > + pixfmt-sdr-scu16be > + pixfmt-sdr-scu18be > + pixfmt-sdr-scu20be -- Regards, Laurent Pinchart
next prev parent reply other threads:[~2016-10-18 18:35 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-12 14:10 [RFC 0/5] Add V4L2 SDR (DRIF & MAX2175) driver Ramesh Shanmugasundaram 2016-10-12 14:10 ` [RFC 1/5] media: i2c: max2175: Add MAX2175 support Ramesh Shanmugasundaram [not found] ` <1476281429-27603-2-git-send-email-ramesh.shanmugasundaram-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> 2016-10-15 12:42 ` Geert Uytterhoeven 2016-10-15 12:42 ` Geert Uytterhoeven [not found] ` <CAMuHMdUYQoJL4h8prEpontF4YH8Ha+SWDdeZHYEV3_uMZ-SBXw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-10-18 15:04 ` Ramesh Shanmugasundaram 2016-10-18 15:04 ` Ramesh Shanmugasundaram 2016-10-18 19:25 ` Laurent Pinchart 2016-10-21 14:49 ` Ramesh Shanmugasundaram 2016-11-10 8:46 ` Laurent Pinchart 2016-10-12 14:10 ` [RFC 2/5] media: v4l2-ctrls: Reserve controls for MAX217X Ramesh Shanmugasundaram 2016-10-12 14:10 ` [RFC 3/5] media: platform: rcar_drif: Add DRIF support Ramesh Shanmugasundaram 2016-10-18 13:13 ` Rob Herring 2016-10-18 15:13 ` Ramesh Shanmugasundaram 2016-10-18 14:29 ` Geert Uytterhoeven 2016-10-18 18:26 ` Laurent Pinchart 2016-10-21 13:17 ` Ramesh Shanmugasundaram 2016-10-21 13:17 ` Ramesh Shanmugasundaram [not found] ` <CAMuHMdXvGEm3bdNOsa6Q1FLB9yMSTAzO4nHcCb-pnYYwg6f6Cg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-10-21 13:15 ` Ramesh Shanmugasundaram 2016-10-21 13:15 ` Ramesh Shanmugasundaram 2016-10-12 14:10 ` [RFC 4/5] media: Add new SDR formats SC16, SC18 & SC20 Ramesh Shanmugasundaram 2016-10-12 14:10 ` [RFC 5/5] doc_rst: media: New " Ramesh Shanmugasundaram [not found] ` <1476281429-27603-6-git-send-email-ramesh.shanmugasundaram-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org> 2016-10-18 18:35 ` Laurent Pinchart [this message] 2016-10-18 18:35 ` Laurent Pinchart 2016-10-24 10:19 ` Ramesh Shanmugasundaram 2016-11-02 9:00 ` Ramesh Shanmugasundaram 2016-11-02 9:00 ` Ramesh Shanmugasundaram [not found] ` <SG2PR06MB10389152CEC59BB77A5DA7DDC3A00-ESzmfEwOt/zfc7TNChRnj20DtJ1/0DrXvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2016-11-02 20:58 ` Laurent Pinchart 2016-11-02 20:58 ` Laurent Pinchart 2016-11-03 20:36 ` Antti Palosaari 2016-11-03 20:36 ` Antti Palosaari 2016-11-04 9:23 ` Ramesh Shanmugasundaram 2016-11-10 8:08 ` Laurent Pinchart 2016-11-11 4:54 ` Antti Palosaari 2016-11-11 13:53 ` Hans Verkuil [not found] ` <8438b944-216e-3237-c312-92a674fd4541-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> 2016-11-11 13:57 ` Laurent Pinchart 2016-11-11 13:57 ` Laurent Pinchart 2016-11-11 14:00 ` Hans Verkuil [not found] ` <fb15b6f3-6c5c-0922-8655-aabd4799d158-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org> 2016-11-14 15:53 ` Ramesh Shanmugasundaram 2016-11-14 15:53 ` Ramesh Shanmugasundaram
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2893157.XL3Txm4q5I@avalon \ --to=laurent.pinchart-rylnwiuwjnjg/c1bvhzhaw@public.gmane.org \ --cc=chris.paterson2-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org \ --cc=crope-X3B1VOXEql0@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \ --cc=hverkuil-qWit8jRvyhVmR6Xm/wNWPw@public.gmane.org \ --cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=ramesh.shanmugasundaram-kTT6dE0pTRh9uiUsa/gSgQ@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.