All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH V2 0/8] Fixes for eSDK and testsdkext
@ 2016-12-14  7:24 Robert Yang
  2016-12-14  7:24 ` [PATCH V2 1/8] populate_sdk_ext.bbclass: break the long lines Robert Yang
                   ` (8 more replies)
  0 siblings, 9 replies; 15+ messages in thread
From: Robert Yang @ 2016-12-14  7:24 UTC (permalink / raw)
  To: openembedded-core

* V2
  1) Fix Paul's comments:
     - Drop "don't reset when the test is failed"
     - Update bug id for "oe-publish-sdk: add pyshtables.py to .gitignore"
     - Split "install multilib targets as populate_sdk does" into 2 commits:
       "break the long lines"
       "install multilib SDKs"
  2) Use shorter subject lines

* V1
  Initial version

// Robert

The following changes since commit 4e412234c37efec42b3962c11d44903c0c58c92e:

  libpcap: Disable exposed bits of WinPCAP remote capture support (2016-12-13 22:47:35 +0000)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib rbt/eSDK
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/eSDK

Robert Yang (8):
  populate_sdk_ext.bbclass: break the long lines
  populate_sdk_ext.bbclass: install multilib SDKs
  oeqa/sdkext/devtool.py: remove sources before run test cases
  oe-publish-sdk: make cmd easier to read
  oe-publish-sdk: add pyshtables.py to .gitignore
  oeqa/oetest.py: add hasLockedSig()
  oeqa/sdkext/devtool.py: skip a testcase when no libxml2
  oe/copy_buildsystem.py: add SDK_LAYERS_EXCLUDE_PATTERN

 meta/classes/populate_sdk_ext.bbclass | 63 ++++++++++++++++++++++++-----------
 meta/lib/oe/copy_buildsystem.py       | 18 ++++++++++
 meta/lib/oeqa/oetest.py               | 13 ++++++++
 meta/lib/oeqa/sdkext/devtool.py       |  8 ++++-
 scripts/oe-publish-sdk                | 19 +++++++++--
 5 files changed, 98 insertions(+), 23 deletions(-)

-- 
2.10.2



^ permalink raw reply	[flat|nested] 15+ messages in thread

* [PATCH V2 1/8] populate_sdk_ext.bbclass: break the long lines
  2016-12-14  7:24 [PATCH V2 0/8] Fixes for eSDK and testsdkext Robert Yang
@ 2016-12-14  7:24 ` Robert Yang
  2016-12-14  8:02   ` Ulf Magnusson
  2016-12-14  7:24 ` [PATCH V2 2/8] populate_sdk_ext.bbclass: install multilib SDKs Robert Yang
                   ` (7 subsequent siblings)
  8 siblings, 1 reply; 15+ messages in thread
From: Robert Yang @ 2016-12-14  7:24 UTC (permalink / raw)
  To: openembedded-core

Make it easier to read and maintain.

[YOCTO #10647]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/classes/populate_sdk_ext.bbclass | 24 ++++++++++++++++++++----
 1 file changed, 20 insertions(+), 4 deletions(-)

diff --git a/meta/classes/populate_sdk_ext.bbclass b/meta/classes/populate_sdk_ext.bbclass
index 3c3a73c..adef96d 100644
--- a/meta/classes/populate_sdk_ext.bbclass
+++ b/meta/classes/populate_sdk_ext.bbclass
@@ -567,7 +567,13 @@ sdk_ext_postinst() {
 	printf "\nExtracting buildtools...\n"
 	cd $target_sdk_dir
 	env_setup_script="$target_sdk_dir/environment-setup-${REAL_MULTIMACH_TARGET_SYS}"
-	printf "buildtools\ny" | ./${SDK_BUILDTOOLS_INSTALLER} > buildtools.log || { printf 'ERROR: buildtools installation failed:\n' ; cat buildtools.log ; echo "printf 'ERROR: this SDK was not fully installed and needs reinstalling\n'" >> $env_setup_script ; exit 1 ; }
+	./${SDK_BUILDTOOLS_INSTALLER} -d buildtools -y > buildtools.log
+	if [ $? -ne 0 ]; then
+		printf 'ERROR: buildtools installation failed:\n'
+		cat buildtools.log
+		echo "printf 'ERROR: this SDK was not fully installed and needs reinstalling\n'" >> $env_setup_script
+		exit 1
+	fi
 
 	# Delete the buildtools tar file since it won't be used again
 	rm -f ./${SDK_BUILDTOOLS_INSTALLER}
@@ -588,7 +594,9 @@ sdk_ext_postinst() {
 	echo "printf 'SDK environment now set up; additionally you may now run devtool to perform development tasks.\nRun devtool --help for further details.\n'" >> $env_setup_script
 
 	# Warn if trying to use external bitbake and the ext SDK together
-	echo "(which bitbake > /dev/null 2>&1 && echo 'WARNING: attempting to use the extensible SDK in an environment set up to run bitbake - this may lead to unexpected results. Please source this script in a new shell session instead.') || true" >> $env_setup_script
+	echo "(which bitbake > /dev/null 2>&1 && \
+		echo 'WARNING: attempting to use the extensible SDK in an environment set up to run bitbake - this may lead to unexpected results. Please source this script in a new shell session instead.') || \
+		true" >> $env_setup_script
 
 	if [ "$prepare_buildsystem" != "no" ]; then
 		printf "Preparing build system...\n"
@@ -596,8 +604,16 @@ sdk_ext_postinst() {
 		# current working directory when first ran, nor will it set $1 when
 		# sourcing a script. That is why this has to look so ugly.
 		LOGFILE="$target_sdk_dir/preparing_build_system.log"
-		sh -c ". buildtools/environment-setup* > $LOGFILE && cd $target_sdk_dir/`dirname ${oe_init_build_env_path}` && set $target_sdk_dir && . $target_sdk_dir/${oe_init_build_env_path} $target_sdk_dir >> $LOGFILE && python $target_sdk_dir/ext-sdk-prepare.py $LOGFILE '${SDK_INSTALL_TARGETS}'" || { echo "printf 'ERROR: this SDK was not fully installed and needs reinstalling\n'" >> $env_setup_script ; exit 1 ; }
-		rm $target_sdk_dir/ext-sdk-prepare.py
+		sh -c ". buildtools/environment-setup* > $LOGFILE && \
+			cd $target_sdk_dir/`dirname ${oe_init_build_env_path}` && \
+			set $target_sdk_dir && \
+			. $target_sdk_dir/${oe_init_build_env_path} $target_sdk_dir >> $LOGFILE && \
+			python $target_sdk_dir/ext-sdk-prepare.py $LOGFILE '${SDK_INSTALL_TARGETS}'"
+		if [ $? -ne ]; then
+			echo "printf 'ERROR: this SDK was not fully installed and needs reinstalling\n'" >> $env_setup_script
+			exit 1
+			rm $target_sdk_dir/ext-sdk-prepare.py
+		fi
 	fi
 	echo done
 }
-- 
2.10.2



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH V2 2/8] populate_sdk_ext.bbclass: install multilib SDKs
  2016-12-14  7:24 [PATCH V2 0/8] Fixes for eSDK and testsdkext Robert Yang
  2016-12-14  7:24 ` [PATCH V2 1/8] populate_sdk_ext.bbclass: break the long lines Robert Yang
@ 2016-12-14  7:24 ` Robert Yang
  2016-12-14  7:24 ` [PATCH V2 3/8] oeqa/sdkext/devtool.py: remove sources before run test cases Robert Yang
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 15+ messages in thread
From: Robert Yang @ 2016-12-14  7:24 UTC (permalink / raw)
  To: openembedded-core

Fixed:
MACHINE = "qemux86-64"
require conf/multilib.conf
MULTILIBS = "multilib:lib32"
DEFAULTTUNE_virtclass-multilib-lib32 = "x86"
IMAGE_CLASSES += "testimage"

$ bitbake core-image-minimal -cpopulate_sdk_ext
$ bitbake core-image-minimal -ctestsdkext
[snip]
Testing /buildarea/lyang1/test_po/tmp/work/qemux86_64-poky-linux/core-image-minimal/1.0-r0/testsdkext//tc/environment-setup-x86-pokymllib32-linux
test_cvs (oeqa.sdk.buildcvs.BuildCvsTest) ... FAIL
[snip]

It was failed because no lib32 toolchains.

These fixes include:
* Set SDK_TARGETS correctly
* Return multilib depends in get_ext_sdk_depends()
* Write information to all environment-setup-* scripts.

[YOCTO #10647]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/classes/populate_sdk_ext.bbclass | 49 ++++++++++++++++++++---------------
 1 file changed, 28 insertions(+), 21 deletions(-)

diff --git a/meta/classes/populate_sdk_ext.bbclass b/meta/classes/populate_sdk_ext.bbclass
index adef96d..840e04d 100644
--- a/meta/classes/populate_sdk_ext.bbclass
+++ b/meta/classes/populate_sdk_ext.bbclass
@@ -39,7 +39,7 @@ SDK_LOCAL_CONF_BLACKLIST ?= "CONF_VERSION \
 SDK_INHERIT_BLACKLIST ?= "buildhistory icecc"
 SDK_UPDATE_URL ?= ""
 
-SDK_TARGETS ?= "${PN}"
+SDK_TARGETS ?= "${@multilib_pkg_extend(d, d.getVar('BPN', True))}"
 
 def get_sdk_install_targets(d, images_only=False):
     sdk_install_targets = ''
@@ -566,12 +566,14 @@ SDK_PRE_INSTALL_COMMAND_task-populate-sdk-ext = "${sdk_ext_preinst}"
 sdk_ext_postinst() {
 	printf "\nExtracting buildtools...\n"
 	cd $target_sdk_dir
-	env_setup_script="$target_sdk_dir/environment-setup-${REAL_MULTIMACH_TARGET_SYS}"
+	env_setup_scripts="`ls $target_sdk_dir/environment-setup-*`"
 	./${SDK_BUILDTOOLS_INSTALLER} -d buildtools -y > buildtools.log
 	if [ $? -ne 0 ]; then
 		printf 'ERROR: buildtools installation failed:\n'
 		cat buildtools.log
-		echo "printf 'ERROR: this SDK was not fully installed and needs reinstalling\n'" >> $env_setup_script
+		for e in $env_setup_scripts; do
+			echo "printf 'ERROR: this SDK was not fully installed and needs reinstalling\n'" >> $e
+		done
 		exit 1
 	fi
 
@@ -580,23 +582,25 @@ sdk_ext_postinst() {
 	# We don't need the log either since it succeeded
 	rm -f buildtools.log
 
-	# Make sure when the user sets up the environment, they also get
-	# the buildtools-tarball tools in their path.
-	echo ". $target_sdk_dir/buildtools/environment-setup*" >> $env_setup_script
+	for e in $env_setup_scripts; do
+		# Make sure when the user sets up the environment, they also get
+		# the buildtools-tarball tools in their path.
+		echo ". $target_sdk_dir/buildtools/environment-setup*" >> $e
+		# Allow bitbake environment setup to be ran as part of this sdk.
+		echo "export OE_SKIP_SDK_CHECK=1" >> $e
 
-	# Allow bitbake environment setup to be ran as part of this sdk.
-	echo "export OE_SKIP_SDK_CHECK=1" >> $env_setup_script
+		# A bit of another hack, but we need this in the path only for devtool
+		# so put it at the end of $PATH.
+		echo "export PATH=$target_sdk_dir/sysroots/${SDK_SYS}${bindir_nativesdk}:\$PATH" >> $e
 
-	# A bit of another hack, but we need this in the path only for devtool
-	# so put it at the end of $PATH.
-	echo "export PATH=$target_sdk_dir/sysroots/${SDK_SYS}${bindir_nativesdk}:\$PATH" >> $env_setup_script
+		echo "printf 'SDK environment now set up; additionally you may now run devtool to perform development tasks.\nRun devtool --help for further details.\n'" >> $e
 
-	echo "printf 'SDK environment now set up; additionally you may now run devtool to perform development tasks.\nRun devtool --help for further details.\n'" >> $env_setup_script
+		# Warn if trying to use external bitbake and the ext SDK together
+		echo "(which bitbake > /dev/null 2>&1 && \
+			echo 'WARNING: attempting to use the extensible SDK in an environment set up to run bitbake - this may lead to unexpected results. Please source this script in a new shell session instead.') || \
+			true" >> $e
+	done
 
-	# Warn if trying to use external bitbake and the ext SDK together
-	echo "(which bitbake > /dev/null 2>&1 && \
-		echo 'WARNING: attempting to use the extensible SDK in an environment set up to run bitbake - this may lead to unexpected results. Please source this script in a new shell session instead.') || \
-		true" >> $env_setup_script
 
 	if [ "$prepare_buildsystem" != "no" ]; then
 		printf "Preparing build system...\n"
@@ -610,7 +614,9 @@ sdk_ext_postinst() {
 			. $target_sdk_dir/${oe_init_build_env_path} $target_sdk_dir >> $LOGFILE && \
 			python $target_sdk_dir/ext-sdk-prepare.py $LOGFILE '${SDK_INSTALL_TARGETS}'"
 		if [ $? -ne ]; then
-			echo "printf 'ERROR: this SDK was not fully installed and needs reinstalling\n'" >> $env_setup_script
+			for e in $env_setup_scripts; do
+				echo "printf 'ERROR: this SDK was not fully installed and needs reinstalling\n'" >> $e
+			done
 			exit 1
 			rm $target_sdk_dir/ext-sdk-prepare.py
 		fi
@@ -641,10 +647,11 @@ fakeroot python do_populate_sdk_ext() {
 def get_ext_sdk_depends(d):
     # Note: the deps varflag is a list not a string, so we need to specify expand=False
     deps = d.getVarFlag('do_image_complete', 'deps', False)
-    pn = d.getVar('PN', True)
-    deplist = ['%s:%s' % (pn, dep) for dep in deps]
-    for task in ['do_image_complete', 'do_rootfs', 'do_build']:
-        deplist.extend((d.getVarFlag(task, 'depends', True) or '').split())
+    deplist = []
+    for pn in multilib_pkg_extend(d, d.getVar('BPN', True)).split():
+        deplist += ['%s:%s' % (pn, dep) for dep in deps]
+        for task in ['do_image_complete', 'do_rootfs', 'do_build']:
+            deplist.extend((d.getVarFlag(task, 'depends', True) or '').split())
     return ' '.join(deplist)
 
 python do_sdk_depends() {
-- 
2.10.2



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH V2 3/8] oeqa/sdkext/devtool.py: remove sources before run test cases
  2016-12-14  7:24 [PATCH V2 0/8] Fixes for eSDK and testsdkext Robert Yang
  2016-12-14  7:24 ` [PATCH V2 1/8] populate_sdk_ext.bbclass: break the long lines Robert Yang
  2016-12-14  7:24 ` [PATCH V2 2/8] populate_sdk_ext.bbclass: install multilib SDKs Robert Yang
@ 2016-12-14  7:24 ` Robert Yang
  2016-12-14  7:24 ` [PATCH V2 4/8] oe-publish-sdk: make cmd easier to read Robert Yang
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 15+ messages in thread
From: Robert Yang @ 2016-12-14  7:24 UTC (permalink / raw)
  To: openembedded-core

Fixed:
MACHINE = "qemux86-64"
require conf/multilib.conf
MULTILIBS = "multilib:lib32"
DEFAULTTUNE_virtclass-multilib-lib32 = "x86"

$ bitbake core-image-minimal -cpopulate_sdk_ext
[snip]
ERROR: Source tree path /path/to/tmp/work/qemux86_64-poky-linux/core-image-minimal/1.0-r0/testsdkext/tc/workspace/sources/v4l2loopback-driver already exists and is not empty\n'
[snip]

This is because the test case will run twice
(environment-setup-core2-64-poky-linux and
environment-setup-x86-pokymllib32-linux), it would fail in the second
run, 'devtool reset' can not remove sources, so remove it before running
test cases.

[YOCTO #10647]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/lib/oeqa/sdkext/devtool.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/lib/oeqa/sdkext/devtool.py b/meta/lib/oeqa/sdkext/devtool.py
index 65f41f6..f101eb6 100644
--- a/meta/lib/oeqa/sdkext/devtool.py
+++ b/meta/lib/oeqa/sdkext/devtool.py
@@ -15,6 +15,9 @@ class DevtoolTest(oeSDKExtTest):
         self.myapp_cmake_dst = os.path.join(self.tc.sdktestdir, "myapp_cmake")
         shutil.copytree(self.myapp_cmake_src, self.myapp_cmake_dst)
 
+        # Clean sources dir to make "git clone" can run again
+        shutil.rmtree(os.path.join(self.tc.sdktestdir, "tc/workspace/sources"), True)
+
     def _test_devtool_build(self, directory):
         self._run('devtool add myapp %s' % directory)
         try:
-- 
2.10.2



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH V2 4/8] oe-publish-sdk: make cmd easier to read
  2016-12-14  7:24 [PATCH V2 0/8] Fixes for eSDK and testsdkext Robert Yang
                   ` (2 preceding siblings ...)
  2016-12-14  7:24 ` [PATCH V2 3/8] oeqa/sdkext/devtool.py: remove sources before run test cases Robert Yang
@ 2016-12-14  7:24 ` Robert Yang
  2016-12-14  7:24 ` [PATCH V2 5/8] oe-publish-sdk: add pyshtables.py to .gitignore Robert Yang
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 15+ messages in thread
From: Robert Yang @ 2016-12-14  7:24 UTC (permalink / raw)
  To: openembedded-core

The command was too long to read and maintain.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 scripts/oe-publish-sdk | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/scripts/oe-publish-sdk b/scripts/oe-publish-sdk
index 4fe8974..d95c623 100755
--- a/scripts/oe-publish-sdk
+++ b/scripts/oe-publish-sdk
@@ -113,10 +113,25 @@ def publish(args):
             return ret
 
     # Setting up the git repo
+    cmd_common = "if [ ! -e .git ]; then"
+    cmd_common += "    git init .;"
+    cmd_common += "    mv .git/hooks/post-update.sample .git/hooks/post-update;"
+    cmd_common += "    echo '*.pyc\n*.pyo' > .gitignore;"
+    cmd_common += "fi;"
+    cmd_common += "git add -A .;"
+    cmd_common += "git config user.email 'oe@oe.oe' && git config user.name 'OE' && git commit -q -m 'init repo' || true;"
     if not is_remote:
-        cmd = 'set -e; mkdir -p %s/layers; cd %s/layers; if [ ! -e .git ]; then git init .; mv .git/hooks/post-update.sample .git/hooks/post-update; echo "*.pyc\n*.pyo" > .gitignore; fi; git add -A .; git config user.email "oe@oe.oe" && git config user.name "OE" && git commit -q -m "init repo" || true; git update-server-info' % (destination, destination)
+        cmd = "set -e;"
+        cmd += "mkdir -p %s/layers;" % destination
+        cmd += "cd %s/layers;" % destination
+        cmd += cmd_common
+        cmd += "git update-server-info"
     else:
-        cmd = "ssh %s 'set -e; mkdir -p %s/layers; cd %s/layers; if [ ! -e .git ]; then git init .; mv .git/hooks/post-update.sample .git/hooks/post-update; echo '*.pyc\n*.pyo' > .gitignore; fi; git add -A .; git config user.email 'oe@oe.oe' && git config user.name 'OE' && git commit -q -m \"init repo\" || true; git update-server-info'" % (host, destdir, destdir)
+        cmd = "ssh %s 'set -e;" % host
+        cmd += "mkdir -p %s/layers;" % destdir
+        cmd += "cd %s/layers;" % destdir
+        cmd += cmd_common
+        cmd += "git update-server-info'"
     ret = subprocess.call(cmd, shell=True)
     if ret == 0:
         logger.info('SDK published successfully')
-- 
2.10.2



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH V2 5/8] oe-publish-sdk: add pyshtables.py to .gitignore
  2016-12-14  7:24 [PATCH V2 0/8] Fixes for eSDK and testsdkext Robert Yang
                   ` (3 preceding siblings ...)
  2016-12-14  7:24 ` [PATCH V2 4/8] oe-publish-sdk: make cmd easier to read Robert Yang
@ 2016-12-14  7:24 ` Robert Yang
  2016-12-14  7:24 ` [PATCH V2 6/8] oeqa/oetest.py: add hasLockedSig() Robert Yang
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 15+ messages in thread
From: Robert Yang @ 2016-12-14  7:24 UTC (permalink / raw)
  To: openembedded-core

Fixed:
MACHINE = "qemux86-64"
require conf/multilib.conf
MULTILIBS = "multilib:lib32"
DEFAULTTUNE_virtclass-multilib-lib32 = "x86"

$ bitbake core-image-minimal -cpopulate_sdk_ext
[snip]
ERROR: Failed to update metadata as there have been changes made to it. Aborting.\nERROR: Changed files:\nb' M poky/bitbake/lib/bb/pysh/pyshtables.py\\n'\n"
[snip]

This is because the test case will run twice
(environment-setup-core2-64-poky-linux and
environment-setup-x86-pokymllib32-linux), it would fail in the second
run since pyshtables.py is regenerated in the first run. This file is
generated automatically, publish it doesn't make any sense, so add it to
.gitignore.

[YOCTO #10796]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 scripts/oe-publish-sdk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/oe-publish-sdk b/scripts/oe-publish-sdk
index d95c623..e2b1b95 100755
--- a/scripts/oe-publish-sdk
+++ b/scripts/oe-publish-sdk
@@ -116,7 +116,7 @@ def publish(args):
     cmd_common = "if [ ! -e .git ]; then"
     cmd_common += "    git init .;"
     cmd_common += "    mv .git/hooks/post-update.sample .git/hooks/post-update;"
-    cmd_common += "    echo '*.pyc\n*.pyo' > .gitignore;"
+    cmd_common += "    echo '*.pyc\n*.pyo\npyshtables.py' > .gitignore;"
     cmd_common += "fi;"
     cmd_common += "git add -A .;"
     cmd_common += "git config user.email 'oe@oe.oe' && git config user.name 'OE' && git commit -q -m 'init repo' || true;"
-- 
2.10.2



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH V2 6/8] oeqa/oetest.py: add hasLockedSig()
  2016-12-14  7:24 [PATCH V2 0/8] Fixes for eSDK and testsdkext Robert Yang
                   ` (4 preceding siblings ...)
  2016-12-14  7:24 ` [PATCH V2 5/8] oe-publish-sdk: add pyshtables.py to .gitignore Robert Yang
@ 2016-12-14  7:24 ` Robert Yang
  2016-12-14  7:24 ` [PATCH V2 7/8] oeqa/sdkext/devtool.py: skip a testcase when no libxml2 Robert Yang
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 15+ messages in thread
From: Robert Yang @ 2016-12-14  7:24 UTC (permalink / raw)
  To: openembedded-core

It checks whether there is a "recipe:do_populate_sysroot:" in
locked-sigs.inc, which will help to determine whether the testcase will
run or not.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/lib/oeqa/oetest.py | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/meta/lib/oeqa/oetest.py b/meta/lib/oeqa/oetest.py
index 95d3bf7..d12381d 100644
--- a/meta/lib/oeqa/oetest.py
+++ b/meta/lib/oeqa/oetest.py
@@ -171,6 +171,12 @@ class oeSDKExtTest(oeSDKTest):
         return subprocess.check_output(". %s > /dev/null;"\
             " %s;" % (self.tc.sdkenv, cmd), stderr=subprocess.STDOUT, shell=True, env=env).decode("utf-8")
 
+    @classmethod
+    def hasLockedSig(self, recipe):
+        if re.search(" " + recipe + ":do_populate_sysroot:", oeTest.tc.locked_sigs):
+            return True
+        return False
+
 def getmodule(pos=2):
     # stack returns a list of tuples containg frame information
     # First element of the list the is current frame, caller is 1
@@ -708,6 +714,13 @@ class SDKExtTestContext(SDKTestContext):
         self.sdkextfilesdir = os.path.join(os.path.dirname(os.path.abspath(
             oeqa.sdkext.__file__)), "files")
 
+        self.locked_sig_file = os.path.join(self.sdktestdir, "tc/conf/locked-sigs.inc")
+        if os.path.exists(self.locked_sig_file):
+            with open(self.locked_sig_file) as f:
+                self.locked_sigs = f.read()
+        else:
+            bb.fatal("%s not found. Did you build the ext sdk image?\n%s" % e)
+
     def _get_test_namespace(self):
         if self.cm:
             return "sdk"
-- 
2.10.2



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH V2 7/8] oeqa/sdkext/devtool.py: skip a testcase when no libxml2
  2016-12-14  7:24 [PATCH V2 0/8] Fixes for eSDK and testsdkext Robert Yang
                   ` (5 preceding siblings ...)
  2016-12-14  7:24 ` [PATCH V2 6/8] oeqa/oetest.py: add hasLockedSig() Robert Yang
@ 2016-12-14  7:24 ` Robert Yang
  2016-12-14  7:24 ` [PATCH V2 8/8] oe/copy_buildsystem.py: add SDK_LAYERS_EXCLUDE_PATTERN Robert Yang
  2016-12-20 15:41 ` [PATCH V2 0/8] Fixes for eSDK and testsdkext Burton, Ross
  8 siblings, 0 replies; 15+ messages in thread
From: Robert Yang @ 2016-12-14  7:24 UTC (permalink / raw)
  To: openembedded-core

Skip test_extend_autotools_recipe_creation when no libxml2

The librdfa requires libxml2 to build, otherwise, it would fail:
| configure: error: Package requirements (libxml-2.0 >= 2.6.26) were not met:
|
| No package 'libxml-2.0' found

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/lib/oeqa/sdkext/devtool.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/meta/lib/oeqa/sdkext/devtool.py b/meta/lib/oeqa/sdkext/devtool.py
index f101eb6..6cb8d01 100644
--- a/meta/lib/oeqa/sdkext/devtool.py
+++ b/meta/lib/oeqa/sdkext/devtool.py
@@ -1,7 +1,7 @@
 import shutil
 import subprocess
 import urllib.request
-from oeqa.oetest import oeSDKExtTest
+from oeqa.oetest import oeSDKExtTest, skipModule
 from oeqa.utils.decorators import *
 
 class DevtoolTest(oeSDKExtTest):
@@ -66,6 +66,9 @@ class DevtoolTest(oeSDKExtTest):
     @testcase(1482)
     @skipUnlessPassed('test_devtool_location')
     def test_extend_autotools_recipe_creation(self):
+        # librdfa requires libxml2
+        if not oeSDKExtTest.hasLockedSig("libxml2"):
+            skipModule("No libxml2 package in the eSDK")
         req = 'https://github.com/rdfa/librdfa'
         recipe = "bbexample"
         self._run('devtool add %s %s' % (recipe, req) )
-- 
2.10.2



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* [PATCH V2 8/8] oe/copy_buildsystem.py: add SDK_LAYERS_EXCLUDE_PATTERN
  2016-12-14  7:24 [PATCH V2 0/8] Fixes for eSDK and testsdkext Robert Yang
                   ` (6 preceding siblings ...)
  2016-12-14  7:24 ` [PATCH V2 7/8] oeqa/sdkext/devtool.py: skip a testcase when no libxml2 Robert Yang
@ 2016-12-14  7:24 ` Robert Yang
  2016-12-20 15:41 ` [PATCH V2 0/8] Fixes for eSDK and testsdkext Burton, Ross
  8 siblings, 0 replies; 15+ messages in thread
From: Robert Yang @ 2016-12-14  7:24 UTC (permalink / raw)
  To: openembedded-core

It is helpful we want to exclude a lot of layers.
It uses python re, and supports multiple patterns (separated by space).

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/lib/oe/copy_buildsystem.py | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

diff --git a/meta/lib/oe/copy_buildsystem.py b/meta/lib/oe/copy_buildsystem.py
index 29ac6d4..e5d00c7 100644
--- a/meta/lib/oe/copy_buildsystem.py
+++ b/meta/lib/oe/copy_buildsystem.py
@@ -1,5 +1,12 @@
 # This class should provide easy access to the different aspects of the
 # buildsystem such as layers, bitbake location, etc.
+#
+# SDK_LAYERS_EXCLUDE: Layers which will be excluded from SDK layers.
+# SDK_LAYERS_EXCLUDE_PATTERN: The simiar to SDK_LAYERS_EXCLUDE, this supports
+#                             python regular expression, use space as separator,
+#                              e.g.: ".*-downloads closed-.*"
+#
+
 import stat
 import shutil
 
@@ -23,8 +30,10 @@ class BuildSystem(object):
         self.context = context
         self.layerdirs = [os.path.abspath(pth) for pth in d.getVar('BBLAYERS', True).split()]
         self.layers_exclude = (d.getVar('SDK_LAYERS_EXCLUDE', True) or "").split()
+        self.layers_exclude_pattern = d.getVar('SDK_LAYERS_EXCLUDE_PATTERN', True)
 
     def copy_bitbake_and_layers(self, destdir, workspace_name=None):
+        import re
         # Copy in all metadata layers + bitbake (as repositories)
         layers_copied = []
         bb.utils.mkdirhier(destdir)
@@ -36,8 +45,17 @@ class BuildSystem(object):
         # Exclude layers
         for layer_exclude in self.layers_exclude:
             if layer_exclude in layers:
+                bb.note('Excluded %s from sdk layers since it is in SDK_LAYERS_EXCLUDE' % layer_exclude)
                 layers.remove(layer_exclude)
 
+        if self.layers_exclude_pattern:
+            layers_cp = layers[:]
+            for pattern in self.layers_exclude_pattern.split():
+                for layer in layers_cp:
+                    if re.match(pattern, layer):
+                        bb.note('Excluded %s from sdk layers since matched SDK_LAYERS_EXCLUDE_PATTERN' % layer)
+                        layers.remove(layer)
+
         workspace_newname = workspace_name
         if workspace_newname:
             layernames = [os.path.basename(layer) for layer in layers]
-- 
2.10.2



^ permalink raw reply related	[flat|nested] 15+ messages in thread

* Re: [PATCH V2 1/8] populate_sdk_ext.bbclass: break the long lines
  2016-12-14  7:24 ` [PATCH V2 1/8] populate_sdk_ext.bbclass: break the long lines Robert Yang
@ 2016-12-14  8:02   ` Ulf Magnusson
  2016-12-14  8:37     ` Robert Yang
  0 siblings, 1 reply; 15+ messages in thread
From: Ulf Magnusson @ 2016-12-14  8:02 UTC (permalink / raw)
  To: Robert Yang; +Cc: OE-core

I'm not a big fan of those run-on lines either, so thanks. Some
superficial comments:

On Wed, Dec 14, 2016 at 8:24 AM, Robert Yang <liezhi.yang@windriver.com> wrote:
> Make it easier to read and maintain.
>
> [YOCTO #10647]
>
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  meta/classes/populate_sdk_ext.bbclass | 24 ++++++++++++++++++++----
>  1 file changed, 20 insertions(+), 4 deletions(-)
>
> diff --git a/meta/classes/populate_sdk_ext.bbclass b/meta/classes/populate_sdk_ext.bbclass
> index 3c3a73c..adef96d 100644
> --- a/meta/classes/populate_sdk_ext.bbclass
> +++ b/meta/classes/populate_sdk_ext.bbclass
> @@ -567,7 +567,13 @@ sdk_ext_postinst() {
>         printf "\nExtracting buildtools...\n"
>         cd $target_sdk_dir
>         env_setup_script="$target_sdk_dir/environment-setup-${REAL_MULTIMACH_TARGET_SYS}"
> -       printf "buildtools\ny" | ./${SDK_BUILDTOOLS_INSTALLER} > buildtools.log || { printf 'ERROR: buildtools installation failed:\n' ; cat buildtools.log ; echo "printf 'ERROR: this SDK was not fully installed and needs reinstalling\n'" >> $env_setup_script ; exit 1 ; }
> +       ./${SDK_BUILDTOOLS_INSTALLER} -d buildtools -y > buildtools.log
> +       if [ $? -ne 0 ]; then
> +               printf 'ERROR: buildtools installation failed:\n'
> +               cat buildtools.log
> +               echo "printf 'ERROR: this SDK was not fully installed and needs reinstalling\n'" >> $env_setup_script
> +               exit 1
> +       fi

Maybe it's a deliberate style choice, but just in case you're not
aware of it, the following two snippets work the same:

./${SDK_BUILDTOOLS_INSTALLER} -d buildtools -y > buildtools.log
if [ $? -ne 0 ]; then
    ...

if ! ./${SDK_BUILDTOOLS_INSTALLER} -d buildtools -y > buildtools.log; then
    ...

>
>         # Delete the buildtools tar file since it won't be used again
>         rm -f ./${SDK_BUILDTOOLS_INSTALLER}
> @@ -588,7 +594,9 @@ sdk_ext_postinst() {
>         echo "printf 'SDK environment now set up; additionally you may now run devtool to perform development tasks.\nRun devtool --help for further details.\n'" >> $env_setup_script
>
>         # Warn if trying to use external bitbake and the ext SDK together
> -       echo "(which bitbake > /dev/null 2>&1 && echo 'WARNING: attempting to use the extensible SDK in an environment set up to run bitbake - this may lead to unexpected results. Please source this script in a new shell session instead.') || true" >> $env_setup_script
> +       echo "(which bitbake > /dev/null 2>&1 && \
> +               echo 'WARNING: attempting to use the extensible SDK in an environment set up to run bitbake - this may lead to unexpected results. Please source this script in a new shell session instead.') || \
> +               true" >> $env_setup_script
>
>         if [ "$prepare_buildsystem" != "no" ]; then
>                 printf "Preparing build system...\n"
> @@ -596,8 +604,16 @@ sdk_ext_postinst() {
>                 # current working directory when first ran, nor will it set $1 when
>                 # sourcing a script. That is why this has to look so ugly.
>                 LOGFILE="$target_sdk_dir/preparing_build_system.log"
> -               sh -c ". buildtools/environment-setup* > $LOGFILE && cd $target_sdk_dir/`dirname ${oe_init_build_env_path}` && set $target_sdk_dir && . $target_sdk_dir/${oe_init_build_env_path} $target_sdk_dir >> $LOGFILE && python $target_sdk_dir/ext-sdk-prepare.py $LOGFILE '${SDK_INSTALL_TARGETS}'" || { echo "printf 'ERROR: this SDK was not fully installed and needs reinstalling\n'" >> $env_setup_script ; exit 1 ; }
> -               rm $target_sdk_dir/ext-sdk-prepare.py
> +               sh -c ". buildtools/environment-setup* > $LOGFILE && \
> +                       cd $target_sdk_dir/`dirname ${oe_init_build_env_path}` && \
> +                       set $target_sdk_dir && \

I know it was there before, but I wonder what the point of the 'set'
is here. It sets $1 to $target_sdk_dir, but $target_sdk_dir is already
passed explicitly to $target_sdk_dir/${oe_init_build_env_path} below.

> +                       . $target_sdk_dir/${oe_init_build_env_path} $target_sdk_dir >> $LOGFILE && \
> +                       python $target_sdk_dir/ext-sdk-prepare.py $LOGFILE '${SDK_INSTALL_TARGETS}'"
> +               if [ $? -ne ]; then
> +                       echo "printf 'ERROR: this SDK was not fully installed and needs reinstalling\n'" >> $env_setup_script
> +                       exit 1
> +                       rm $target_sdk_dir/ext-sdk-prepare.py

Unreachable code.

> +               fi
>         fi
>         echo done
>  }
> --
> 2.10.2
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Cheers,
Ulf


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH V2 1/8] populate_sdk_ext.bbclass: break the long lines
  2016-12-14  8:02   ` Ulf Magnusson
@ 2016-12-14  8:37     ` Robert Yang
  0 siblings, 0 replies; 15+ messages in thread
From: Robert Yang @ 2016-12-14  8:37 UTC (permalink / raw)
  To: Ulf Magnusson; +Cc: OE-core

Hi Ulf,

On 12/14/2016 04:02 PM, Ulf Magnusson wrote:
> I'm not a big fan of those run-on lines either, so thanks. Some
> superficial comments:
>
> On Wed, Dec 14, 2016 at 8:24 AM, Robert Yang <liezhi.yang@windriver.com> wrote:
>> Make it easier to read and maintain.
>>
>> [YOCTO #10647]
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>>  meta/classes/populate_sdk_ext.bbclass | 24 ++++++++++++++++++++----
>>  1 file changed, 20 insertions(+), 4 deletions(-)
>>
>> diff --git a/meta/classes/populate_sdk_ext.bbclass b/meta/classes/populate_sdk_ext.bbclass
>> index 3c3a73c..adef96d 100644
>> --- a/meta/classes/populate_sdk_ext.bbclass
>> +++ b/meta/classes/populate_sdk_ext.bbclass
>> @@ -567,7 +567,13 @@ sdk_ext_postinst() {
>>         printf "\nExtracting buildtools...\n"
>>         cd $target_sdk_dir
>>         env_setup_script="$target_sdk_dir/environment-setup-${REAL_MULTIMACH_TARGET_SYS}"
>> -       printf "buildtools\ny" | ./${SDK_BUILDTOOLS_INSTALLER} > buildtools.log || { printf 'ERROR: buildtools installation failed:\n' ; cat buildtools.log ; echo "printf 'ERROR: this SDK was not fully installed and needs reinstalling\n'" >> $env_setup_script ; exit 1 ; }
>> +       ./${SDK_BUILDTOOLS_INSTALLER} -d buildtools -y > buildtools.log
>> +       if [ $? -ne 0 ]; then
>> +               printf 'ERROR: buildtools installation failed:\n'
>> +               cat buildtools.log
>> +               echo "printf 'ERROR: this SDK was not fully installed and needs reinstalling\n'" >> $env_setup_script
>> +               exit 1
>> +       fi
>
> Maybe it's a deliberate style choice, but just in case you're not
> aware of it, the following two snippets work the same:
>
> ./${SDK_BUILDTOOLS_INSTALLER} -d buildtools -y > buildtools.log
> if [ $? -ne 0 ]; then
>     ...
>
> if ! ./${SDK_BUILDTOOLS_INSTALLER} -d buildtools -y > buildtools.log; then
>     ...

I'm not sure which is better. We have both of them in the real world.

>
>>
>>         # Delete the buildtools tar file since it won't be used again
>>         rm -f ./${SDK_BUILDTOOLS_INSTALLER}
>> @@ -588,7 +594,9 @@ sdk_ext_postinst() {
>>         echo "printf 'SDK environment now set up; additionally you may now run devtool to perform development tasks.\nRun devtool --help for further details.\n'" >> $env_setup_script
>>
>>         # Warn if trying to use external bitbake and the ext SDK together
>> -       echo "(which bitbake > /dev/null 2>&1 && echo 'WARNING: attempting to use the extensible SDK in an environment set up to run bitbake - this may lead to unexpected results. Please source this script in a new shell session instead.') || true" >> $env_setup_script
>> +       echo "(which bitbake > /dev/null 2>&1 && \
>> +               echo 'WARNING: attempting to use the extensible SDK in an environment set up to run bitbake - this may lead to unexpected results. Please source this script in a new shell session instead.') || \
>> +               true" >> $env_setup_script
>>
>>         if [ "$prepare_buildsystem" != "no" ]; then
>>                 printf "Preparing build system...\n"
>> @@ -596,8 +604,16 @@ sdk_ext_postinst() {
>>                 # current working directory when first ran, nor will it set $1 when
>>                 # sourcing a script. That is why this has to look so ugly.
>>                 LOGFILE="$target_sdk_dir/preparing_build_system.log"
>> -               sh -c ". buildtools/environment-setup* > $LOGFILE && cd $target_sdk_dir/`dirname ${oe_init_build_env_path}` && set $target_sdk_dir && . $target_sdk_dir/${oe_init_build_env_path} $target_sdk_dir >> $LOGFILE && python $target_sdk_dir/ext-sdk-prepare.py $LOGFILE '${SDK_INSTALL_TARGETS}'" || { echo "printf 'ERROR: this SDK was not fully installed and needs reinstalling\n'" >> $env_setup_script ; exit 1 ; }
>> -               rm $target_sdk_dir/ext-sdk-prepare.py
>> +               sh -c ". buildtools/environment-setup* > $LOGFILE && \
>> +                       cd $target_sdk_dir/`dirname ${oe_init_build_env_path}` && \
>> +                       set $target_sdk_dir && \
>
> I know it was there before, but I wonder what the point of the 'set'
> is here. It sets $1 to $target_sdk_dir, but $target_sdk_dir is already
> passed explicitly to $target_sdk_dir/${oe_init_build_env_path} below.

Will remove it in another thread the extra sed is useless here.

>
>> +                       . $target_sdk_dir/${oe_init_build_env_path} $target_sdk_dir >> $LOGFILE && \
>> +                       python $target_sdk_dir/ext-sdk-prepare.py $LOGFILE '${SDK_INSTALL_TARGETS}'"
>> +               if [ $? -ne ]; then
>> +                       echo "printf 'ERROR: this SDK was not fully installed and needs reinstalling\n'" >> $env_setup_script
>> +                       exit 1
>> +                       rm $target_sdk_dir/ext-sdk-prepare.py
>
> Unreachable code.

Good catch, thanks, updated in the repo.

// Robert

>
>> +               fi
>>         fi
>>         echo done
>>  }
>> --
>> 2.10.2
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
> Cheers,
> Ulf
>


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH V2 0/8] Fixes for eSDK and testsdkext
  2016-12-14  7:24 [PATCH V2 0/8] Fixes for eSDK and testsdkext Robert Yang
                   ` (7 preceding siblings ...)
  2016-12-14  7:24 ` [PATCH V2 8/8] oe/copy_buildsystem.py: add SDK_LAYERS_EXCLUDE_PATTERN Robert Yang
@ 2016-12-20 15:41 ` Burton, Ross
  2016-12-21  1:41   ` akuster808
  2016-12-21  6:20   ` Robert Yang
  8 siblings, 2 replies; 15+ messages in thread
From: Burton, Ross @ 2016-12-20 15:41 UTC (permalink / raw)
  To: Robert Yang; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 2029 bytes --]

This doesn't apply to master since Josh's getVar() changes landed, can you
please rebase?

Ross

On 14 December 2016 at 07:24, Robert Yang <liezhi.yang@windriver.com> wrote:

> * V2
>   1) Fix Paul's comments:
>      - Drop "don't reset when the test is failed"
>      - Update bug id for "oe-publish-sdk: add pyshtables.py to .gitignore"
>      - Split "install multilib targets as populate_sdk does" into 2
> commits:
>        "break the long lines"
>        "install multilib SDKs"
>   2) Use shorter subject lines
>
> * V1
>   Initial version
>
> // Robert
>
> The following changes since commit 4e412234c37efec42b3962c11d4490
> 3c0c58c92e:
>
>   libpcap: Disable exposed bits of WinPCAP remote capture support
> (2016-12-13 22:47:35 +0000)
>
> are available in the git repository at:
>
>   git://git.openembedded.org/openembedded-core-contrib rbt/eSDK
>   http://cgit.openembedded.org/cgit.cgi/openembedded-core-
> contrib/log/?h=rbt/eSDK
>
> Robert Yang (8):
>   populate_sdk_ext.bbclass: break the long lines
>   populate_sdk_ext.bbclass: install multilib SDKs
>   oeqa/sdkext/devtool.py: remove sources before run test cases
>   oe-publish-sdk: make cmd easier to read
>   oe-publish-sdk: add pyshtables.py to .gitignore
>   oeqa/oetest.py: add hasLockedSig()
>   oeqa/sdkext/devtool.py: skip a testcase when no libxml2
>   oe/copy_buildsystem.py: add SDK_LAYERS_EXCLUDE_PATTERN
>
>  meta/classes/populate_sdk_ext.bbclass | 63 ++++++++++++++++++++++++------
> -----
>  meta/lib/oe/copy_buildsystem.py       | 18 ++++++++++
>  meta/lib/oeqa/oetest.py               | 13 ++++++++
>  meta/lib/oeqa/sdkext/devtool.py       |  8 ++++-
>  scripts/oe-publish-sdk                | 19 +++++++++--
>  5 files changed, 98 insertions(+), 23 deletions(-)
>
> --
> 2.10.2
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 3078 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH V2 0/8] Fixes for eSDK and testsdkext
  2016-12-20 15:41 ` [PATCH V2 0/8] Fixes for eSDK and testsdkext Burton, Ross
@ 2016-12-21  1:41   ` akuster808
  2016-12-21  1:48     ` Robert Yang
  2016-12-21  6:20   ` Robert Yang
  1 sibling, 1 reply; 15+ messages in thread
From: akuster808 @ 2016-12-21  1:41 UTC (permalink / raw)
  To: Burton, Ross, Robert Yang; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 2659 bytes --]



On 12/20/2016 07:41 AM, Burton, Ross wrote:
> This doesn't apply to master since Josh's getVar() changes landed, can 
> you please rebase?

Would this appropriate for Morty in its current version?
- Armin
>
> Ross
>
> On 14 December 2016 at 07:24, Robert Yang <liezhi.yang@windriver.com 
> <mailto:liezhi.yang@windriver.com>> wrote:
>
>     * V2
>       1) Fix Paul's comments:
>          - Drop "don't reset when the test is failed"
>          - Update bug id for "oe-publish-sdk: add pyshtables.py to
>     .gitignore"
>          - Split "install multilib targets as populate_sdk does" into
>     2 commits:
>            "break the long lines"
>            "install multilib SDKs"
>       2) Use shorter subject lines
>
>     * V1
>       Initial version
>
>     // Robert
>
>     The following changes since commit
>     4e412234c37efec42b3962c11d44903c0c58c92e:
>
>       libpcap: Disable exposed bits of WinPCAP remote capture support
>     (2016-12-13 22:47:35 +0000)
>
>     are available in the git repository at:
>
>       git://git.openembedded.org/openembedded-core-contrib
>     <http://git.openembedded.org/openembedded-core-contrib> rbt/eSDK
>     http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/eSDK
>     <http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/eSDK>
>
>     Robert Yang (8):
>       populate_sdk_ext.bbclass: break the long lines
>       populate_sdk_ext.bbclass: install multilib SDKs
>       oeqa/sdkext/devtool.py: remove sources before run test cases
>       oe-publish-sdk: make cmd easier to read
>       oe-publish-sdk: add pyshtables.py to .gitignore
>       oeqa/oetest.py: add hasLockedSig()
>       oeqa/sdkext/devtool.py: skip a testcase when no libxml2
>       oe/copy_buildsystem.py: add SDK_LAYERS_EXCLUDE_PATTERN
>
>      meta/classes/populate_sdk_ext.bbclass | 63
>     ++++++++++++++++++++++++-----------
>      meta/lib/oe/copy_buildsystem.py       | 18 ++++++++++
>      meta/lib/oeqa/oetest.py               | 13 ++++++++
>      meta/lib/oeqa/sdkext/devtool.py       |  8 ++++-
>      scripts/oe-publish-sdk                | 19 +++++++++--
>      5 files changed, 98 insertions(+), 23 deletions(-)
>
>     --
>     2.10.2
>
>     --
>     _______________________________________________
>     Openembedded-core mailing list
>     Openembedded-core@lists.openembedded.org
>     <mailto:Openembedded-core@lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-core
>     <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>
>
>
>


[-- Attachment #2: Type: text/html, Size: 4827 bytes --]

^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH V2 0/8] Fixes for eSDK and testsdkext
  2016-12-21  1:41   ` akuster808
@ 2016-12-21  1:48     ` Robert Yang
  0 siblings, 0 replies; 15+ messages in thread
From: Robert Yang @ 2016-12-21  1:48 UTC (permalink / raw)
  To: akuster808, Burton, Ross; +Cc: OE-core



On 12/21/2016 09:41 AM, akuster808 wrote:
>
>
> On 12/20/2016 07:41 AM, Burton, Ross wrote:
>> This doesn't apply to master since Josh's getVar() changes landed, can you
>> please rebase?
>
> Would this appropriate for Morty in its current version?

Hi Armin,

These patches should be considered as enhancement (support multilib + eSDK),
I'm leaning to not backport to morty.

// Robert

> - Armin
>>
>> Ross
>>
>> On 14 December 2016 at 07:24, Robert Yang <liezhi.yang@windriver.com
>> <mailto:liezhi.yang@windriver.com>> wrote:
>>
>>     * V2
>>       1) Fix Paul's comments:
>>          - Drop "don't reset when the test is failed"
>>          - Update bug id for "oe-publish-sdk: add pyshtables.py to .gitignore"
>>          - Split "install multilib targets as populate_sdk does" into 2 commits:
>>            "break the long lines"
>>            "install multilib SDKs"
>>       2) Use shorter subject lines
>>
>>     * V1
>>       Initial version
>>
>>     // Robert
>>
>>     The following changes since commit 4e412234c37efec42b3962c11d44903c0c58c92e:
>>
>>       libpcap: Disable exposed bits of WinPCAP remote capture support
>>     (2016-12-13 22:47:35 +0000)
>>
>>     are available in the git repository at:
>>
>>       git://git.openembedded.org/openembedded-core-contrib
>>     <http://git.openembedded.org/openembedded-core-contrib> rbt/eSDK
>>
>>     http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/eSDK
>>     <http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/eSDK>
>>
>>     Robert Yang (8):
>>       populate_sdk_ext.bbclass: break the long lines
>>       populate_sdk_ext.bbclass: install multilib SDKs
>>       oeqa/sdkext/devtool.py: remove sources before run test cases
>>       oe-publish-sdk: make cmd easier to read
>>       oe-publish-sdk: add pyshtables.py to .gitignore
>>       oeqa/oetest.py: add hasLockedSig()
>>       oeqa/sdkext/devtool.py: skip a testcase when no libxml2
>>       oe/copy_buildsystem.py: add SDK_LAYERS_EXCLUDE_PATTERN
>>
>>      meta/classes/populate_sdk_ext.bbclass | 63
>>     ++++++++++++++++++++++++-----------
>>      meta/lib/oe/copy_buildsystem.py       | 18 ++++++++++
>>      meta/lib/oeqa/oetest.py               | 13 ++++++++
>>      meta/lib/oeqa/sdkext/devtool.py       |  8 ++++-
>>      scripts/oe-publish-sdk                | 19 +++++++++--
>>      5 files changed, 98 insertions(+), 23 deletions(-)
>>
>>     --
>>     2.10.2
>>
>>     --
>>     _______________________________________________
>>     Openembedded-core mailing list
>>     Openembedded-core@lists.openembedded.org
>>     <mailto:Openembedded-core@lists.openembedded.org>
>>     http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>     <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>>
>>
>>
>>
>


^ permalink raw reply	[flat|nested] 15+ messages in thread

* Re: [PATCH V2 0/8] Fixes for eSDK and testsdkext
  2016-12-20 15:41 ` [PATCH V2 0/8] Fixes for eSDK and testsdkext Burton, Ross
  2016-12-21  1:41   ` akuster808
@ 2016-12-21  6:20   ` Robert Yang
  1 sibling, 0 replies; 15+ messages in thread
From: Robert Yang @ 2016-12-21  6:20 UTC (permalink / raw)
  To: Burton, Ross; +Cc: OE-core


Hi Ross,

I rebased and tested again it in the repo:

   git://git.openembedded.org/openembedded-core-contrib rbt/eSDK
   http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/eSDK

Robert Yang (8):
   populate_sdk_ext.bbclass: break the long lines
   populate_sdk_ext.bbclass: install multilib SDKs
   oeqa/sdkext/devtool.py: remove sources before run test cases
   oe-publish-sdk: make cmd easier to read
   oe-publish-sdk: add pyshtables.py to .gitignore
   oeqa/oetest.py: add hasLockedSig()
   oeqa/sdkext/devtool.py: skip a testcase when no libxml2
   oe/copy_buildsystem.py: add SDK_LAYERS_EXCLUDE_PATTERN

// Robert

On 12/20/2016 11:41 PM, Burton, Ross wrote:
> This doesn't apply to master since Josh's getVar() changes landed, can you
> please rebase?
>
> Ross
>
> On 14 December 2016 at 07:24, Robert Yang <liezhi.yang@windriver.com
> <mailto:liezhi.yang@windriver.com>> wrote:
>
>     * V2
>       1) Fix Paul's comments:
>          - Drop "don't reset when the test is failed"
>          - Update bug id for "oe-publish-sdk: add pyshtables.py to .gitignore"
>          - Split "install multilib targets as populate_sdk does" into 2 commits:
>            "break the long lines"
>            "install multilib SDKs"
>       2) Use shorter subject lines
>
>     * V1
>       Initial version
>
>     // Robert
>
>     The following changes since commit 4e412234c37efec42b3962c11d44903c0c58c92e:
>
>       libpcap: Disable exposed bits of WinPCAP remote capture support
>     (2016-12-13 22:47:35 +0000)
>
>     are available in the git repository at:
>
>       git://git.openembedded.org/openembedded-core-contrib
>     <http://git.openembedded.org/openembedded-core-contrib> rbt/eSDK
>
>     http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/eSDK
>     <http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/eSDK>
>
>     Robert Yang (8):
>       populate_sdk_ext.bbclass: break the long lines
>       populate_sdk_ext.bbclass: install multilib SDKs
>       oeqa/sdkext/devtool.py: remove sources before run test cases
>       oe-publish-sdk: make cmd easier to read
>       oe-publish-sdk: add pyshtables.py to .gitignore
>       oeqa/oetest.py: add hasLockedSig()
>       oeqa/sdkext/devtool.py: skip a testcase when no libxml2
>       oe/copy_buildsystem.py: add SDK_LAYERS_EXCLUDE_PATTERN
>
>      meta/classes/populate_sdk_ext.bbclass | 63 ++++++++++++++++++++++++-----------
>      meta/lib/oe/copy_buildsystem.py       | 18 ++++++++++
>      meta/lib/oeqa/oetest.py               | 13 ++++++++
>      meta/lib/oeqa/sdkext/devtool.py       |  8 ++++-
>      scripts/oe-publish-sdk                | 19 +++++++++--
>      5 files changed, 98 insertions(+), 23 deletions(-)
>
>     --
>     2.10.2
>
>     --
>     _______________________________________________
>     Openembedded-core mailing list
>     Openembedded-core@lists.openembedded.org
>     <mailto:Openembedded-core@lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-core
>     <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>
>


^ permalink raw reply	[flat|nested] 15+ messages in thread

end of thread, other threads:[~2016-12-21  6:20 UTC | newest]

Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-12-14  7:24 [PATCH V2 0/8] Fixes for eSDK and testsdkext Robert Yang
2016-12-14  7:24 ` [PATCH V2 1/8] populate_sdk_ext.bbclass: break the long lines Robert Yang
2016-12-14  8:02   ` Ulf Magnusson
2016-12-14  8:37     ` Robert Yang
2016-12-14  7:24 ` [PATCH V2 2/8] populate_sdk_ext.bbclass: install multilib SDKs Robert Yang
2016-12-14  7:24 ` [PATCH V2 3/8] oeqa/sdkext/devtool.py: remove sources before run test cases Robert Yang
2016-12-14  7:24 ` [PATCH V2 4/8] oe-publish-sdk: make cmd easier to read Robert Yang
2016-12-14  7:24 ` [PATCH V2 5/8] oe-publish-sdk: add pyshtables.py to .gitignore Robert Yang
2016-12-14  7:24 ` [PATCH V2 6/8] oeqa/oetest.py: add hasLockedSig() Robert Yang
2016-12-14  7:24 ` [PATCH V2 7/8] oeqa/sdkext/devtool.py: skip a testcase when no libxml2 Robert Yang
2016-12-14  7:24 ` [PATCH V2 8/8] oe/copy_buildsystem.py: add SDK_LAYERS_EXCLUDE_PATTERN Robert Yang
2016-12-20 15:41 ` [PATCH V2 0/8] Fixes for eSDK and testsdkext Burton, Ross
2016-12-21  1:41   ` akuster808
2016-12-21  1:48     ` Robert Yang
2016-12-21  6:20   ` Robert Yang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.