From: <Mario.Limonciello@dell.com> To: <jiaxun.yang@flygoat.com>, <ibm-acpi@hmh.eng.br> Cc: <dvhart@infradead.org>, <andy@infradead.org>, <ibm-acpi-devel@lists.sourceforge.net>, <platform-driver-x86@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org> Subject: RE: [PATCH] platform/x86: thinkpad_acpi: disable bluetooth for some machines Date: Thu, 7 Mar 2019 23:14:21 +0000 [thread overview] Message-ID: <28af3c22ad144cf69284aa6f91ee6565@ausx13mpc124.AMER.DELL.COM> (raw) In-Reply-To: <20190307080820.9723-1-jiaxun.yang@flygoat.com> -----Original Message----- > From: platform-driver-x86-owner@vger.kernel.org <platform-driver-x86- > owner@vger.kernel.org> On Behalf Of Jiaxun Yang > Sent: Thursday, March 7, 2019 2:08 AM > To: ibm-acpi@hmh.eng.br > Cc: dvhart@infradead.org; andy@infradead.org; ibm-acpi- > devel@lists.sourceforge.net; platform-driver-x86@vger.kernel.org; linux- > kernel@vger.kernel.org; stable@vger.kernel.org; Jiaxun Yang > Subject: [PATCH] platform/x86: thinkpad_acpi: disable bluetooth for some > machines > > > [EXTERNAL EMAIL] > > Some AMD based ThinkPads have a firmware bug that calling > "GBDC" will cause bluetooth on Intel wireless cards blocked. Since this is considered a firmware bug; has the OEM (and IBV) been notified? Is it fixed in a newer version of the firmware? If so, then this should probably only match particular broken firmware versions. > > Probe these models by DMI match and disable bluetooth subdriver > if specified Intel wireless card exist. > > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com> > --- > drivers/platform/x86/thinkpad_acpi.c | 70 ++++++++++++++++++++++++++++ > 1 file changed, 70 insertions(+) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c > b/drivers/platform/x86/thinkpad_acpi.c > index 726341f2b638..29e835f9368a 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -79,6 +79,7 @@ > #include <linux/jiffies.h> > #include <linux/workqueue.h> > #include <linux/acpi.h> > +#include <linux/pci.h> > #include <linux/pci_ids.h> > #include <linux/power_supply.h> > #include <sound/core.h> > @@ -4501,11 +4502,80 @@ static void bluetooth_exit(void) > bluetooth_shutdown(); > } > > +static const struct dmi_system_id bt_fwbug_list[] __initconst = { > + { > + .ident = "ThinkPad E485", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "20KU"), > + }, > + }, > + { > + .ident = "ThinkPad E585", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "20KV"), > + }, > + }, > + { > + .ident = "ThinkPad A285 - 20MW", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "20MW"), > + }, > + }, > + { > + .ident = "ThinkPad A285 - 20MX", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "20MX"), > + }, > + }, > + { > + .ident = "ThinkPad A485 - 20MU", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "20MU"), > + }, > + }, > + { > + .ident = "ThinkPad A485 - 20MV", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "20MV"), > + }, > + }, > + {} > +}; > + > +static int __init have_bt_fwbug(void) > +{ > + /* Some AMD based ThinkPads have a firmware bug that calling > + * "GBDC" will cause bluetooth on Intel wireless cards blocked > + */ > + if (dmi_check_system(bt_fwbug_list)) { > + if (pci_get_device(PCI_VENDOR_ID_INTEL, 0x24F3, NULL) || \ > + pci_get_device(PCI_VENDOR_ID_INTEL, 0x24FD, NULL) || \ > + pci_get_device(PCI_VENDOR_ID_INTEL, 0x2526, NULL)) > + return 1; > + else > + return 0; > + } else { > + return 0; > + } > +} > + > static int __init bluetooth_init(struct ibm_init_struct *iibm) > { > int res; > int status = 0; > > + if (have_bt_fwbug()) { > + vdbg_printk(TPACPI_DBG_INIT | TPACPI_DBG_RFKILL, > + FW_BUG "disable bluetooth subdriver for Intel cards\n"); > + return 1; > + } > + > vdbg_printk(TPACPI_DBG_INIT | TPACPI_DBG_RFKILL, > "initializing bluetooth subdriver\n"); > > -- > 2.20.1
WARNING: multiple messages have this Message-ID (diff)
From: <Mario.Limonciello@dell.com> To: jiaxun.yang@flygoat.com, ibm-acpi@hmh.eng.br Cc: dvhart@infradead.org, andy@infradead.org, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: RE: [PATCH] platform/x86: thinkpad_acpi: disable bluetooth for some machines Date: Thu, 7 Mar 2019 23:14:21 +0000 [thread overview] Message-ID: <28af3c22ad144cf69284aa6f91ee6565@ausx13mpc124.AMER.DELL.COM> (raw) In-Reply-To: <20190307080820.9723-1-jiaxun.yang@flygoat.com> -----Original Message----- > From: platform-driver-x86-owner@vger.kernel.org <platform-driver-x86- > owner@vger.kernel.org> On Behalf Of Jiaxun Yang > Sent: Thursday, March 7, 2019 2:08 AM > To: ibm-acpi@hmh.eng.br > Cc: dvhart@infradead.org; andy@infradead.org; ibm-acpi- > devel@lists.sourceforge.net; platform-driver-x86@vger.kernel.org; linux- > kernel@vger.kernel.org; stable@vger.kernel.org; Jiaxun Yang > Subject: [PATCH] platform/x86: thinkpad_acpi: disable bluetooth for some > machines > > > [EXTERNAL EMAIL] > > Some AMD based ThinkPads have a firmware bug that calling > "GBDC" will cause bluetooth on Intel wireless cards blocked. Since this is considered a firmware bug; has the OEM (and IBV) been notified? Is it fixed in a newer version of the firmware? If so, then this should probably only match particular broken firmware versions. > > Probe these models by DMI match and disable bluetooth subdriver > if specified Intel wireless card exist. > > Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com> > --- > drivers/platform/x86/thinkpad_acpi.c | 70 ++++++++++++++++++++++++++++ > 1 file changed, 70 insertions(+) > > diff --git a/drivers/platform/x86/thinkpad_acpi.c > b/drivers/platform/x86/thinkpad_acpi.c > index 726341f2b638..29e835f9368a 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -79,6 +79,7 @@ > #include <linux/jiffies.h> > #include <linux/workqueue.h> > #include <linux/acpi.h> > +#include <linux/pci.h> > #include <linux/pci_ids.h> > #include <linux/power_supply.h> > #include <sound/core.h> > @@ -4501,11 +4502,80 @@ static void bluetooth_exit(void) > bluetooth_shutdown(); > } > > +static const struct dmi_system_id bt_fwbug_list[] __initconst = { > + { > + .ident = "ThinkPad E485", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "20KU"), > + }, > + }, > + { > + .ident = "ThinkPad E585", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "20KV"), > + }, > + }, > + { > + .ident = "ThinkPad A285 - 20MW", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "20MW"), > + }, > + }, > + { > + .ident = "ThinkPad A285 - 20MX", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "20MX"), > + }, > + }, > + { > + .ident = "ThinkPad A485 - 20MU", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "20MU"), > + }, > + }, > + { > + .ident = "ThinkPad A485 - 20MV", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "LENOVO"), > + DMI_MATCH(DMI_BOARD_NAME, "20MV"), > + }, > + }, > + {} > +}; > + > +static int __init have_bt_fwbug(void) > +{ > + /* Some AMD based ThinkPads have a firmware bug that calling > + * "GBDC" will cause bluetooth on Intel wireless cards blocked > + */ > + if (dmi_check_system(bt_fwbug_list)) { > + if (pci_get_device(PCI_VENDOR_ID_INTEL, 0x24F3, NULL) || \ > + pci_get_device(PCI_VENDOR_ID_INTEL, 0x24FD, NULL) || \ > + pci_get_device(PCI_VENDOR_ID_INTEL, 0x2526, NULL)) > + return 1; > + else > + return 0; > + } else { > + return 0; > + } > +} > + > static int __init bluetooth_init(struct ibm_init_struct *iibm) > { > int res; > int status = 0; > > + if (have_bt_fwbug()) { > + vdbg_printk(TPACPI_DBG_INIT | TPACPI_DBG_RFKILL, > + FW_BUG "disable bluetooth subdriver for Intel cards\n"); > + return 1; > + } > + > vdbg_printk(TPACPI_DBG_INIT | TPACPI_DBG_RFKILL, > "initializing bluetooth subdriver\n"); > > -- > 2.20.1
next prev parent reply other threads:[~2019-03-07 23:14 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-07 8:08 [PATCH] platform/x86: thinkpad_acpi: disable bluetooth for some machines Jiaxun Yang 2019-03-07 8:23 ` Andy Shevchenko 2019-03-07 9:37 ` [PATCH v2] " Jiaxun Yang 2019-03-07 11:20 ` [PATCH] " Greg KH 2019-03-07 12:30 ` Jiaxun Yang 2019-03-07 12:41 ` Andy Shevchenko 2019-03-07 17:00 ` David Laight 2019-03-07 17:00 ` David Laight 2019-03-07 23:14 ` Mario.Limonciello [this message] 2019-03-07 23:14 ` Mario.Limonciello 2019-03-08 1:14 ` Jiaxun Yang 2019-03-08 1:14 ` Jiaxun Yang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=28af3c22ad144cf69284aa6f91ee6565@ausx13mpc124.AMER.DELL.COM \ --to=mario.limonciello@dell.com \ --cc=andy@infradead.org \ --cc=dvhart@infradead.org \ --cc=ibm-acpi-devel@lists.sourceforge.net \ --cc=ibm-acpi@hmh.eng.br \ --cc=jiaxun.yang@flygoat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=platform-driver-x86@vger.kernel.org \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.