All of lore.kernel.org
 help / color / mirror / Atom feed
From: Helen Koike <helen.koike@collabora.com>
To: kbuild test robot <lkp@intel.com>,
	"Carlos E. C. Barbosa" <climacobarbosacee@gmail.com>
Cc: kbuild-all@01.org, lkcamp@lists.libreplanetbr.org,
	Shuah Khan <skhan@linuxfoundation.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] media: vimc: vimc_pix_map_fmt_info() can be static
Date: Sat, 5 Oct 2019 22:36:02 -0300	[thread overview]
Message-ID: <28ba4406-c231-e589-2eeb-bca5da5d3245@collabora.com> (raw)
In-Reply-To: <20191006002805.i2gbquub7egjczhx@332d0cec05f4>

Hi Carlos,

On 10/5/19 9:28 PM, kbuild test robot wrote:
> 
> Fixes: 4d124d159dff ("media: vimc: get pixformat info from v4l2_format_info to avoid code repetition")

Usually, the Fixes flag is used for something that is already accepted in mainline.
If you want to fix anything in the previous version of the patch you sent, you should update the last patch
and re-send it as a new version, i.e. [PATCH v2], adding a change log just after the 3 dashes to explain
what you changed.

Check this example:

https://www.spinics.net/lists/linux-media/msg158251.html

Let me know if you need help!
And thanks for working on this :)
Helen

> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
>  vimc-common.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/vimc/vimc-common.c b/drivers/media/platform/vimc/vimc-common.c
> index 9ea698810e1a1..c37442aba70b1 100644
> --- a/drivers/media/platform/vimc/vimc-common.c
> +++ b/drivers/media/platform/vimc/vimc-common.c
> @@ -118,7 +118,7 @@ static struct vimc_pix_map_fmt vimc_pix_map_fmt_list[] = {
>  	},
>  };
>  
> -struct vimc_pix_map vimc_pix_map_fmt_info(struct vimc_pix_map_fmt *vfmt)
> +static struct vimc_pix_map vimc_pix_map_fmt_info(struct vimc_pix_map_fmt *vfmt)
>  {
>  
>  	struct vimc_pix_map vpix = {
> 

WARNING: multiple messages have this Message-ID (diff)
From: Helen Koike <helen.koike@collabora.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH] media: vimc: vimc_pix_map_fmt_info() can be static
Date: Sat, 05 Oct 2019 22:36:02 -0300	[thread overview]
Message-ID: <28ba4406-c231-e589-2eeb-bca5da5d3245@collabora.com> (raw)
In-Reply-To: <20191006002805.i2gbquub7egjczhx@332d0cec05f4>

[-- Attachment #1: Type: text/plain, Size: 1351 bytes --]

Hi Carlos,

On 10/5/19 9:28 PM, kbuild test robot wrote:
> 
> Fixes: 4d124d159dff ("media: vimc: get pixformat info from v4l2_format_info to avoid code repetition")

Usually, the Fixes flag is used for something that is already accepted in mainline.
If you want to fix anything in the previous version of the patch you sent, you should update the last patch
and re-send it as a new version, i.e. [PATCH v2], adding a change log just after the 3 dashes to explain
what you changed.

Check this example:

https://www.spinics.net/lists/linux-media/msg158251.html

Let me know if you need help!
And thanks for working on this :)
Helen

> Signed-off-by: kbuild test robot <lkp@intel.com>
> ---
>  vimc-common.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/vimc/vimc-common.c b/drivers/media/platform/vimc/vimc-common.c
> index 9ea698810e1a1..c37442aba70b1 100644
> --- a/drivers/media/platform/vimc/vimc-common.c
> +++ b/drivers/media/platform/vimc/vimc-common.c
> @@ -118,7 +118,7 @@ static struct vimc_pix_map_fmt vimc_pix_map_fmt_list[] = {
>  	},
>  };
>  
> -struct vimc_pix_map vimc_pix_map_fmt_info(struct vimc_pix_map_fmt *vfmt)
> +static struct vimc_pix_map vimc_pix_map_fmt_info(struct vimc_pix_map_fmt *vfmt)
>  {
>  
>  	struct vimc_pix_map vpix = {
> 

  reply	other threads:[~2019-10-06  1:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-05 21:11 [PATCH] media: vimc: get pixformat info from v4l2_format_info to avoid code repetition Carlos E. C. Barbosa
2019-10-06  0:28 ` kbuild test robot
2019-10-06  0:28   ` kbuild test robot
2019-10-06  0:28 ` [RFC PATCH] media: vimc: vimc_pix_map_fmt_info() can be static kbuild test robot
2019-10-06  0:28   ` kbuild test robot
2019-10-06  1:36   ` Helen Koike [this message]
2019-10-06  1:36     ` Helen Koike
2019-10-07 15:18     ` [Lkcamp] " André Almeida
2019-10-07 15:18       ` André Almeida
2019-10-07 16:12       ` Helen Koike
2019-10-07 16:12         ` Helen Koike
2019-10-06  1:27 ` [PATCH] media: vimc: get pixformat info from v4l2_format_info to avoid code repetition Helen Koike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=28ba4406-c231-e589-2eeb-bca5da5d3245@collabora.com \
    --to=helen.koike@collabora.com \
    --cc=climacobarbosacee@gmail.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lkcamp@lists.libreplanetbr.org \
    --cc=lkp@intel.com \
    --cc=mchehab@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.