From: SF Markus Elfring <elfring@users.sourceforge.net> To: linux-media@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>, Jan Kara <jack@suse.cz>, Lorenzo Stoakes <lstoakes@gmail.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Michal Hocko <mhocko@suse.com>, Muralidharan Karicheri <mkaricheri@gmail.com>, Vaibhav Hiremath <hvaibhav@ti.com> Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org Subject: [PATCH 3/6] [media] omap_vout: Adjust a null pointer check in two functions Date: Sun, 24 Sep 2017 12:26:35 +0200 [thread overview] Message-ID: <28d2db5e-0cc3-04eb-16d6-0b6f0ecfe19c@users.sourceforge.net> (raw) In-Reply-To: <f9dc652b-4fca-37aa-0b72-8c9e6a828da9@users.sourceforge.net> From: Markus Elfring <elfring@users.sourceforge.net> Date: Sun, 24 Sep 2017 10:30:29 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/media/platform/omap/omap_vout.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/omap/omap_vout.c b/drivers/media/platform/omap/omap_vout.c index 4a4d171ca573..2b55a8ebd1ad 100644 --- a/drivers/media/platform/omap/omap_vout.c +++ b/drivers/media/platform/omap/omap_vout.c @@ -1006,7 +1006,7 @@ static int omap_vout_open(struct file *file) vout = video_drvdata(file); v4l2_dbg(1, debug, &vout->vid_dev->v4l2_dev, "Entering %s\n", __func__); - if (vout == NULL) + if (!vout) return -ENODEV; /* for now, we only support single open */ @@ -2095,7 +2095,7 @@ static int __init omap_vout_probe(struct platform_device *pdev) } vid_dev = kzalloc(sizeof(*vid_dev), GFP_KERNEL); - if (vid_dev == NULL) { + if (!vid_dev) { ret = -ENOMEM; goto err_dss_init; } -- 2.14.1
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net> To: linux-media@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>, Jan Kara <jack@suse.cz>, Lorenzo Stoakes <lstoakes@gmail.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Michal Hocko <mhocko@suse.com>, Muralidharan Karicheri <mkaricheri@gmail.com>, Vaibhav Hiremath <hvaibhav@ti.com> Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org Subject: [PATCH 3/6] [media] omap_vout: Adjust a null pointer check in two functions Date: Sun, 24 Sep 2017 10:26:35 +0000 [thread overview] Message-ID: <28d2db5e-0cc3-04eb-16d6-0b6f0ecfe19c@users.sourceforge.net> (raw) In-Reply-To: <f9dc652b-4fca-37aa-0b72-8c9e6a828da9@users.sourceforge.net> From: Markus Elfring <elfring@users.sourceforge.net> Date: Sun, 24 Sep 2017 10:30:29 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/media/platform/omap/omap_vout.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/omap/omap_vout.c b/drivers/media/platform/omap/omap_vout.c index 4a4d171ca573..2b55a8ebd1ad 100644 --- a/drivers/media/platform/omap/omap_vout.c +++ b/drivers/media/platform/omap/omap_vout.c @@ -1006,7 +1006,7 @@ static int omap_vout_open(struct file *file) vout = video_drvdata(file); v4l2_dbg(1, debug, &vout->vid_dev->v4l2_dev, "Entering %s\n", __func__); - if (vout = NULL) + if (!vout) return -ENODEV; /* for now, we only support single open */ @@ -2095,7 +2095,7 @@ static int __init omap_vout_probe(struct platform_device *pdev) } vid_dev = kzalloc(sizeof(*vid_dev), GFP_KERNEL); - if (vid_dev = NULL) { + if (!vid_dev) { ret = -ENOMEM; goto err_dss_init; } -- 2.14.1
next prev parent reply other threads:[~2017-09-24 10:26 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-09-24 10:20 [PATCH 0/6] [media] omap_vout: Adjustments for three function implementations SF Markus Elfring 2017-09-24 10:20 ` SF Markus Elfring 2017-09-24 10:22 ` [PATCH 1/6] [media] omap_vout: Delete an error message for a failed memory allocation in omap_vout_create_video_devices() SF Markus Elfring 2017-09-24 10:22 ` [PATCH 1/6] [media] omap_vout: Delete an error message for a failed memory allocation in omap_vout_c SF Markus Elfring 2017-09-24 10:35 ` [PATCH 1/6] [media] omap_vout: Delete an error message for a failed memory allocation in omap_vout_create_video_devices() Joe Perches 2017-09-24 10:35 ` [PATCH 1/6] [media] omap_vout: Delete an error message for a failed memory allocation in omap_vo Joe Perches 2017-09-24 10:24 ` [PATCH 2/6] [media] omap_vout: Improve a size determination in two functions SF Markus Elfring 2017-09-24 10:24 ` SF Markus Elfring 2017-09-24 10:26 ` SF Markus Elfring [this message] 2017-09-24 10:26 ` [PATCH 3/6] [media] omap_vout: Adjust a null pointer check " SF Markus Elfring 2017-09-24 10:28 ` [PATCH 4/6] [media] omap_vout: Fix a possible null pointer dereference in omap_vout_open() SF Markus Elfring 2017-09-24 10:28 ` SF Markus Elfring 2017-09-24 10:30 ` [PATCH 5/6] [media] omap_vout: Delete an unnecessary variable initialisation " SF Markus Elfring 2017-09-24 10:30 ` SF Markus Elfring 2017-09-24 10:33 ` [PATCH 6/6] [media] omap_vout: Delete two unnecessary variable initialisations in omap_vout_probe() SF Markus Elfring 2017-09-24 10:33 ` SF Markus Elfring 2017-10-30 8:36 ` [PATCH 0/6] [media] omap_vout: Adjustments for three function implementations Hans Verkuil 2017-10-30 8:36 ` Hans Verkuil 2017-10-30 9:16 ` Adjustments for a lot of " SF Markus Elfring 2017-10-30 9:16 ` SF Markus Elfring 2017-10-30 9:47 ` Julia Lawall 2017-10-30 9:47 ` Julia Lawall 2017-10-30 9:57 ` Hans Verkuil 2017-10-30 9:57 ` Hans Verkuil 2017-10-30 10:40 ` SF Markus Elfring 2017-10-30 10:40 ` SF Markus Elfring 2017-10-30 10:48 ` Hans Verkuil 2017-10-30 10:48 ` Hans Verkuil 2017-10-30 11:41 ` SF Markus Elfring 2017-10-30 11:41 ` SF Markus Elfring 2017-11-26 19:06 ` SF Markus Elfring 2017-11-26 19:06 ` SF Markus Elfring 2018-01-08 11:44 ` SF Markus Elfring 2018-01-08 11:44 ` SF Markus Elfring 2018-02-02 9:55 ` SF Markus Elfring 2018-02-02 9:55 ` SF Markus Elfring 2018-02-02 10:29 ` Hans Verkuil 2018-02-02 10:29 ` Hans Verkuil 2018-02-02 12:30 ` SF Markus Elfring 2018-02-02 12:30 ` SF Markus Elfring 2018-02-10 8:39 ` SF Markus Elfring 2018-02-10 8:39 ` SF Markus Elfring 2017-10-31 8:27 ` SF Markus Elfring 2017-10-31 8:27 ` SF Markus Elfring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=28d2db5e-0cc3-04eb-16d6-0b6f0ecfe19c@users.sourceforge.net \ --to=elfring@users.sourceforge.net \ --cc=hvaibhav@ti.com \ --cc=hverkuil@xs4all.nl \ --cc=jack@suse.cz \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=lstoakes@gmail.com \ --cc=mchehab@kernel.org \ --cc=mhocko@suse.com \ --cc=mkaricheri@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.