* [PATCH] qapi: Delete unwanted indentation of top-level expressions
@ 2020-07-30 9:16 Markus Armbruster
2020-07-30 13:11 ` Max Reitz
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Markus Armbruster @ 2020-07-30 9:16 UTC (permalink / raw)
To: qemu-devel; +Cc: vsementsov, jsnow, kraxel, mreitz
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qapi/block-core.json | 24 ++++++++++++------------
qapi/ui.json | 4 ++--
2 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/qapi/block-core.json b/qapi/block-core.json
index ab7bf3c612..bdcc8e5f9f 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -1847,8 +1847,8 @@
#
# Since: 4.0
##
- { 'enum': 'BlockPermission',
- 'data': [ 'consistent-read', 'write', 'write-unchanged', 'resize',
+{ 'enum': 'BlockPermission',
+ 'data': [ 'consistent-read', 'write', 'write-unchanged', 'resize',
'graph-mod' ] }
##
# @XDbgBlockGraphEdge:
@@ -2155,8 +2155,8 @@
# <- { "return": {} }
#
##
- { 'command': 'block-dirty-bitmap-enable',
- 'data': 'BlockDirtyBitmap' }
+{ 'command': 'block-dirty-bitmap-enable',
+ 'data': 'BlockDirtyBitmap' }
##
# @block-dirty-bitmap-disable:
@@ -2176,8 +2176,8 @@
# <- { "return": {} }
#
##
- { 'command': 'block-dirty-bitmap-disable',
- 'data': 'BlockDirtyBitmap' }
+{ 'command': 'block-dirty-bitmap-disable',
+ 'data': 'BlockDirtyBitmap' }
##
# @block-dirty-bitmap-merge:
@@ -2208,8 +2208,8 @@
# <- { "return": {} }
#
##
- { 'command': 'block-dirty-bitmap-merge',
- 'data': 'BlockDirtyBitmapMerge' }
+{ 'command': 'block-dirty-bitmap-merge',
+ 'data': 'BlockDirtyBitmapMerge' }
##
# @BlockDirtyBitmapSha256:
@@ -2220,8 +2220,8 @@
#
# Since: 2.10
##
- { 'struct': 'BlockDirtyBitmapSha256',
- 'data': {'sha256': 'str'} }
+{ 'struct': 'BlockDirtyBitmapSha256',
+ 'data': {'sha256': 'str'} }
##
# @x-debug-block-dirty-bitmap-sha256:
@@ -2235,8 +2235,8 @@
#
# Since: 2.10
##
- { 'command': 'x-debug-block-dirty-bitmap-sha256',
- 'data': 'BlockDirtyBitmap', 'returns': 'BlockDirtyBitmapSha256' }
+{ 'command': 'x-debug-block-dirty-bitmap-sha256',
+ 'data': 'BlockDirtyBitmap', 'returns': 'BlockDirtyBitmapSha256' }
##
# @blockdev-mirror:
diff --git a/qapi/ui.json b/qapi/ui.json
index e16e98a060..1568cfeaad 100644
--- a/qapi/ui.json
+++ b/qapi/ui.json
@@ -1081,8 +1081,8 @@
# Since: 3.0
#
##
- { 'enum' : 'DisplayGLMode',
- 'data' : [ 'off', 'on', 'core', 'es' ] }
+{ 'enum' : 'DisplayGLMode',
+ 'data' : [ 'off', 'on', 'core', 'es' ] }
##
# @DisplayCurses:
--
2.26.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] qapi: Delete unwanted indentation of top-level expressions
2020-07-30 9:16 [PATCH] qapi: Delete unwanted indentation of top-level expressions Markus Armbruster
@ 2020-07-30 13:11 ` Max Reitz
2020-07-30 14:50 ` Markus Armbruster
2020-07-30 14:56 ` Eric Blake
2020-08-03 6:24 ` Markus Armbruster
2 siblings, 1 reply; 5+ messages in thread
From: Max Reitz @ 2020-07-30 13:11 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: vsementsov, jsnow, kraxel
[-- Attachment #1.1: Type: text/plain, Size: 799 bytes --]
On 30.07.20 11:16, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qapi/block-core.json | 24 ++++++++++++------------
> qapi/ui.json | 4 ++--
> 2 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index ab7bf3c612..bdcc8e5f9f 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -1847,8 +1847,8 @@
> #
> # Since: 4.0
> ##
> - { 'enum': 'BlockPermission',
> - 'data': [ 'consistent-read', 'write', 'write-unchanged', 'resize',
> +{ 'enum': 'BlockPermission',
> + 'data': [ 'consistent-read', 'write', 'write-unchanged', 'resize',
> 'graph-mod' ] }
Do we want to keep the alignment at the opening parenthesis here?
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qapi: Delete unwanted indentation of top-level expressions
2020-07-30 13:11 ` Max Reitz
@ 2020-07-30 14:50 ` Markus Armbruster
0 siblings, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2020-07-30 14:50 UTC (permalink / raw)
To: Max Reitz; +Cc: vsementsov, jsnow, qemu-devel, kraxel
Max Reitz <mreitz@redhat.com> writes:
> On 30.07.20 11:16, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>> ---
>> qapi/block-core.json | 24 ++++++++++++------------
>> qapi/ui.json | 4 ++--
>> 2 files changed, 14 insertions(+), 14 deletions(-)
>>
>> diff --git a/qapi/block-core.json b/qapi/block-core.json
>> index ab7bf3c612..bdcc8e5f9f 100644
>> --- a/qapi/block-core.json
>> +++ b/qapi/block-core.json
>> @@ -1847,8 +1847,8 @@
>> #
>> # Since: 4.0
>> ##
>> - { 'enum': 'BlockPermission',
>> - 'data': [ 'consistent-read', 'write', 'write-unchanged', 'resize',
>> +{ 'enum': 'BlockPermission',
>> + 'data': [ 'consistent-read', 'write', 'write-unchanged', 'resize',
>> 'graph-mod' ] }
>
> Do we want to keep the alignment at the opening parenthesis here?
Yes, we do. Thanks!
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qapi: Delete unwanted indentation of top-level expressions
2020-07-30 9:16 [PATCH] qapi: Delete unwanted indentation of top-level expressions Markus Armbruster
2020-07-30 13:11 ` Max Reitz
@ 2020-07-30 14:56 ` Eric Blake
2020-08-03 6:24 ` Markus Armbruster
2 siblings, 0 replies; 5+ messages in thread
From: Eric Blake @ 2020-07-30 14:56 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: vsementsov, jsnow, kraxel, mreitz
On 7/30/20 4:16 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qapi/block-core.json | 24 ++++++++++++------------
> qapi/ui.json | 4 ++--
> 2 files changed, 14 insertions(+), 14 deletions(-)
>
> +++ b/qapi/ui.json
> @@ -1081,8 +1081,8 @@
> # Since: 3.0
> #
> ##
> - { 'enum' : 'DisplayGLMode',
> - 'data' : [ 'off', 'on', 'core', 'es' ] }
> +{ 'enum' : 'DisplayGLMode',
> + 'data' : [ 'off', 'on', 'core', 'es' ] }
We are really inconsistent on whether we use space before ':'. Oh well,
not the problem of this patch.
With the one additional line reindented as covered by Max' review,
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] qapi: Delete unwanted indentation of top-level expressions
2020-07-30 9:16 [PATCH] qapi: Delete unwanted indentation of top-level expressions Markus Armbruster
2020-07-30 13:11 ` Max Reitz
2020-07-30 14:56 ` Eric Blake
@ 2020-08-03 6:24 ` Markus Armbruster
2 siblings, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2020-08-03 6:24 UTC (permalink / raw)
To: qemu-devel; +Cc: vsementsov, jsnow, kraxel, mreitz
Queued.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-03 6:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-30 9:16 [PATCH] qapi: Delete unwanted indentation of top-level expressions Markus Armbruster
2020-07-30 13:11 ` Max Reitz
2020-07-30 14:50 ` Markus Armbruster
2020-07-30 14:56 ` Eric Blake
2020-08-03 6:24 ` Markus Armbruster
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.