All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 3/4] dt-bindings: display: panel: mipi-dbi-spi: Add missing power-supply
@ 2022-11-25 18:00 Otto Pflüger
  0 siblings, 0 replies; 4+ messages in thread
From: Otto Pflüger @ 2022-11-25 18:00 UTC (permalink / raw)
  To: Noralf Trønnes, Thierry Reding, Sam Ravnborg, David Airlie,
	Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, dri-devel,
	devicetree, linux-kernel

The power-supply property is currently only mentioned in the
description, but not listed in the properties section as it should be.
Add it there.

Signed-off-by: Otto Pflüger <affenull2345@gmail.com>
---
  .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml  | 3 +++
  1 file changed, 3 insertions(+)

diff --git 
a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml 
b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
index c2df8d28aaf5..d55bf12ecead 100644
--- 
a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
+++ 
b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
@@ -80,6 +80,9 @@ properties:
        Controller data/command selection (D/CX) in 4-line SPI mode.
        If not set, the controller is in 3-line SPI mode.

+  power-supply:
+    description: Power supply for the display module (Vdd).
+
  required:
    - compatible
    - reg
-- 
2.30.2

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 3/4] dt-bindings: display: panel: mipi-dbi-spi: Add missing power-supply
  2022-11-27 19:14 ` [PATCH 3/4] dt-bindings: display: panel: mipi-dbi-spi: Add missing power-supply Otto Pflüger
@ 2022-12-01 21:58     ` Rob Herring
  0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-12-01 21:58 UTC (permalink / raw)
  To: Otto Pflüger
  Cc: Noralf Trønnes, Thierry Reding, Sam Ravnborg, David Airlie,
	Daniel Vetter, Krzysztof Kozlowski, Maarten Lankhorst,
	Maxime Ripard, Thomas Zimmermann, dri-devel, devicetree,
	linux-kernel

On Sun, Nov 27, 2022 at 08:14:32PM +0100, Otto Pflüger wrote:
> The power-supply property is only mentioned in the description and not
> listed in the properties section of the binding. Add it there.

That's because it is described in panel-common.yaml already.

But I guess it is somewhat useful to define it corresponds to Vdd.

> 
> Signed-off-by: Otto Pflüger <otto.pflueger@abscue.de>
> ---
>  .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml  | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 3/4] dt-bindings: display: panel: mipi-dbi-spi: Add missing power-supply
@ 2022-12-01 21:58     ` Rob Herring
  0 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2022-12-01 21:58 UTC (permalink / raw)
  To: Otto Pflüger
  Cc: devicetree, Thomas Zimmermann, linux-kernel, Noralf Trønnes,
	Thierry Reding, dri-devel, Krzysztof Kozlowski, Sam Ravnborg

On Sun, Nov 27, 2022 at 08:14:32PM +0100, Otto Pflüger wrote:
> The power-supply property is only mentioned in the description and not
> listed in the properties section of the binding. Add it there.

That's because it is described in panel-common.yaml already.

But I guess it is somewhat useful to define it corresponds to Vdd.

> 
> Signed-off-by: Otto Pflüger <otto.pflueger@abscue.de>
> ---
>  .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml  | 3 +++
>  1 file changed, 3 insertions(+)

Reviewed-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 3/4] dt-bindings: display: panel: mipi-dbi-spi: Add missing power-supply
  2022-11-27 19:14 [PATCH 1/4] drm/mipi-dbi: Support separate I/O regulator Otto Pflüger
@ 2022-11-27 19:14 ` Otto Pflüger
  2022-12-01 21:58     ` Rob Herring
  0 siblings, 1 reply; 4+ messages in thread
From: Otto Pflüger @ 2022-11-27 19:14 UTC (permalink / raw)
  To: Noralf Trønnes, Thierry Reding, Sam Ravnborg, David Airlie,
	Daniel Vetter, Rob Herring, Krzysztof Kozlowski,
	Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, dri-devel,
	devicetree, linux-kernel
  Cc: Otto Pflüger

The power-supply property is only mentioned in the description and not
listed in the properties section of the binding. Add it there.

Signed-off-by: Otto Pflüger <otto.pflueger@abscue.de>
---
 .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml  | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
index c2df8d28aaf5..d55bf12ecead 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml
@@ -80,6 +80,9 @@ properties:
       Controller data/command selection (D/CX) in 4-line SPI mode.
       If not set, the controller is in 3-line SPI mode.
 
+  power-supply:
+    description: Power supply for the display module (Vdd).
+
 required:
   - compatible
   - reg
-- 
2.30.2

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-12-01 21:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-25 18:00 [PATCH 3/4] dt-bindings: display: panel: mipi-dbi-spi: Add missing power-supply Otto Pflüger
2022-11-27 19:14 [PATCH 1/4] drm/mipi-dbi: Support separate I/O regulator Otto Pflüger
2022-11-27 19:14 ` [PATCH 3/4] dt-bindings: display: panel: mipi-dbi-spi: Add missing power-supply Otto Pflüger
2022-12-01 21:58   ` Rob Herring
2022-12-01 21:58     ` Rob Herring

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.