* [PATCH] ixgbe: Fix for 82599 Bypass NIC, getting incorrect media type @ 2014-06-10 14:59 Pablo de Lara [not found] ` <1402412388-12580-1-git-send-email-pablox.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Pablo de Lara @ 2014-06-10 14:59 UTC (permalink / raw) To: dev-VfR2kkLFssw From: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Function ixgbe_get_media_type_82599 returns media_type = ixgbe_media_type_unknown, when using an 82599 Bypass NIC, so that causes link status interrupt not to work properly. Signed-off-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> --- lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c index db07789..e230a5b 100644 --- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c +++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c @@ -436,6 +436,7 @@ enum ixgbe_media_type ixgbe_get_media_type_82599(struct ixgbe_hw *hw) case IXGBE_DEV_ID_82599_SFP_SF2: case IXGBE_DEV_ID_82599_SFP_SF_QP: case IXGBE_DEV_ID_82599EN_SFP: + case IXGBE_DEV_ID_82599_BYPASS: media_type = ixgbe_media_type_fiber; break; case IXGBE_DEV_ID_82599_CX4: -- 1.7.0.7 ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <1402412388-12580-1-git-send-email-pablox.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]
* [PATCH v2] ixgbe: Fix for 82599 Bypass NIC, getting incorrect media type [not found] ` <1402412388-12580-1-git-send-email-pablox.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> @ 2014-06-10 21:33 ` Pablo de Lara [not found] ` <1402436007-25730-1-git-send-email-pablox.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Pablo de Lara @ 2014-06-10 21:33 UTC (permalink / raw) To: dev-VfR2kkLFssw From: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Function ixgbe_get_media_type_82599 returns media_type = ixgbe_media_type_unknown, when using an 82599 Bypass NIC, so that causes link status interrupt not to work properly. change in v2: Fixed compilation error when RTE_NIC_BYPASS=n Signed-off-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> --- lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c index db07789..7d9decd 100644 --- a/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c +++ b/lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c @@ -436,6 +436,9 @@ enum ixgbe_media_type ixgbe_get_media_type_82599(struct ixgbe_hw *hw) case IXGBE_DEV_ID_82599_SFP_SF2: case IXGBE_DEV_ID_82599_SFP_SF_QP: case IXGBE_DEV_ID_82599EN_SFP: +#ifdef RTE_NIC_BYPASS + case IXGBE_DEV_ID_82599_BYPASS: +#endif media_type = ixgbe_media_type_fiber; break; case IXGBE_DEV_ID_82599_CX4: -- 1.7.0.7 ^ permalink raw reply related [flat|nested] 3+ messages in thread
[parent not found: <1402436007-25730-1-git-send-email-pablox.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH v2] ixgbe: Fix for 82599 Bypass NIC, getting incorrect media type [not found] ` <1402436007-25730-1-git-send-email-pablox.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> @ 2014-06-17 9:58 ` Thomas Monjalon 0 siblings, 0 replies; 3+ messages in thread From: Thomas Monjalon @ 2014-06-17 9:58 UTC (permalink / raw) To: Pablo de Lara; +Cc: dev-VfR2kkLFssw > Function ixgbe_get_media_type_82599 returns media_type = > ixgbe_media_type_unknown, when using an 82599 Bypass NIC, > so that causes link status interrupt not to work properly. > > change in v2: Fixed compilation error when RTE_NIC_BYPASS=n > > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> > --- > lib/librte_pmd_ixgbe/ixgbe/ixgbe_82599.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) Note that we shouldn't modify the Intel base driver. Acked-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org> Applied for version 1.7.0. Feel free to revert if someone think it's not acceptable. -- Thomas ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-06-17 9:58 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2014-06-10 14:59 [PATCH] ixgbe: Fix for 82599 Bypass NIC, getting incorrect media type Pablo de Lara [not found] ` <1402412388-12580-1-git-send-email-pablox.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 2014-06-10 21:33 ` [PATCH v2] " Pablo de Lara [not found] ` <1402436007-25730-1-git-send-email-pablox.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> 2014-06-17 9:58 ` Thomas Monjalon
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.