From: Anshuman Khandual <anshuman.khandual@arm.com> To: Wei Yongjun <weiyongjun1@huawei.com>, Mathieu Poirier <mathieu.poirier@linaro.org>, Suzuki K Poulose <suzuki.poulose@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot <hulkci@huawei.com> Subject: Re: [PATCH -next] coresight: core: Make symbol 'csdev_sink' static Date: Fri, 9 Apr 2021 14:35:07 +0530 [thread overview] Message-ID: <291c6015-dbef-553b-c756-9d5acd1d9fe2@arm.com> (raw) In-Reply-To: <20210409013215.488823-1-weiyongjun1@huawei.com> On 4/9/21 7:02 AM, Wei Yongjun wrote: > The sparse tool complains as follows: > > drivers/hwtracing/coresight/coresight-core.c:26:1: warning: > symbol '__pcpu_scope_csdev_sink' was not declared. Should it be static? > > This symbol is not used outside of coresight-core.c, so this > commit marks it static. commit ? It is not on the tree yet. s/commit/change instead. > > Fixes: 2cd87a7b293d ("coresight: core: Add support for dedicated percpu sinks") There is no functional problem that this patch is proposing to fix and hence the "Fixes:" tag is not warranted. Suzuki/Matihieu ? > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/hwtracing/coresight/coresight-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c > index 3e779e1619ed..6c68d34d956e 100644 > --- a/drivers/hwtracing/coresight/coresight-core.c > +++ b/drivers/hwtracing/coresight/coresight-core.c > @@ -23,7 +23,7 @@ > #include "coresight-priv.h" > > static DEFINE_MUTEX(coresight_mutex); > -DEFINE_PER_CPU(struct coresight_device *, csdev_sink); > +static DEFINE_PER_CPU(struct coresight_device *, csdev_sink); > > /** > * struct coresight_node - elements of a path, from source to sink > Otherwise LGTM. As csdev_sink is not being used outside coresight-core.c file after the introduction of coresight_[set|get]_percpu_sink() helpers.
WARNING: multiple messages have this Message-ID (diff)
From: Anshuman Khandual <anshuman.khandual@arm.com> To: Wei Yongjun <weiyongjun1@huawei.com>, Mathieu Poirier <mathieu.poirier@linaro.org>, Suzuki K Poulose <suzuki.poulose@arm.com>, Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Hulk Robot <hulkci@huawei.com> Subject: Re: [PATCH -next] coresight: core: Make symbol 'csdev_sink' static Date: Fri, 9 Apr 2021 14:35:07 +0530 [thread overview] Message-ID: <291c6015-dbef-553b-c756-9d5acd1d9fe2@arm.com> (raw) In-Reply-To: <20210409013215.488823-1-weiyongjun1@huawei.com> On 4/9/21 7:02 AM, Wei Yongjun wrote: > The sparse tool complains as follows: > > drivers/hwtracing/coresight/coresight-core.c:26:1: warning: > symbol '__pcpu_scope_csdev_sink' was not declared. Should it be static? > > This symbol is not used outside of coresight-core.c, so this > commit marks it static. commit ? It is not on the tree yet. s/commit/change instead. > > Fixes: 2cd87a7b293d ("coresight: core: Add support for dedicated percpu sinks") There is no functional problem that this patch is proposing to fix and hence the "Fixes:" tag is not warranted. Suzuki/Matihieu ? > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/hwtracing/coresight/coresight-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c > index 3e779e1619ed..6c68d34d956e 100644 > --- a/drivers/hwtracing/coresight/coresight-core.c > +++ b/drivers/hwtracing/coresight/coresight-core.c > @@ -23,7 +23,7 @@ > #include "coresight-priv.h" > > static DEFINE_MUTEX(coresight_mutex); > -DEFINE_PER_CPU(struct coresight_device *, csdev_sink); > +static DEFINE_PER_CPU(struct coresight_device *, csdev_sink); > > /** > * struct coresight_node - elements of a path, from source to sink > Otherwise LGTM. As csdev_sink is not being used outside coresight-core.c file after the introduction of coresight_[set|get]_percpu_sink() helpers. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-09 9:04 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-09 1:32 [PATCH -next] coresight: core: Make symbol 'csdev_sink' static Wei Yongjun 2021-04-09 1:32 ` Wei Yongjun 2021-04-09 9:05 ` Anshuman Khandual [this message] 2021-04-09 9:05 ` Anshuman Khandual
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=291c6015-dbef-553b-c756-9d5acd1d9fe2@arm.com \ --to=anshuman.khandual@arm.com \ --cc=alexander.shishkin@linux.intel.com \ --cc=coresight@lists.linaro.org \ --cc=hulkci@huawei.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mathieu.poirier@linaro.org \ --cc=suzuki.poulose@arm.com \ --cc=weiyongjun1@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.