From: Dave Anderson <anderson@redhat.com> To: Vivek Goyal <vgoyal@redhat.com> Cc: prasad@linux.vnet.ibm.com, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Andi Kleen <andi@firstfloor.org>, Tony Luck <tony.luck@intel.com>, kexec@lists.infradead.org, "Eric W. Biederman" <ebiederm@xmission.com> Subject: Re: [RFC Patch 4/6] PANIC_MCE: Introduce a new panic flag for fatal MCE, capture related information Date: Wed, 1 Jun 2011 13:41:34 -0400 (EDT) [thread overview] Message-ID: <292370127.12181.1306950094350.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> (raw) In-Reply-To: <20110601172326.GA17449@redhat.com> ----- Original Message ----- > On Wed, Jun 01, 2011 at 01:18:16PM -0400, Dave Anderson wrote: > > FWIW, unlike mcelog, it really doesn't have to be maintained in the crash > > utility. It's just another kernel data structure whose contents can be > > determined dynamically during runtime: > > > > That's what I was wondering. Why can't we simple extract the contents > of this structure from /proc/vmcore and save it, instead of trying to > export it by appending additional elf notes to vmcore. Actually I take that back -- Prasad's patch looks at the ELF header contents and exits before the crash utility invokes the embedded gdb, so the structure contents are unavailable at that time. It doesn't even use the vmlinux file. Dave > > Thanks > Vivek > > > crash> struct mce > > struct mce { > > __u64 status; > > __u64 misc; > > __u64 addr; > > __u64 mcgstatus; > > __u64 ip; > > __u64 tsc; > > __u64 time; > > __u8 cpuvendor; > > __u8 inject_flags; > > __u16 pad; > > __u32 cpuid; > > __u8 cs; > > __u8 bank; > > __u8 cpu; > > __u8 finished; > > __u32 extcpu; > > __u32 socketid; > > __u32 apicid; > > __u64 mcgcap; > > } > > SIZE: 88 > > crash> > > > > Dave > > > > > If you think that this complicates the patch, I'll start with a > > > much > > > 'slimmer' version (!) of the slimdump and the improvements may be > > > contemplated iteratively. > > > > > > Thanks, > > > K.Prasad
WARNING: multiple messages have this Message-ID (diff)
From: Dave Anderson <anderson@redhat.com> To: Vivek Goyal <vgoyal@redhat.com> Cc: Tony Luck <tony.luck@intel.com>, kexec@lists.infradead.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Andi Kleen <andi@firstfloor.org>, "Eric W. Biederman" <ebiederm@xmission.com>, prasad@linux.vnet.ibm.com Subject: Re: [RFC Patch 4/6] PANIC_MCE: Introduce a new panic flag for fatal MCE, capture related information Date: Wed, 1 Jun 2011 13:41:34 -0400 (EDT) [thread overview] Message-ID: <292370127.12181.1306950094350.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com> (raw) In-Reply-To: <20110601172326.GA17449@redhat.com> ----- Original Message ----- > On Wed, Jun 01, 2011 at 01:18:16PM -0400, Dave Anderson wrote: > > FWIW, unlike mcelog, it really doesn't have to be maintained in the crash > > utility. It's just another kernel data structure whose contents can be > > determined dynamically during runtime: > > > > That's what I was wondering. Why can't we simple extract the contents > of this structure from /proc/vmcore and save it, instead of trying to > export it by appending additional elf notes to vmcore. Actually I take that back -- Prasad's patch looks at the ELF header contents and exits before the crash utility invokes the embedded gdb, so the structure contents are unavailable at that time. It doesn't even use the vmlinux file. Dave > > Thanks > Vivek > > > crash> struct mce > > struct mce { > > __u64 status; > > __u64 misc; > > __u64 addr; > > __u64 mcgstatus; > > __u64 ip; > > __u64 tsc; > > __u64 time; > > __u8 cpuvendor; > > __u8 inject_flags; > > __u16 pad; > > __u32 cpuid; > > __u8 cs; > > __u8 bank; > > __u8 cpu; > > __u8 finished; > > __u32 extcpu; > > __u32 socketid; > > __u32 apicid; > > __u64 mcgcap; > > } > > SIZE: 88 > > crash> > > > > Dave > > > > > If you think that this complicates the patch, I'll start with a > > > much > > > 'slimmer' version (!) of the slimdump and the improvements may be > > > contemplated iteratively. > > > > > > Thanks, > > > K.Prasad _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2011-06-01 17:41 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-05-26 17:07 [RFC Patch 0/6] slimdump: Enable slimdump if crashing kernel memory is not required K.Prasad 2011-05-26 17:07 ` K.Prasad 2011-05-26 17:12 ` [Patch 1/6] XPANIC: Add extended panic interface K.Prasad 2011-05-26 17:12 ` K.Prasad 2011-05-26 17:38 ` richard -rw- weinberger 2011-05-26 17:38 ` richard -rw- weinberger 2011-05-27 15:56 ` K.Prasad 2011-05-27 15:56 ` K.Prasad 2011-05-27 17:59 ` Eric W. Biederman 2011-05-27 17:59 ` Eric W. Biederman 2011-05-26 17:12 ` [Patch 2/6] x86: mce: Convert mce code to xpanic K.Prasad 2011-05-26 17:12 ` K.Prasad 2011-05-27 18:01 ` Eric W. Biederman 2011-05-27 18:01 ` Eric W. Biederman 2011-05-26 17:14 ` [Bugfix][Patch 3/3] Invoke vpanic inside xpanic function K.Prasad 2011-05-26 17:14 ` K.Prasad 2011-05-26 17:15 ` [RFC Patch 4/6] PANIC_MCE: Introduce a new panic flag for fatal MCE, capture related information K.Prasad 2011-05-26 17:15 ` K.Prasad 2011-05-26 18:43 ` Vivek Goyal 2011-05-26 18:43 ` Vivek Goyal 2011-05-27 17:03 ` K.Prasad 2011-05-27 17:03 ` K.Prasad 2011-05-27 18:29 ` Vivek Goyal 2011-05-27 18:29 ` Vivek Goyal 2011-05-27 18:04 ` Eric W. Biederman 2011-05-27 18:04 ` Eric W. Biederman 2011-05-31 17:40 ` K.Prasad 2011-05-31 17:40 ` K.Prasad 2011-06-01 17:18 ` Dave Anderson 2011-06-01 17:18 ` Dave Anderson 2011-06-01 17:23 ` Vivek Goyal 2011-06-01 17:23 ` Vivek Goyal 2011-06-01 17:41 ` Dave Anderson [this message] 2011-06-01 17:41 ` Dave Anderson 2011-06-08 17:16 ` K.Prasad 2011-06-08 17:16 ` K.Prasad 2011-06-12 15:44 ` Eric W. Biederman 2011-06-12 15:44 ` Eric W. Biederman 2011-06-15 2:06 ` K.Prasad 2011-06-15 2:06 ` K.Prasad 2011-05-27 18:09 ` Eric W. Biederman 2011-05-27 18:09 ` Eric W. Biederman 2011-05-26 17:23 ` [RFC Patch 5/6] slimdump: Capture slimdump for fatal MCE generated crashes K.Prasad 2011-05-26 17:23 ` K.Prasad 2011-05-26 17:32 ` Andi Kleen 2011-05-26 17:32 ` Andi Kleen 2011-05-27 15:53 ` K.Prasad 2011-05-27 15:53 ` K.Prasad 2011-05-26 17:44 ` Vivek Goyal 2011-05-26 17:44 ` Vivek Goyal 2011-05-26 18:09 ` Andi Kleen 2011-05-26 18:09 ` Andi Kleen 2011-05-26 18:26 ` Vivek Goyal 2011-05-26 18:26 ` Vivek Goyal 2011-05-26 18:58 ` Andi Kleen 2011-05-26 18:58 ` Andi Kleen 2011-05-26 19:10 ` Vivek Goyal 2011-05-26 19:10 ` Vivek Goyal 2011-05-26 23:44 ` Simon Horman 2011-05-26 23:44 ` Simon Horman 2011-05-27 16:57 ` K.Prasad 2011-05-27 16:57 ` K.Prasad 2011-05-27 17:59 ` Vivek Goyal 2011-05-27 17:59 ` Vivek Goyal 2011-06-08 17:00 ` K.Prasad 2011-06-08 17:00 ` K.Prasad 2011-05-27 18:14 ` Eric W. Biederman 2011-05-27 18:14 ` Eric W. Biederman 2011-05-26 17:26 ` [RFC Patch 6/6] Crash: Recognise slim coredumps and process new elf-note sections K.Prasad 2011-05-26 17:26 ` K.Prasad 2011-05-27 15:37 ` Mahesh J Salgaonkar 2011-05-27 15:37 ` Mahesh J Salgaonkar 2011-05-27 18:16 ` Eric W. Biederman 2011-05-27 18:16 ` Eric W. Biederman 2011-05-27 18:22 ` Vivek Goyal 2011-05-27 18:22 ` Vivek Goyal 2011-05-27 18:35 ` Eric W. Biederman 2011-05-27 18:35 ` Eric W. Biederman 2011-05-26 17:31 ` [RFC Patch 0/6] slimdump: Enable slimdump if crashing kernel memory is not required K.Prasad 2011-05-26 17:31 ` K.Prasad
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=292370127.12181.1306950094350.JavaMail.root@zmail05.collab.prod.int.phx2.redhat.com \ --to=anderson@redhat.com \ --cc=andi@firstfloor.org \ --cc=ebiederm@xmission.com \ --cc=kexec@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=prasad@linux.vnet.ibm.com \ --cc=tony.luck@intel.com \ --cc=vgoyal@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.