* [PATCH v3 13/13] rust: sync: add functions for initializing `UniqueArc<MaybeUninit<T>>`
@ 2023-03-29 22:33 y86-dev
2023-03-30 11:09 ` Gary Guo
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: y86-dev @ 2023-03-29 22:33 UTC (permalink / raw)
To: Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho, Boqun Feng,
Gary Guo, Björn Roy Baron, Alice Ryhl
Cc: rust-for-linux, linux-kernel, patches
From: Benno Lossin <y86-dev@protonmail.com>
Add two functions `init_with` and `pin_init_with` to
`UniqueArc<MaybeUninit<T>>` to initialize the memory of already allocated
`UniqueArc`s. This is useful when you want to allocate memory check some
condition inside of a context where allocation is forbidden and then
conditionally initialize an object.
Signed-off-by: Benno Lossin <y86-dev@protonmail.com>
---
rust/kernel/sync/arc.rs | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs
index 4ed6329a5e5f..64b0e9d67025 100644
--- a/rust/kernel/sync/arc.rs
+++ b/rust/kernel/sync/arc.rs
@@ -540,6 +540,30 @@ impl<T> UniqueArc<MaybeUninit<T>> {
inner: unsafe { Arc::from_inner(inner.cast()) },
}
}
+
+ /// Initialize `self` using the given initializer.
+ pub fn init_with<E>(mut self, init: impl Init<T, E>) -> core::result::Result<UniqueArc<T>, E> {
+ // SAFETY: The supplied pointer is valid for initialization.
+ match unsafe { init.__init(self.as_mut_ptr()) } {
+ // SAFETY: Initialization completed successfully.
+ Ok(()) => Ok(unsafe { self.assume_init() }),
+ Err(err) => Err(err),
+ }
+ }
+
+ /// Pin-initialize `self` using the given pin-initializer.
+ pub fn pin_init_with<E>(
+ mut self,
+ init: impl PinInit<T, E>,
+ ) -> core::result::Result<Pin<UniqueArc<T>>, E> {
+ // SAFETY: The supplied pointer is valid for initialization and we will later pin the value
+ // to ensure it does not move.
+ match unsafe { init.__pinned_init(self.as_mut_ptr()) } {
+ // SAFETY: Initialization completed successfully.
+ Ok(()) => Ok(unsafe { self.assume_init() }.into()),
+ Err(err) => Err(err),
+ }
+ }
}
impl<T: ?Sized> From<UniqueArc<T>> for Pin<UniqueArc<T>> {
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3 13/13] rust: sync: add functions for initializing `UniqueArc<MaybeUninit<T>>`
2023-03-29 22:33 [PATCH v3 13/13] rust: sync: add functions for initializing `UniqueArc<MaybeUninit<T>>` y86-dev
@ 2023-03-30 11:09 ` Gary Guo
2023-03-31 7:07 ` Alice Ryhl
2023-03-31 13:07 ` Andreas Hindborg
2 siblings, 0 replies; 4+ messages in thread
From: Gary Guo @ 2023-03-30 11:09 UTC (permalink / raw)
To: y86-dev
Cc: Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho, Boqun Feng,
Björn Roy Baron, Alice Ryhl, rust-for-linux, linux-kernel,
patches
On Wed, 29 Mar 2023 22:33:53 +0000
y86-dev@protonmail.com wrote:
> From: Benno Lossin <y86-dev@protonmail.com>
>
> Add two functions `init_with` and `pin_init_with` to
> `UniqueArc<MaybeUninit<T>>` to initialize the memory of already allocated
> `UniqueArc`s. This is useful when you want to allocate memory check some
> condition inside of a context where allocation is forbidden and then
> conditionally initialize an object.
>
> Signed-off-by: Benno Lossin <y86-dev@protonmail.com>
Reviewed-by: Gary Guo <gary@garyguo.net>
> ---
> rust/kernel/sync/arc.rs | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs
> index 4ed6329a5e5f..64b0e9d67025 100644
> --- a/rust/kernel/sync/arc.rs
> +++ b/rust/kernel/sync/arc.rs
> @@ -540,6 +540,30 @@ impl<T> UniqueArc<MaybeUninit<T>> {
> inner: unsafe { Arc::from_inner(inner.cast()) },
> }
> }
> +
> + /// Initialize `self` using the given initializer.
> + pub fn init_with<E>(mut self, init: impl Init<T, E>) -> core::result::Result<UniqueArc<T>, E> {
> + // SAFETY: The supplied pointer is valid for initialization.
> + match unsafe { init.__init(self.as_mut_ptr()) } {
> + // SAFETY: Initialization completed successfully.
> + Ok(()) => Ok(unsafe { self.assume_init() }),
> + Err(err) => Err(err),
> + }
> + }
> +
> + /// Pin-initialize `self` using the given pin-initializer.
> + pub fn pin_init_with<E>(
> + mut self,
> + init: impl PinInit<T, E>,
> + ) -> core::result::Result<Pin<UniqueArc<T>>, E> {
> + // SAFETY: The supplied pointer is valid for initialization and we will later pin the value
> + // to ensure it does not move.
> + match unsafe { init.__pinned_init(self.as_mut_ptr()) } {
> + // SAFETY: Initialization completed successfully.
> + Ok(()) => Ok(unsafe { self.assume_init() }.into()),
> + Err(err) => Err(err),
> + }
> + }
> }
>
> impl<T: ?Sized> From<UniqueArc<T>> for Pin<UniqueArc<T>> {
> --
> 2.39.2
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 13/13] rust: sync: add functions for initializing `UniqueArc<MaybeUninit<T>>`
2023-03-29 22:33 [PATCH v3 13/13] rust: sync: add functions for initializing `UniqueArc<MaybeUninit<T>>` y86-dev
2023-03-30 11:09 ` Gary Guo
@ 2023-03-31 7:07 ` Alice Ryhl
2023-03-31 13:07 ` Andreas Hindborg
2 siblings, 0 replies; 4+ messages in thread
From: Alice Ryhl @ 2023-03-31 7:07 UTC (permalink / raw)
To: y86-dev
Cc: rust-for-linux, linux-kernel, patches, Miguel Ojeda, Alex Gaynor,
Wedson Almeida Filho, Boqun Feng, Gary Guo, Björn Roy Baron
On 3/30/23 00:33, y86-dev@protonmail.com wrote:
> From: Benno Lossin <y86-dev@protonmail.com>
>
> Add two functions `init_with` and `pin_init_with` to
> `UniqueArc<MaybeUninit<T>>` to initialize the memory of already allocated
> `UniqueArc`s. This is useful when you want to allocate memory check some
> condition inside of a context where allocation is forbidden and then
> conditionally initialize an object.
>
> Signed-off-by: Benno Lossin <y86-dev@protonmail.com>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
I asked for this one because we will need it in the binder driver.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3 13/13] rust: sync: add functions for initializing `UniqueArc<MaybeUninit<T>>`
2023-03-29 22:33 [PATCH v3 13/13] rust: sync: add functions for initializing `UniqueArc<MaybeUninit<T>>` y86-dev
2023-03-30 11:09 ` Gary Guo
2023-03-31 7:07 ` Alice Ryhl
@ 2023-03-31 13:07 ` Andreas Hindborg
2 siblings, 0 replies; 4+ messages in thread
From: Andreas Hindborg @ 2023-03-31 13:07 UTC (permalink / raw)
To: y86-dev
Cc: Miguel Ojeda, Alex Gaynor, Wedson Almeida Filho, Boqun Feng,
Gary Guo, Björn Roy Baron, Alice Ryhl, rust-for-linux,
linux-kernel, patches, Andreas Hindborg
y86-dev@protonmail.com writes:
> From: Benno Lossin <y86-dev@protonmail.com>
>
> Add two functions `init_with` and `pin_init_with` to
> `UniqueArc<MaybeUninit<T>>` to initialize the memory of already allocated
> `UniqueArc`s. This is useful when you want to allocate memory check some
> condition inside of a context where allocation is forbidden and then
> conditionally initialize an object.
>
> Signed-off-by: Benno Lossin <y86-dev@protonmail.com>
> ---
Reviewed-by: Andreas Hindborg <a.hindborg@samsung.com>
> rust/kernel/sync/arc.rs | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs
> index 4ed6329a5e5f..64b0e9d67025 100644
> --- a/rust/kernel/sync/arc.rs
> +++ b/rust/kernel/sync/arc.rs
> @@ -540,6 +540,30 @@ impl<T> UniqueArc<MaybeUninit<T>> {
> inner: unsafe { Arc::from_inner(inner.cast()) },
> }
> }
> +
> + /// Initialize `self` using the given initializer.
> + pub fn init_with<E>(mut self, init: impl Init<T, E>) -> core::result::Result<UniqueArc<T>, E> {
> + // SAFETY: The supplied pointer is valid for initialization.
> + match unsafe { init.__init(self.as_mut_ptr()) } {
> + // SAFETY: Initialization completed successfully.
> + Ok(()) => Ok(unsafe { self.assume_init() }),
> + Err(err) => Err(err),
> + }
> + }
> +
> + /// Pin-initialize `self` using the given pin-initializer.
> + pub fn pin_init_with<E>(
> + mut self,
> + init: impl PinInit<T, E>,
> + ) -> core::result::Result<Pin<UniqueArc<T>>, E> {
> + // SAFETY: The supplied pointer is valid for initialization and we will later pin the value
> + // to ensure it does not move.
> + match unsafe { init.__pinned_init(self.as_mut_ptr()) } {
> + // SAFETY: Initialization completed successfully.
> + Ok(()) => Ok(unsafe { self.assume_init() }.into()),
> + Err(err) => Err(err),
> + }
> + }
> }
>
> impl<T: ?Sized> From<UniqueArc<T>> for Pin<UniqueArc<T>> {
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-31 13:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-29 22:33 [PATCH v3 13/13] rust: sync: add functions for initializing `UniqueArc<MaybeUninit<T>>` y86-dev
2023-03-30 11:09 ` Gary Guo
2023-03-31 7:07 ` Alice Ryhl
2023-03-31 13:07 ` Andreas Hindborg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.