All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 3/5] rxrpc: mention that client key payloads are not arbitrary
@ 2018-09-27 13:14 Ben Boeckel
  2018-09-27 17:12 ` David Howells
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Boeckel @ 2018-09-27 13:14 UTC (permalink / raw)
  To: keyrings

Signed-off-by: Ben Boeckel <mathstuf@gmail.com>
---
 net/rxrpc/key.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/rxrpc/key.c b/net/rxrpc/key.c
index e7f6b8823eb6..51fb50541397 100644
--- a/net/rxrpc/key.c
+++ b/net/rxrpc/key.c
@@ -38,8 +38,8 @@ static void rxrpc_describe(const struct key *, struct seq_file *);
 static long rxrpc_read(const struct key *, char __user *, size_t);
 
 /*
- * rxrpc defined keys take an arbitrary string as the description and an
- * arbitrary blob of data as the payload
+ * rxrpc defined keys take an arbitrary string as the description. See
+ * rxrpc_preparse for the payload format.
  */
 struct key_type key_type_rxrpc = {
 	.name		= "rxrpc",
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 3/5] rxrpc: mention that client key payloads are not arbitrary
  2018-09-27 13:14 [PATCH 3/5] rxrpc: mention that client key payloads are not arbitrary Ben Boeckel
@ 2018-09-27 17:12 ` David Howells
  0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2018-09-27 17:12 UTC (permalink / raw)
  To: keyrings

Ben Boeckel <mathstuf@gmail.com> wrote:

> - * rxrpc defined keys take an arbitrary string as the description and an
> - * arbitrary blob of data as the payload
> + * rxrpc defined keys take an arbitrary string as the description. See
> + * rxrpc_preparse for the payload format.

I think this change is unnecessary.  Someone who knows what they're looking at
should know that.  Better would be to describe it in Documentation somewhere.
Might be worth just deleting that particular comment entirely.

David

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-09-27 17:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-27 13:14 [PATCH 3/5] rxrpc: mention that client key payloads are not arbitrary Ben Boeckel
2018-09-27 17:12 ` David Howells

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.