Re: pvops-dom0 console freezes after latest ballooning patch (+possible fix)

Re: pvops-dom0 console freezes after latest ballooning patch (+possible fix)

[Ronny.Hegewald]

>On 12/09/09 11:22, Ronny.Hegewald@online.de wrote:
>> Setup: xen 3.4.1, 32-bit linux dom0 2.6.31.6 from pvops-git tree from 
>> 2009-12-03
>>
>>
>> Since the latest ballooning patch "Add hugepage support to balloon 
>> driver 
>> 
><http://git.kernel.org/?p=linux/kernel/git/jeremy/xen.git;a=commit;h=0e898d5e9b
>893324435e0e77b67fe8d2f0523dbe>" 
>> i experience dom0 console freezes. Additional to that there is a 
>> stacktrace about a kernel-bug in drivers/xen/balloon.c in line 346, 
>> invalide opcode 0000 (i can send the full stacktrace if someone is 
>> interested).
>>
>
>Yes, please.  Presumably its from the BUG_ON testing the hypercall 
>return status?

Attached the stacktrace.

Re: pvops-dom0 console freezes after latest ballooning patch (+possible fix)

[Ronny.Hegewald]

>On 12/09/09 12:55, Ronny.Hegewald@online.de wrote:
>>> On 12/09/09 11:22, Ronny.Hegewald@online.de wrote:
>>>      
>>>> Setup: xen 3.4.1, 32-bit linux dom0 2.6.31.6 from pvops-git tree from
>>>> 2009-12-03
>>>>
>>>>
>>>> Since the latest ballooning patch "Add hugepage support to balloon
>>>> driver
>>>>
>>>>        

>Thanks.
>
>BTW, it looks like I hadn't merged the hugepage into xen/master until 
>now.  Did you merge it yourself?  Or trying something else?
>
>     J
>

No, i used a unpatched xen/master.

That hugepage patch got merged into xen/master on 2009-11-06 (commit   c38510904c76f910610a6e790aab594cfa5c7a2c) through xen/dom0/backend/core that was merged with xen/balloon before.

Re: pvops-dom0 console freezes after latest ballooning patch (+possible fix)

[Jeremy Fitzhardinge]

On 12/09/09 12:55, Ronny.Hegewald@online.de wrote:
>> On 12/09/09 11:22, Ronny.Hegewald@online.de wrote:
>>      
>>> Setup: xen 3.4.1, 32-bit linux dom0 2.6.31.6 from pvops-git tree from
>>> 2009-12-03
>>>
>>>
>>> Since the latest ballooning patch "Add hugepage support to balloon
>>> driver
>>>
>>>        
>> <http://git.kernel.org/?p=linux/kernel/git/jeremy/xen.git;a=commit;h=0e898d5e9b
>> 893324435e0e77b67fe8d2f0523dbe>"
>>      
>>> i experience dom0 console freezes. Additional to that there is a
>>> stacktrace about a kernel-bug in drivers/xen/balloon.c in line 346,
>>> invalide opcode 0000 (i can send the full stacktrace if someone is
>>> interested).
>>>
>>>        
>> Yes, please.  Presumably its from the BUG_ON testing the hypercall
>> return status?
>>
>>      
> This time really with the attachment ...

Thanks.

BTW, it looks like I hadn't merged the hugepage into xen/master until 
now.  Did you merge it yourself?  Or trying something else?

     J

Re: pvops-dom0 console freezes after latest ballooning patch (+possible fix)

[Ronny.Hegewald]

[-- Attachment #1: Type: text/plain, Size: 709 bytes --]

>On 12/09/09 11:22, Ronny.Hegewald@online.de wrote:
>> Setup: xen 3.4.1, 32-bit linux dom0 2.6.31.6 from pvops-git tree from 
>> 2009-12-03
>>
>>
>> Since the latest ballooning patch "Add hugepage support to balloon 
>> driver 
>> 
><http://git.kernel.org/?p=linux/kernel/git/jeremy/xen.git;a=commit;h=0e898d5e9b
>893324435e0e77b67fe8d2f0523dbe>" 
>> i experience dom0 console freezes. Additional to that there is a 
>> stacktrace about a kernel-bug in drivers/xen/balloon.c in line 346, 
>> invalide opcode 0000 (i can send the full stacktrace if someone is 
>> interested).
>>
>
>Yes, please.  Presumably its from the BUG_ON testing the hypercall 
>return status?
>

This time really with the attachment ...

[-- Attachment #2: balloon-stacktrace.log --]
[-- Type: application/octet-stream, Size: 2128 bytes --]

------------[ cut here ]------------
kernel BUG at drivers/xen/balloon.c:346!
invalid opcode: 0000 [#1] SMP 
last sysfs file: /sys/devices/system/xen_memory/xen_memory0/info/current_kb
Modules linked in: iptable_filter ip_tables x_tables bridge stp llc ipv6 r8169 bitrev crc32 mii thermal nfs lockd sunrpc snd_hwdep snd_pcm_oss snd_mixer_oss snd_seq_oss snd_seq_midi_event snd_seq snd_via82xx snd_ac97_codec ac97_bus snd_pcm snd_timer snd_page_alloc snd_mpu401_uart snd_rawmidi snd_seq_device snd soundcore dm_mod netbk blkbk evtchn xenfs sata_via libata sg sd_mod via82cxxx ide_gd_mod ide_core ext3 jbd ext2 af_packet loop unix

Pid: 5, comm: events/0 Tainted: G        W  (2.6.31.6-xen-pvops #2) MS-7094
EIP: 0061:[<c1148b58>] EFLAGS: 00010082 CPU: 0
EIP is at decrease_reservation+0x2a8/0x2b0
EAX: ffffffea EBX: f8f8e000 ECX: 00000000 EDX: 00000000
ESI: 00000000 EDI: f7049efc EBP: f7049f14 ESP: f7049ebc
 DS: 007b ES: 007b FS: 00d8 GS: 0000 SS: 0069
Process events/0 (pid: 5, ti=f7048000 task=f7033b20 task.ti=f7048000)
Stack:
 00000000 f8f8e000 00000000 00000000 c268af80 c1340220 00000000 00000000
<0> 00005d8e 00038f8e 00000300 00000000 00000000 00000000 00000000 00007ff0
<0> c1d38200 f7049f20 f7049f14 fffffd00 00000000 c12d03cc f7049f24 c1148c0a
Call Trace:
 [<c1148c0a>] ? balloon_process+0xaa/0xc0
 [<c104676d>] ? run_workqueue+0x5d/0xf0
 [<c1006877>] ? xen_restore_fl_direct_end+0x0/0x1
 [<c1212c77>] ? _spin_unlock_irqrestore+0x17/0x20
 [<c1148b60>] ? balloon_process+0x0/0xc0
 [<c1046899>] ? worker_thread+0x99/0xf0
 [<c104a570>] ? autoremove_wake_function+0x0/0x50
 [<c121109c>] ? schedule+0x21c/0x3d0
 [<c104a570>] ? autoremove_wake_function+0x0/0x50
 [<c1030d86>] ? complete+0x46/0x60
 [<c1049fad>] ? kthread+0x7d/0x90
 [<c1046800>] ? worker_thread+0x0/0xf0
 [<c1049f30>] ? kthread+0x0/0x90
 [<c100aff7>] ? kernel_thread_helper+0x7/0x10
Code: c4 4c 5b 5e 5f 5d c3 e8 87 ae eb ff 89 c2 81 e2 ff ff ff 7f e9 f3 fd ff ff c7 45 b4 01 00 00 00 8b 55 c4 89 55 d0 e9 f6 fd ff ff <0f> 0b eb fe 0f 0b eb fe 55 b8 b0 03 2d c1 89 e5 56 31 f6 53 e8 
EIP: [<c1148b58>] decrease_reservation+0x2a8/0x2b0 SS:ESP 0069:f7049ebc

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: pvops-dom0 console freezes after latest ballooning patch (+possible fix)

[Jeremy Fitzhardinge]

On 12/09/09 12:20, Dave McCracken wrote:
> Yes, absolutely.  It's the correct fix.  Good catch.
>    

OK, I'll add an acked-by for you.

Ronny, thanks for the patch and the good description of the bug it fixes 
and how; together they're almost a perfect patch.  I added a 
Signed-off-by: line for you.

     J

Re: pvops-dom0 console freezes after latest ballooning patch (+possible fix)

[Dave McCracken]

On Wednesday 09 December 2009, Jeremy Fitzhardinge wrote:
> On 12/09/09 11:22, Ronny.Hegewald@online.de wrote:
> > Setup: xen 3.4.1, 32-bit linux dom0 2.6.31.6 from pvops-git tree from
> > 2009-12-03
> >
> >
> > Since the latest ballooning patch "Add hugepage support to balloon
> > driver
> > <http://git.kernel.org/?p=linux/kernel/git/jeremy/xen.git;a=commit;h=0e89
> >8d5e9b893324435e0e77b67fe8d2f0523dbe>" i experience dom0 console freezes.
> > Additional to that there is a stacktrace about a kernel-bug in
> > drivers/xen/balloon.c in line 346, invalide opcode 0000 (i can send the
> > full stacktrace if someone is interested).
> 
> Yes, please.  Presumably its from the BUG_ON testing the hypercall
> return status?
> 
> > The cause for that seems to be that in the
> > decrease_reservation-funtion the PageHighMem - check is not executed
> > on the assocciated page for the current pfn. Its always the last page
> > that got allocated in the for-loop before, when all the pages are
> > allocated.
> >
> > With the attached patch that crashes dont occur anymore. But im not a
> > kernel-developer so im not sure that this is the correct fix.
> 
> It looks reasonable to me.  Dave?
> 
>      J

Yes, absolutely.  It's the correct fix.  Good catch.

Dave McCracken
Oracle Corp.

Re: pvops-dom0 console freezes after latest ballooning patch (+possible fix)

[Jeremy Fitzhardinge]

On 12/09/09 11:22, Ronny.Hegewald@online.de wrote:
> Setup: xen 3.4.1, 32-bit linux dom0 2.6.31.6 from pvops-git tree from 
> 2009-12-03
>
>
> Since the latest ballooning patch "Add hugepage support to balloon 
> driver 
> <http://git.kernel.org/?p=linux/kernel/git/jeremy/xen.git;a=commit;h=0e898d5e9b893324435e0e77b67fe8d2f0523dbe>" 
> i experience dom0 console freezes. Additional to that there is a 
> stacktrace about a kernel-bug in drivers/xen/balloon.c in line 346, 
> invalide opcode 0000 (i can send the full stacktrace if someone is 
> interested).
>

Yes, please.  Presumably its from the BUG_ON testing the hypercall 
return status?


> The cause for that seems to be that in the 
> decrease_reservation-funtion the PageHighMem - check is not executed 
> on the assocciated page for the current pfn. Its always the last page 
> that got allocated in the for-loop before, when all the pages are 
> allocated.
>
> With the attached patch that crashes dont occur anymore. But im not a 
> kernel-developer so im not sure that this is the correct fix.

It looks reasonable to me.  Dave?

     J

pvops-dom0 console freezes after latest ballooning patch (+possible fix)

[Ronny.Hegewald]

[-- Attachment #1: Type: text/html, Size: 2238 bytes --]

[-- Attachment #2: balloon.patch --]
[-- Type: application/octet-stream, Size: 396 bytes --]

--- drivers/xen/balloon.c.org	2009-12-06 02:24:08.000000000 +0100
+++ drivers/xen/balloon.c	2009-12-09 21:56:17.000000000 +0100
@@ -339,6 +339,8 @@
 				discontig_free = 1;
 
 			set_phys_to_machine(lpfn, INVALID_P2M_ENTRY);
+                        page = pfn_to_page(lpfn);
+
 			if (!PageHighMem(page)) {
 				ret = HYPERVISOR_update_va_mapping(
 					(unsigned long)__va(lpfn << PAGE_SHIFT),

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel