From: David Howells <dhowells@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "Schofield, Alison <alison.schofield@intel.com>,
Kees Cook <keescook@chromium.org>,
linux-nvdimm" <linux-nvdimm@lists.01.org>,
Eric Biggers <ebiggers3@gmail.com>,
dhowells@redhat.com, keyrings@vger.kernel.org
Subject: Re: [PATCH v8 02/12] libnvdimm: create keyring to store security keys
Date: Mon, 24 Sep 2018 22:04:47 +0100 [thread overview]
Message-ID: <29624.1537823087@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAPcyv4j02Ts5J8CFHFVVioBYjHwr7cbsqrz3yTCm4Yoxf1CTOg@mail.gmail.com>
Dan Williams <dan.j.williams@intel.com> wrote:
> I think you want to use prepare_kernel_cred(), not export init_cred.
That only works if the searching is done with the creds generated by
prepare_kernel_cred(). He probably does want init_cred, or at least
current_cred() if module loading overrides the creds with init_cred whilst
initialising the module.
David
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: David Howells <dhowells@redhat.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "Schofield, Alison <alison.schofield@intel.com>,
Kees Cook <keescook@chromium.org>,
linux-nvdimm" <linux-nvdimm@lists.01.org>,
Eric Biggers <ebiggers3@gmail.com>,
dhowells@redhat.com, keyrings@vger.kernel.org
Subject: Re: [PATCH v8 02/12] libnvdimm: create keyring to store security keys
Date: Mon, 24 Sep 2018 21:04:47 +0000 [thread overview]
Message-ID: <29624.1537823087@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAPcyv4j02Ts5J8CFHFVVioBYjHwr7cbsqrz3yTCm4Yoxf1CTOg@mail.gmail.com>
Dan Williams <dan.j.williams@intel.com> wrote:
> I think you want to use prepare_kernel_cred(), not export init_cred.
That only works if the searching is done with the creds generated by
prepare_kernel_cred(). He probably does want init_cred, or at least
current_cred() if module loading overrides the creds with init_cred whilst
initialising the module.
David
next prev parent reply other threads:[~2018-09-24 21:04 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 22:47 [PATCH v8 00/12] Adding security support for nvdimm Dave Jiang
2018-08-28 22:47 ` Dave Jiang
2018-08-28 22:47 ` [PATCH v8 01/12] nfit: add support for Intel DSM 1.7 commands Dave Jiang
2018-08-28 22:47 ` Dave Jiang
2018-08-28 22:47 ` [PATCH v8 02/12] libnvdimm: create keyring to store security keys Dave Jiang
2018-08-28 22:47 ` Dave Jiang
2018-09-22 0:19 ` Dan Williams
2018-09-22 0:19 ` Dan Williams
2018-09-24 21:04 ` David Howells [this message]
2018-09-24 21:04 ` David Howells
2018-09-24 21:12 ` Dave Jiang
2018-09-24 21:12 ` Dave Jiang
2018-08-28 22:47 ` [PATCH v8 03/12] nfit/libnvdimm: store dimm id as a member to struct nvdimm Dave Jiang
2018-08-28 22:47 ` Dave Jiang
2018-08-28 22:47 ` [PATCH v8 04/12] keys: export lookup_user_key to external users Dave Jiang
2018-08-28 22:47 ` Dave Jiang
2018-09-21 21:59 ` Dan Williams
2018-09-21 21:59 ` Dan Williams
2018-09-21 22:02 ` Dave Jiang
2018-09-21 22:02 ` Dave Jiang
2018-09-21 23:05 ` David Howells
2018-09-21 23:05 ` David Howells
2018-08-28 22:47 ` [PATCH v8 05/12] nfit/libnvdimm: add unlock of nvdimm support for Intel DIMMs Dave Jiang
2018-08-28 22:47 ` Dave Jiang
2018-09-23 0:10 ` Dan Williams
2018-09-23 0:10 ` Dan Williams
2018-08-28 22:47 ` [PATCH v8 06/12] nfit/libnvdimm: add set passphrase support for Intel nvdimms Dave Jiang
2018-08-28 22:47 ` [PATCH v8 07/12] nfit/libnvdimm: add disable passphrase support to Intel nvdimm Dave Jiang
2018-08-28 22:47 ` Dave Jiang
2018-08-28 22:48 ` [PATCH v8 08/12] nfit/libnvdimm: add freeze security " Dave Jiang
2018-08-28 22:48 ` Dave Jiang
2018-08-28 22:48 ` [PATCH v8 09/12] nfit/libnvdimm: add support for issue secure erase DSM " Dave Jiang
2018-08-28 22:48 ` Dave Jiang
2018-08-28 22:48 ` [PATCH v8 10/12] nfit_test: add context to dimm_dev for nfit_test Dave Jiang
2018-08-28 22:48 ` Dave Jiang
2018-08-28 22:48 ` [PATCH v8 11/12] nfit_test: add test support for Intel nvdimm security DSMs Dave Jiang
2018-08-28 22:48 ` Dave Jiang
2018-08-28 22:48 ` [PATCH v8 12/12] libnvdimm: add documentation for nvdimm security support Dave Jiang
2018-08-28 22:48 ` Dave Jiang
2018-09-21 23:07 ` [PATCH v8 02/12] libnvdimm: create keyring to store security keys David Howells
2018-09-21 23:07 ` David Howells
2018-09-21 23:20 ` [PATCH v8 05/12] nfit/libnvdimm: add unlock of nvdimm support for Intel DIMMs David Howells
2018-09-21 23:20 ` David Howells
2018-09-21 23:27 ` Dave Jiang
2018-09-21 23:27 ` Dave Jiang
2018-09-21 23:51 ` Dan Williams
2018-09-21 23:51 ` Dan Williams
2018-09-21 23:57 ` [PATCH v8 06/12] nfit/libnvdimm: add set passphrase support for Intel nvdimms David Howells
2018-09-21 23:57 ` David Howells
2018-09-22 0:25 ` Dave Jiang
2018-09-22 0:25 ` Dave Jiang
2018-09-22 1:26 ` Dan Williams
2018-09-22 1:26 ` Dan Williams
2018-09-22 0:01 ` [PATCH v8 04/12] keys: export lookup_user_key to external users David Howells
2018-09-22 0:01 ` David Howells
2018-09-24 21:02 ` [PATCH v8 02/12] libnvdimm: create keyring to store security keys David Howells
2018-09-24 21:02 ` David Howells
2018-09-24 21:15 ` Dave Jiang
2018-09-24 21:15 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29624.1537823087@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=ebiggers3@gmail.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.