* [PATCH] x86/NMI: invert condition in nmi_show_execution_state()
@ 2018-02-06 10:41 Jan Beulich
2018-02-06 10:42 ` Andrew Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2018-02-06 10:41 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper
We want to decode the symbol when _not_ in guest mode.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/traps.c
+++ b/xen/arch/x86/traps.c
@@ -632,7 +632,7 @@ static int nmi_show_execution_state(cons
show_execution_state(regs);
else
printk(XENLOG_ERR "CPU%d @ %04x:%08lx (%pS)\n", cpu, regs->cs,
- regs->rip, guest_mode(regs) ? _p(regs->rip) : NULL);
+ regs->rip, guest_mode(regs) ? NULL : _p(regs->rip));
cpumask_clear_cpu(cpu, &show_state_mask);
return 1;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/NMI: invert condition in nmi_show_execution_state()
2018-02-06 10:41 [PATCH] x86/NMI: invert condition in nmi_show_execution_state() Jan Beulich
@ 2018-02-06 10:42 ` Andrew Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cooper @ 2018-02-06 10:42 UTC (permalink / raw)
To: Jan Beulich, xen-devel
On 06/02/18 10:41, Jan Beulich wrote:
> We want to decode the symbol when _not_ in guest mode.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Nice. Figuring out why this wasn't working was on my todo list.
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/arch/x86/traps.c
> +++ b/xen/arch/x86/traps.c
> @@ -632,7 +632,7 @@ static int nmi_show_execution_state(cons
> show_execution_state(regs);
> else
> printk(XENLOG_ERR "CPU%d @ %04x:%08lx (%pS)\n", cpu, regs->cs,
> - regs->rip, guest_mode(regs) ? _p(regs->rip) : NULL);
> + regs->rip, guest_mode(regs) ? NULL : _p(regs->rip));
> cpumask_clear_cpu(cpu, &show_state_mask);
>
> return 1;
>
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-06 10:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-06 10:41 [PATCH] x86/NMI: invert condition in nmi_show_execution_state() Jan Beulich
2018-02-06 10:42 ` Andrew Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.