All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Björn Gerhart" <oss@extracloud.de>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (it87) Add support for  IT8781F, IT8782F, IT8783E/F
Date: Tue, 27 Mar 2012 19:21:35 +0000	[thread overview]
Message-ID: <296C0394-16BB-426F-B13B-1A924A7BBDE5@extracloud.de> (raw)
In-Reply-To: <6.2.5.6.2.20120324091434.02773d68@roeck-us.net>

Hi Jean,

Am 26.03.2012 um 19:01 schrieb Jean Delvare:
> [..]
>> If actually it is the job of the module to do such calculations, I would offer to create an it87 patch for IT8783 fixing this - analog to an existing module with a similar behavior (if you know one).
> 
> You assume that the PECI value always refers to the CPU. I do not think
> this is true, other parts (e.g. north bridge) could report their
> temperature through PECI as well.
> 
> And if it is the CPU temperature, we already have the coretemp driver
> providing the same information, so there's little point in implementing
> the same in it87. The only benefit of handling PECI sensors in it87 and
> the like would be so that they can be used as sources for automatic fan
> speed control, but if the chip itself has no idea about the absolute
> value of the temperature then I doubt it can use it for automatic fan
> speed control.
> 
Yes, with the coretemp driver even both core temperatures are displayed correctly. So I agree, it's nonsense to implement our special design into the generic driver  ;-)

Björn


_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2012-03-27 19:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-24 16:23 [lm-sensors] [PATCH] hwmon: (it87) Add support for IT8781F, IT8782F, IT8783E/F Guenter Roeck
2012-03-24 18:07 ` Guenter Roeck
2012-03-26 16:08 ` Björn Gerhart
2012-03-26 17:01 ` Jean Delvare
2012-03-26 17:38 ` Guenter Roeck
2012-03-26 19:05 ` Guenter Roeck
2012-03-27 19:12 ` Björn Gerhart
2012-03-27 19:21 ` Björn Gerhart [this message]
2012-03-27 23:28 ` Guenter Roeck
2012-03-29 19:46 ` Björn Gerhart
  -- strict thread matches above, loose matches on Subject: below --
2012-03-08  4:25 Guenter Roeck
2012-03-13 18:43 ` Bjoern Gerhart
2012-03-15 21:13 ` Guenter Roeck
2012-03-15 21:18 ` Jean Delvare
2012-03-23 21:02 ` Jean Delvare
2012-03-23 21:17 ` Jean Delvare
2012-03-23 23:24 ` Björn Gerhart
2012-03-24  4:18 ` Guenter Roeck
2012-03-24  7:05 ` Jean Delvare
2012-03-24  8:11 ` Björn Gerhart
2012-03-24  8:37 ` Jean Delvare
2012-03-24 15:22 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=296C0394-16BB-426F-B13B-1A924A7BBDE5@extracloud.de \
    --to=oss@extracloud.de \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.