From: Felix Fietkau <nbd@nbd.name>
To: Chen Lin <chen45464546@163.com>,
john@phrozen.org, sean.wang@mediatek.com,
Mark-MC.Lee@mediatek.com
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, matthias.bgg@gmail.com,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
alexander.duyck@gmail.com
Subject: Re: [PATCH] net: ethernet: mtk_eth_soc: fix misuse of mem alloc interface netdev_alloc_frag
Date: Fri, 3 Jun 2022 06:30:42 +0200 [thread overview]
Message-ID: <2997c5b0-3611-5e00-466c-b2966f09f067@nbd.name> (raw)
In-Reply-To: <1654229435-2934-1-git-send-email-chen45464546@163.com>
On 03.06.22 06:10, Chen Lin wrote:
> When rx_flag == MTK_RX_FLAGS_HWLRO,
> rx_data_len = MTK_MAX_LRO_RX_LENGTH(4096 * 3) > PAGE_SIZE.
> netdev_alloc_frag is for alloction of page fragment only.
> Reference to other drivers and Documentation/vm/page_frags.rst
>
> Branch to use kmalloc when rx_data_len > PAGE_SIZE.
>
> Signed-off-by: Chen Lin <chen45464546@163.com>
> ---
> drivers/net/ethernet/mediatek/mtk_eth_soc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index b3b3c07..d0eebca 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -1914,7 +1914,10 @@ static int mtk_rx_alloc(struct mtk_eth *eth, int ring_no, int rx_flag)
> return -ENOMEM;
>
> for (i = 0; i < rx_dma_size; i++) {
> - ring->data[i] = netdev_alloc_frag(ring->frag_size);
> + if (ring->frag_size <= PAGE_SIZE)
> + ring->data[i] = netdev_alloc_frag(ring->frag_size);
> + else
> + ring->data[i] = kmalloc(ring->frag_size, GFP_KERNEL);
I'm pretty sure you also need to update all the other places in the code
that currently assume that the buffer is allocated using the page frag
allocator.
- Felix
WARNING: multiple messages have this Message-ID (diff)
From: Felix Fietkau <nbd@nbd.name>
To: Chen Lin <chen45464546@163.com>,
john@phrozen.org, sean.wang@mediatek.com,
Mark-MC.Lee@mediatek.com
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, matthias.bgg@gmail.com,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
alexander.duyck@gmail.com
Subject: Re: [PATCH] net: ethernet: mtk_eth_soc: fix misuse of mem alloc interface netdev_alloc_frag
Date: Fri, 3 Jun 2022 06:30:42 +0200 [thread overview]
Message-ID: <2997c5b0-3611-5e00-466c-b2966f09f067@nbd.name> (raw)
In-Reply-To: <1654229435-2934-1-git-send-email-chen45464546@163.com>
On 03.06.22 06:10, Chen Lin wrote:
> When rx_flag == MTK_RX_FLAGS_HWLRO,
> rx_data_len = MTK_MAX_LRO_RX_LENGTH(4096 * 3) > PAGE_SIZE.
> netdev_alloc_frag is for alloction of page fragment only.
> Reference to other drivers and Documentation/vm/page_frags.rst
>
> Branch to use kmalloc when rx_data_len > PAGE_SIZE.
>
> Signed-off-by: Chen Lin <chen45464546@163.com>
> ---
> drivers/net/ethernet/mediatek/mtk_eth_soc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index b3b3c07..d0eebca 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -1914,7 +1914,10 @@ static int mtk_rx_alloc(struct mtk_eth *eth, int ring_no, int rx_flag)
> return -ENOMEM;
>
> for (i = 0; i < rx_dma_size; i++) {
> - ring->data[i] = netdev_alloc_frag(ring->frag_size);
> + if (ring->frag_size <= PAGE_SIZE)
> + ring->data[i] = netdev_alloc_frag(ring->frag_size);
> + else
> + ring->data[i] = kmalloc(ring->frag_size, GFP_KERNEL);
I'm pretty sure you also need to update all the other places in the code
that currently assume that the buffer is allocated using the page frag
allocator.
- Felix
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Felix Fietkau <nbd@nbd.name>
To: Chen Lin <chen45464546@163.com>,
john@phrozen.org, sean.wang@mediatek.com,
Mark-MC.Lee@mediatek.com
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, matthias.bgg@gmail.com,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
alexander.duyck@gmail.com
Subject: Re: [PATCH] net: ethernet: mtk_eth_soc: fix misuse of mem alloc interface netdev_alloc_frag
Date: Fri, 3 Jun 2022 06:30:42 +0200 [thread overview]
Message-ID: <2997c5b0-3611-5e00-466c-b2966f09f067@nbd.name> (raw)
In-Reply-To: <1654229435-2934-1-git-send-email-chen45464546@163.com>
On 03.06.22 06:10, Chen Lin wrote:
> When rx_flag == MTK_RX_FLAGS_HWLRO,
> rx_data_len = MTK_MAX_LRO_RX_LENGTH(4096 * 3) > PAGE_SIZE.
> netdev_alloc_frag is for alloction of page fragment only.
> Reference to other drivers and Documentation/vm/page_frags.rst
>
> Branch to use kmalloc when rx_data_len > PAGE_SIZE.
>
> Signed-off-by: Chen Lin <chen45464546@163.com>
> ---
> drivers/net/ethernet/mediatek/mtk_eth_soc.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index b3b3c07..d0eebca 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -1914,7 +1914,10 @@ static int mtk_rx_alloc(struct mtk_eth *eth, int ring_no, int rx_flag)
> return -ENOMEM;
>
> for (i = 0; i < rx_dma_size; i++) {
> - ring->data[i] = netdev_alloc_frag(ring->frag_size);
> + if (ring->frag_size <= PAGE_SIZE)
> + ring->data[i] = netdev_alloc_frag(ring->frag_size);
> + else
> + ring->data[i] = kmalloc(ring->frag_size, GFP_KERNEL);
I'm pretty sure you also need to update all the other places in the code
that currently assume that the buffer is allocated using the page frag
allocator.
- Felix
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-03 4:31 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-03 4:10 [PATCH] net: ethernet: mtk_eth_soc: fix misuse of mem alloc interface netdev_alloc_frag Chen Lin
2022-06-03 4:10 ` Chen Lin
2022-06-03 4:10 ` Chen Lin
2022-06-03 4:24 ` Jakub Kicinski
2022-06-03 4:24 ` Jakub Kicinski
2022-06-03 4:24 ` Jakub Kicinski
2022-06-03 4:30 ` Felix Fietkau [this message]
2022-06-03 4:30 ` Felix Fietkau
2022-06-03 4:30 ` Felix Fietkau
2022-06-03 8:46 ` [PATCH v2] net: ethernet: mtk_eth_soc: fix misuse of mem alloc interface netdev[napi]_alloc_frag Chen Lin
2022-06-03 8:46 ` Chen Lin
2022-06-03 8:46 ` Chen Lin
2022-06-03 15:25 ` Alexander Duyck
2022-06-03 15:25 ` Alexander Duyck
2022-06-03 15:25 ` Alexander Duyck
2022-06-03 15:33 ` Alexander Duyck
2022-06-03 15:33 ` Alexander Duyck
2022-06-03 15:33 ` Alexander Duyck
2022-06-05 2:22 ` Chen Lin
2022-06-05 2:22 ` Chen Lin
2022-06-05 2:22 ` Chen Lin
2022-06-05 3:12 ` [PATCH v3] " Chen Lin
2022-06-05 3:12 ` Chen Lin
2022-06-05 3:12 ` Chen Lin
2022-06-06 21:34 ` Jakub Kicinski
2022-06-06 21:34 ` Jakub Kicinski
2022-06-06 21:34 ` Jakub Kicinski
2022-06-06 23:39 ` [PATCH v4] " Chen Lin
2022-06-06 23:39 ` Chen Lin
2022-06-06 23:39 ` Chen Lin
2022-06-07 23:14 ` Jakub Kicinski
2022-06-07 23:14 ` Jakub Kicinski
2022-06-07 23:14 ` Jakub Kicinski
2022-06-08 12:43 ` Chen Lin
2022-06-08 12:43 ` Chen Lin
2022-06-08 12:43 ` Chen Lin
2022-06-08 12:46 ` [PATCH v5] " Chen Lin
2022-06-08 12:46 ` Chen Lin
2022-06-08 12:46 ` Chen Lin
2022-06-09 3:50 ` patchwork-bot+netdevbpf
2022-06-09 3:50 ` patchwork-bot+netdevbpf
2022-06-09 3:50 ` patchwork-bot+netdevbpf
2022-06-03 17:25 ` [PATCH v2] " Eric Dumazet
2022-06-03 17:25 ` Eric Dumazet
2022-06-03 17:25 ` Eric Dumazet
2022-06-03 18:59 ` Jakub Kicinski
2022-06-03 18:59 ` Jakub Kicinski
2022-06-03 18:59 ` Jakub Kicinski
2022-06-03 19:11 ` Eric Dumazet
2022-06-03 19:11 ` Eric Dumazet
2022-06-03 19:11 ` Eric Dumazet
2022-06-03 19:55 ` Jakub Kicinski
2022-06-03 19:55 ` Jakub Kicinski
2022-06-03 19:55 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2997c5b0-3611-5e00-466c-b2966f09f067@nbd.name \
--to=nbd@nbd.name \
--cc=Mark-MC.Lee@mediatek.com \
--cc=alexander.duyck@gmail.com \
--cc=chen45464546@163.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john@phrozen.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.