From: Waiman Long <longman@redhat.com>
To: Haifeng Xu <haifeng.xu@shopee.com>
Cc: lizefan.x@bytedance.com, tj@kernel.org, hannes@cmpxchg.org,
akpm@linux-foundation.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpuset: Clean up cpuset_node_allowed
Date: Fri, 17 Mar 2023 21:35:39 -0400 [thread overview]
Message-ID: <299c9c34-0c07-ae52-61d7-6332f35c6245@redhat.com> (raw)
In-Reply-To: <20230228083537.102665-1-haifeng.xu@shopee.com>
On 2/28/23 03:35, Haifeng Xu wrote:
> Commit 002f290627c2 ("cpuset: use static key better and convert to new API")
> has used __cpuset_node_allowed() instead of cpuset_node_allowed() to check
> whether we can allocate on a memory node. Now this function isn't used by
> anyone, so we can do the follow things to clean up it.
>
> 1. remove unused codes
> 2. rename __cpuset_node_allowed() to cpuset_node_allowed()
> 3. update comments in mm/page_alloc.c
>
> Suggested-by: Waiman Long <longman@redhat.com>
> Signed-off-by: Haifeng Xu <haifeng.xu@shopee.com>
> ---
> include/linux/cpuset.h | 16 ++--------------
> kernel/cgroup/cpuset.c | 4 ++--
> mm/page_alloc.c | 4 ++--
> 3 files changed, 6 insertions(+), 18 deletions(-)
>
> diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h
> index d58e0476ee8e..980b76a1237e 100644
> --- a/include/linux/cpuset.h
> +++ b/include/linux/cpuset.h
> @@ -80,18 +80,11 @@ extern nodemask_t cpuset_mems_allowed(struct task_struct *p);
> void cpuset_init_current_mems_allowed(void);
> int cpuset_nodemask_valid_mems_allowed(nodemask_t *nodemask);
>
> -extern bool __cpuset_node_allowed(int node, gfp_t gfp_mask);
> -
> -static inline bool cpuset_node_allowed(int node, gfp_t gfp_mask)
> -{
> - if (cpusets_enabled())
> - return __cpuset_node_allowed(node, gfp_mask);
> - return true;
> -}
> +extern bool cpuset_node_allowed(int node, gfp_t gfp_mask);
>
> static inline bool __cpuset_zone_allowed(struct zone *z, gfp_t gfp_mask)
> {
> - return __cpuset_node_allowed(zone_to_nid(z), gfp_mask);
> + return cpuset_node_allowed(zone_to_nid(z), gfp_mask);
> }
>
> static inline bool cpuset_zone_allowed(struct zone *z, gfp_t gfp_mask)
> @@ -223,11 +216,6 @@ static inline int cpuset_nodemask_valid_mems_allowed(nodemask_t *nodemask)
> return 1;
> }
>
> -static inline bool cpuset_node_allowed(int node, gfp_t gfp_mask)
> -{
> - return true;
> -}
> -
Sorry for the late reply as I apparently drop the ball.
You need to keep the above cpuset_node_allowed() inline function or you
will get compilation error when compiling with a config without
CONFIG_CPUSETS. Other than that, the other changes look good.
Cheers,
Longman
WARNING: multiple messages have this Message-ID (diff)
From: Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Haifeng Xu <haifeng.xu-LL2PKPoSiP3QT0dZR+AlfA@public.gmane.org>
Cc: lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] cpuset: Clean up cpuset_node_allowed
Date: Fri, 17 Mar 2023 21:35:39 -0400 [thread overview]
Message-ID: <299c9c34-0c07-ae52-61d7-6332f35c6245@redhat.com> (raw)
In-Reply-To: <20230228083537.102665-1-haifeng.xu-LL2PKPoSiP3QT0dZR+AlfA@public.gmane.org>
On 2/28/23 03:35, Haifeng Xu wrote:
> Commit 002f290627c2 ("cpuset: use static key better and convert to new API")
> has used __cpuset_node_allowed() instead of cpuset_node_allowed() to check
> whether we can allocate on a memory node. Now this function isn't used by
> anyone, so we can do the follow things to clean up it.
>
> 1. remove unused codes
> 2. rename __cpuset_node_allowed() to cpuset_node_allowed()
> 3. update comments in mm/page_alloc.c
>
> Suggested-by: Waiman Long <longman-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Haifeng Xu <haifeng.xu-LL2PKPoSiP3QT0dZR+AlfA@public.gmane.org>
> ---
> include/linux/cpuset.h | 16 ++--------------
> kernel/cgroup/cpuset.c | 4 ++--
> mm/page_alloc.c | 4 ++--
> 3 files changed, 6 insertions(+), 18 deletions(-)
>
> diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h
> index d58e0476ee8e..980b76a1237e 100644
> --- a/include/linux/cpuset.h
> +++ b/include/linux/cpuset.h
> @@ -80,18 +80,11 @@ extern nodemask_t cpuset_mems_allowed(struct task_struct *p);
> void cpuset_init_current_mems_allowed(void);
> int cpuset_nodemask_valid_mems_allowed(nodemask_t *nodemask);
>
> -extern bool __cpuset_node_allowed(int node, gfp_t gfp_mask);
> -
> -static inline bool cpuset_node_allowed(int node, gfp_t gfp_mask)
> -{
> - if (cpusets_enabled())
> - return __cpuset_node_allowed(node, gfp_mask);
> - return true;
> -}
> +extern bool cpuset_node_allowed(int node, gfp_t gfp_mask);
>
> static inline bool __cpuset_zone_allowed(struct zone *z, gfp_t gfp_mask)
> {
> - return __cpuset_node_allowed(zone_to_nid(z), gfp_mask);
> + return cpuset_node_allowed(zone_to_nid(z), gfp_mask);
> }
>
> static inline bool cpuset_zone_allowed(struct zone *z, gfp_t gfp_mask)
> @@ -223,11 +216,6 @@ static inline int cpuset_nodemask_valid_mems_allowed(nodemask_t *nodemask)
> return 1;
> }
>
> -static inline bool cpuset_node_allowed(int node, gfp_t gfp_mask)
> -{
> - return true;
> -}
> -
Sorry for the late reply as I apparently drop the ball.
You need to keep the above cpuset_node_allowed() inline function or you
will get compilation error when compiling with a config without
CONFIG_CPUSETS. Other than that, the other changes look good.
Cheers,
Longman
next prev parent reply other threads:[~2023-03-18 1:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 8:07 [PATCH] cpuset: Remove unused cpuset_node_allowed Haifeng Xu
2023-02-27 8:07 ` Haifeng Xu
2023-02-27 14:56 ` Waiman Long
2023-02-27 14:56 ` Waiman Long
2023-02-28 2:40 ` Haifeng Xu
2023-02-28 2:40 ` Haifeng Xu
2023-02-28 2:52 ` Waiman Long
2023-02-28 2:52 ` Waiman Long
2023-02-28 3:13 ` Haifeng Xu
2023-02-28 3:13 ` Haifeng Xu
2023-02-28 8:35 ` [PATCH] cpuset: Clean up cpuset_node_allowed Haifeng Xu
2023-02-28 8:35 ` Haifeng Xu
2023-03-17 21:37 ` Tejun Heo
2023-03-17 21:37 ` Tejun Heo
2023-03-18 1:35 ` Waiman Long [this message]
2023-03-18 1:35 ` Waiman Long
2023-03-18 21:30 ` Waiman Long
2023-03-18 21:30 ` Waiman Long
2023-03-24 2:03 ` Tejun Heo
2023-03-24 2:03 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=299c9c34-0c07-ae52-61d7-6332f35c6245@redhat.com \
--to=longman@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=haifeng.xu@shopee.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.