All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andrew F. Davis" <afd@ti.com>
To: Evgeniy Polyakov <zbr@ioremap.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sebastian Reichel <sre@kernel.org>,
	<kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] w1: Add subsystem kernel public interface
Date: Thu, 25 May 2017 08:21:59 -0500	[thread overview]
Message-ID: <299fe87d-d0fd-6f16-2f7e-ba56096e5021@ti.com> (raw)
In-Reply-To: <1499591495717767@web38g.yandex.ru>

On 05/25/2017 08:09 AM, Evgeniy Polyakov wrote:
> Hi everyone
> 
> 25.05.2017, 16:07, "Andrew F. Davis" <afd@ti.com>:
> 
>>>  Do you have a patch that does that? I don't want to accept this patch
>>>  if that never happens...
>>
>> Yes, this reorganization stems from the need to move the BQ27xxx slave
>> out, patches were posted and reviewed last cycle here[0] and will be
>> reposted when this patch is accepted. Other w1/slaves can be moved out
>> at their owners convenience if/when they wish.
> 
> Why does BQ27xxx need to move out of w1 tree?
> 

Currently we have to enable a pseudo-platform device driver in the
power/supply BQ27xxx driver, then the w1 driver has to instantiate this
platform device and then they connect and communicate by sharing
callbacks. This is rather hacky.

Other buses USB, SPI, I2C, etc. allow the client device drivers to live
with the subsystem they for whose functionality they expose (e.g an I2C
attached temp sensor goes in drivers/hwmon, not drivers/i2c).

"Need" is a bit strong, but moving this out makes things a lot cleaner
and more consistent.

Andrew

WARNING: multiple messages have this Message-ID (diff)
From: "Andrew F. Davis" <afd@ti.com>
To: Evgeniy Polyakov <zbr@ioremap.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Sebastian Reichel <sre@kernel.org>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] w1: Add subsystem kernel public interface
Date: Thu, 25 May 2017 13:21:59 +0000	[thread overview]
Message-ID: <299fe87d-d0fd-6f16-2f7e-ba56096e5021@ti.com> (raw)
In-Reply-To: <1499591495717767@web38g.yandex.ru>

On 05/25/2017 08:09 AM, Evgeniy Polyakov wrote:
> Hi everyone
> 
> 25.05.2017, 16:07, "Andrew F. Davis" <afd@ti.com>:
> 
>>>  Do you have a patch that does that? I don't want to accept this patch
>>>  if that never happens...
>>
>> Yes, this reorganization stems from the need to move the BQ27xxx slave
>> out, patches were posted and reviewed last cycle here[0] and will be
>> reposted when this patch is accepted. Other w1/slaves can be moved out
>> at their owners convenience if/when they wish.
> 
> Why does BQ27xxx need to move out of w1 tree?
> 

Currently we have to enable a pseudo-platform device driver in the
power/supply BQ27xxx driver, then the w1 driver has to instantiate this
platform device and then they connect and communicate by sharing
callbacks. This is rather hacky.

Other buses USB, SPI, I2C, etc. allow the client device drivers to live
with the subsystem they for whose functionality they expose (e.g an I2C
attached temp sensor goes in drivers/hwmon, not drivers/i2c).

"Need" is a bit strong, but moving this out makes things a lot cleaner
and more consistent.

Andrew

  parent reply	other threads:[~2017-05-25 13:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20170516200814.12360-1-afd@ti.com>
2017-05-16 20:08 ` [PATCH v2 1/1] w1: Add subsystem kernel public interface Andrew F. Davis
2017-05-16 20:08   ` Andrew F. Davis
2017-05-25 13:00   ` Greg Kroah-Hartman
2017-05-25 13:00     ` Greg Kroah-Hartman
2017-05-25 13:07     ` Andrew F. Davis
2017-05-25 13:07       ` Andrew F. Davis
     [not found]       ` <1499591495717767@web38g.yandex.ru>
2017-05-25 13:21         ` Andrew F. Davis [this message]
2017-05-25 13:21           ` Andrew F. Davis
     [not found]           ` <1604131495718924@web38g.yandex.ru>
2017-05-25 13:47             ` Andrew F. Davis
2017-05-25 13:47               ` Andrew F. Davis
     [not found]               ` <3947221495815182@web23o.yandex.ru>
2017-05-26 16:31                 ` Andrew F. Davis
2017-05-26 16:31                   ` Andrew F. Davis
2017-06-03 10:22   ` Greg Kroah-Hartman
2017-06-03 10:22     ` Greg Kroah-Hartman
2017-06-05 13:57     ` Andrew F. Davis
2017-06-05 13:57       ` Andrew F. Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=299fe87d-d0fd-6f16-2f7e-ba56096e5021@ti.com \
    --to=afd@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sre@kernel.org \
    --cc=zbr@ioremap.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.