All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-java][PATCH 1/2] openjdk: fix host-user-contaminated QA issue
@ 2015-12-18  7:31 jackie.huang
  2015-12-18  7:31 ` [meta-java][PATCH 2/2] openjdk-8: skip the dev-so test jackie.huang
  0 siblings, 1 reply; 4+ messages in thread
From: jackie.huang @ 2015-12-18  7:31 UTC (permalink / raw)
  To: openembedded-devel

From: Jackie Huang <jackie.huang@windriver.com>

Fixed:
WARNING: QA Issue: openjdk-8:
/openjdk-8-doc/usr/lib/jvm/openjdk-8/jre/THIRD_PARTY_README is owned by
uid 1786, which is the same as the user running bitbake. This may be due
to host contamination [host-user-contaminated]

The use of cp results in files in the recipe being owned by the user
running bitbake, so fix the owner to root:root

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 recipes-core/openjdk/openjdk-8_72b05.bb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/recipes-core/openjdk/openjdk-8_72b05.bb b/recipes-core/openjdk/openjdk-8_72b05.bb
index 96473f5..d962b1f 100644
--- a/recipes-core/openjdk/openjdk-8_72b05.bb
+++ b/recipes-core/openjdk/openjdk-8_72b05.bb
@@ -20,6 +20,7 @@ do_install() {
     rm -rf ${D}${JDK_HOME}
         mkdir -p ${D}${JDK_HOME}
     cp -rp ${B}/images/j2sdk-image/* ${D}${JDK_HOME}
+    chown -R root:root ${D}${JDK_HOME}
     install -m644 ${WORKDIR}/jvm.cfg  ${D}${JDK_HOME}/jre/lib/${JDK_ARCH}/
     find ${D}${JDK_HOME} -name "*.debuginfo" -print0 | xargs -0 rm
 }
-- 
2.3.5



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [meta-java][PATCH 2/2] openjdk-8: skip the dev-so test
  2015-12-18  7:31 [meta-java][PATCH 1/2] openjdk: fix host-user-contaminated QA issue jackie.huang
@ 2015-12-18  7:31 ` jackie.huang
  2015-12-22  7:33   ` Huang, Jie (Jackie)
  0 siblings, 1 reply; 4+ messages in thread
From: jackie.huang @ 2015-12-18  7:31 UTC (permalink / raw)
  To: openembedded-devel

From: Jackie Huang <jackie.huang@windriver.com>

Fixed:
ERROR: QA Issue: non -dev/-dbg/nativesdk- package contains symlink .so:
openjdk-8 path
'work/core2-64-poky-linux/openjdk-8/72b05-r0/packages-split/openjdk-8/usr/lib/jvm/openjdk-8/jre/lib/amd64/server/libjsig.so'
[dev-so]

The symlink .so is valid so we just skip the test
just like what we does in openjdk-7.

Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
---
 recipes-core/openjdk/openjdk-8_72b05.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/recipes-core/openjdk/openjdk-8_72b05.bb b/recipes-core/openjdk/openjdk-8_72b05.bb
index d962b1f..8aa9f9f 100644
--- a/recipes-core/openjdk/openjdk-8_72b05.bb
+++ b/recipes-core/openjdk/openjdk-8_72b05.bb
@@ -92,6 +92,9 @@ PROVIDES_${PN} = "java2-vm"
 RPROVIDES_${PN} = "java2-runtime"
 PROVIDES_${PN} = "java2-runtime"
 
+# There is a symlink to a .so but this one is valid.
+INSANE_SKIP_${PN} = "dev-so"
+
 inherit update-alternatives
 
 ALTERNATIVE_PRIORITY = "100"
-- 
2.3.5



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [meta-java][PATCH 2/2] openjdk-8: skip the dev-so test
  2015-12-18  7:31 ` [meta-java][PATCH 2/2] openjdk-8: skip the dev-so test jackie.huang
@ 2015-12-22  7:33   ` Huang, Jie (Jackie)
  2016-01-15  9:49     ` Jens Rehsack
  0 siblings, 1 reply; 4+ messages in thread
From: Huang, Jie (Jackie) @ 2015-12-22  7:33 UTC (permalink / raw)
  To: openembedded-devel

Please ignore this since openjre-8 also has same issue, I will re-patch in
a .inc. But a question I have is, why do we needs a different packaging
strategy for openjdk-8 and there are two recipes: on for openjdk-8 and
another for openjre-8? Openjdk-7 is using one recipe to provide
openjdk-7-jdk and opendk-7-jre.

Thanks,
Jackie

> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-
> bounces@lists.openembedded.org] On Behalf Of jackie.huang@windriver.com
> Sent: Friday, December 18, 2015 3:32 PM
> To: openembedded-devel@lists.openembedded.org
> Subject: [oe] [meta-java][PATCH 2/2] openjdk-8: skip the dev-so test
> 
> From: Jackie Huang <jackie.huang@windriver.com>
> 
> Fixed:
> ERROR: QA Issue: non -dev/-dbg/nativesdk- package contains symlink .so:
> openjdk-8 path
> 'work/core2-64-poky-linux/openjdk-8/72b05-r0/packages-split/openjdk-8/usr/lib/jvm/openjdk-
> 8/jre/lib/amd64/server/libjsig.so'
> [dev-so]
> 
> The symlink .so is valid so we just skip the test
> just like what we does in openjdk-7.
> 
> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
> ---
>  recipes-core/openjdk/openjdk-8_72b05.bb | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/recipes-core/openjdk/openjdk-8_72b05.bb b/recipes-core/openjdk/openjdk-8_72b05.bb
> index d962b1f..8aa9f9f 100644
> --- a/recipes-core/openjdk/openjdk-8_72b05.bb
> +++ b/recipes-core/openjdk/openjdk-8_72b05.bb
> @@ -92,6 +92,9 @@ PROVIDES_${PN} = "java2-vm"
>  RPROVIDES_${PN} = "java2-runtime"
>  PROVIDES_${PN} = "java2-runtime"
> 
> +# There is a symlink to a .so but this one is valid.
> +INSANE_SKIP_${PN} = "dev-so"
> +
>  inherit update-alternatives
> 
>  ALTERNATIVE_PRIORITY = "100"
> --
> 2.3.5
> 
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [meta-java][PATCH 2/2] openjdk-8: skip the dev-so test
  2015-12-22  7:33   ` Huang, Jie (Jackie)
@ 2016-01-15  9:49     ` Jens Rehsack
  0 siblings, 0 replies; 4+ messages in thread
From: Jens Rehsack @ 2016-01-15  9:49 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 2615 bytes --]


> Am 22.12.2015 um 08:33 schrieb Huang, Jie (Jackie) <Jackie.Huang@windriver.com>:
> 
> Please ignore this since openjre-8 also has same issue, I will re-patch in
> a .inc. But a question I have is, why do we needs a different packaging
> strategy for openjdk-8 and there are two recipes: on for openjdk-8 and
> another for openjre-8? Openjdk-7 is using one recipe to provide
> openjdk-7-jdk and opendk-7-jre.

That's easy to answer - openjdk-7-jre installs a part from an j2dk build, which
includes more that just the jre. Since size matters on some embedded platforms,
I decided to Do the right thing (tm) for Java8.

> Thanks,
> Jackie
> 
>> -----Original Message-----
>> From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-
>> bounces@lists.openembedded.org] On Behalf Of jackie.huang@windriver.com
>> Sent: Friday, December 18, 2015 3:32 PM
>> To: openembedded-devel@lists.openembedded.org
>> Subject: [oe] [meta-java][PATCH 2/2] openjdk-8: skip the dev-so test
>> 
>> From: Jackie Huang <jackie.huang@windriver.com>
>> 
>> Fixed:
>> ERROR: QA Issue: non -dev/-dbg/nativesdk- package contains symlink .so:
>> openjdk-8 path
>> 'work/core2-64-poky-linux/openjdk-8/72b05-r0/packages-split/openjdk-8/usr/lib/jvm/openjdk-
>> 8/jre/lib/amd64/server/libjsig.so'
>> [dev-so]
>> 
>> The symlink .so is valid so we just skip the test
>> just like what we does in openjdk-7.
>> 
>> Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
>> ---
>> recipes-core/openjdk/openjdk-8_72b05.bb | 3 +++
>> 1 file changed, 3 insertions(+)
>> 
>> diff --git a/recipes-core/openjdk/openjdk-8_72b05.bb b/recipes-core/openjdk/openjdk-8_72b05.bb
>> index d962b1f..8aa9f9f 100644
>> --- a/recipes-core/openjdk/openjdk-8_72b05.bb
>> +++ b/recipes-core/openjdk/openjdk-8_72b05.bb
>> @@ -92,6 +92,9 @@ PROVIDES_${PN} = "java2-vm"
>> RPROVIDES_${PN} = "java2-runtime"
>> PROVIDES_${PN} = "java2-runtime"
>> 
>> +# There is a symlink to a .so but this one is valid.
>> +INSANE_SKIP_${PN} = "dev-so"
>> +
>> inherit update-alternatives
>> 
>> ALTERNATIVE_PRIORITY = "100"
>> --
>> 2.3.5
>> 
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
Jens Rehsack - rehsack@gmail.com


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 859 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-01-15  9:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-18  7:31 [meta-java][PATCH 1/2] openjdk: fix host-user-contaminated QA issue jackie.huang
2015-12-18  7:31 ` [meta-java][PATCH 2/2] openjdk-8: skip the dev-so test jackie.huang
2015-12-22  7:33   ` Huang, Jie (Jackie)
2016-01-15  9:49     ` Jens Rehsack

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.