* [PATCH] net: qcom/emac: fix the error of tpd buff address valid bit
@ 2017-11-10 9:49 Wang Dongsheng
2017-11-10 12:57 ` Timur Tabi
0 siblings, 1 reply; 4+ messages in thread
From: Wang Dongsheng @ 2017-11-10 9:49 UTC (permalink / raw)
To: timur; +Cc: netdev, Wang Dongsheng
From: Wang Dongsheng <wdsch86@gmail.com>
TPD has 46-bits as buff address valid bit. So fix the buff address
from 45-bits to 46-bits.
Signed-off-by: Wang Dongsheng <wdsch86@gmail.com>
diff --git a/drivers/net/ethernet/qualcomm/emac/emac-mac.h b/drivers/net/ethernet/qualcomm/emac/emac-mac.h
index 5028fb4..66e0ce2 100644
--- a/drivers/net/ethernet/qualcomm/emac/emac-mac.h
+++ b/drivers/net/ethernet/qualcomm/emac/emac-mac.h
@@ -115,7 +115,7 @@ struct emac_tpd {
/* High-14bit Buffer Address, So, the 64b-bit address is
* {DESC_CTRL_11_TX_DATA_HIADDR[17:0],(register) BUFFER_ADDR_H, BUFFER_ADDR_L}
*/
-#define TPD_BUFFER_ADDR_H_SET(tpd, val) BITS_SET((tpd)->word[3], 18, 30, val)
+#define TPD_BUFFER_ADDR_H_SET(tpd, val) BITS_SET((tpd)->word[3], 18, 31, val)
/* Format D. Word offset from the 1st byte of this packet to start to calculate
* the custom checksum.
*/
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: qcom/emac: fix the error of tpd buff address valid bit
2017-11-10 9:49 [PATCH] net: qcom/emac: fix the error of tpd buff address valid bit Wang Dongsheng
@ 2017-11-10 12:57 ` Timur Tabi
2017-11-10 13:24 ` Wang, Dongsheng
0 siblings, 1 reply; 4+ messages in thread
From: Timur Tabi @ 2017-11-10 12:57 UTC (permalink / raw)
To: Wang Dongsheng; +Cc: netdev
On 11/10/17 3:49 AM, Wang Dongsheng wrote:
> TPD has 46-bits as buff address valid bit. So fix the buff address
> from 45-bits to 46-bits.
NAK.
The TPD has 45 bits. Why do you say it was 46?
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: qcom/emac: fix the error of tpd buff address valid bit
2017-11-10 12:57 ` Timur Tabi
@ 2017-11-10 13:24 ` Wang, Dongsheng
2017-11-10 14:08 ` Timur Tabi
0 siblings, 1 reply; 4+ messages in thread
From: Wang, Dongsheng @ 2017-11-10 13:24 UTC (permalink / raw)
To: Timur Tabi; +Cc: netdev
Hey, Timur,
On 2017/11/10 20:57, Timur Tabi wrote:
> On 11/10/17 3:49 AM, Wang Dongsheng wrote:
>> TPD has 46-bits as buff address valid bit. So fix the buff address
>> from 45-bits to 46-bits.
>
> NAK.
>
> The TPD has 45 bits. Why do you say it was 46?
>
On QDF2400, EMAC TPD buff address size is [45:0]. buff address_l [31:0],
buff address_h [31:18].
The address_h should change from [30:18] to [31:18]. So TPD buff address
should has 46bits.
Cheers,
-Dongsheng
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: qcom/emac: fix the error of tpd buff address valid bit
2017-11-10 13:24 ` Wang, Dongsheng
@ 2017-11-10 14:08 ` Timur Tabi
0 siblings, 0 replies; 4+ messages in thread
From: Timur Tabi @ 2017-11-10 14:08 UTC (permalink / raw)
To: Wang, Dongsheng; +Cc: netdev
On 11/10/2017 07:24 AM, Wang, Dongsheng wrote:
>>
> On QDF2400, EMAC TPD buff address size is [45:0]. buff address_l [31:0],
> buff address_h [31:18].
> The address_h should change from [30:18] to [31:18]. So TPD buff address
> should has 46bits.
Bit 31 of the Word 3 in the TPD is the Timestamp_save. BUFFER_ADDR_H is
[30:18], not [31:18].
I'm curious to know where you get your information. For one thing, if
you're a Qualcomm employee, you should be using your codeaurora.org
email address. You would know that if you took LOST training.
--
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm
Technologies, Inc. Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-10 14:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-10 9:49 [PATCH] net: qcom/emac: fix the error of tpd buff address valid bit Wang Dongsheng
2017-11-10 12:57 ` Timur Tabi
2017-11-10 13:24 ` Wang, Dongsheng
2017-11-10 14:08 ` Timur Tabi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.