* [PATCH] ext4: ext4_mb_mark_free_simple: Fix integer value truncation
@ 2016-11-03 9:14 ` Chandan Rajendra
0 siblings, 0 replies; 4+ messages in thread
From: Chandan Rajendra @ 2016-11-03 9:14 UTC (permalink / raw)
To: linux-ext4; +Cc: jack, Chandan Rajendra, tytso, aneesh.kumar, linuxppc-dev
'border' variable is set to a value of 2 times the block size of the
underlying filesystem. With 64k block size, the resulting value won't
fit into a 16-bit variable. Hence this commit changes the data type of
'border' to 'unsigned int'.
Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
---
fs/ext4/mballoc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index f418f55..a937ac7 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -669,7 +669,7 @@ static void ext4_mb_mark_free_simple(struct super_block *sb,
ext4_grpblk_t min;
ext4_grpblk_t max;
ext4_grpblk_t chunk;
- unsigned short border;
+ unsigned int border;
BUG_ON(len > EXT4_CLUSTERS_PER_GROUP(sb));
--
2.5.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ext4: ext4_mb_mark_free_simple: Fix integer value truncation
@ 2016-11-03 9:14 ` Chandan Rajendra
0 siblings, 0 replies; 4+ messages in thread
From: Chandan Rajendra @ 2016-11-03 9:14 UTC (permalink / raw)
To: linux-ext4; +Cc: Chandan Rajendra, tytso, jack, aneesh.kumar, linuxppc-dev
'border' variable is set to a value of 2 times the block size of the
underlying filesystem. With 64k block size, the resulting value won't
fit into a 16-bit variable. Hence this commit changes the data type of
'border' to 'unsigned int'.
Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
---
fs/ext4/mballoc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index f418f55..a937ac7 100644
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -669,7 +669,7 @@ static void ext4_mb_mark_free_simple(struct super_block *sb,
ext4_grpblk_t min;
ext4_grpblk_t max;
ext4_grpblk_t chunk;
- unsigned short border;
+ unsigned int border;
BUG_ON(len > EXT4_CLUSTERS_PER_GROUP(sb));
--
2.5.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ext4: ext4_mb_mark_free_simple: Fix integer value truncation
2016-11-03 9:14 ` Chandan Rajendra
(?)
@ 2016-11-03 19:32 ` Andreas Dilger
2016-11-15 2:24 ` Theodore Ts'o
-1 siblings, 1 reply; 4+ messages in thread
From: Andreas Dilger @ 2016-11-03 19:32 UTC (permalink / raw)
To: Chandan Rajendra; +Cc: linux-ext4, tytso, jack, aneesh.kumar, linuxppc-dev
[-- Attachment #1: Type: text/plain, Size: 1206 bytes --]
On Nov 3, 2016, at 3:14 AM, Chandan Rajendra <chandan@linux.vnet.ibm.com> wrote:
>
> 'border' variable is set to a value of 2 times the block size of the
> underlying filesystem. With 64k block size, the resulting value won't
> fit into a 16-bit variable. Hence this commit changes the data type of
> 'border' to 'unsigned int'.
>
> Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
> ---
> fs/ext4/mballoc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index f418f55..a937ac7 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -669,7 +669,7 @@ static void ext4_mb_mark_free_simple(struct super_block *sb,
> ext4_grpblk_t min;
> ext4_grpblk_t max;
> ext4_grpblk_t chunk;
> - unsigned short border;
> + unsigned int border;
>
> BUG_ON(len > EXT4_CLUSTERS_PER_GROUP(sb));
>
> --
> 2.5.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Cheers, Andreas
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ext4: ext4_mb_mark_free_simple: Fix integer value truncation
2016-11-03 19:32 ` Andreas Dilger
@ 2016-11-15 2:24 ` Theodore Ts'o
0 siblings, 0 replies; 4+ messages in thread
From: Theodore Ts'o @ 2016-11-15 2:24 UTC (permalink / raw)
To: Andreas Dilger
Cc: Chandan Rajendra, linux-ext4, jack, aneesh.kumar, linuxppc-dev
On Thu, Nov 03, 2016 at 01:32:33PM -0600, Andreas Dilger wrote:
> On Nov 3, 2016, at 3:14 AM, Chandan Rajendra <chandan@linux.vnet.ibm.com> wrote:
> >
> > 'border' variable is set to a value of 2 times the block size of the
> > underlying filesystem. With 64k block size, the resulting value won't
> > fit into a 16-bit variable. Hence this commit changes the data type of
> > 'border' to 'unsigned int'.
> >
> > Signed-off-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
>
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Applied, with a change in the commit summary:
ext4: fix mballoc breakage with 64k block size
Many thanks!!
- Ted
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-15 2:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-03 9:14 [PATCH] ext4: ext4_mb_mark_free_simple: Fix integer value truncation Chandan Rajendra
2016-11-03 9:14 ` Chandan Rajendra
2016-11-03 19:32 ` Andreas Dilger
2016-11-15 2:24 ` Theodore Ts'o
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.