* [Xen-devel] [PATCH] docs/misc: livepatch: Espace backslash
@ 2020-01-13 22:12 Julien Grall
2020-01-14 8:40 ` Wieczorkiewicz, Pawel
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Julien Grall @ 2020-01-13 22:12 UTC (permalink / raw)
To: xen-devel
Cc: Ross Lagerwall, Pawel Wieczorkiewicz, Julien Grall,
Konrad Rzeszutek Wilk
pandoc is currently failing to generate the pdf with the following
error:
! Undefined control sequence.
l.1048 metadata string format is: key=value\0
In this case, we want to print \0 so we need to backslash-escape the
first character.
Interestingly pandoc will not complain when creating html and will just
ignore \0 completely.
Fixes: 5083e0ff93 ("livepatch: Add metadata runtime retrieval mechanism")
Signed-off-by: Julien Grall <julien@xen.org>
Cc: Pawel Wieczorkiewicz <wipawel@amazon.de>
---
docs/misc/livepatch.pandoc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/misc/livepatch.pandoc b/docs/misc/livepatch.pandoc
index 2f3f95ed37..9473ad5991 100644
--- a/docs/misc/livepatch.pandoc
+++ b/docs/misc/livepatch.pandoc
@@ -739,7 +739,7 @@ The caller provides:
Caller *MUST* allocate enough space to be able to store all received data
(i.e. total allocated space *MUST* match the `metadata_total_size` value
provided by the hypervisor). Individual payload metadata string can be of
- arbitrary length. The metadata string format is: key=value\0...key=value\0.
+ arbitrary length. The metadata string format is: key=value\\0...key=value\\0.
* `metadata_len` - Virtual address of where to write the length of each metadata
string of the payload. Caller *MUST* allocate up to `nr` of them. Each *MUST*
be of sizeof(uint32_t) (4 bytes).
--
2.17.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Xen-devel] [PATCH] docs/misc: livepatch: Espace backslash
2020-01-13 22:12 [Xen-devel] [PATCH] docs/misc: livepatch: Espace backslash Julien Grall
@ 2020-01-14 8:40 ` Wieczorkiewicz, Pawel
2020-01-14 9:23 ` Ross Lagerwall
2020-01-14 9:53 ` Durrant, Paul
2 siblings, 0 replies; 5+ messages in thread
From: Wieczorkiewicz, Pawel @ 2020-01-14 8:40 UTC (permalink / raw)
To: Julien Grall
Cc: Xen-devel, Wieczorkiewicz, Pawel, Ross Lagerwall, Konrad Rzeszutek Wilk
> On 13. Jan 2020, at 23:12, Julien Grall <julien@xen.org> wrote:
>
> pandoc is currently failing to generate the pdf with the following
> error:
> ! Undefined control sequence.
> l.1048 metadata string format is: key=value\0
>
> In this case, we want to print \0 so we need to backslash-escape the
> first character.
>
> Interestingly pandoc will not complain when creating html and will just
> ignore \0 completely.
>
> Fixes: 5083e0ff93 ("livepatch: Add metadata runtime retrieval mechanism")
> Signed-off-by: Julien Grall <julien@xen.org>
> Cc: Pawel Wieczorkiewicz <wipawel@amazon.de>
> ---
> docs/misc/livepatch.pandoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/misc/livepatch.pandoc b/docs/misc/livepatch.pandoc
> index 2f3f95ed37..9473ad5991 100644
> --- a/docs/misc/livepatch.pandoc
> +++ b/docs/misc/livepatch.pandoc
> @@ -739,7 +739,7 @@ The caller provides:
> Caller *MUST* allocate enough space to be able to store all received data
> (i.e. total allocated space *MUST* match the `metadata_total_size` value
> provided by the hypervisor). Individual payload metadata string can be of
> - arbitrary length. The metadata string format is: key=value\0...key=value\0.
> + arbitrary length. The metadata string format is: key=value\\0...key=value\\0.
> * `metadata_len` - Virtual address of where to write the length of each metadata
> string of the payload. Caller *MUST* allocate up to `nr` of them. Each *MUST*
> be of sizeof(uint32_t) (4 bytes).
> --
> 2.17.1
>
Sorry for yet another problem...
Reviewed-by: Pawel Wieczorkiewicz <wipawel@amazon.de>
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Jonathan Weiss
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Xen-devel] [PATCH] docs/misc: livepatch: Espace backslash
2020-01-13 22:12 [Xen-devel] [PATCH] docs/misc: livepatch: Espace backslash Julien Grall
2020-01-14 8:40 ` Wieczorkiewicz, Pawel
@ 2020-01-14 9:23 ` Ross Lagerwall
2020-01-14 9:53 ` Durrant, Paul
2 siblings, 0 replies; 5+ messages in thread
From: Ross Lagerwall @ 2020-01-14 9:23 UTC (permalink / raw)
To: Julien Grall, xen-devel; +Cc: Pawel Wieczorkiewicz, Konrad Rzeszutek Wilk
On 1/13/20 10:12 PM, Julien Grall wrote:
> pandoc is currently failing to generate the pdf with the following
> error:
> ! Undefined control sequence.
> l.1048 metadata string format is: key=value\0
>
> In this case, we want to print \0 so we need to backslash-escape the
> first character.
>
> Interestingly pandoc will not complain when creating html and will just
> ignore \0 completely.
>
> Fixes: 5083e0ff93 ("livepatch: Add metadata runtime retrieval mechanism")
> Signed-off-by: Julien Grall <julien@xen.org>
> Cc: Pawel Wieczorkiewicz <wipawel@amazon.de>
> ---
> docs/misc/livepatch.pandoc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/misc/livepatch.pandoc b/docs/misc/livepatch.pandoc
> index 2f3f95ed37..9473ad5991 100644
> --- a/docs/misc/livepatch.pandoc
> +++ b/docs/misc/livepatch.pandoc
> @@ -739,7 +739,7 @@ The caller provides:
> Caller *MUST* allocate enough space to be able to store all received data
> (i.e. total allocated space *MUST* match the `metadata_total_size` value
> provided by the hypervisor). Individual payload metadata string can be of
> - arbitrary length. The metadata string format is: key=value\0...key=value\0.
> + arbitrary length. The metadata string format is: key=value\\0...key=value\\0.
> * `metadata_len` - Virtual address of where to write the length of each metadata
> string of the payload. Caller *MUST* allocate up to `nr` of them. Each *MUST*
> be of sizeof(uint32_t) (4 bytes).
>
Reviewed-by: Ross Lagerwall <ross.lagerwall@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Xen-devel] [PATCH] docs/misc: livepatch: Espace backslash
2020-01-13 22:12 [Xen-devel] [PATCH] docs/misc: livepatch: Espace backslash Julien Grall
2020-01-14 8:40 ` Wieczorkiewicz, Pawel
2020-01-14 9:23 ` Ross Lagerwall
@ 2020-01-14 9:53 ` Durrant, Paul
2020-01-14 13:29 ` Julien Grall
2 siblings, 1 reply; 5+ messages in thread
From: Durrant, Paul @ 2020-01-14 9:53 UTC (permalink / raw)
To: Julien Grall, xen-devel
Cc: Ross Lagerwall, Konrad Rzeszutek Wilk, Wieczorkiewicz, Pawel
> -----Original Message-----
> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of
> Julien Grall
> Sent: 13 January 2020 23:12
> To: xen-devel@lists.xenproject.org
> Cc: Ross Lagerwall <ross.lagerwall@citrix.com>; Wieczorkiewicz, Pawel
> <wipawel@amazon.de>; Julien Grall <julien@xen.org>; Konrad Rzeszutek
Wilk
> <konrad.wilk@oracle.com>
> Subject: [Xen-devel] [PATCH] docs/misc: livepatch: Espace backslash
>
s/Espace/Escape, I assume
Paul
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Xen-devel] [PATCH] docs/misc: livepatch: Espace backslash
2020-01-14 9:53 ` Durrant, Paul
@ 2020-01-14 13:29 ` Julien Grall
0 siblings, 0 replies; 5+ messages in thread
From: Julien Grall @ 2020-01-14 13:29 UTC (permalink / raw)
To: Durrant, Paul, xen-devel
Cc: Ross Lagerwall, Konrad Rzeszutek Wilk, Wieczorkiewicz, Pawel
Hi Paul,
On 14/01/2020 09:53, Durrant, Paul wrote:
>> -----Original Message-----
>> From: Xen-devel <xen-devel-bounces@lists.xenproject.org> On Behalf Of
>> Julien Grall
>> Sent: 13 January 2020 23:12
>> To: xen-devel@lists.xenproject.org
>> Cc: Ross Lagerwall <ross.lagerwall@citrix.com>; Wieczorkiewicz, Pawel
>> <wipawel@amazon.de>; Julien Grall <julien@xen.org>; Konrad Rzeszutek
> Wilk
>> <konrad.wilk@oracle.com>
>> Subject: [Xen-devel] [PATCH] docs/misc: livepatch: Espace backslash
>>
>
> s/Espace/Escape, I assume
Hmm, yes. Thank you for spotting it!
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-14 13:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-13 22:12 [Xen-devel] [PATCH] docs/misc: livepatch: Espace backslash Julien Grall
2020-01-14 8:40 ` Wieczorkiewicz, Pawel
2020-01-14 9:23 ` Ross Lagerwall
2020-01-14 9:53 ` Durrant, Paul
2020-01-14 13:29 ` Julien Grall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.