* [PATCH] ASoC: da7219: Connect output enable register to DAIOUT
@ 2016-10-28 1:02 Stephen Barber
2016-10-28 9:36 ` Adam Thomson
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Barber @ 2016-10-28 1:02 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: Adam Thomson, Support Opensource, alsa-devel, linux-kernel,
Hsin-Yu Chao, Dylan Reid, Stephen Barber
da7219 output (for headset capture) should be set to high-impedance when
not in use, since it will otherwise interfere with output from other
codecs attached to the same DAI.
Signed-off-by: Stephen Barber <smbarber@chromium.org>
---
sound/soc/codecs/da7219.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
index 2610fc5..9960162 100644
--- a/sound/soc/codecs/da7219.c
+++ b/sound/soc/codecs/da7219.c
@@ -959,7 +959,8 @@ static const struct snd_soc_dapm_widget da7219_dapm_widgets[] = {
SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMD),
/* DAI */
- SND_SOC_DAPM_AIF_OUT("DAIOUT", "Capture", 0, SND_SOC_NOPM, 0, 0),
+ SND_SOC_DAPM_AIF_OUT("DAIOUT", "Capture", 0, DA7219_DAI_TDM_CTRL,
+ DA7219_DAI_OE_SHIFT, DA7219_NO_INVERT),
SND_SOC_DAPM_AIF_IN("DAIIN", "Playback", 0, SND_SOC_NOPM, 0, 0),
/* Output Muxes */
--
2.8.0.rc3.226.g39d4020
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] ASoC: da7219: Connect output enable register to DAIOUT
2016-10-28 1:02 [PATCH] ASoC: da7219: Connect output enable register to DAIOUT Stephen Barber
@ 2016-10-28 9:36 ` Adam Thomson
0 siblings, 0 replies; 2+ messages in thread
From: Adam Thomson @ 2016-10-28 9:36 UTC (permalink / raw)
To: Stephen Barber, Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai
Cc: Adam Thomson, Support Opensource, alsa-devel, linux-kernel,
Hsin-Yu Chao, Dylan Reid
On 28 October 2016 02:02, Steve Barber wrote:
> da7219 output (for headset capture) should be set to high-impedance when
> not in use, since it will otherwise interfere with output from other
> codecs attached to the same DAI.
>
> Signed-off-by: Stephen Barber <smbarber@chromium.org>
> ---
> sound/soc/codecs/da7219.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/da7219.c b/sound/soc/codecs/da7219.c
> index 2610fc5..9960162 100644
> --- a/sound/soc/codecs/da7219.c
> +++ b/sound/soc/codecs/da7219.c
> @@ -959,7 +959,8 @@ static const struct snd_soc_dapm_widget
> da7219_dapm_widgets[] = {
> SND_SOC_DAPM_PRE_PMU |
> SND_SOC_DAPM_POST_PMD),
>
> /* DAI */
> - SND_SOC_DAPM_AIF_OUT("DAIOUT", "Capture", 0, SND_SOC_NOPM, 0, 0),
> + SND_SOC_DAPM_AIF_OUT("DAIOUT", "Capture", 0,
> DA7219_DAI_TDM_CTRL,
> + DA7219_DAI_OE_SHIFT, DA7219_NO_INVERT),
> SND_SOC_DAPM_AIF_IN("DAIIN", "Playback", 0, SND_SOC_NOPM, 0, 0),
>
> /* Output Muxes */
> --
> 2.8.0.rc3.226.g39d4020
Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-28 9:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-28 1:02 [PATCH] ASoC: da7219: Connect output enable register to DAIOUT Stephen Barber
2016-10-28 9:36 ` Adam Thomson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.