From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com> To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>, Adam Thomson <Adam.Thomson.Opensource@diasemi.com>, Heikki Krogerus <heikki.krogerus@linux.intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org> Subject: RE: [PATCH] typec: tcpm: Fix incorrect 'and' operator Date: Mon, 30 Apr 2018 14:44:31 +0000 [thread overview] Message-ID: <2E89032DDAA8B9408CB92943514A0337014C1E9323@SW-EX-MBX01.diasemi.com> (raw) In-Reply-To: <20180430132305.GA20092@embeddedor.com> On 30 April 2018 14:23, Gustavo A. R. Silva wrote: > Currently, logical and is being used instead of *bitwise* and. > > Fix this by using a proper bitwise and operator. > > Addresses-Coverity-ID: 1468455 ("Logical vs. bitwise operator") > Fixes: 64f7c494a3c0 ("typec: tcpm: Add support for sink PPS related > messages") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- Good spot. :( Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com> > drivers/usb/typec/tcpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c > index 1ee259b..7ee417a 100644 > --- a/drivers/usb/typec/tcpm.c > +++ b/drivers/usb/typec/tcpm.c > @@ -1772,7 +1772,7 @@ static void tcpm_pd_ext_msg_request(struct tcpm_port > *port, > enum pd_ext_msg_type type = pd_header_type_le(msg->header); > unsigned int data_size = pd_ext_header_data_size_le(msg- > >ext_msg.header); > > - if (!(msg->ext_msg.header && PD_EXT_HDR_CHUNKED)) { > + if (!(msg->ext_msg.header & PD_EXT_HDR_CHUNKED)) { > tcpm_log(port, "Unchunked extended messages unsupported"); > return; > } > -- > 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: "Opensource \[Adam Thomson\]" <Adam.Thomson.Opensource@diasemi.com> To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>, Adam Thomson <Adam.Thomson.Opensource@diasemi.com>, Heikki Krogerus <heikki.krogerus@linux.intel.com>, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org> Subject: typec: tcpm: Fix incorrect 'and' operator Date: Mon, 30 Apr 2018 14:44:31 +0000 [thread overview] Message-ID: <2E89032DDAA8B9408CB92943514A0337014C1E9323@SW-EX-MBX01.diasemi.com> (raw) On 30 April 2018 14:23, Gustavo A. R. Silva wrote: > Currently, logical and is being used instead of *bitwise* and. > > Fix this by using a proper bitwise and operator. > > Addresses-Coverity-ID: 1468455 ("Logical vs. bitwise operator") > Fixes: 64f7c494a3c0 ("typec: tcpm: Add support for sink PPS related > messages") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- Good spot. :( Acked-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com> > drivers/usb/typec/tcpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c > index 1ee259b..7ee417a 100644 > --- a/drivers/usb/typec/tcpm.c > +++ b/drivers/usb/typec/tcpm.c > @@ -1772,7 +1772,7 @@ static void tcpm_pd_ext_msg_request(struct tcpm_port > *port, > enum pd_ext_msg_type type = pd_header_type_le(msg->header); > unsigned int data_size = pd_ext_header_data_size_le(msg- > >ext_msg.header); > > - if (!(msg->ext_msg.header && PD_EXT_HDR_CHUNKED)) { > + if (!(msg->ext_msg.header & PD_EXT_HDR_CHUNKED)) { > tcpm_log(port, "Unchunked extended messages unsupported"); > return; > } > -- > 2.7.4 --- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-04-30 14:44 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-30 13:23 [PATCH] typec: tcpm: Fix incorrect 'and' operator Gustavo A. R. Silva 2018-04-30 13:23 ` Gustavo A. R. Silva 2018-04-30 13:23 ` [PATCH] " Gustavo A. R. Silva 2018-04-30 14:44 ` Adam Thomson [this message] 2018-04-30 14:44 ` Opensource [Adam Thomson] 2018-05-02 14:07 ` [PATCH] " Heikki Krogerus 2018-05-02 14:07 ` Heikki Krogerus 2018-05-02 14:07 ` [PATCH] " Heikki Krogerus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2E89032DDAA8B9408CB92943514A0337014C1E9323@SW-EX-MBX01.diasemi.com \ --to=adam.thomson.opensource@diasemi.com \ --cc=gregkh@linuxfoundation.org \ --cc=gustavo@embeddedor.com \ --cc=heikki.krogerus@linux.intel.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.