From: Pierre Morel <pmorel@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: linux-kernel@vger.kernel.org, pasic@linux.ibm.com,
borntraeger@de.ibm.com, frankja@linux.ibm.com, mst@redhat.com,
jasowang@redhat.com, kvm@vger.kernel.org,
linux-s390@vger.kernel.org,
virtualization@lists.linux-foundation.org,
thomas.lendacky@amd.com, david@gibson.dropbear.id.au,
linuxram@us.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com
Subject: Re: [PATCH v8 2/2] s390: virtio: PV needs VIRTIO I/O device protection
Date: Wed, 19 Aug 2020 10:51:32 +0200 [thread overview]
Message-ID: <2a0e6ac5-1238-fd7b-f39f-6fad767b1493@linux.ibm.com> (raw)
In-Reply-To: <20200818192233.6c80798e.cohuck@redhat.com>
On 2020-08-18 19:22, Cornelia Huck wrote:
>> + */
>> +int arch_has_restricted_memory_access(struct virtio_device *dev)
>> +{
>> + if (!is_prot_virt_guest())
>> + return 0;
>
> If you just did a
>
> return is_prot_virt_guest();
>
> and did the virtio feature stuff in the virtio core, this function
> would be short and sweet :)
yes, the smaller the better, thanks
Pierre
--
Pierre Morel
IBM Lab Boeblingen
WARNING: multiple messages have this Message-ID (diff)
From: Pierre Morel <pmorel@linux.ibm.com>
To: Cornelia Huck <cohuck@redhat.com>
Cc: gor@linux.ibm.com, linux-s390@vger.kernel.org,
frankja@linux.ibm.com, kvm@vger.kernel.org, mst@redhat.com,
linuxram@us.ibm.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, pasic@linux.ibm.com,
borntraeger@de.ibm.com, thomas.lendacky@amd.com,
hca@linux.ibm.com, david@gibson.dropbear.id.au
Subject: Re: [PATCH v8 2/2] s390: virtio: PV needs VIRTIO I/O device protection
Date: Wed, 19 Aug 2020 10:51:32 +0200 [thread overview]
Message-ID: <2a0e6ac5-1238-fd7b-f39f-6fad767b1493@linux.ibm.com> (raw)
In-Reply-To: <20200818192233.6c80798e.cohuck@redhat.com>
On 2020-08-18 19:22, Cornelia Huck wrote:
>> + */
>> +int arch_has_restricted_memory_access(struct virtio_device *dev)
>> +{
>> + if (!is_prot_virt_guest())
>> + return 0;
>
> If you just did a
>
> return is_prot_virt_guest();
>
> and did the virtio feature stuff in the virtio core, this function
> would be short and sweet :)
yes, the smaller the better, thanks
Pierre
--
Pierre Morel
IBM Lab Boeblingen
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2020-08-19 8:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 14:58 [PATCH v8 0/2] s390: virtio: let arch validate VIRTIO features Pierre Morel
2020-08-18 14:58 ` Pierre Morel
2020-08-18 14:58 ` [PATCH v8 1/2] " Pierre Morel
2020-08-18 14:58 ` Pierre Morel
2020-08-18 17:19 ` Cornelia Huck
2020-08-18 17:19 ` Cornelia Huck
2020-08-19 8:50 ` Pierre Morel
2020-08-19 8:50 ` Pierre Morel
2020-08-19 9:34 ` Cornelia Huck
2020-08-19 9:34 ` Cornelia Huck
2020-08-18 14:58 ` [PATCH v8 2/2] s390: virtio: PV needs VIRTIO I/O device protection Pierre Morel
2020-08-18 14:58 ` Pierre Morel
2020-08-18 17:22 ` Cornelia Huck
2020-08-18 17:22 ` Cornelia Huck
2020-08-19 8:51 ` Pierre Morel [this message]
2020-08-19 8:51 ` Pierre Morel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a0e6ac5-1238-fd7b-f39f-6fad767b1493@linux.ibm.com \
--to=pmorel@linux.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=frankja@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linuxram@us.ibm.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=thomas.lendacky@amd.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.