* Re: [PATCH] x86/Xen: further refine add_preferred_console() invocations
[not found] <5B30C7DD02000078001CD735@suse.com>
@ 2018-07-02 14:38 ` Juergen Gross
2018-08-15 21:35 ` Boris Ostrovsky
0 siblings, 1 reply; 3+ messages in thread
From: Juergen Gross @ 2018-07-02 14:38 UTC (permalink / raw)
To: Jan Beulich, Boris Ostrovsky; +Cc: xen-devel
On 25/06/18 12:45, Jan Beulich wrote:
> As the sequence of invocations matters, add "tty" only after "hvc" when
> a VGA console is available (which is often the case for Dom0, but hardly
> ever for DomU).
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/Xen: further refine add_preferred_console() invocations
2018-07-02 14:38 ` [PATCH] x86/Xen: further refine add_preferred_console() invocations Juergen Gross
@ 2018-08-15 21:35 ` Boris Ostrovsky
0 siblings, 0 replies; 3+ messages in thread
From: Boris Ostrovsky @ 2018-08-15 21:35 UTC (permalink / raw)
To: Juergen Gross, Jan Beulich; +Cc: xen-devel
On 07/02/2018 10:38 AM, Juergen Gross wrote:
> On 25/06/18 12:45, Jan Beulich wrote:
>> As the sequence of invocations matters, add "tty" only after "hvc" when
>> a VGA console is available (which is often the case for Dom0, but hardly
>> ever for DomU).
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> Reviewed-by: Juergen Gross <jgross@suse.com>
>
Applied to for-linus-4.19.
-boris
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] x86/Xen: further refine add_preferred_console() invocations
@ 2018-06-25 10:45 Jan Beulich
0 siblings, 0 replies; 3+ messages in thread
From: Jan Beulich @ 2018-06-25 10:45 UTC (permalink / raw)
To: Boris Ostrovsky, Juergen Gross; +Cc: xen-devel
As the sequence of invocations matters, add "tty" only after "hvc" when
a VGA console is available (which is often the case for Dom0, but hardly
ever for DomU).
Signed-off-by: Jan Beulich <jbeulich@suse.com>
---
Slightly RFC, as there may be side effects which I simply haven't
observed myself yet.
---
arch/x86/xen/enlighten_pv.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--- 4.18-rc2/arch/x86/xen/enlighten_pv.c
+++ 4.18-rc2-x86-xen-console-order/arch/x86/xen/enlighten_pv.c
@@ -1386,8 +1386,11 @@ asmlinkage __visible void __init xen_sta
xen_boot_params_init_edd();
}
- add_preferred_console("tty", 0, NULL);
+ if (!boot_params.screen_info.orig_video_isVGA)
+ add_preferred_console("tty", 0, NULL);
add_preferred_console("hvc", 0, NULL);
+ if (boot_params.screen_info.orig_video_isVGA)
+ add_preferred_console("tty", 0, NULL);
#ifdef CONFIG_PCI
/* PCI BIOS service won't work from a PV guest. */
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-15 21:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <5B30C7DD02000078001CD735@suse.com>
2018-07-02 14:38 ` [PATCH] x86/Xen: further refine add_preferred_console() invocations Juergen Gross
2018-08-15 21:35 ` Boris Ostrovsky
2018-06-25 10:45 Jan Beulich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.