From: Laxman Dewangan <ldewangan@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: linux-tegra@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 6/6] gpio: max77620: Initialize hardware state of interrupts
Date: Thu, 9 Jul 2020 20:33:49 +0530 [thread overview]
Message-ID: <2a3295f9-7473-9251-b416-ef51ec85503a@nvidia.com> (raw)
In-Reply-To: <20200708202355.28507-7-digetx@gmail.com>
On Thursday 09 July 2020 01:53 AM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> I noticed on Nexus 7 that after rebooting from downstream kernel to
> upstream, the GPIO interrupt is triggering non-stop despite interrupts
> being disabled for all of GPIOs. This happens because Nexus 7 uses a
> soft-reboot, meaning that bootloader should take care of resetting
> hardware, but the bootloader doesn't do it well. As a result, GPIO
> interrupt may be left ON at a boot time. Let's mask all GPIO interrupts
> at the driver's initialization time in order to resolve the issue.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>
Looks good to me.
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
"Bartosz Golaszewski" <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: <linux-tegra@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 6/6] gpio: max77620: Initialize hardware state of interrupts
Date: Thu, 9 Jul 2020 20:33:49 +0530 [thread overview]
Message-ID: <2a3295f9-7473-9251-b416-ef51ec85503a@nvidia.com> (raw)
In-Reply-To: <20200708202355.28507-7-digetx@gmail.com>
On Thursday 09 July 2020 01:53 AM, Dmitry Osipenko wrote:
> External email: Use caution opening links or attachments
>
>
> I noticed on Nexus 7 that after rebooting from downstream kernel to
> upstream, the GPIO interrupt is triggering non-stop despite interrupts
> being disabled for all of GPIOs. This happens because Nexus 7 uses a
> soft-reboot, meaning that bootloader should take care of resetting
> hardware, but the bootloader doesn't do it well. As a result, GPIO
> interrupt may be left ON at a boot time. Let's mask all GPIO interrupts
> at the driver's initialization time in order to resolve the issue.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
>
Looks good to me.
Acked-by: Laxman Dewangan <ldewangan@nvidia.com>
next prev parent reply other threads:[~2020-07-09 15:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 20:23 [PATCH v3 0/6] Improvements for MAX77620 GPIO driver Dmitry Osipenko
2020-07-08 20:23 ` Dmitry Osipenko
2020-07-08 20:23 ` [PATCH v3 1/6] gpio: max77620: Replace 8 with MAX77620_GPIO_NR Dmitry Osipenko
2020-07-09 14:54 ` Laxman Dewangan
2020-07-09 14:54 ` Laxman Dewangan
2020-07-08 20:23 ` [PATCH v3 2/6] gpio: max77620: Fix missing release of interrupt Dmitry Osipenko
[not found] ` <20200708202355.28507-3-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-07-09 14:57 ` Laxman Dewangan
2020-07-09 14:57 ` Laxman Dewangan
[not found] ` <80f4d1ff-8096-9060-3cf0-a59448866c40-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2020-07-09 16:36 ` Dmitry Osipenko
2020-07-09 16:36 ` Dmitry Osipenko
[not found] ` <20200708202355.28507-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-07-08 20:23 ` [PATCH v3 3/6] gpio: max77620: Don't set of_node Dmitry Osipenko
2020-07-08 20:23 ` Dmitry Osipenko
[not found] ` <CAHp75VejftNuSqdYvd1YE1SdRON6=mQ_iD2dEr4K9D8YGgeRBQ@mail.gmail.com>
[not found] ` <CAHp75VejftNuSqdYvd1YE1SdRON6=mQ_iD2dEr4K9D8YGgeRBQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-07-08 21:44 ` Dmitry Osipenko
2020-07-08 21:44 ` Dmitry Osipenko
[not found] ` <675c4691-d372-4fe1-d515-c86fdba2f588-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-07-09 9:07 ` Andy Shevchenko
2020-07-09 9:07 ` Andy Shevchenko
[not found] ` <CAHp75Vd89QpwaGvkpzG+pxnLd8S2guPCARLW5xPwhxXL8ZRfFw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-07-09 10:38 ` Dmitry Osipenko
2020-07-09 10:38 ` Dmitry Osipenko
[not found] ` <20200708202355.28507-4-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-07-09 14:58 ` Laxman Dewangan
2020-07-09 14:58 ` Laxman Dewangan
2020-07-08 20:23 ` [PATCH v3 6/6] gpio: max77620: Initialize hardware state of interrupts Dmitry Osipenko
2020-07-08 20:23 ` Dmitry Osipenko
2020-07-09 15:03 ` Laxman Dewangan [this message]
2020-07-09 15:03 ` Laxman Dewangan
2020-07-08 20:23 ` [PATCH v3 4/6] gpio: max77620: Don't shadow error code of platform_get_irq() Dmitry Osipenko
[not found] ` <20200708202355.28507-5-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-07-09 15:01 ` Laxman Dewangan
2020-07-09 15:01 ` Laxman Dewangan
2020-07-08 20:23 ` [PATCH v3 5/6] gpio: max77620: Use irqchip template Dmitry Osipenko
[not found] ` <20200708202355.28507-6-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2020-07-09 15:03 ` Laxman Dewangan
2020-07-09 15:03 ` Laxman Dewangan
[not found] ` <CAHp75VcNao84UajMYDJRH2gX7t8n=uo_Th8VVgcxJj3YkiA+pA@mail.gmail.com>
[not found] ` <CAHp75VcNao84UajMYDJRH2gX7t8n=uo_Th8VVgcxJj3YkiA+pA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-07-08 21:49 ` [PATCH v1 0/5] Improvements for MAX77620 GPIO driver Dmitry Osipenko
2020-07-08 21:49 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a3295f9-7473-9251-b416-ef51ec85503a@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.