* [v1,0/3] Add mt8186 dsi compatoble & Move the getting bridge node function @ 2022-01-27 11:42 ` xinlei.lee 0 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-01-27 11:42 UTC (permalink / raw) To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi, xinlei lee From: xinlei lee <xinlei.lee@mediatek.com> The modification is based on avoiding screen shift: https://patchwork.kernel.org/project/linux-mediatek/cover/20220114092110.12137-1-rex-bc.chen@mediatek.com/ xinlei lee (3): dt-bindings: display: mediatek: dsi: add documentation for MT8186 SoC drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c drm/mediatek: Move the getting bridge node function to mtk_dsi_bind .../bindings/display/mediatek/mediatek,dsi.txt | 2 +- drivers/gpu/drm/mediatek/mtk_dsi.c | 37 ++++++++++++++-------- 2 files changed, 24 insertions(+), 15 deletions(-) -- 2.6.4 ^ permalink raw reply [flat|nested] 36+ messages in thread
* [v1, 0/3] Add mt8186 dsi compatoble & Move the getting bridge node function @ 2022-01-27 11:42 ` xinlei.lee 0 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-01-27 11:42 UTC (permalink / raw) To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: jitao.shi, xinlei lee, srv_heupstream, linux-kernel, dri-devel, linux-mediatek, linux-arm-kernel From: xinlei lee <xinlei.lee@mediatek.com> The modification is based on avoiding screen shift: https://patchwork.kernel.org/project/linux-mediatek/cover/20220114092110.12137-1-rex-bc.chen@mediatek.com/ xinlei lee (3): dt-bindings: display: mediatek: dsi: add documentation for MT8186 SoC drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c drm/mediatek: Move the getting bridge node function to mtk_dsi_bind .../bindings/display/mediatek/mediatek,dsi.txt | 2 +- drivers/gpu/drm/mediatek/mtk_dsi.c | 37 ++++++++++++++-------- 2 files changed, 24 insertions(+), 15 deletions(-) -- 2.6.4 ^ permalink raw reply [flat|nested] 36+ messages in thread
* [v1, 0/3] Add mt8186 dsi compatoble & Move the getting bridge node function @ 2022-01-27 11:42 ` xinlei.lee 0 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-01-27 11:42 UTC (permalink / raw) To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi, xinlei lee From: xinlei lee <xinlei.lee@mediatek.com> The modification is based on avoiding screen shift: https://patchwork.kernel.org/project/linux-mediatek/cover/20220114092110.12137-1-rex-bc.chen@mediatek.com/ xinlei lee (3): dt-bindings: display: mediatek: dsi: add documentation for MT8186 SoC drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c drm/mediatek: Move the getting bridge node function to mtk_dsi_bind .../bindings/display/mediatek/mediatek,dsi.txt | 2 +- drivers/gpu/drm/mediatek/mtk_dsi.c | 37 ++++++++++++++-------- 2 files changed, 24 insertions(+), 15 deletions(-) -- 2.6.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 36+ messages in thread
* [v1, 0/3] Add mt8186 dsi compatoble & Move the getting bridge node function @ 2022-01-27 11:42 ` xinlei.lee 0 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-01-27 11:42 UTC (permalink / raw) To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi, xinlei lee From: xinlei lee <xinlei.lee@mediatek.com> The modification is based on avoiding screen shift: https://patchwork.kernel.org/project/linux-mediatek/cover/20220114092110.12137-1-rex-bc.chen@mediatek.com/ xinlei lee (3): dt-bindings: display: mediatek: dsi: add documentation for MT8186 SoC drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c drm/mediatek: Move the getting bridge node function to mtk_dsi_bind .../bindings/display/mediatek/mediatek,dsi.txt | 2 +- drivers/gpu/drm/mediatek/mtk_dsi.c | 37 ++++++++++++++-------- 2 files changed, 24 insertions(+), 15 deletions(-) -- 2.6.4 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 36+ messages in thread
* [v1,1/3] dt-bindings: display: mediatek: dsi: add documentation for MT8186 SoC 2022-01-27 11:42 ` xinlei.lee (?) (?) @ 2022-01-27 11:42 ` xinlei.lee -1 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-01-27 11:42 UTC (permalink / raw) To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi, xinlei lee From: xinlei lee <xinlei.lee@mediatek.com> Add binding documentation for the MT8186 SoC. Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> --- Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt index 36b0145..c82b8b2 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt @@ -7,7 +7,7 @@ channel output. Required properties: - compatible: "mediatek,<chip>-dsi" -- the supported chips are mt2701, mt7623, mt8167, mt8173 and mt8183. +- the supported chips are mt2701, mt7623, mt8167, mt8173, mt8183 and mt8186. - reg: Physical base address and length of the controller's registers - interrupts: The interrupt signal from the function block. - clocks: device clocks -- 2.6.4 ^ permalink raw reply related [flat|nested] 36+ messages in thread
* [v1, 1/3] dt-bindings: display: mediatek: dsi: add documentation for MT8186 SoC @ 2022-01-27 11:42 ` xinlei.lee 0 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-01-27 11:42 UTC (permalink / raw) To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: jitao.shi, xinlei lee, srv_heupstream, linux-kernel, dri-devel, linux-mediatek, linux-arm-kernel From: xinlei lee <xinlei.lee@mediatek.com> Add binding documentation for the MT8186 SoC. Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> --- Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt index 36b0145..c82b8b2 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt @@ -7,7 +7,7 @@ channel output. Required properties: - compatible: "mediatek,<chip>-dsi" -- the supported chips are mt2701, mt7623, mt8167, mt8173 and mt8183. +- the supported chips are mt2701, mt7623, mt8167, mt8173, mt8183 and mt8186. - reg: Physical base address and length of the controller's registers - interrupts: The interrupt signal from the function block. - clocks: device clocks -- 2.6.4 ^ permalink raw reply related [flat|nested] 36+ messages in thread
* [v1, 1/3] dt-bindings: display: mediatek: dsi: add documentation for MT8186 SoC @ 2022-01-27 11:42 ` xinlei.lee 0 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-01-27 11:42 UTC (permalink / raw) To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi, xinlei lee From: xinlei lee <xinlei.lee@mediatek.com> Add binding documentation for the MT8186 SoC. Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> --- Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt index 36b0145..c82b8b2 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt @@ -7,7 +7,7 @@ channel output. Required properties: - compatible: "mediatek,<chip>-dsi" -- the supported chips are mt2701, mt7623, mt8167, mt8173 and mt8183. +- the supported chips are mt2701, mt7623, mt8167, mt8173, mt8183 and mt8186. - reg: Physical base address and length of the controller's registers - interrupts: The interrupt signal from the function block. - clocks: device clocks -- 2.6.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 36+ messages in thread
* [v1, 1/3] dt-bindings: display: mediatek: dsi: add documentation for MT8186 SoC @ 2022-01-27 11:42 ` xinlei.lee 0 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-01-27 11:42 UTC (permalink / raw) To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi, xinlei lee From: xinlei lee <xinlei.lee@mediatek.com> Add binding documentation for the MT8186 SoC. Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> --- Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt index 36b0145..c82b8b2 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt @@ -7,7 +7,7 @@ channel output. Required properties: - compatible: "mediatek,<chip>-dsi" -- the supported chips are mt2701, mt7623, mt8167, mt8173 and mt8183. +- the supported chips are mt2701, mt7623, mt8167, mt8173, mt8183 and mt8186. - reg: Physical base address and length of the controller's registers - interrupts: The interrupt signal from the function block. - clocks: device clocks -- 2.6.4 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 36+ messages in thread
* Re: [v1, 1/3] dt-bindings: display: mediatek: dsi: add documentation for MT8186 SoC 2022-01-27 11:42 ` xinlei.lee (?) (?) @ 2022-01-28 5:08 ` CK Hu -1 siblings, 0 replies; 36+ messages in thread From: CK Hu @ 2022-01-28 5:08 UTC (permalink / raw) To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi Hi, Xinlei: On Thu, 2022-01-27 at 19:42 +0800, xinlei.lee@mediatek.com wrote: > From: xinlei lee <xinlei.lee@mediatek.com> > > Add binding documentation for the MT8186 SoC. DPI has a yaml format document, so I would like DSI also has a yaml format document. Please send a patch to transfer DSI document to yaml, and then apply this patch to yaml document. Regards, CK > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> > --- > Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > index 36b0145..c82b8b2 100644 > --- > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > +++ > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > @@ -7,7 +7,7 @@ channel output. > > Required properties: > - compatible: "mediatek,<chip>-dsi" > -- the supported chips are mt2701, mt7623, mt8167, mt8173 and mt8183. > +- the supported chips are mt2701, mt7623, mt8167, mt8173, mt8183 and > mt8186. > - reg: Physical base address and length of the controller's > registers > - interrupts: The interrupt signal from the function block. > - clocks: device clocks ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [v1, 1/3] dt-bindings: display: mediatek: dsi: add documentation for MT8186 SoC @ 2022-01-28 5:08 ` CK Hu 0 siblings, 0 replies; 36+ messages in thread From: CK Hu @ 2022-01-28 5:08 UTC (permalink / raw) To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi Hi, Xinlei: On Thu, 2022-01-27 at 19:42 +0800, xinlei.lee@mediatek.com wrote: > From: xinlei lee <xinlei.lee@mediatek.com> > > Add binding documentation for the MT8186 SoC. DPI has a yaml format document, so I would like DSI also has a yaml format document. Please send a patch to transfer DSI document to yaml, and then apply this patch to yaml document. Regards, CK > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> > --- > Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > index 36b0145..c82b8b2 100644 > --- > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > +++ > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > @@ -7,7 +7,7 @@ channel output. > > Required properties: > - compatible: "mediatek,<chip>-dsi" > -- the supported chips are mt2701, mt7623, mt8167, mt8173 and mt8183. > +- the supported chips are mt2701, mt7623, mt8167, mt8173, mt8183 and > mt8186. > - reg: Physical base address and length of the controller's > registers > - interrupts: The interrupt signal from the function block. > - clocks: device clocks _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [v1, 1/3] dt-bindings: display: mediatek: dsi: add documentation for MT8186 SoC @ 2022-01-28 5:08 ` CK Hu 0 siblings, 0 replies; 36+ messages in thread From: CK Hu @ 2022-01-28 5:08 UTC (permalink / raw) To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: jitao.shi, srv_heupstream, linux-kernel, dri-devel, linux-mediatek, linux-arm-kernel Hi, Xinlei: On Thu, 2022-01-27 at 19:42 +0800, xinlei.lee@mediatek.com wrote: > From: xinlei lee <xinlei.lee@mediatek.com> > > Add binding documentation for the MT8186 SoC. DPI has a yaml format document, so I would like DSI also has a yaml format document. Please send a patch to transfer DSI document to yaml, and then apply this patch to yaml document. Regards, CK > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> > --- > Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > index 36b0145..c82b8b2 100644 > --- > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > +++ > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > @@ -7,7 +7,7 @@ channel output. > > Required properties: > - compatible: "mediatek,<chip>-dsi" > -- the supported chips are mt2701, mt7623, mt8167, mt8173 and mt8183. > +- the supported chips are mt2701, mt7623, mt8167, mt8173, mt8183 and > mt8186. > - reg: Physical base address and length of the controller's > registers > - interrupts: The interrupt signal from the function block. > - clocks: device clocks ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [v1, 1/3] dt-bindings: display: mediatek: dsi: add documentation for MT8186 SoC @ 2022-01-28 5:08 ` CK Hu 0 siblings, 0 replies; 36+ messages in thread From: CK Hu @ 2022-01-28 5:08 UTC (permalink / raw) To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi Hi, Xinlei: On Thu, 2022-01-27 at 19:42 +0800, xinlei.lee@mediatek.com wrote: > From: xinlei lee <xinlei.lee@mediatek.com> > > Add binding documentation for the MT8186 SoC. DPI has a yaml format document, so I would like DSI also has a yaml format document. Please send a patch to transfer DSI document to yaml, and then apply this patch to yaml document. Regards, CK > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> > --- > Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > index 36b0145..c82b8b2 100644 > --- > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > +++ > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.txt > @@ -7,7 +7,7 @@ channel output. > > Required properties: > - compatible: "mediatek,<chip>-dsi" > -- the supported chips are mt2701, mt7623, mt8167, mt8173 and mt8183. > +- the supported chips are mt2701, mt7623, mt8167, mt8173, mt8183 and > mt8186. > - reg: Physical base address and length of the controller's > registers > - interrupts: The interrupt signal from the function block. > - clocks: device clocks _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [v1, 1/3] dt-bindings: display: mediatek: dsi: add documentation for MT8186 SoC 2022-01-28 5:08 ` CK Hu (?) @ 2022-02-14 8:17 ` xinlei.lee -1 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-02-14 8:17 UTC (permalink / raw) To: CK Hu, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: jitao.shi, srv_heupstream, linux-kernel, dri-devel, Project_Global_Chrome_Upstream_Group, linux-mediatek, linux-arm-kernel On Fri, 2022-01-28 at 13:08 +0800, CK Hu wrote: > Hi, Xinlei: > > On Thu, 2022-01-27 at 19:42 +0800, xinlei.lee@mediatek.com wrote: > > From: xinlei lee <xinlei.lee@mediatek.com> > > > > Add binding documentation for the MT8186 SoC. > > DPI has a yaml format document, so I would like DSI also has a yaml > format document. > Please send a patch to transfer DSI document to yaml, and then apply > this patch to yaml document. > > Regards, > CK > Hi, CK: I have prepared DSI document to yaml, and will sent it out in the next edition. Thanks for your suggestion. Best Regards! xinlei > > > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> > > --- > > Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.tx > > t > > > 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.t > > xt > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.t > > xt > > index 36b0145..c82b8b2 100644 > > --- > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.t > > xt > > +++ > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.t > > xt > > @@ -7,7 +7,7 @@ channel output. > > > > Required properties: > > - compatible: "mediatek,<chip>-dsi" > > -- the supported chips are mt2701, mt7623, mt8167, mt8173 and > > mt8183. > > +- the supported chips are mt2701, mt7623, mt8167, mt8173, mt8183 > > and > > mt8186. > > - reg: Physical base address and length of the controller's > > registers > > - interrupts: The interrupt signal from the function block. > > - clocks: device clocks > > ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [v1, 1/3] dt-bindings: display: mediatek: dsi: add documentation for MT8186 SoC @ 2022-02-14 8:17 ` xinlei.lee 0 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-02-14 8:17 UTC (permalink / raw) To: CK Hu, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi, Project_Global_Chrome_Upstream_Group On Fri, 2022-01-28 at 13:08 +0800, CK Hu wrote: > Hi, Xinlei: > > On Thu, 2022-01-27 at 19:42 +0800, xinlei.lee@mediatek.com wrote: > > From: xinlei lee <xinlei.lee@mediatek.com> > > > > Add binding documentation for the MT8186 SoC. > > DPI has a yaml format document, so I would like DSI also has a yaml > format document. > Please send a patch to transfer DSI document to yaml, and then apply > this patch to yaml document. > > Regards, > CK > Hi, CK: I have prepared DSI document to yaml, and will sent it out in the next edition. Thanks for your suggestion. Best Regards! xinlei > > > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> > > --- > > Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.tx > > t > > > 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.t > > xt > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.t > > xt > > index 36b0145..c82b8b2 100644 > > --- > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.t > > xt > > +++ > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.t > > xt > > @@ -7,7 +7,7 @@ channel output. > > > > Required properties: > > - compatible: "mediatek,<chip>-dsi" > > -- the supported chips are mt2701, mt7623, mt8167, mt8173 and > > mt8183. > > +- the supported chips are mt2701, mt7623, mt8167, mt8173, mt8183 > > and > > mt8186. > > - reg: Physical base address and length of the controller's > > registers > > - interrupts: The interrupt signal from the function block. > > - clocks: device clocks > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [v1, 1/3] dt-bindings: display: mediatek: dsi: add documentation for MT8186 SoC @ 2022-02-14 8:17 ` xinlei.lee 0 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-02-14 8:17 UTC (permalink / raw) To: CK Hu, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi, Project_Global_Chrome_Upstream_Group On Fri, 2022-01-28 at 13:08 +0800, CK Hu wrote: > Hi, Xinlei: > > On Thu, 2022-01-27 at 19:42 +0800, xinlei.lee@mediatek.com wrote: > > From: xinlei lee <xinlei.lee@mediatek.com> > > > > Add binding documentation for the MT8186 SoC. > > DPI has a yaml format document, so I would like DSI also has a yaml > format document. > Please send a patch to transfer DSI document to yaml, and then apply > this patch to yaml document. > > Regards, > CK > Hi, CK: I have prepared DSI document to yaml, and will sent it out in the next edition. Thanks for your suggestion. Best Regards! xinlei > > > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> > > --- > > Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.tx > > t > > > 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.t > > xt > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.t > > xt > > index 36b0145..c82b8b2 100644 > > --- > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.t > > xt > > +++ > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dsi.t > > xt > > @@ -7,7 +7,7 @@ channel output. > > > > Required properties: > > - compatible: "mediatek,<chip>-dsi" > > -- the supported chips are mt2701, mt7623, mt8167, mt8173 and > > mt8183. > > +- the supported chips are mt2701, mt7623, mt8167, mt8173, mt8183 > > and > > mt8186. > > - reg: Physical base address and length of the controller's > > registers > > - interrupts: The interrupt signal from the function block. > > - clocks: device clocks > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 36+ messages in thread
* [v1,2/3] drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c 2022-01-27 11:42 ` xinlei.lee (?) (?) @ 2022-01-27 11:42 ` xinlei.lee -1 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-01-27 11:42 UTC (permalink / raw) To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi, xinlei lee From: xinlei lee <xinlei.lee@mediatek.com> Add the compatible of mt8186-dsi because we use different cmdq addresses in mt8186. Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index e91b3ff..62af60d 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -1151,6 +1151,12 @@ static const struct mtk_dsi_driver_data mt8183_dsi_driver_data = { .has_size_ctl = true, }; +static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = { + .reg_cmdq_off = 0xd00, + .has_shadow_ctl = true, + .has_size_ctl = true, +}; + static const struct of_device_id mtk_dsi_of_match[] = { { .compatible = "mediatek,mt2701-dsi", .data = &mt2701_dsi_driver_data }, @@ -1158,6 +1164,8 @@ static const struct of_device_id mtk_dsi_of_match[] = { .data = &mt8173_dsi_driver_data }, { .compatible = "mediatek,mt8183-dsi", .data = &mt8183_dsi_driver_data }, + { .compatible = "mediatek,mt8186-dsi", + .data = &mt8186_dsi_driver_data }, { }, }; MODULE_DEVICE_TABLE(of, mtk_dsi_of_match); -- 2.6.4 ^ permalink raw reply related [flat|nested] 36+ messages in thread
* [v1,2/3] drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c @ 2022-01-27 11:42 ` xinlei.lee 0 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-01-27 11:42 UTC (permalink / raw) To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: jitao.shi, xinlei lee, srv_heupstream, linux-kernel, dri-devel, linux-mediatek, linux-arm-kernel From: xinlei lee <xinlei.lee@mediatek.com> Add the compatible of mt8186-dsi because we use different cmdq addresses in mt8186. Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index e91b3ff..62af60d 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -1151,6 +1151,12 @@ static const struct mtk_dsi_driver_data mt8183_dsi_driver_data = { .has_size_ctl = true, }; +static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = { + .reg_cmdq_off = 0xd00, + .has_shadow_ctl = true, + .has_size_ctl = true, +}; + static const struct of_device_id mtk_dsi_of_match[] = { { .compatible = "mediatek,mt2701-dsi", .data = &mt2701_dsi_driver_data }, @@ -1158,6 +1164,8 @@ static const struct of_device_id mtk_dsi_of_match[] = { .data = &mt8173_dsi_driver_data }, { .compatible = "mediatek,mt8183-dsi", .data = &mt8183_dsi_driver_data }, + { .compatible = "mediatek,mt8186-dsi", + .data = &mt8186_dsi_driver_data }, { }, }; MODULE_DEVICE_TABLE(of, mtk_dsi_of_match); -- 2.6.4 ^ permalink raw reply related [flat|nested] 36+ messages in thread
* [v1,2/3] drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c @ 2022-01-27 11:42 ` xinlei.lee 0 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-01-27 11:42 UTC (permalink / raw) To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi, xinlei lee From: xinlei lee <xinlei.lee@mediatek.com> Add the compatible of mt8186-dsi because we use different cmdq addresses in mt8186. Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index e91b3ff..62af60d 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -1151,6 +1151,12 @@ static const struct mtk_dsi_driver_data mt8183_dsi_driver_data = { .has_size_ctl = true, }; +static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = { + .reg_cmdq_off = 0xd00, + .has_shadow_ctl = true, + .has_size_ctl = true, +}; + static const struct of_device_id mtk_dsi_of_match[] = { { .compatible = "mediatek,mt2701-dsi", .data = &mt2701_dsi_driver_data }, @@ -1158,6 +1164,8 @@ static const struct of_device_id mtk_dsi_of_match[] = { .data = &mt8173_dsi_driver_data }, { .compatible = "mediatek,mt8183-dsi", .data = &mt8183_dsi_driver_data }, + { .compatible = "mediatek,mt8186-dsi", + .data = &mt8186_dsi_driver_data }, { }, }; MODULE_DEVICE_TABLE(of, mtk_dsi_of_match); -- 2.6.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 36+ messages in thread
* [v1,2/3] drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c @ 2022-01-27 11:42 ` xinlei.lee 0 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-01-27 11:42 UTC (permalink / raw) To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi, xinlei lee From: xinlei lee <xinlei.lee@mediatek.com> Add the compatible of mt8186-dsi because we use different cmdq addresses in mt8186. Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index e91b3ff..62af60d 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -1151,6 +1151,12 @@ static const struct mtk_dsi_driver_data mt8183_dsi_driver_data = { .has_size_ctl = true, }; +static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = { + .reg_cmdq_off = 0xd00, + .has_shadow_ctl = true, + .has_size_ctl = true, +}; + static const struct of_device_id mtk_dsi_of_match[] = { { .compatible = "mediatek,mt2701-dsi", .data = &mt2701_dsi_driver_data }, @@ -1158,6 +1164,8 @@ static const struct of_device_id mtk_dsi_of_match[] = { .data = &mt8173_dsi_driver_data }, { .compatible = "mediatek,mt8183-dsi", .data = &mt8183_dsi_driver_data }, + { .compatible = "mediatek,mt8186-dsi", + .data = &mt8186_dsi_driver_data }, { }, }; MODULE_DEVICE_TABLE(of, mtk_dsi_of_match); -- 2.6.4 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 36+ messages in thread
* Re: [v1,2/3] drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c 2022-01-27 11:42 ` xinlei.lee (?) (?) @ 2022-01-28 5:10 ` CK Hu -1 siblings, 0 replies; 36+ messages in thread From: CK Hu @ 2022-01-28 5:10 UTC (permalink / raw) To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi Hi, Xinlei: On Thu, 2022-01-27 at 19:42 +0800, xinlei.lee@mediatek.com wrote: > From: xinlei lee <xinlei.lee@mediatek.com> > > Add the compatible of mt8186-dsi because we use different cmdq > addresses in mt8186. Reviewed-by: CK Hu <ck.hu@mediatek.com> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > b/drivers/gpu/drm/mediatek/mtk_dsi.c > index e91b3ff..62af60d 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -1151,6 +1151,12 @@ static const struct mtk_dsi_driver_data > mt8183_dsi_driver_data = { > .has_size_ctl = true, > }; > > +static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = { > + .reg_cmdq_off = 0xd00, > + .has_shadow_ctl = true, > + .has_size_ctl = true, > +}; > + > static const struct of_device_id mtk_dsi_of_match[] = { > { .compatible = "mediatek,mt2701-dsi", > .data = &mt2701_dsi_driver_data }, > @@ -1158,6 +1164,8 @@ static const struct of_device_id > mtk_dsi_of_match[] = { > .data = &mt8173_dsi_driver_data }, > { .compatible = "mediatek,mt8183-dsi", > .data = &mt8183_dsi_driver_data }, > + { .compatible = "mediatek,mt8186-dsi", > + .data = &mt8186_dsi_driver_data }, > { }, > }; > MODULE_DEVICE_TABLE(of, mtk_dsi_of_match); ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [v1,2/3] drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c @ 2022-01-28 5:10 ` CK Hu 0 siblings, 0 replies; 36+ messages in thread From: CK Hu @ 2022-01-28 5:10 UTC (permalink / raw) To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi Hi, Xinlei: On Thu, 2022-01-27 at 19:42 +0800, xinlei.lee@mediatek.com wrote: > From: xinlei lee <xinlei.lee@mediatek.com> > > Add the compatible of mt8186-dsi because we use different cmdq > addresses in mt8186. Reviewed-by: CK Hu <ck.hu@mediatek.com> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > b/drivers/gpu/drm/mediatek/mtk_dsi.c > index e91b3ff..62af60d 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -1151,6 +1151,12 @@ static const struct mtk_dsi_driver_data > mt8183_dsi_driver_data = { > .has_size_ctl = true, > }; > > +static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = { > + .reg_cmdq_off = 0xd00, > + .has_shadow_ctl = true, > + .has_size_ctl = true, > +}; > + > static const struct of_device_id mtk_dsi_of_match[] = { > { .compatible = "mediatek,mt2701-dsi", > .data = &mt2701_dsi_driver_data }, > @@ -1158,6 +1164,8 @@ static const struct of_device_id > mtk_dsi_of_match[] = { > .data = &mt8173_dsi_driver_data }, > { .compatible = "mediatek,mt8183-dsi", > .data = &mt8183_dsi_driver_data }, > + { .compatible = "mediatek,mt8186-dsi", > + .data = &mt8186_dsi_driver_data }, > { }, > }; > MODULE_DEVICE_TABLE(of, mtk_dsi_of_match); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [v1,2/3] drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c @ 2022-01-28 5:10 ` CK Hu 0 siblings, 0 replies; 36+ messages in thread From: CK Hu @ 2022-01-28 5:10 UTC (permalink / raw) To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: jitao.shi, srv_heupstream, linux-kernel, dri-devel, linux-mediatek, linux-arm-kernel Hi, Xinlei: On Thu, 2022-01-27 at 19:42 +0800, xinlei.lee@mediatek.com wrote: > From: xinlei lee <xinlei.lee@mediatek.com> > > Add the compatible of mt8186-dsi because we use different cmdq > addresses in mt8186. Reviewed-by: CK Hu <ck.hu@mediatek.com> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > b/drivers/gpu/drm/mediatek/mtk_dsi.c > index e91b3ff..62af60d 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -1151,6 +1151,12 @@ static const struct mtk_dsi_driver_data > mt8183_dsi_driver_data = { > .has_size_ctl = true, > }; > > +static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = { > + .reg_cmdq_off = 0xd00, > + .has_shadow_ctl = true, > + .has_size_ctl = true, > +}; > + > static const struct of_device_id mtk_dsi_of_match[] = { > { .compatible = "mediatek,mt2701-dsi", > .data = &mt2701_dsi_driver_data }, > @@ -1158,6 +1164,8 @@ static const struct of_device_id > mtk_dsi_of_match[] = { > .data = &mt8173_dsi_driver_data }, > { .compatible = "mediatek,mt8183-dsi", > .data = &mt8183_dsi_driver_data }, > + { .compatible = "mediatek,mt8186-dsi", > + .data = &mt8186_dsi_driver_data }, > { }, > }; > MODULE_DEVICE_TABLE(of, mtk_dsi_of_match); ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [v1,2/3] drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c @ 2022-01-28 5:10 ` CK Hu 0 siblings, 0 replies; 36+ messages in thread From: CK Hu @ 2022-01-28 5:10 UTC (permalink / raw) To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi Hi, Xinlei: On Thu, 2022-01-27 at 19:42 +0800, xinlei.lee@mediatek.com wrote: > From: xinlei lee <xinlei.lee@mediatek.com> > > Add the compatible of mt8186-dsi because we use different cmdq > addresses in mt8186. Reviewed-by: CK Hu <ck.hu@mediatek.com> > > Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > b/drivers/gpu/drm/mediatek/mtk_dsi.c > index e91b3ff..62af60d 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -1151,6 +1151,12 @@ static const struct mtk_dsi_driver_data > mt8183_dsi_driver_data = { > .has_size_ctl = true, > }; > > +static const struct mtk_dsi_driver_data mt8186_dsi_driver_data = { > + .reg_cmdq_off = 0xd00, > + .has_shadow_ctl = true, > + .has_size_ctl = true, > +}; > + > static const struct of_device_id mtk_dsi_of_match[] = { > { .compatible = "mediatek,mt2701-dsi", > .data = &mt2701_dsi_driver_data }, > @@ -1158,6 +1164,8 @@ static const struct of_device_id > mtk_dsi_of_match[] = { > .data = &mt8173_dsi_driver_data }, > { .compatible = "mediatek,mt8183-dsi", > .data = &mt8183_dsi_driver_data }, > + { .compatible = "mediatek,mt8186-dsi", > + .data = &mt8186_dsi_driver_data }, > { }, > }; > MODULE_DEVICE_TABLE(of, mtk_dsi_of_match); _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 36+ messages in thread
* [v1,3/3] drm/mediatek: Move the getting bridge node function to mtk_dsi_bind 2022-01-27 11:42 ` xinlei.lee (?) (?) @ 2022-01-27 11:42 ` xinlei.lee -1 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-01-27 11:42 UTC (permalink / raw) To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi, xinlei lee From: xinlei lee <xinlei.lee@mediatek.com> The order of probe function for bridge drivers and dsi drivers is uncertain. To avoid the dsi probe cannot be executed, we place getting bridge node function in mtk_dsi_bind. Signed-off-by:Xinlei Lee <xinlei.lee@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index 62af60d..a390f26 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -991,6 +991,21 @@ static int mtk_dsi_bind(struct device *dev, struct device *master, void *data) int ret; struct drm_device *drm = data; struct mtk_dsi *dsi = dev_get_drvdata(dev); + struct drm_panel *panel; + + ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, + &panel, &dsi->next_bridge); + if (ret) + return ret; + + if (panel) { + dsi->next_bridge = devm_drm_panel_bridge_add(dev, panel); + if (IS_ERR(dsi->next_bridge)) { + ret = PTR_ERR(dsi->next_bridge); + dev_err(dev, "failed to add bridge: %d\n", ret); + return ret; + } + } ret = mtk_dsi_encoder_init(drm, dsi); if (ret) @@ -1016,7 +1031,6 @@ static int mtk_dsi_probe(struct platform_device *pdev) { struct mtk_dsi *dsi; struct device *dev = &pdev->dev; - struct drm_panel *panel; struct resource *regs; int irq_num; int ret; @@ -1033,19 +1047,6 @@ static int mtk_dsi_probe(struct platform_device *pdev) return ret; } - ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, - &panel, &dsi->next_bridge); - if (ret) - goto err_unregister_host; - - if (panel) { - dsi->next_bridge = devm_drm_panel_bridge_add(dev, panel); - if (IS_ERR(dsi->next_bridge)) { - ret = PTR_ERR(dsi->next_bridge); - goto err_unregister_host; - } - } - dsi->driver_data = of_device_get_match_data(dev); dsi->engine_clk = devm_clk_get(dev, "engine"); -- 2.6.4 ^ permalink raw reply related [flat|nested] 36+ messages in thread
* [v1, 3/3] drm/mediatek: Move the getting bridge node function to mtk_dsi_bind @ 2022-01-27 11:42 ` xinlei.lee 0 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-01-27 11:42 UTC (permalink / raw) To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: jitao.shi, xinlei lee, srv_heupstream, linux-kernel, dri-devel, linux-mediatek, linux-arm-kernel From: xinlei lee <xinlei.lee@mediatek.com> The order of probe function for bridge drivers and dsi drivers is uncertain. To avoid the dsi probe cannot be executed, we place getting bridge node function in mtk_dsi_bind. Signed-off-by:Xinlei Lee <xinlei.lee@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index 62af60d..a390f26 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -991,6 +991,21 @@ static int mtk_dsi_bind(struct device *dev, struct device *master, void *data) int ret; struct drm_device *drm = data; struct mtk_dsi *dsi = dev_get_drvdata(dev); + struct drm_panel *panel; + + ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, + &panel, &dsi->next_bridge); + if (ret) + return ret; + + if (panel) { + dsi->next_bridge = devm_drm_panel_bridge_add(dev, panel); + if (IS_ERR(dsi->next_bridge)) { + ret = PTR_ERR(dsi->next_bridge); + dev_err(dev, "failed to add bridge: %d\n", ret); + return ret; + } + } ret = mtk_dsi_encoder_init(drm, dsi); if (ret) @@ -1016,7 +1031,6 @@ static int mtk_dsi_probe(struct platform_device *pdev) { struct mtk_dsi *dsi; struct device *dev = &pdev->dev; - struct drm_panel *panel; struct resource *regs; int irq_num; int ret; @@ -1033,19 +1047,6 @@ static int mtk_dsi_probe(struct platform_device *pdev) return ret; } - ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, - &panel, &dsi->next_bridge); - if (ret) - goto err_unregister_host; - - if (panel) { - dsi->next_bridge = devm_drm_panel_bridge_add(dev, panel); - if (IS_ERR(dsi->next_bridge)) { - ret = PTR_ERR(dsi->next_bridge); - goto err_unregister_host; - } - } - dsi->driver_data = of_device_get_match_data(dev); dsi->engine_clk = devm_clk_get(dev, "engine"); -- 2.6.4 ^ permalink raw reply related [flat|nested] 36+ messages in thread
* [v1, 3/3] drm/mediatek: Move the getting bridge node function to mtk_dsi_bind @ 2022-01-27 11:42 ` xinlei.lee 0 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-01-27 11:42 UTC (permalink / raw) To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi, xinlei lee From: xinlei lee <xinlei.lee@mediatek.com> The order of probe function for bridge drivers and dsi drivers is uncertain. To avoid the dsi probe cannot be executed, we place getting bridge node function in mtk_dsi_bind. Signed-off-by:Xinlei Lee <xinlei.lee@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index 62af60d..a390f26 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -991,6 +991,21 @@ static int mtk_dsi_bind(struct device *dev, struct device *master, void *data) int ret; struct drm_device *drm = data; struct mtk_dsi *dsi = dev_get_drvdata(dev); + struct drm_panel *panel; + + ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, + &panel, &dsi->next_bridge); + if (ret) + return ret; + + if (panel) { + dsi->next_bridge = devm_drm_panel_bridge_add(dev, panel); + if (IS_ERR(dsi->next_bridge)) { + ret = PTR_ERR(dsi->next_bridge); + dev_err(dev, "failed to add bridge: %d\n", ret); + return ret; + } + } ret = mtk_dsi_encoder_init(drm, dsi); if (ret) @@ -1016,7 +1031,6 @@ static int mtk_dsi_probe(struct platform_device *pdev) { struct mtk_dsi *dsi; struct device *dev = &pdev->dev; - struct drm_panel *panel; struct resource *regs; int irq_num; int ret; @@ -1033,19 +1047,6 @@ static int mtk_dsi_probe(struct platform_device *pdev) return ret; } - ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, - &panel, &dsi->next_bridge); - if (ret) - goto err_unregister_host; - - if (panel) { - dsi->next_bridge = devm_drm_panel_bridge_add(dev, panel); - if (IS_ERR(dsi->next_bridge)) { - ret = PTR_ERR(dsi->next_bridge); - goto err_unregister_host; - } - } - dsi->driver_data = of_device_get_match_data(dev); dsi->engine_clk = devm_clk_get(dev, "engine"); -- 2.6.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 36+ messages in thread
* [v1, 3/3] drm/mediatek: Move the getting bridge node function to mtk_dsi_bind @ 2022-01-27 11:42 ` xinlei.lee 0 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-01-27 11:42 UTC (permalink / raw) To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi, xinlei lee From: xinlei lee <xinlei.lee@mediatek.com> The order of probe function for bridge drivers and dsi drivers is uncertain. To avoid the dsi probe cannot be executed, we place getting bridge node function in mtk_dsi_bind. Signed-off-by:Xinlei Lee <xinlei.lee@mediatek.com> --- drivers/gpu/drm/mediatek/mtk_dsi.c | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index 62af60d..a390f26 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -991,6 +991,21 @@ static int mtk_dsi_bind(struct device *dev, struct device *master, void *data) int ret; struct drm_device *drm = data; struct mtk_dsi *dsi = dev_get_drvdata(dev); + struct drm_panel *panel; + + ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, + &panel, &dsi->next_bridge); + if (ret) + return ret; + + if (panel) { + dsi->next_bridge = devm_drm_panel_bridge_add(dev, panel); + if (IS_ERR(dsi->next_bridge)) { + ret = PTR_ERR(dsi->next_bridge); + dev_err(dev, "failed to add bridge: %d\n", ret); + return ret; + } + } ret = mtk_dsi_encoder_init(drm, dsi); if (ret) @@ -1016,7 +1031,6 @@ static int mtk_dsi_probe(struct platform_device *pdev) { struct mtk_dsi *dsi; struct device *dev = &pdev->dev; - struct drm_panel *panel; struct resource *regs; int irq_num; int ret; @@ -1033,19 +1047,6 @@ static int mtk_dsi_probe(struct platform_device *pdev) return ret; } - ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, - &panel, &dsi->next_bridge); - if (ret) - goto err_unregister_host; - - if (panel) { - dsi->next_bridge = devm_drm_panel_bridge_add(dev, panel); - if (IS_ERR(dsi->next_bridge)) { - ret = PTR_ERR(dsi->next_bridge); - goto err_unregister_host; - } - } - dsi->driver_data = of_device_get_match_data(dev); dsi->engine_clk = devm_clk_get(dev, "engine"); -- 2.6.4 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply related [flat|nested] 36+ messages in thread
* Re: [v1, 3/3] drm/mediatek: Move the getting bridge node function to mtk_dsi_bind 2022-01-27 11:42 ` xinlei.lee (?) (?) @ 2022-01-28 5:03 ` CK Hu -1 siblings, 0 replies; 36+ messages in thread From: CK Hu @ 2022-01-28 5:03 UTC (permalink / raw) To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi Hi, Xinlei: On Thu, 2022-01-27 at 19:42 +0800, xinlei.lee@mediatek.com wrote: > From: xinlei lee <xinlei.lee@mediatek.com> > > The order of probe function for bridge drivers and dsi drivers is > uncertain. > To avoid the dsi probe cannot be executed, we place getting bridge > node function in > mtk_dsi_bind. It seems this patch want to fix the same problem as [1]. Does [1] fix your problem? If so, let's ignore this patch. [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20220127143623.123025-1-angelogioacchino.delregno@collabora.com/ Regards, CK > > Signed-off-by:Xinlei Lee <xinlei.lee@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 29 +++++++++++++++------------- > - > 1 file changed, 15 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > b/drivers/gpu/drm/mediatek/mtk_dsi.c > index 62af60d..a390f26 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -991,6 +991,21 @@ static int mtk_dsi_bind(struct device *dev, > struct device *master, void *data) > int ret; > struct drm_device *drm = data; > struct mtk_dsi *dsi = dev_get_drvdata(dev); > + struct drm_panel *panel; > + > + ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > + &panel, &dsi->next_bridge); > + if (ret) > + return ret; > + > + if (panel) { > + dsi->next_bridge = devm_drm_panel_bridge_add(dev, > panel); > + if (IS_ERR(dsi->next_bridge)) { > + ret = PTR_ERR(dsi->next_bridge); > + dev_err(dev, "failed to add bridge: %d\n", > ret); > + return ret; > + } > + } > > ret = mtk_dsi_encoder_init(drm, dsi); > if (ret) > @@ -1016,7 +1031,6 @@ static int mtk_dsi_probe(struct platform_device > *pdev) > { > struct mtk_dsi *dsi; > struct device *dev = &pdev->dev; > - struct drm_panel *panel; > struct resource *regs; > int irq_num; > int ret; > @@ -1033,19 +1047,6 @@ static int mtk_dsi_probe(struct > platform_device *pdev) > return ret; > } > > - ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > - &panel, &dsi->next_bridge); > - if (ret) > - goto err_unregister_host; > - > - if (panel) { > - dsi->next_bridge = devm_drm_panel_bridge_add(dev, > panel); > - if (IS_ERR(dsi->next_bridge)) { > - ret = PTR_ERR(dsi->next_bridge); > - goto err_unregister_host; > - } > - } > - > dsi->driver_data = of_device_get_match_data(dev); > > dsi->engine_clk = devm_clk_get(dev, "engine"); ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [v1, 3/3] drm/mediatek: Move the getting bridge node function to mtk_dsi_bind @ 2022-01-28 5:03 ` CK Hu 0 siblings, 0 replies; 36+ messages in thread From: CK Hu @ 2022-01-28 5:03 UTC (permalink / raw) To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi Hi, Xinlei: On Thu, 2022-01-27 at 19:42 +0800, xinlei.lee@mediatek.com wrote: > From: xinlei lee <xinlei.lee@mediatek.com> > > The order of probe function for bridge drivers and dsi drivers is > uncertain. > To avoid the dsi probe cannot be executed, we place getting bridge > node function in > mtk_dsi_bind. It seems this patch want to fix the same problem as [1]. Does [1] fix your problem? If so, let's ignore this patch. [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20220127143623.123025-1-angelogioacchino.delregno@collabora.com/ Regards, CK > > Signed-off-by:Xinlei Lee <xinlei.lee@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 29 +++++++++++++++------------- > - > 1 file changed, 15 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > b/drivers/gpu/drm/mediatek/mtk_dsi.c > index 62af60d..a390f26 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -991,6 +991,21 @@ static int mtk_dsi_bind(struct device *dev, > struct device *master, void *data) > int ret; > struct drm_device *drm = data; > struct mtk_dsi *dsi = dev_get_drvdata(dev); > + struct drm_panel *panel; > + > + ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > + &panel, &dsi->next_bridge); > + if (ret) > + return ret; > + > + if (panel) { > + dsi->next_bridge = devm_drm_panel_bridge_add(dev, > panel); > + if (IS_ERR(dsi->next_bridge)) { > + ret = PTR_ERR(dsi->next_bridge); > + dev_err(dev, "failed to add bridge: %d\n", > ret); > + return ret; > + } > + } > > ret = mtk_dsi_encoder_init(drm, dsi); > if (ret) > @@ -1016,7 +1031,6 @@ static int mtk_dsi_probe(struct platform_device > *pdev) > { > struct mtk_dsi *dsi; > struct device *dev = &pdev->dev; > - struct drm_panel *panel; > struct resource *regs; > int irq_num; > int ret; > @@ -1033,19 +1047,6 @@ static int mtk_dsi_probe(struct > platform_device *pdev) > return ret; > } > > - ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > - &panel, &dsi->next_bridge); > - if (ret) > - goto err_unregister_host; > - > - if (panel) { > - dsi->next_bridge = devm_drm_panel_bridge_add(dev, > panel); > - if (IS_ERR(dsi->next_bridge)) { > - ret = PTR_ERR(dsi->next_bridge); > - goto err_unregister_host; > - } > - } > - > dsi->driver_data = of_device_get_match_data(dev); > > dsi->engine_clk = devm_clk_get(dev, "engine"); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [v1, 3/3] drm/mediatek: Move the getting bridge node function to mtk_dsi_bind @ 2022-01-28 5:03 ` CK Hu 0 siblings, 0 replies; 36+ messages in thread From: CK Hu @ 2022-01-28 5:03 UTC (permalink / raw) To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: jitao.shi, srv_heupstream, linux-kernel, dri-devel, linux-mediatek, linux-arm-kernel Hi, Xinlei: On Thu, 2022-01-27 at 19:42 +0800, xinlei.lee@mediatek.com wrote: > From: xinlei lee <xinlei.lee@mediatek.com> > > The order of probe function for bridge drivers and dsi drivers is > uncertain. > To avoid the dsi probe cannot be executed, we place getting bridge > node function in > mtk_dsi_bind. It seems this patch want to fix the same problem as [1]. Does [1] fix your problem? If so, let's ignore this patch. [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20220127143623.123025-1-angelogioacchino.delregno@collabora.com/ Regards, CK > > Signed-off-by:Xinlei Lee <xinlei.lee@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 29 +++++++++++++++------------- > - > 1 file changed, 15 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > b/drivers/gpu/drm/mediatek/mtk_dsi.c > index 62af60d..a390f26 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -991,6 +991,21 @@ static int mtk_dsi_bind(struct device *dev, > struct device *master, void *data) > int ret; > struct drm_device *drm = data; > struct mtk_dsi *dsi = dev_get_drvdata(dev); > + struct drm_panel *panel; > + > + ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > + &panel, &dsi->next_bridge); > + if (ret) > + return ret; > + > + if (panel) { > + dsi->next_bridge = devm_drm_panel_bridge_add(dev, > panel); > + if (IS_ERR(dsi->next_bridge)) { > + ret = PTR_ERR(dsi->next_bridge); > + dev_err(dev, "failed to add bridge: %d\n", > ret); > + return ret; > + } > + } > > ret = mtk_dsi_encoder_init(drm, dsi); > if (ret) > @@ -1016,7 +1031,6 @@ static int mtk_dsi_probe(struct platform_device > *pdev) > { > struct mtk_dsi *dsi; > struct device *dev = &pdev->dev; > - struct drm_panel *panel; > struct resource *regs; > int irq_num; > int ret; > @@ -1033,19 +1047,6 @@ static int mtk_dsi_probe(struct > platform_device *pdev) > return ret; > } > > - ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > - &panel, &dsi->next_bridge); > - if (ret) > - goto err_unregister_host; > - > - if (panel) { > - dsi->next_bridge = devm_drm_panel_bridge_add(dev, > panel); > - if (IS_ERR(dsi->next_bridge)) { > - ret = PTR_ERR(dsi->next_bridge); > - goto err_unregister_host; > - } > - } > - > dsi->driver_data = of_device_get_match_data(dev); > > dsi->engine_clk = devm_clk_get(dev, "engine"); ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [v1, 3/3] drm/mediatek: Move the getting bridge node function to mtk_dsi_bind @ 2022-01-28 5:03 ` CK Hu 0 siblings, 0 replies; 36+ messages in thread From: CK Hu @ 2022-01-28 5:03 UTC (permalink / raw) To: xinlei.lee, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi Hi, Xinlei: On Thu, 2022-01-27 at 19:42 +0800, xinlei.lee@mediatek.com wrote: > From: xinlei lee <xinlei.lee@mediatek.com> > > The order of probe function for bridge drivers and dsi drivers is > uncertain. > To avoid the dsi probe cannot be executed, we place getting bridge > node function in > mtk_dsi_bind. It seems this patch want to fix the same problem as [1]. Does [1] fix your problem? If so, let's ignore this patch. [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20220127143623.123025-1-angelogioacchino.delregno@collabora.com/ Regards, CK > > Signed-off-by:Xinlei Lee <xinlei.lee@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 29 +++++++++++++++------------- > - > 1 file changed, 15 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > b/drivers/gpu/drm/mediatek/mtk_dsi.c > index 62af60d..a390f26 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -991,6 +991,21 @@ static int mtk_dsi_bind(struct device *dev, > struct device *master, void *data) > int ret; > struct drm_device *drm = data; > struct mtk_dsi *dsi = dev_get_drvdata(dev); > + struct drm_panel *panel; > + > + ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > + &panel, &dsi->next_bridge); > + if (ret) > + return ret; > + > + if (panel) { > + dsi->next_bridge = devm_drm_panel_bridge_add(dev, > panel); > + if (IS_ERR(dsi->next_bridge)) { > + ret = PTR_ERR(dsi->next_bridge); > + dev_err(dev, "failed to add bridge: %d\n", > ret); > + return ret; > + } > + } > > ret = mtk_dsi_encoder_init(drm, dsi); > if (ret) > @@ -1016,7 +1031,6 @@ static int mtk_dsi_probe(struct platform_device > *pdev) > { > struct mtk_dsi *dsi; > struct device *dev = &pdev->dev; > - struct drm_panel *panel; > struct resource *regs; > int irq_num; > int ret; > @@ -1033,19 +1047,6 @@ static int mtk_dsi_probe(struct > platform_device *pdev) > return ret; > } > > - ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > - &panel, &dsi->next_bridge); > - if (ret) > - goto err_unregister_host; > - > - if (panel) { > - dsi->next_bridge = devm_drm_panel_bridge_add(dev, > panel); > - if (IS_ERR(dsi->next_bridge)) { > - ret = PTR_ERR(dsi->next_bridge); > - goto err_unregister_host; > - } > - } > - > dsi->driver_data = of_device_get_match_data(dev); > > dsi->engine_clk = devm_clk_get(dev, "engine"); _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 36+ messages in thread
* 答复: [v1, 3/3] drm/mediatek: Move the getting bridge node function to mtk_dsi_bind 2022-01-28 5:03 ` CK Hu @ 2022-01-28 5:37 ` Xinlei Lee (李昕磊) -1 siblings, 0 replies; 36+ messages in thread From: Xinlei Lee (李昕磊) @ 2022-01-28 5:37 UTC (permalink / raw) To: CK Hu (胡俊光), chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, Jitao Shi (石记涛), Rex-BC Chen (陳柏辰) Hi, CK: As you describe, these two patches modify the same thing, let's ignore this patch. Thanks for your suggestion. Best Regards, xinlei -----邮件原件----- 发件人: CK Hu [mailto:ck.hu@mediatek.com] 发送时间: 2022年1月28日 13:04 收件人: Xinlei Lee (李昕磊); chunkuang.hu@kernel.org; p.zabel@pengutronix.de; airlied@linux.ie; daniel@ffwll.ch; matthias.bgg@gmail.com 抄送: dri-devel@lists.freedesktop.org; linux-mediatek@lists.infradead.org; linux-arm-kernel@lists.infradead.org; srv_heupstream; linux-kernel@vger.kernel.org; Jitao Shi (石记涛) 主题: Re: [v1, 3/3] drm/mediatek: Move the getting bridge node function to mtk_dsi_bind Hi, Xinlei: On Thu, 2022-01-27 at 19:42 +0800, xinlei.lee@mediatek.com wrote: > From: xinlei lee <xinlei.lee@mediatek.com> > > The order of probe function for bridge drivers and dsi drivers is > uncertain. > To avoid the dsi probe cannot be executed, we place getting bridge > node function in mtk_dsi_bind. It seems this patch want to fix the same problem as [1]. Does [1] fix your problem? If so, let's ignore this patch. [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20220127143623.123025-1-angelogioacchino.delregno@collabora.com/ Regards, CK > > Signed-off-by:Xinlei Lee <xinlei.lee@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 29 +++++++++++++++------------- > - > 1 file changed, 15 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > b/drivers/gpu/drm/mediatek/mtk_dsi.c > index 62af60d..a390f26 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -991,6 +991,21 @@ static int mtk_dsi_bind(struct device *dev, > struct device *master, void *data) > int ret; > struct drm_device *drm = data; > struct mtk_dsi *dsi = dev_get_drvdata(dev); > + struct drm_panel *panel; > + > + ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > + &panel, &dsi->next_bridge); > + if (ret) > + return ret; > + > + if (panel) { > + dsi->next_bridge = devm_drm_panel_bridge_add(dev, > panel); > + if (IS_ERR(dsi->next_bridge)) { > + ret = PTR_ERR(dsi->next_bridge); > + dev_err(dev, "failed to add bridge: %d\n", > ret); > + return ret; > + } > + } > > ret = mtk_dsi_encoder_init(drm, dsi); > if (ret) > @@ -1016,7 +1031,6 @@ static int mtk_dsi_probe(struct platform_device > *pdev) > { > struct mtk_dsi *dsi; > struct device *dev = &pdev->dev; > - struct drm_panel *panel; > struct resource *regs; > int irq_num; > int ret; > @@ -1033,19 +1047,6 @@ static int mtk_dsi_probe(struct platform_device > *pdev) > return ret; > } > > - ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > - &panel, &dsi->next_bridge); > - if (ret) > - goto err_unregister_host; > - > - if (panel) { > - dsi->next_bridge = devm_drm_panel_bridge_add(dev, > panel); > - if (IS_ERR(dsi->next_bridge)) { > - ret = PTR_ERR(dsi->next_bridge); > - goto err_unregister_host; > - } > - } > - > dsi->driver_data = of_device_get_match_data(dev); > > dsi->engine_clk = devm_clk_get(dev, "engine"); ^ permalink raw reply [flat|nested] 36+ messages in thread
* 答复: [v1, 3/3] drm/mediatek: Move the getting bridge node function to mtk_dsi_bind @ 2022-01-28 5:37 ` Xinlei Lee (李昕磊) 0 siblings, 0 replies; 36+ messages in thread From: Xinlei Lee (李昕磊) @ 2022-01-28 5:37 UTC (permalink / raw) To: CK Hu (胡俊光), chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: Jitao Shi (石记涛), srv_heupstream, linux-kernel, dri-devel, linux-mediatek, Rex-BC Chen (陳柏辰), linux-arm-kernel [-- Attachment #1: Type: text/html, Size: 5834 bytes --] [-- Attachment #2: Type: text/plain, Size: 3215 bytes --] Hi, CK: As you describe, these two patches modify the same thing, let's ignore this patch. Thanks for your suggestion. Best Regards, xinlei -----邮件原件----- 发件人: CK Hu [mailto:ck.hu@mediatek.com] 发送时间: 2022年1月28日 13:04 收件人: Xinlei Lee (李昕磊); chunkuang.hu@kernel.org; p.zabel@pengutronix.de; airlied@linux.ie; daniel@ffwll.ch; matthias.bgg@gmail.com 抄送: dri-devel@lists.freedesktop.org; linux-mediatek@lists.infradead.org; linux-arm-kernel@lists.infradead.org; srv_heupstream; linux-kernel@vger.kernel.org; Jitao Shi (石记涛) 主题: Re: [v1, 3/3] drm/mediatek: Move the getting bridge node function to mtk_dsi_bind Hi, Xinlei: On Thu, 2022-01-27 at 19:42 +0800, xinlei.lee@mediatek.com wrote: > From: xinlei lee <xinlei.lee@mediatek.com> > > The order of probe function for bridge drivers and dsi drivers is > uncertain. > To avoid the dsi probe cannot be executed, we place getting bridge > node function in mtk_dsi_bind. It seems this patch want to fix the same problem as [1]. Does [1] fix your problem? If so, let's ignore this patch. [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20220127143623.123025-1-angelogioacchino.delregno@collabora.com/ Regards, CK > > Signed-off-by:Xinlei Lee <xinlei.lee@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 29 +++++++++++++++------------- > - > 1 file changed, 15 insertions(+), 14 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > b/drivers/gpu/drm/mediatek/mtk_dsi.c > index 62af60d..a390f26 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -991,6 +991,21 @@ static int mtk_dsi_bind(struct device *dev, > struct device *master, void *data) > int ret; > struct drm_device *drm = data; > struct mtk_dsi *dsi = dev_get_drvdata(dev); > + struct drm_panel *panel; > + > + ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > + &panel, &dsi->next_bridge); > + if (ret) > + return ret; > + > + if (panel) { > + dsi->next_bridge = devm_drm_panel_bridge_add(dev, > panel); > + if (IS_ERR(dsi->next_bridge)) { > + ret = PTR_ERR(dsi->next_bridge); > + dev_err(dev, "failed to add bridge: %d\n", > ret); > + return ret; > + } > + } > > ret = mtk_dsi_encoder_init(drm, dsi); > if (ret) > @@ -1016,7 +1031,6 @@ static int mtk_dsi_probe(struct platform_device > *pdev) > { > struct mtk_dsi *dsi; > struct device *dev = &pdev->dev; > - struct drm_panel *panel; > struct resource *regs; > int irq_num; > int ret; > @@ -1033,19 +1047,6 @@ static int mtk_dsi_probe(struct platform_device > *pdev) > return ret; > } > > - ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > - &panel, &dsi->next_bridge); > - if (ret) > - goto err_unregister_host; > - > - if (panel) { > - dsi->next_bridge = devm_drm_panel_bridge_add(dev, > panel); > - if (IS_ERR(dsi->next_bridge)) { > - ret = PTR_ERR(dsi->next_bridge); > - goto err_unregister_host; > - } > - } > - > dsi->driver_data = of_device_get_match_data(dev); > > dsi->engine_clk = devm_clk_get(dev, "engine"); ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [v1, 3/3] drm/mediatek: Move the getting bridge node function to mtk_dsi_bind 2022-01-28 5:03 ` CK Hu (?) @ 2022-02-14 8:10 ` xinlei.lee -1 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-02-14 8:10 UTC (permalink / raw) To: CK Hu, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: jitao.shi, srv_heupstream, linux-kernel, dri-devel, linux-mediatek, Project_Global_Chrome_Upstream_ Group, linux-arm-kernel On Fri, 2022-01-28 at 13:03 +0800, CK Hu wrote: > Hi, Xinlei: > > On Thu, 2022-01-27 at 19:42 +0800, xinlei.lee@mediatek.com wrote: > > From: xinlei lee <xinlei.lee@mediatek.com> > > > > The order of probe function for bridge drivers and dsi drivers is > > uncertain. > > To avoid the dsi probe cannot be executed, we place getting bridge > > node function in > > mtk_dsi_bind. > > It seems this patch want to fix the same problem as [1]. Does [1] fix > your problem? If so, let's ignore this patch. > > [1] > https://patchwork.kernel.org/project/linux-mediatek/patch/20220127143623.123025-1-angelogioacchino.delregno@collabora.com/ > > Regards, > CK > Hi, CK: As you describe,these two patches modify the same thing,we can ignore this patch. Thanks for your suggestion. Best Regards! xinlei > > > > Signed-off-by:Xinlei Lee <xinlei.lee@mediatek.com> > > --- > > drivers/gpu/drm/mediatek/mtk_dsi.c | 29 +++++++++++++++----------- > > -- > > - > > 1 file changed, 15 insertions(+), 14 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > > b/drivers/gpu/drm/mediatek/mtk_dsi.c > > index 62af60d..a390f26 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > > @@ -991,6 +991,21 @@ static int mtk_dsi_bind(struct device *dev, > > struct device *master, void *data) > > int ret; > > struct drm_device *drm = data; > > struct mtk_dsi *dsi = dev_get_drvdata(dev); > > + struct drm_panel *panel; > > + > > + ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > > + &panel, &dsi->next_bridge); > > + if (ret) > > + return ret; > > + > > + if (panel) { > > + dsi->next_bridge = devm_drm_panel_bridge_add(dev, > > panel); > > + if (IS_ERR(dsi->next_bridge)) { > > + ret = PTR_ERR(dsi->next_bridge); > > + dev_err(dev, "failed to add bridge: %d\n", > > ret); > > + return ret; > > + } > > + } > > > > ret = mtk_dsi_encoder_init(drm, dsi); > > if (ret) > > @@ -1016,7 +1031,6 @@ static int mtk_dsi_probe(struct > > platform_device > > *pdev) > > { > > struct mtk_dsi *dsi; > > struct device *dev = &pdev->dev; > > - struct drm_panel *panel; > > struct resource *regs; > > int irq_num; > > int ret; > > @@ -1033,19 +1047,6 @@ static int mtk_dsi_probe(struct > > platform_device *pdev) > > return ret; > > } > > > > - ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > > - &panel, &dsi->next_bridge); > > - if (ret) > > - goto err_unregister_host; > > - > > - if (panel) { > > - dsi->next_bridge = devm_drm_panel_bridge_add(dev, > > panel); > > - if (IS_ERR(dsi->next_bridge)) { > > - ret = PTR_ERR(dsi->next_bridge); > > - goto err_unregister_host; > > - } > > - } > > - > > dsi->driver_data = of_device_get_match_data(dev); > > > > dsi->engine_clk = devm_clk_get(dev, "engine"); > > ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [v1, 3/3] drm/mediatek: Move the getting bridge node function to mtk_dsi_bind @ 2022-02-14 8:10 ` xinlei.lee 0 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-02-14 8:10 UTC (permalink / raw) To: CK Hu, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi, Project_Global_Chrome_Upstream_ Group On Fri, 2022-01-28 at 13:03 +0800, CK Hu wrote: > Hi, Xinlei: > > On Thu, 2022-01-27 at 19:42 +0800, xinlei.lee@mediatek.com wrote: > > From: xinlei lee <xinlei.lee@mediatek.com> > > > > The order of probe function for bridge drivers and dsi drivers is > > uncertain. > > To avoid the dsi probe cannot be executed, we place getting bridge > > node function in > > mtk_dsi_bind. > > It seems this patch want to fix the same problem as [1]. Does [1] fix > your problem? If so, let's ignore this patch. > > [1] > https://patchwork.kernel.org/project/linux-mediatek/patch/20220127143623.123025-1-angelogioacchino.delregno@collabora.com/ > > Regards, > CK > Hi, CK: As you describe,these two patches modify the same thing,we can ignore this patch. Thanks for your suggestion. Best Regards! xinlei > > > > Signed-off-by:Xinlei Lee <xinlei.lee@mediatek.com> > > --- > > drivers/gpu/drm/mediatek/mtk_dsi.c | 29 +++++++++++++++----------- > > -- > > - > > 1 file changed, 15 insertions(+), 14 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > > b/drivers/gpu/drm/mediatek/mtk_dsi.c > > index 62af60d..a390f26 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > > @@ -991,6 +991,21 @@ static int mtk_dsi_bind(struct device *dev, > > struct device *master, void *data) > > int ret; > > struct drm_device *drm = data; > > struct mtk_dsi *dsi = dev_get_drvdata(dev); > > + struct drm_panel *panel; > > + > > + ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > > + &panel, &dsi->next_bridge); > > + if (ret) > > + return ret; > > + > > + if (panel) { > > + dsi->next_bridge = devm_drm_panel_bridge_add(dev, > > panel); > > + if (IS_ERR(dsi->next_bridge)) { > > + ret = PTR_ERR(dsi->next_bridge); > > + dev_err(dev, "failed to add bridge: %d\n", > > ret); > > + return ret; > > + } > > + } > > > > ret = mtk_dsi_encoder_init(drm, dsi); > > if (ret) > > @@ -1016,7 +1031,6 @@ static int mtk_dsi_probe(struct > > platform_device > > *pdev) > > { > > struct mtk_dsi *dsi; > > struct device *dev = &pdev->dev; > > - struct drm_panel *panel; > > struct resource *regs; > > int irq_num; > > int ret; > > @@ -1033,19 +1047,6 @@ static int mtk_dsi_probe(struct > > platform_device *pdev) > > return ret; > > } > > > > - ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > > - &panel, &dsi->next_bridge); > > - if (ret) > > - goto err_unregister_host; > > - > > - if (panel) { > > - dsi->next_bridge = devm_drm_panel_bridge_add(dev, > > panel); > > - if (IS_ERR(dsi->next_bridge)) { > > - ret = PTR_ERR(dsi->next_bridge); > > - goto err_unregister_host; > > - } > > - } > > - > > dsi->driver_data = of_device_get_match_data(dev); > > > > dsi->engine_clk = devm_clk_get(dev, "engine"); > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 36+ messages in thread
* Re: [v1, 3/3] drm/mediatek: Move the getting bridge node function to mtk_dsi_bind @ 2022-02-14 8:10 ` xinlei.lee 0 siblings, 0 replies; 36+ messages in thread From: xinlei.lee @ 2022-02-14 8:10 UTC (permalink / raw) To: CK Hu, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg Cc: dri-devel, linux-mediatek, linux-arm-kernel, srv_heupstream, linux-kernel, jitao.shi, Project_Global_Chrome_Upstream_ Group On Fri, 2022-01-28 at 13:03 +0800, CK Hu wrote: > Hi, Xinlei: > > On Thu, 2022-01-27 at 19:42 +0800, xinlei.lee@mediatek.com wrote: > > From: xinlei lee <xinlei.lee@mediatek.com> > > > > The order of probe function for bridge drivers and dsi drivers is > > uncertain. > > To avoid the dsi probe cannot be executed, we place getting bridge > > node function in > > mtk_dsi_bind. > > It seems this patch want to fix the same problem as [1]. Does [1] fix > your problem? If so, let's ignore this patch. > > [1] > https://patchwork.kernel.org/project/linux-mediatek/patch/20220127143623.123025-1-angelogioacchino.delregno@collabora.com/ > > Regards, > CK > Hi, CK: As you describe,these two patches modify the same thing,we can ignore this patch. Thanks for your suggestion. Best Regards! xinlei > > > > Signed-off-by:Xinlei Lee <xinlei.lee@mediatek.com> > > --- > > drivers/gpu/drm/mediatek/mtk_dsi.c | 29 +++++++++++++++----------- > > -- > > - > > 1 file changed, 15 insertions(+), 14 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c > > b/drivers/gpu/drm/mediatek/mtk_dsi.c > > index 62af60d..a390f26 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > > @@ -991,6 +991,21 @@ static int mtk_dsi_bind(struct device *dev, > > struct device *master, void *data) > > int ret; > > struct drm_device *drm = data; > > struct mtk_dsi *dsi = dev_get_drvdata(dev); > > + struct drm_panel *panel; > > + > > + ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > > + &panel, &dsi->next_bridge); > > + if (ret) > > + return ret; > > + > > + if (panel) { > > + dsi->next_bridge = devm_drm_panel_bridge_add(dev, > > panel); > > + if (IS_ERR(dsi->next_bridge)) { > > + ret = PTR_ERR(dsi->next_bridge); > > + dev_err(dev, "failed to add bridge: %d\n", > > ret); > > + return ret; > > + } > > + } > > > > ret = mtk_dsi_encoder_init(drm, dsi); > > if (ret) > > @@ -1016,7 +1031,6 @@ static int mtk_dsi_probe(struct > > platform_device > > *pdev) > > { > > struct mtk_dsi *dsi; > > struct device *dev = &pdev->dev; > > - struct drm_panel *panel; > > struct resource *regs; > > int irq_num; > > int ret; > > @@ -1033,19 +1047,6 @@ static int mtk_dsi_probe(struct > > platform_device *pdev) > > return ret; > > } > > > > - ret = drm_of_find_panel_or_bridge(dev->of_node, 0, 0, > > - &panel, &dsi->next_bridge); > > - if (ret) > > - goto err_unregister_host; > > - > > - if (panel) { > > - dsi->next_bridge = devm_drm_panel_bridge_add(dev, > > panel); > > - if (IS_ERR(dsi->next_bridge)) { > > - ret = PTR_ERR(dsi->next_bridge); > > - goto err_unregister_host; > > - } > > - } > > - > > dsi->driver_data = of_device_get_match_data(dev); > > > > dsi->engine_clk = devm_clk_get(dev, "engine"); > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 36+ messages in thread
end of thread, other threads:[~2022-02-14 8:41 UTC | newest] Thread overview: 36+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-01-27 11:42 [v1,0/3] Add mt8186 dsi compatoble & Move the getting bridge node function xinlei.lee 2022-01-27 11:42 ` [v1, 0/3] " xinlei.lee 2022-01-27 11:42 ` xinlei.lee 2022-01-27 11:42 ` xinlei.lee 2022-01-27 11:42 ` [v1,1/3] dt-bindings: display: mediatek: dsi: add documentation for MT8186 SoC xinlei.lee 2022-01-27 11:42 ` [v1, 1/3] " xinlei.lee 2022-01-27 11:42 ` xinlei.lee 2022-01-27 11:42 ` xinlei.lee 2022-01-28 5:08 ` CK Hu 2022-01-28 5:08 ` CK Hu 2022-01-28 5:08 ` CK Hu 2022-01-28 5:08 ` CK Hu 2022-02-14 8:17 ` xinlei.lee 2022-02-14 8:17 ` xinlei.lee 2022-02-14 8:17 ` xinlei.lee 2022-01-27 11:42 ` [v1,2/3] drm/mediatek: Add mt8186 dsi compatible to mtk_dsi.c xinlei.lee 2022-01-27 11:42 ` xinlei.lee 2022-01-27 11:42 ` xinlei.lee 2022-01-27 11:42 ` xinlei.lee 2022-01-28 5:10 ` CK Hu 2022-01-28 5:10 ` CK Hu 2022-01-28 5:10 ` CK Hu 2022-01-28 5:10 ` CK Hu 2022-01-27 11:42 ` [v1,3/3] drm/mediatek: Move the getting bridge node function to mtk_dsi_bind xinlei.lee 2022-01-27 11:42 ` [v1, 3/3] " xinlei.lee 2022-01-27 11:42 ` xinlei.lee 2022-01-27 11:42 ` xinlei.lee 2022-01-28 5:03 ` CK Hu 2022-01-28 5:03 ` CK Hu 2022-01-28 5:03 ` CK Hu 2022-01-28 5:03 ` CK Hu 2022-01-28 5:37 ` 答复: " Xinlei Lee (李昕磊) 2022-01-28 5:37 ` Xinlei Lee (李昕磊) 2022-02-14 8:10 ` xinlei.lee 2022-02-14 8:10 ` xinlei.lee 2022-02-14 8:10 ` xinlei.lee
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.