All of lore.kernel.org
 help / color / mirror / Atom feed
* AW: [PATCH v5] Input: add bu21029 touch driver
@ 2018-06-15 14:28 Jonas Mark (BT-FIR/ENG1)
  0 siblings, 0 replies; 2+ messages in thread
From: Jonas Mark (BT-FIR/ENG1) @ 2018-06-15 14:28 UTC (permalink / raw)
  To: Dmitry Torokhov
  Cc: Rob Herring, Mark Rutland, linux-input, devicetree, linux-kernel,
	hs, andy.shevchenko, D_ZHU Yi (BT-FIR/ENG1-Zhu),
	ZHANG Kevin (BT-FIR/ENG1-Zhu),
	Zhu Yi, RUAN Tingquan (BT-FIR/ENG1-Zhu)

Hi,

Correction:

> Only for 4.14 an #include <linux/regulator/consumer.h> was missing. I
> Guess the API changed here a little in the meantime.

The missing include is #include <linux/irq.h>.

Greetings,
Mark

Building Technologies, Panel Software Fire (BT-FIR/ENG1)
Bosch Sicherheitssysteme GmbH | Postfach 11 11 | 85626 Grasbrunn | GERMANY | www.boschsecurity.com

Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart HRB 23118
Aufsichtsratsvorsitzender: Stefan Hartung; Geschäftsführung: Gert van Iperen, Andreas Bartz, Thomas Quante, Bernhard Schuster

^ permalink raw reply	[flat|nested] 2+ messages in thread

* AW: [PATCH v5] Input: add bu21029 touch driver
  2018-06-13 22:20 ` Dmitry Torokhov
@ 2018-06-14 16:23   ` Jonas Mark (BT-FIR/ENG1)
  0 siblings, 0 replies; 2+ messages in thread
From: Jonas Mark (BT-FIR/ENG1) @ 2018-06-14 16:23 UTC (permalink / raw)
  To: Dmitry Torokhov
  Cc: Rob Herring, Mark Rutland, linux-input, devicetree, linux-kernel,
	hs, andy.shevchenko, ZHU Yi (BT-FIR/ENG1-Zhu),
	ZHANG Kevin (BT-FIR/ENG1-Zhu), Zhu Yi, Jonas Mark (BT-FIR/ENG1)

Hello Dmitry,

> Sorry for the delay. Could you please tell me if the patch below (shoudl
> apply on top of your v5 version) works?

The patch applies cleanly and we will give the code a thorough test.

> diff --git a/Documentation/devicetree/bindings/input/touchscreen/bu21029.txt
> b/Documentation/devicetree/bindings/input/touchscreen/bu21029.txt
> index 030a888365dff..1aaa647cc3eaa 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/bu21029.txt
> +++ b/Documentation/devicetree/bindings/input/touchscreen/bu21029.txt
> @@ -5,13 +5,14 @@ Required properties:
>   - reg                     : i2c device address of the chip (0x40 or 0x41)
>   - interrupt-parent        : the phandle for the gpio controller
>   - interrupts              : (gpio) interrupt to which the chip is connected
> - - reset-gpios             : gpio pin to reset the chip (active low)
>   - rohm,x-plate-ohms       : x-plate resistance in Ohm
> 
>  Optional properties:
> + - reset-gpios             : gpio pin to reset the chip (active low)
>   - touchscreen-size-x      : horizontal resolution of touchscreen (in pixels)
>   - touchscreen-size-y      : vertical resolution of touchscreen (in pixels)
>   - touchscreen-max-pressure: maximum pressure value
> + - vdd-supply              : power supply for the controoler

There is a typo in controller.

Greetings,
Mark

Building Technologies, Panel Software Fire (BT-FIR/ENG1) 
Bosch Sicherheitssysteme GmbH | Postfach 11 11 | 85626 Grasbrunn | GERMANY | www.boschsecurity.com

Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart HRB 23118 
Aufsichtsratsvorsitzender: Stefan Hartung; Geschäftsführung: Gert van Iperen, Andreas Bartz, Thomas Quante, Bernhard Schuster

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-06-15 14:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-15 14:28 AW: [PATCH v5] Input: add bu21029 touch driver Jonas Mark (BT-FIR/ENG1)
  -- strict thread matches above, loose matches on Subject: below --
2018-06-13 15:27 Jonas Mark (BT-FIR/ENG1)
2018-06-13 22:20 ` Dmitry Torokhov
2018-06-14 16:23   ` AW: " Jonas Mark (BT-FIR/ENG1)

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.