All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Anderson <seanga2@gmail.com>
To: Samuel Holland <samuel@sholland.org>,
	u-boot@lists.denx.de, Jagan Teki <jagan@amarulasolutions.com>,
	Andre Przywara <andre.przywara@arm.com>,
	Lukasz Majewski <lukma@denx.de>
Cc: Bin Meng <bmeng.cn@gmail.com>,
	Heinrich Schuchardt <xypron.glpk@gmx.de>,
	Maxime Ripard <maxime.ripard@bootlin.com>
Subject: Re: [PATCH 0/7] clk: sunxi: Out-of-bounds access fix and driver cleanup
Date: Wed, 11 May 2022 11:48:47 -0400	[thread overview]
Message-ID: <2a6ea152-3143-4f06-66ff-110c568cab55@gmail.com> (raw)
In-Reply-To: <20220509052937.42283-1-samuel@sholland.org>

On 5/9/22 1:29 AM, Samuel Holland wrote:
> This series fixes an issue with out-of-bounds access to the gate array
> (patches 1-2), uses the rearranged array size information to remove a
> bunch of duplicate code (patches 3-4), and then simplifies how the reset
> driver is bound (patches 5-7).
> 
> The original motivation for these changes was adding a driver for the
> legacy A31/A23/A33 PRCM binding (which I will send separately), and
> trying to use OF_PLATDATA in SPL (which did not work out). But I think
> at least some of the cleanup is worth applying on its own.
> 
> Patch 4 is generally the same change I made between v1 and v2 of the
> pinctrl series, using some #ifdefs to share a U_BOOT_DRIVER. It's not
> quite as clean as the pinctrl case, because here the SoC-specific parts
> are in different files, so all of the CCU descriptors have to be global.
> 
> 
> Samuel Holland (7):
>    clk: sunxi: Store the array sizes in the CCU descriptor
>    clk: sunxi: Prevent out-of-bounds gate array access
>    reset: sunxi: Get the reset count from the CCU descriptor
>    clk: sunxi: Use a single driver for all variants
>    clk: sunxi: Convert driver private data to platform data
>    reset: sunxi: Convert driver private data to platform data
>    reset: sunxi: Reuse the platform data from the clock driver
> 
>   drivers/clk/sunxi/clk_a10.c   |  27 +-----
>   drivers/clk/sunxi/clk_a10s.c  |  27 +-----
>   drivers/clk/sunxi/clk_a23.c   |  27 +-----
>   drivers/clk/sunxi/clk_a31.c   |  25 +----
>   drivers/clk/sunxi/clk_a31_r.c |  29 +-----
>   drivers/clk/sunxi/clk_a64.c   |  25 +----
>   drivers/clk/sunxi/clk_a80.c   |  36 ++------
>   drivers/clk/sunxi/clk_a83t.c  |  25 +----
>   drivers/clk/sunxi/clk_h3.c    |  27 +-----
>   drivers/clk/sunxi/clk_h6.c    |  25 +----
>   drivers/clk/sunxi/clk_h616.c  |  25 +----
>   drivers/clk/sunxi/clk_h6_r.c  |  27 +-----
>   drivers/clk/sunxi/clk_r40.c   |  25 +----
>   drivers/clk/sunxi/clk_sunxi.c | 168 ++++++++++++++++++++++++++++++----
>   drivers/clk/sunxi/clk_v3s.c   |  27 +-----
>   drivers/reset/reset-sunxi.c   |  55 ++---------
>   include/clk/sunxi.h           |  21 +----
>   17 files changed, 208 insertions(+), 413 deletions(-)
> 

For this series:

Acked-by: Sean Anderson <seanga2@gmail.com>

  parent reply	other threads:[~2022-05-11 15:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09  5:29 [PATCH 0/7] clk: sunxi: Out-of-bounds access fix and driver cleanup Samuel Holland
2022-05-09  5:29 ` [PATCH 1/7] clk: sunxi: Store the array sizes in the CCU descriptor Samuel Holland
2022-06-25 17:10   ` Andre Przywara
2022-05-09  5:29 ` [PATCH 2/7] clk: sunxi: Prevent out-of-bounds gate array access Samuel Holland
2022-06-26 10:43   ` Andre Przywara
2022-05-09  5:29 ` [PATCH 3/7] reset: sunxi: Get the reset count from the CCU descriptor Samuel Holland
2022-06-26 10:51   ` Andre Przywara
2022-05-09  5:29 ` [PATCH 4/7] clk: sunxi: Use a single driver for all variants Samuel Holland
2022-06-27  0:43   ` Andre Przywara
2022-05-09  5:29 ` [PATCH 5/7] clk: sunxi: Convert driver private data to platform data Samuel Holland
2022-06-27 19:34   ` Andre Przywara
2022-05-09  5:29 ` [PATCH 6/7] reset: " Samuel Holland
2022-06-27 19:41   ` Andre Przywara
2022-05-09  5:29 ` [PATCH 7/7] reset: sunxi: Reuse the platform data from the clock driver Samuel Holland
2022-06-27 23:45   ` Andre Przywara
2022-05-10 23:24 ` [PATCH 0/7] clk: sunxi: Out-of-bounds access fix and driver cleanup Andre Przywara
2022-05-11 15:48 ` Sean Anderson [this message]
2022-06-28  0:40 ` Andre Przywara
2022-06-28  2:45   ` Samuel Holland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2a6ea152-3143-4f06-66ff-110c568cab55@gmail.com \
    --to=seanga2@gmail.com \
    --cc=andre.przywara@arm.com \
    --cc=bmeng.cn@gmail.com \
    --cc=jagan@amarulasolutions.com \
    --cc=lukma@denx.de \
    --cc=maxime.ripard@bootlin.com \
    --cc=samuel@sholland.org \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.