Re: [PATCH 0/7] clk: sunxi: Out-of-bounds access fix and driver cleanup

[Samuel Holland <samuel@sholland.org>]

Hi Andre,

On 6/27/22 7:40 PM, Andre Przywara wrote:
> On Mon,  9 May 2022 00:29:30 -0500
> Samuel Holland <samuel@sholland.org> wrote:
> 
> Hi Samuel,
> 
>> This series fixes an issue with out-of-bounds access to the gate array
>> (patches 1-2), uses the rearranged array size information to remove a
>> bunch of duplicate code (patches 3-4), and then simplifies how the reset
>> driver is bound (patches 5-7).
>>
>> The original motivation for these changes was adding a driver for the
>> legacy A31/A23/A33 PRCM binding (which I will send separately), and
>> trying to use OF_PLATDATA in SPL (which did not work out). But I think
>> at least some of the cleanup is worth applying on its own.
>>
>> Patch 4 is generally the same change I made between v1 and v2 of the
>> pinctrl series, using some #ifdefs to share a U_BOOT_DRIVER. It's not
>> quite as clean as the pinctrl case, because here the SoC-specific parts
>> are in different files, so all of the CCU descriptors have to be global.
> 
> Many thanks for your work on this!
> So I am done with reviewing this series, and as mentioned quite like it
> and am fine with it. I added F1C100s support, which got added in U-Boot
> meanwhile, and pushed that to sunxi/next:
> https://source.denx.de/u-boot/custodians/u-boot-sunxi/-/commits/next/
> 
> Can you please have a look and confirm that this is fine? I will then
> send the PR in about two weeks time, if nothing breaks.

Looks good to me, and thanks for taking care of F1C100s. My only trivial comment
is that you left out Sean's ack.

Regards,
Samuel