From: Guenter Roeck <linux@roeck-us.net> To: Jaghathiswari Rankappagounder Natarajan <jaghu@google.com>, joel@jms.id.au, jdelvare@suse.com, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, corbet@lwn.net, linux-doc@vger.kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, devicetree@vger.kernel.org Subject: Re: [PATCH linux v6 1/2] Documentation: dt-bindings: Document bindings for ASPEED AST2400/AST2500 PWM and Fan tach controller device driver Date: Tue, 4 Apr 2017 05:52:29 -0700 [thread overview] Message-ID: <2a7035fe-25ac-e0da-4f18-958eb20a1dc8@roeck-us.net> (raw) In-Reply-To: <20170403233025.26952-2-jaghu@google.com> On 04/03/2017 04:30 PM, Jaghathiswari Rankappagounder Natarajan wrote: > This binding provides interface for adding values related to ASPEED > AST2400/2500 PWM and Fan tach controller support. > The PWM controller can support upto 8 PWM output ports. > The Fan tach controller can support upto 16 tachometer inputs. > > Signed-off-by: Jaghathiswari Rankappagounder Natarajan <jaghu@google.com> Applied with Acked-by: From Rob (for v5 with the requested changes made). Thanks, Guenter > --- > v6: > - Changed to aspeed,fan-tach-ch > > v5: > - Changed the naming scheme to aspeed,ast2400/2500-pwm-tacho > - Removed gpio pin muxing > - Added aspeed vendor prefix for fan-tach-ch > - Changed to fan@0/1 > - Changed reg to 32 bits > > v4: > - Used 'reg' > > v3: > - Made the structure more common > > v2: > - Removed '_' in node and property names > - Gave some explanation for the properties used > > .../devicetree/bindings/hwmon/aspeed-pwm-tacho.txt | 68 ++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt > > diff --git a/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt b/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt > new file mode 100644 > index 000000000000..ac0a69ab0755 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt > @@ -0,0 +1,68 @@ > +ASPEED AST2400/AST2500 PWM and Fan Tacho controller device driver > + > +The ASPEED PWM controller can support upto 8 PWM outputs. The ASPEED Fan Tacho > +controller can support upto 16 Fan tachometer inputs. > + > +There can be upto 8 fans supported. Each fan can have one PWM output and > +one/two Fan tach inputs. > + > +Required properties for pwm-tacho node: > +- #address-cells : should be 1. > + > +- #size-cells : should be 1. > + > +- reg : address and length of the register set for the device. > + > +- pinctrl-names : a pinctrl state named "default" must be defined. > + > +- pinctrl-0 : phandle referencing pin configuration of the PWM ports. > + > +- compatible : should be "aspeed,ast2400-pwm-tacho" for AST2400 and > + "aspeed,ast2500-pwm-tacho" for AST2500. > + > +- clocks : a fixed clock providing input clock frequency(PWM > + and Fan Tach clock) > + > +fan subnode format: > +=================== > +Under fan subnode there can upto 8 child nodes, with each child node > +representing a fan. If there are 8 fans each fan can have one PWM port and > +one/two Fan tach inputs. > + > +Required properties for each child node: > +- reg : should specify PWM source port. > + integer value in the range 0 to 7 with 0 indicating PWM port A and > + 7 indicating PWM port H. > + > +- aspeed,fan-tach-ch : should specify the Fan tach input channel. > + integer value in the range 0 through 15, with 0 indicating > + Fan tach channel 0 and 15 indicating Fan tach channel 15. > + Atleast one Fan tach input channel is required. > + > +Examples: > + > +pwm_tacho_fixed_clk: fixedclk { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <24000000>; > +} > + > +pwm_tacho: pwmtachocontroller@1e786000 { > + #address-cells = <1>; > + #size-cells = <1>; > + reg = <0x1E786000 0x1000>; > + compatible = "aspeed,ast2500-pwm-tacho"; > + clocks = <&pwm_tacho_fixed_clk>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default>; > + > + fan@0 { > + reg = <0x00>; > + aspeed,fan-tach-ch = /bits/ 8 <0x00>; > + }; > + > + fan@1 { > + reg = <0x01>; > + aspeed,fan-tach-ch = /bits/ 8 <0x01 0x02>; > + }; > +}; > -- > 2.12.2.715.g7642488e1d-goog > > -- > To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org> To: Jaghathiswari Rankappagounder Natarajan <jaghu-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org, jdelvare-IBi9RG/b67k@public.gmane.org, linux-hwmon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, openbmc-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, corbet-T1hC0tSOHrs@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH linux v6 1/2] Documentation: dt-bindings: Document bindings for ASPEED AST2400/AST2500 PWM and Fan tach controller device driver Date: Tue, 4 Apr 2017 05:52:29 -0700 [thread overview] Message-ID: <2a7035fe-25ac-e0da-4f18-958eb20a1dc8@roeck-us.net> (raw) In-Reply-To: <20170403233025.26952-2-jaghu-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> On 04/03/2017 04:30 PM, Jaghathiswari Rankappagounder Natarajan wrote: > This binding provides interface for adding values related to ASPEED > AST2400/2500 PWM and Fan tach controller support. > The PWM controller can support upto 8 PWM output ports. > The Fan tach controller can support upto 16 tachometer inputs. > > Signed-off-by: Jaghathiswari Rankappagounder Natarajan <jaghu-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Applied with Acked-by: From Rob (for v5 with the requested changes made). Thanks, Guenter > --- > v6: > - Changed to aspeed,fan-tach-ch > > v5: > - Changed the naming scheme to aspeed,ast2400/2500-pwm-tacho > - Removed gpio pin muxing > - Added aspeed vendor prefix for fan-tach-ch > - Changed to fan@0/1 > - Changed reg to 32 bits > > v4: > - Used 'reg' > > v3: > - Made the structure more common > > v2: > - Removed '_' in node and property names > - Gave some explanation for the properties used > > .../devicetree/bindings/hwmon/aspeed-pwm-tacho.txt | 68 ++++++++++++++++++++++ > 1 file changed, 68 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt > > diff --git a/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt b/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt > new file mode 100644 > index 000000000000..ac0a69ab0755 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/aspeed-pwm-tacho.txt > @@ -0,0 +1,68 @@ > +ASPEED AST2400/AST2500 PWM and Fan Tacho controller device driver > + > +The ASPEED PWM controller can support upto 8 PWM outputs. The ASPEED Fan Tacho > +controller can support upto 16 Fan tachometer inputs. > + > +There can be upto 8 fans supported. Each fan can have one PWM output and > +one/two Fan tach inputs. > + > +Required properties for pwm-tacho node: > +- #address-cells : should be 1. > + > +- #size-cells : should be 1. > + > +- reg : address and length of the register set for the device. > + > +- pinctrl-names : a pinctrl state named "default" must be defined. > + > +- pinctrl-0 : phandle referencing pin configuration of the PWM ports. > + > +- compatible : should be "aspeed,ast2400-pwm-tacho" for AST2400 and > + "aspeed,ast2500-pwm-tacho" for AST2500. > + > +- clocks : a fixed clock providing input clock frequency(PWM > + and Fan Tach clock) > + > +fan subnode format: > +=================== > +Under fan subnode there can upto 8 child nodes, with each child node > +representing a fan. If there are 8 fans each fan can have one PWM port and > +one/two Fan tach inputs. > + > +Required properties for each child node: > +- reg : should specify PWM source port. > + integer value in the range 0 to 7 with 0 indicating PWM port A and > + 7 indicating PWM port H. > + > +- aspeed,fan-tach-ch : should specify the Fan tach input channel. > + integer value in the range 0 through 15, with 0 indicating > + Fan tach channel 0 and 15 indicating Fan tach channel 15. > + Atleast one Fan tach input channel is required. > + > +Examples: > + > +pwm_tacho_fixed_clk: fixedclk { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <24000000>; > +} > + > +pwm_tacho: pwmtachocontroller@1e786000 { > + #address-cells = <1>; > + #size-cells = <1>; > + reg = <0x1E786000 0x1000>; > + compatible = "aspeed,ast2500-pwm-tacho"; > + clocks = <&pwm_tacho_fixed_clk>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_pwm0_default &pinctrl_pwm1_default>; > + > + fan@0 { > + reg = <0x00>; > + aspeed,fan-tach-ch = /bits/ 8 <0x00>; > + }; > + > + fan@1 { > + reg = <0x01>; > + aspeed,fan-tach-ch = /bits/ 8 <0x01 0x02>; > + }; > +}; > -- > 2.12.2.715.g7642488e1d-goog > > -- > To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-04-04 12:52 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-03 23:30 [PATCH linux v6 0/2] Support for ASPEED AST2400/AST2500 PWM and Fan Tach driver Jaghathiswari Rankappagounder Natarajan 2017-04-03 23:30 ` [PATCH linux v6 1/2] Documentation: dt-bindings: Document bindings for ASPEED AST2400/AST2500 PWM and Fan tach controller device driver Jaghathiswari Rankappagounder Natarajan 2017-04-04 12:52 ` Guenter Roeck [this message] 2017-04-04 12:52 ` Guenter Roeck 2017-04-03 23:30 ` [PATCH linux v6 2/2] drivers: hwmon: Support for ASPEED PWM/Fan tach Jaghathiswari Rankappagounder Natarajan 2017-04-04 12:55 ` Guenter Roeck 2017-04-04 16:30 ` Guenter Roeck
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2a7035fe-25ac-e0da-4f18-958eb20a1dc8@roeck-us.net \ --to=linux@roeck-us.net \ --cc=corbet@lwn.net \ --cc=devicetree@vger.kernel.org \ --cc=jaghu@google.com \ --cc=jdelvare@suse.com \ --cc=joel@jms.id.au \ --cc=linux-doc@vger.kernel.org \ --cc=linux-hwmon@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=openbmc@lists.ozlabs.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.