From: Vidya Sagar <vidyas@nvidia.com>
To: "Kenneth R. Crudup" <kenny@panix.com>
Cc: <bhelgaas@google.com>, <lorenzo.pieralisi@arm.com>,
<hkallweit1@gmail.com>, <wangxiongfeng2@huawei.com>,
<mika.westerberg@linux.intel.com>, <kai.heng.feng@canonical.com>,
<chris.packham@alliedtelesis.co.nz>, <yangyicong@hisilicon.com>,
<treding@nvidia.com>, <jonathanh@nvidia.com>,
<abhsahu@nvidia.com>, <sagupta@nvidia.com>,
<linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kthota@nvidia.com>, <mmaddireddy@nvidia.com>,
<sagar.tv@gmail.com>
Subject: Re: [PATCH V1] PCI/ASPM: Save/restore L1SS Capability for suspend/resume
Date: Wed, 2 Feb 2022 00:54:48 +0530 [thread overview]
Message-ID: <2ab59f0d-3ae7-ca5e-6bfc-12bed18813b2@nvidia.com> (raw)
In-Reply-To: <8aa96f79-402-4897-424f-64a2c6893de8@panix.com>
Hi Kenneth,
Thanks for sharing the files.
BTW, I see that the ASPM L1SS capability is supported by only two
endpoints viz. KIOXIA's NVMe drive and Realtek's Card reader. None of
the root ports seem to have the support. So, I'm wondering how was it
even getting enabled in the first place earlier?
(OR)
was it the case that L1SS sub-states were never enabled earlier also and
the issue was occurring without having ASPM L1SS enabled? (but with only
L0s and L1 enabled??)
Also, I see that from 'before' and 'after' logs that for both NVMe and
Card reader and their corresponding root ports, none of the ASPM states
are enabled (not even L0s or L1).
Did you set the policy to 'powersupersave' before hibernating the system?
On 2/2/2022 12:23 AM, Kenneth R. Crudup wrote:
> External email: Use caution opening links or attachments
>
>
> On Tue, 1 Feb 2022, Vidya Sagar wrote:
>
>> Kenneth R. Crudup <kenny@panix.com>
>> Could you please try this patch on top of linux-next and collect more info?
>> - 'sudo lspci -vvvv' output before and after hibernation
>
> See attached. Added a diff file, too.
>
>> - could you please confirm the working of this patch for non NVMe devices that
>> support L1 Sub-States?
>
> It seems to work, I'm on it now. I saw a "GPU Hang" from the i915 driver, but
> it doesn't seem to be affecting the GPU any.
>
>> - Could you please try "NVME_QUIRK_NO_DEEPEST_PS" and "NVME_QUIRK_SIMPLE_SUSPEND"
>> quirks (one at a time) in check_vendor_combination_bug() API and see if it
>> makes any difference?
>
> Do you still need me to do that, since this appears to work?
>
> I will try another hibernate attempt just to be sure, too.
>
> -Kenny
>
> --
> Kenneth R. Crudup / Sr. SW Engineer, Scott County Consulting, Orange County CA
>
next prev parent reply other threads:[~2022-02-01 19:25 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-01 12:35 [PATCH V1] PCI/ASPM: Save/restore L1SS Capability for suspend/resume Vidya Sagar
2022-02-01 13:54 ` Kenneth R. Crudup
2022-02-01 18:53 ` Kenneth R. Crudup
2022-02-01 19:03 ` Kenneth R. Crudup
2022-02-01 19:05 ` Kenneth R. Crudup
2022-02-01 19:10 ` Kenneth R. Crudup
2022-02-01 19:24 ` Vidya Sagar [this message]
2022-02-01 22:25 ` Kenneth R. Crudup
2022-02-02 4:17 ` Vidya Sagar
2022-02-04 1:18 ` Kenneth R. Crudup
2022-02-04 5:37 ` Vidya Sagar
2022-02-04 23:02 ` Bjorn Helgaas
2022-02-04 23:17 ` Kenneth R. Crudup
2022-02-05 16:44 ` Vidya Sagar
2022-02-05 17:30 ` Kenneth R. Crudup
2022-02-05 17:32 ` Kenneth R. Crudup
2022-02-05 17:33 ` Kenneth R. Crudup
2022-02-07 16:33 ` Bjorn Helgaas
2022-02-07 18:20 ` Kenneth R. Crudup
2022-02-15 13:10 ` Kenneth R. Crudup
2022-02-16 4:40 ` Vidya Sagar
2022-02-16 6:00 ` Kenneth R. Crudup
2022-02-16 13:11 ` Vidya Sagar
2022-04-12 22:50 ` Bjorn Helgaas
2022-04-13 0:19 ` Kai-Heng Feng
2022-04-14 16:41 ` Bjorn Helgaas
2022-04-15 14:26 ` Kai-Heng Feng
2022-04-15 21:25 ` Bjorn Helgaas
2022-04-21 6:16 ` Kai-Heng Feng
2022-04-21 20:36 ` Bjorn Helgaas
2022-04-21 20:40 ` Kenneth R. Crudup
2022-04-21 21:11 ` Bjorn Helgaas
2022-04-21 21:21 ` Kenneth R. Crudup
2022-04-13 13:26 ` Bjorn Helgaas
2022-11-23 21:44 ` Matthias Kaehlcke
2022-11-23 22:01 ` Kenneth R. Crudup
2022-11-24 0:07 ` Matthias Kaehlcke
2022-02-15 13:12 ` Kenneth R. Crudup
2022-02-04 11:23 ` Abhishek Sahu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ab59f0d-3ae7-ca5e-6bfc-12bed18813b2@nvidia.com \
--to=vidyas@nvidia.com \
--cc=abhsahu@nvidia.com \
--cc=bhelgaas@google.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=hkallweit1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kai.heng.feng@canonical.com \
--cc=kenny@panix.com \
--cc=kthota@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=mmaddireddy@nvidia.com \
--cc=sagar.tv@gmail.com \
--cc=sagupta@nvidia.com \
--cc=treding@nvidia.com \
--cc=wangxiongfeng2@huawei.com \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.