From: Oliver Hartkopp <socketcan@hartkopp.net> To: SF Markus Elfring <elfring@users.sourceforge.net>, linux-can@vger.kernel.org, netdev@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>, Wolfgang Grandegger <wg@grandegger.com> Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] can: Use common error handling code in vxcan_newlink() Date: Sat, 28 Oct 2017 08:48:16 +0200 [thread overview] Message-ID: <2ab5d794-7a5c-9036-835c-67cfcc541795@hartkopp.net> (raw) In-Reply-To: <2e600d9a-faec-dd39-08f0-5a7fb260d7ca@users.sourceforge.net> Hi Markus, On 10/27/2017 10:30 PM, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Fri, 27 Oct 2017 22:22:24 +0200 > > * Add a jump target so that a bit of exception handling can be better > reused at the end of this function. > > * Adjust two condition checks. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/net/can/vxcan.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/can/vxcan.c b/drivers/net/can/vxcan.c > index 8404e8852a0f..97f250cbc4ff 100644 > --- a/drivers/net/can/vxcan.c > +++ b/drivers/net/can/vxcan.c > @@ -227,10 +227,8 @@ static int vxcan_newlink(struct net *net, struct net_device *dev, > netif_carrier_off(peer); > > err = rtnl_configure_link(peer, ifmp); > - if (err < 0) { > - unregister_netdevice(peer); > - return err; > - } > + if (err) > + goto unregister_network_device; You are changing semantic in the if-statement here. I would be fine with the patch if you revert that if-statement as I would like to stay on the behavior from veth.c in veth_newlink(). Regards, Oliver > > /* register first device */ > if (tb[IFLA_IFNAME]) > @@ -239,10 +237,8 @@ static int vxcan_newlink(struct net *net, struct net_device *dev, > snprintf(dev->name, IFNAMSIZ, DRV_NAME "%%d"); > > err = register_netdevice(dev); > - if (err < 0) { > - unregister_netdevice(peer); > - return err; > - } > + if (err) > + goto unregister_network_device; > > netif_carrier_off(dev); > > @@ -254,6 +250,10 @@ static int vxcan_newlink(struct net *net, struct net_device *dev, > rcu_assign_pointer(priv->peer, dev); > > return 0; > + > +unregister_network_device: > + unregister_netdevice(peer); > + return err; > } > > static void vxcan_dellink(struct net_device *dev, struct list_head *head) >
WARNING: multiple messages have this Message-ID (diff)
From: Oliver Hartkopp <socketcan@hartkopp.net> To: SF Markus Elfring <elfring@users.sourceforge.net>, linux-can@vger.kernel.org, netdev@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>, Wolfgang Grandegger <wg@grandegger.com> Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] can: Use common error handling code in vxcan_newlink() Date: Sat, 28 Oct 2017 06:48:16 +0000 [thread overview] Message-ID: <2ab5d794-7a5c-9036-835c-67cfcc541795@hartkopp.net> (raw) In-Reply-To: <2e600d9a-faec-dd39-08f0-5a7fb260d7ca@users.sourceforge.net> Hi Markus, On 10/27/2017 10:30 PM, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Fri, 27 Oct 2017 22:22:24 +0200 > > * Add a jump target so that a bit of exception handling can be better > reused at the end of this function. > > * Adjust two condition checks. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/net/can/vxcan.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/can/vxcan.c b/drivers/net/can/vxcan.c > index 8404e8852a0f..97f250cbc4ff 100644 > --- a/drivers/net/can/vxcan.c > +++ b/drivers/net/can/vxcan.c > @@ -227,10 +227,8 @@ static int vxcan_newlink(struct net *net, struct net_device *dev, > netif_carrier_off(peer); > > err = rtnl_configure_link(peer, ifmp); > - if (err < 0) { > - unregister_netdevice(peer); > - return err; > - } > + if (err) > + goto unregister_network_device; You are changing semantic in the if-statement here. I would be fine with the patch if you revert that if-statement as I would like to stay on the behavior from veth.c in veth_newlink(). Regards, Oliver > > /* register first device */ > if (tb[IFLA_IFNAME]) > @@ -239,10 +237,8 @@ static int vxcan_newlink(struct net *net, struct net_device *dev, > snprintf(dev->name, IFNAMSIZ, DRV_NAME "%%d"); > > err = register_netdevice(dev); > - if (err < 0) { > - unregister_netdevice(peer); > - return err; > - } > + if (err) > + goto unregister_network_device; > > netif_carrier_off(dev); > > @@ -254,6 +250,10 @@ static int vxcan_newlink(struct net *net, struct net_device *dev, > rcu_assign_pointer(priv->peer, dev); > > return 0; > + > +unregister_network_device: > + unregister_netdevice(peer); > + return err; > } > > static void vxcan_dellink(struct net_device *dev, struct list_head *head) >
next prev parent reply other threads:[~2017-10-28 6:48 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-27 20:30 [PATCH] can: Use common error handling code in vxcan_newlink() SF Markus Elfring 2017-10-27 20:30 ` SF Markus Elfring 2017-10-28 6:48 ` Oliver Hartkopp [this message] 2017-10-28 6:48 ` Oliver Hartkopp 2017-10-28 8:23 ` SF Markus Elfring 2017-10-28 8:23 ` SF Markus Elfring 2017-10-28 17:40 ` Oliver Hartkopp 2017-10-28 17:40 ` Oliver Hartkopp 2017-10-28 18:33 ` SF Markus Elfring 2017-10-28 18:33 ` SF Markus Elfring 2017-10-28 19:04 ` Oliver Hartkopp 2017-10-28 19:04 ` Oliver Hartkopp 2017-10-28 19:18 ` SF Markus Elfring 2017-10-28 19:18 ` SF Markus Elfring 2017-10-28 19:54 ` Oliver Hartkopp 2017-10-28 19:54 ` Oliver Hartkopp 2017-10-28 20:13 ` SF Markus Elfring 2017-10-28 20:13 ` SF Markus Elfring 2017-10-29 10:51 ` Oliver Hartkopp 2017-10-29 10:51 ` Oliver Hartkopp 2017-11-01 14:16 ` [PATCH v2] " SF Markus Elfring 2017-11-01 14:16 ` SF Markus Elfring 2017-11-01 19:09 ` Oliver Hartkopp 2017-11-01 19:09 ` Oliver Hartkopp 2017-11-01 19:37 ` [v2] " SF Markus Elfring 2017-11-01 19:37 ` SF Markus Elfring 2017-11-02 8:22 ` Oliver Hartkopp 2017-11-02 8:22 ` Oliver Hartkopp 2017-11-07 8:21 ` [PATCH v2] " Marc Kleine-Budde 2017-11-07 8:21 ` Marc Kleine-Budde
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2ab5d794-7a5c-9036-835c-67cfcc541795@hartkopp.net \ --to=socketcan@hartkopp.net \ --cc=elfring@users.sourceforge.net \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-can@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mkl@pengutronix.de \ --cc=netdev@vger.kernel.org \ --cc=wg@grandegger.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.