* [U-Boot] PATCH: bugfix for reading maximum TLB size on mpc85xx
@ 2009-05-14 17:38 Fredrik Arnerup
2009-05-14 18:08 ` Kumar Gala
0 siblings, 1 reply; 3+ messages in thread
From: Fredrik Arnerup @ 2009-05-14 17:38 UTC (permalink / raw)
To: u-boot
The MAXSIZE field in the TLB1CFG register is 4 bits, not 8 bits.
This made setup_ddr_tlbs() try to set up a TLB larger than the e500 maximum
(256 MB)
which made u-boot hang in board_init_f() when trying to create a new stack
in RAM.
I have an mpc8540 with one 1GB dimm.
Signed-off-by: Fredrik Arnerup <fredrik.arnerup@edgeware.tv>
--- ../tmp/u-boot-2009.03/cpu/mpc85xx/tlb.c 2009-03-21
22:04:41.000000000 +0100
+++ cpu/mpc85xx/tlb.c 2009-05-14 19:26:17.000000000 +0200
@@ -134,7 +134,7 @@
unsigned int tlb_size;
unsigned int ram_tlb_index = CONFIG_SYS_DDR_TLB_START;
unsigned int ram_tlb_address = (unsigned
int)CONFIG_SYS_DDR_SDRAM_BASE;
- unsigned int max_cam = (mfspr(SPRN_TLB1CFG) >> 16) & 0xff;
+ unsigned int max_cam = (mfspr(SPRN_TLB1CFG) >> 16) & 0xf;
u64 size, memsize = (u64)memsize_in_meg << 20;
size = min(memsize, CONFIG_MAX_MEM_MAPPED);
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] PATCH: bugfix for reading maximum TLB size on mpc85xx
2009-05-14 17:38 [U-Boot] PATCH: bugfix for reading maximum TLB size on mpc85xx Fredrik Arnerup
@ 2009-05-14 18:08 ` Kumar Gala
2009-06-02 21:46 ` Andy Fleming
0 siblings, 1 reply; 3+ messages in thread
From: Kumar Gala @ 2009-05-14 18:08 UTC (permalink / raw)
To: u-boot
On May 14, 2009, at 12:38 PM, Fredrik Arnerup wrote:
> The MAXSIZE field in the TLB1CFG register is 4 bits, not 8 bits.
> This made setup_ddr_tlbs() try to set up a TLB larger than the e500
> maximum
> (256 MB)
> which made u-boot hang in board_init_f() when trying to create a new
> stack
> in RAM.
> I have an mpc8540 with one 1GB dimm.
>
> Signed-off-by: Fredrik Arnerup <fredrik.arnerup@edgeware.tv>
>
> --- ../tmp/u-boot-2009.03/cpu/mpc85xx/tlb.c 2009-03-21
> 22:04:41.000000000 +0100
> +++ cpu/mpc85xx/tlb.c 2009-05-14 19:26:17.000000000 +0200
> @@ -134,7 +134,7 @@
> unsigned int tlb_size;
> unsigned int ram_tlb_index = CONFIG_SYS_DDR_TLB_START;
> unsigned int ram_tlb_address = (unsigned
> int)CONFIG_SYS_DDR_SDRAM_BASE;
> - unsigned int max_cam = (mfspr(SPRN_TLB1CFG) >> 16) & 0xff;
> + unsigned int max_cam = (mfspr(SPRN_TLB1CFG) >> 16) & 0xf;
> u64 size, memsize = (u64)memsize_in_meg << 20;
>
> size = min(memsize, CONFIG_MAX_MEM_MAPPED);
Ack. This should get picked up for v2009.06
- k
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] PATCH: bugfix for reading maximum TLB size on mpc85xx
2009-05-14 18:08 ` Kumar Gala
@ 2009-06-02 21:46 ` Andy Fleming
0 siblings, 0 replies; 3+ messages in thread
From: Andy Fleming @ 2009-06-02 21:46 UTC (permalink / raw)
To: u-boot
On Thu, May 14, 2009 at 1:08 PM, Kumar Gala <galak@kernel.crashing.org>wrote:
>
> On May 14, 2009, at 12:38 PM, Fredrik Arnerup wrote:
>
> > The MAXSIZE field in the TLB1CFG register is 4 bits, not 8 bits.
> > This made setup_ddr_tlbs() try to set up a TLB larger than the e500
> > maximum
> > (256 MB)
> > which made u-boot hang in board_init_f() when trying to create a new
> > stack
> > in RAM.
> > I have an mpc8540 with one 1GB dimm.
> >
> > Signed-off-by: Fredrik Arnerup <fredrik.arnerup@edgeware.tv>
>
Applied to HEAD, thanks!
Andy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-02 21:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-05-14 17:38 [U-Boot] PATCH: bugfix for reading maximum TLB size on mpc85xx Fredrik Arnerup
2009-05-14 18:08 ` Kumar Gala
2009-06-02 21:46 ` Andy Fleming
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.