All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Leitner <richard.leitner@skidata.com>
To: Serge Semin <fancer.lancer@gmail.com>,
	<gregkh@linuxfoundation.org>, <robh+dt@kernel.org>,
	<mark.rutland@arm.com>
Cc: <Sergey.Semin@t-platforms.ru>, <linux-usb@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Richard Leitner <richard.leitner@skidata.com>
Subject: Re: [PATCH 3/9 v2] usb: usb251xb: Add 5,6,7 ports mapping def setting
Date: Wed, 4 Oct 2017 09:51:01 +0200	[thread overview]
Message-ID: <2ad7bb5b-d8cb-65f3-7b03-be5972d7acd3@skidata.com> (raw)
In-Reply-To: <20170916104220.3742-4-fancer.lancer@gmail.com>


On 09/16/2017 12:42 PM, Serge Semin wrote:
> USB2517 got three additionl downstream ports, which can
> as well be mapped to another logical ports. USB2551xb driver

typo in "USB251xb"

> currently doesn't fully support such setting configuration
> from dts file. This patch doesn't change this, but adds
> usb2517 spcific ports default liner mapping.
> 
> Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
> ---
>  drivers/usb/misc/usb251xb.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 

Code itself looks good to me, therefore feel free to add:

Acked-by: Richard Leitner <richard.leitner@skidata.com>

regards,
Richard.L

WARNING: multiple messages have this Message-ID (diff)
From: Richard Leitner <richard.leitner@skidata.com>
To: Serge Semin <fancer.lancer@gmail.com>,
	gregkh@linuxfoundation.org, robh+dt@kernel.org,
	mark.rutland@arm.com
Cc: Sergey.Semin@t-platforms.ru, linux-usb@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Richard Leitner <richard.leitner@skidata.com>
Subject: Re: [PATCH 3/9 v2] usb: usb251xb: Add 5,6,7 ports mapping def setting
Date: Wed, 4 Oct 2017 09:51:01 +0200	[thread overview]
Message-ID: <2ad7bb5b-d8cb-65f3-7b03-be5972d7acd3@skidata.com> (raw)
In-Reply-To: <20170916104220.3742-4-fancer.lancer@gmail.com>


On 09/16/2017 12:42 PM, Serge Semin wrote:
> USB2517 got three additionl downstream ports, which can
> as well be mapped to another logical ports. USB2551xb driver

typo in "USB251xb"

> currently doesn't fully support such setting configuration
> from dts file. This patch doesn't change this, but adds
> usb2517 spcific ports default liner mapping.
> 
> Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
> ---
>  drivers/usb/misc/usb251xb.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 

Code itself looks good to me, therefore feel free to add:

Acked-by: Richard Leitner <richard.leitner@skidata.com>

regards,
Richard.L

  reply	other threads:[~2017-10-04  7:51 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-15 23:31 [PATCH 0/5] usb: usb251xb: Add USB2517i hub support and fix some bugs Serge Semin
2017-09-15 23:31 ` Serge Semin
2017-09-15 23:31 ` [PATCH 1/5] usb: usb251xb: Add USB2517/i hub support Serge Semin
2017-09-15 23:45   ` Greg KH
2017-09-15 23:55     ` Serge Semin
2017-09-15 23:55       ` Serge Semin
2017-09-20 20:52   ` Rob Herring
2017-09-20 21:15     ` Serge Semin
2017-09-21 16:53       ` Rob Herring
2017-09-21 17:40         ` Serge Semin
2017-09-21 17:40           ` Serge Semin
2017-09-15 23:31 ` [PATCH 2/5] usb: usb251xb: Fix property_u32 NULL pointer dereference Serge Semin
2017-09-15 23:31 ` [PATCH 3/5] usb: usb251xb: Add max power/current dts nodes Serge Semin
2017-09-15 23:31 ` [PATCH 4/5] usb: usb251xb: Use GPIO descriptor consumer interface Serge Semin
2017-09-15 23:31 ` [PATCH 5/5] usb: usb251xb: Add copyrights Serge Semin
2017-09-15 23:40   ` Greg KH
2017-09-15 23:40     ` Greg KH
2017-09-15 23:42     ` Greg KH
2017-09-15 23:42       ` Greg KH
2017-09-15 23:45     ` Serge Semin
2017-09-15 23:45       ` Serge Semin
2017-09-15 23:53       ` Greg KH
2017-09-15 23:53         ` Greg KH
2017-09-16  0:11         ` Serge Semin
2017-09-16 10:42 ` [PATCH 0/9 v2] usb: usb251xb: Add USB2517i hub support and fix some bugs Serge Semin
2017-09-16 10:42   ` Serge Semin
2017-09-16 10:42   ` [PATCH 1/9 v2] usb: usb251xb: Add USB2517i specific struct and IDs Serge Semin
2017-10-04  7:39     ` Richard Leitner
2017-10-04  7:39       ` Richard Leitner
2017-09-16 10:42   ` [PATCH 2/9 v2] usb: usb251xb: Add USB251x specific port count setting Serge Semin
2017-10-04  7:27     ` Richard Leitner
2017-10-04  7:27       ` Richard Leitner
2017-09-16 10:42   ` [PATCH 3/9 v2] usb: usb251xb: Add 5,6,7 ports mapping def setting Serge Semin
2017-10-04  7:51     ` Richard Leitner [this message]
2017-10-04  7:51       ` Richard Leitner
2017-09-16 10:42   ` [PATCH 4/9 v2] usb: usb251xb: Add 5,6,7 ports boost settings Serge Semin
2017-09-16 10:42     ` Serge Semin
2017-10-04  7:57     ` Richard Leitner
2017-10-04  7:57       ` Richard Leitner
2017-09-16 10:42   ` [PATCH 5/9 v2] usb: usb251xb: Add battery enable setting flag Serge Semin
2017-09-16 10:42   ` [PATCH 6/9 v2] usb: usb251xb: Add USB2517 LED settings Serge Semin
2017-09-16 10:42   ` [PATCH 7/9 v2] usb: usb251xb: Fix property_u32 NULL pointer dereference Serge Semin
2017-09-16 10:42   ` [PATCH 8/9 v2] usb: usb251xb: Add max power/current dts property support Serge Semin
2017-09-16 10:42     ` Serge Semin
2017-09-20 20:52     ` Rob Herring
2017-09-20 21:27       ` Serge Semin
2017-09-21 16:26         ` Rob Herring
2017-09-21 16:26           ` Rob Herring
2017-09-21 17:10           ` Serge Semin
2017-09-21 17:10             ` Serge Semin
2017-10-04  8:12             ` Richard Leitner
2017-10-04  8:12               ` Richard Leitner
2017-10-04 13:44               ` Rob Herring
2017-10-04 13:44                 ` Rob Herring
2017-09-16 10:42   ` [PATCH 9/9 v2] usb: usb251xb: Use GPIO descriptor consumer interface Serge Semin
2017-09-20 20:52     ` Rob Herring
2017-09-20 21:29       ` Serge Semin
2017-09-21  8:23     ` Greg KH
2017-09-21 14:51       ` Serge Semin
2017-09-21 14:51         ` Serge Semin
2017-09-21 15:07         ` Greg KH
2017-09-22 15:26           ` Serge Semin
2017-09-22 15:26             ` Serge Semin
2017-09-22 16:05             ` Greg KH
2017-10-22 20:38   ` [PATCH 00/10 v3] usb: usb251xb: Add USB2517i hub support and fix some bugs Serge Semin
2017-10-22 20:38     ` Serge Semin
2017-10-22 20:38     ` [PATCH 01/10 v3] usb: usb251xb: Update usb251xb bindings Serge Semin
2017-10-27  3:21       ` Rob Herring
2017-10-27  3:21         ` Rob Herring
2017-10-22 20:38     ` [PATCH 02/10 v3] usb: usb251xb: Add USB2517i specific struct and IDs Serge Semin
2017-10-23 21:47       ` Richard Leitner
2017-10-23 21:47         ` Richard Leitner
2017-10-22 20:38     ` [PATCH 03/10 v3] usb: usb251xb: Add USB251x specific port count setting Serge Semin
2017-10-22 20:38       ` Serge Semin
2017-10-23 21:36       ` Richard Leitner
2017-10-23 21:36         ` Richard Leitner
2017-10-22 20:38     ` [PATCH 04/10 v3] usb: usb251xb: Add 5,6,7 ports mapping def setting Serge Semin
2017-10-22 20:38     ` [PATCH 05/10 v3] usb: usb251xb: Add 5,6,7 ports boost settings Serge Semin
2017-10-22 20:38     ` [PATCH 06/10 v3] usb: usb251xb: Add battery enable setting flag Serge Semin
2017-10-22 20:38     ` [PATCH 07/10 v3] usb: usb251xb: Add USB2517 LED settings Serge Semin
2017-10-22 20:38     ` [PATCH 08/10 v3] usb: usb251xb: Fix property_u32 NULL pointer dereference Serge Semin
2017-10-22 20:38     ` [PATCH 09/10 v3] usb: usb251xb: Add max power/current dts property support Serge Semin
2017-10-23 21:55       ` Richard Leitner
2017-10-23 21:55         ` Richard Leitner
2017-10-22 20:38     ` [PATCH 10/10 v3] usb: usb251xb: Use GPIO descriptor consumer interface Serge Semin
2017-10-22 20:38       ` Serge Semin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ad7bb5b-d8cb-65f3-7b03-be5972d7acd3@skidata.com \
    --to=richard.leitner@skidata.com \
    --cc=Sergey.Semin@t-platforms.ru \
    --cc=devicetree@vger.kernel.org \
    --cc=fancer.lancer@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.